fix temp file leak in sem_open on successful creation of new semaphore

diff --git a/src/thread/sem_open.c b/src/thread/sem_open.c
index 66f12ee..9a95d25 100644 (file)
--- a/src/thread/sem_open.c
+++ b/src/thread/sem_open.c
@@ -123,9 +123,9 @@ sem_t *sem_open(const char *name, int flags, ...)
                        goto fail;
                }
                close(fd);
                        goto fail;
                }
                close(fd);

-               if (link(tmp, name) == 0) break;
-               e = errno;
+               e = link(tmp, name) ? errno : 0;

                unlink(tmp);
                unlink(tmp);

+               if (!e) break;

                /* Failure is only fatal when doing an exclusive open;
                 * otherwise, next iteration will try to open the
                 * existing file. */
                /* Failure is only fatal when doing an exclusive open;
                 * otherwise, next iteration will try to open the
                 * existing file. */