fix stale locks left behind when pthread_create fails

[musl] / src / thread / pthread_cond_timedwait.c

diff --git a/src/thread/pthread_cond_timedwait.c b/src/thread/pthread_cond_timedwait.c
index db2744b..1f25c8e 100644 (file)
--- a/src/thread/pthread_cond_timedwait.c
+++ b/src/thread/pthread_cond_timedwait.c
@@ -12,6 +12,7 @@ static void unwait(pthread_cond_t *c, pthread_mutex_t *m)
 
        if (c->_c_mutex == (void *)-1) {
                a_dec(&c->_c_waiters);
+               if (c->_c_destroy) __wake(&c->_c_waiters, 1, 0);
                return;
        }
 
@@ -23,6 +24,9 @@ static void unwait(pthread_cond_t *c, pthread_mutex_t *m)
 
        a_store(&c->_c_lock, 0);
        if (c->_c_lockwait) __wake(&c->_c_lock, 1, 1);
+
+       a_dec(&c->_c_waiters);
+       if (c->_c_destroy) __wake(&c->_c_waiters, 1, 1);
 }
 
 static void cleanup(void *p)
@@ -32,11 +36,14 @@ static void cleanup(void *p)
        pthread_mutex_lock(cm->m);
 }
 
-int pthread_cond_timedwait(pthread_cond_t *c, pthread_mutex_t *m, const struct timespec *ts)
+int pthread_cond_timedwait(pthread_cond_t *restrict c, pthread_mutex_t *restrict m, const struct timespec *restrict ts)
 {
        struct cm cm = { .c=c, .m=m };
        int r, e=0, seq;
 
+       if (m->_m_type && (m->_m_lock&INT_MAX) != pthread_self()->tid)
+               return EPERM;
+
        if (ts && ts->tv_nsec >= 1000000000UL)
                return EINVAL;
 
@@ -55,7 +62,7 @@ int pthread_cond_timedwait(pthread_cond_t *c, pthread_mutex_t *m, const struct t
 
        seq = c->_c_seq;
 
-       if ((r=pthread_mutex_unlock(m))) return r;
+       pthread_mutex_unlock(m);
 
        do e = __timedwait(&c->_c_seq, seq, c->_c_clock, ts, cleanup, &cm, 0);
        while (c->_c_seq == seq && (!e || e==EINTR));