projects
/
musl
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
fix regression in dlsym: rejection of special RTLD_* handles as invalid
[musl]
/
src
/
ldso
/
dynlink.c
diff --git
a/src/ldso/dynlink.c
b/src/ldso/dynlink.c
index
d564b8f
..
e73806c
100644
(file)
--- a/
src/ldso/dynlink.c
+++ b/
src/ldso/dynlink.c
@@
-433,7
+433,7
@@
static struct dso *load_library(const char *name)
{
char buf[2*NAME_MAX+2];
const char *pathname;
{
char buf[2*NAME_MAX+2];
const char *pathname;
- unsigned char *
base, *
map;
+ unsigned char *map;
size_t map_len;
struct dso *p, temp_dso = {0};
int fd;
size_t map_len;
struct dso *p, temp_dso = {0};
int fd;
@@
-566,7
+566,7
@@
static struct dso *load_library(const char *name)
p->prev = tail;
tail = p;
p->prev = tail;
tail = p;
- if (ldd_mode) dprintf(1, "\t%s => %s (%p)\n", name, pathname, base);
+ if (ldd_mode) dprintf(1, "\t%s => %s (%p)\n", name, pathname,
p->
base);
return p;
}
return p;
}
@@
-1091,6
+1091,15
@@
end:
return p;
}
return p;
}
+static int invalid_dso_handle(void *h)
+{
+ struct dso *p;
+ for (p=head; p; p=p->next) if (h==p) return 0;
+ snprintf(errbuf, sizeof errbuf, "Invalid library handle %p", (void *)h);
+ errflag = 1;
+ return 1;
+}
+
static void *do_dlsym(struct dso *p, const char *s, void *ra)
{
size_t i;
static void *do_dlsym(struct dso *p, const char *s, void *ra)
{
size_t i;
@@
-1110,6
+1119,8
@@
static void *do_dlsym(struct dso *p, const char *s, void *ra)
return __tls_get_addr((size_t []){def.dso->tls_id, def.sym->st_value});
return def.dso->base + def.sym->st_value;
}
return __tls_get_addr((size_t []){def.dso->tls_id, def.sym->st_value});
return def.dso->base + def.sym->st_value;
}
+ if (p != RTLD_DEFAULT && p != RTLD_NEXT && invalid_dso_handle(p))
+ return 0;
if (p->ghashtab) {
gh = gnu_hash(s);
sym = gnu_lookup(s, gh, p);
if (p->ghashtab) {
gh = gnu_hash(s);
sym = gnu_lookup(s, gh, p);
@@
-1178,7
+1189,7
@@
int __dladdr(void *addr, Dl_info *info)
}
for (; nsym; nsym--, sym++) {
}
for (; nsym; nsym--, sym++) {
- if (sym->st_
shndx && sym->st_
value
+ if (sym->st_value
&& (1<<(sym->st_info&0xf) & OK_TYPES)
&& (1<<(sym->st_info>>4) & OK_BINDS)) {
void *symaddr = p->base + sym->st_value;
&& (1<<(sym->st_info&0xf) & OK_TYPES)
&& (1<<(sym->st_info>>4) & OK_BINDS)) {
void *symaddr = p->base + sym->st_value;
@@
-1236,6
+1247,12
@@
int dl_iterate_phdr(int(*callback)(struct dl_phdr_info *info, size_t size, void
return ret;
}
#else
return ret;
}
#else
+static int invalid_dso_handle(void *h)
+{
+ snprintf(errbuf, sizeof errbuf, "Invalid library handle %p", (void *)h);
+ errflag = 1;
+ return 1;
+}
void *dlopen(const char *file, int mode)
{
return 0;
void *dlopen(const char *file, int mode)
{
return 0;
@@
-1259,5
+1276,5
@@
char *dlerror()
int dlclose(void *p)
{
int dlclose(void *p)
{
- return
0
;
+ return
invalid_dso_handle(p)
;
}
}