fix fd leak race (missing O_CLOEXEC) in fchmodat
authorRich Felker <dalias@aerifal.cx>
Thu, 5 Feb 2015 03:50:40 +0000 (22:50 -0500)
committerRich Felker <dalias@aerifal.cx>
Thu, 5 Feb 2015 03:50:40 +0000 (22:50 -0500)
src/stat/fchmodat.c

index afa6d44..a894cb6 100644 (file)
@@ -21,7 +21,7 @@ int fchmodat(int fd, const char *path, mode_t mode, int flag)
        if (S_ISLNK(st.st_mode))
                return __syscall_ret(-EOPNOTSUPP);
 
-       if ((fd2 = __syscall(SYS_openat, fd, path, O_RDONLY|O_PATH|O_NOFOLLOW|O_NOCTTY)) < 0) {
+       if ((fd2 = __syscall(SYS_openat, fd, path, O_RDONLY|O_PATH|O_NOFOLLOW|O_NOCTTY|O_CLOEXEC)) < 0) {
                if (fd2 == -ELOOP)
                        return __syscall_ret(-EOPNOTSUPP);
                return __syscall_ret(fd2);