deduplicate __pthread_self thread pointer adjustment out of each arch
authorRich Felker <dalias@aerifal.cx>
Tue, 25 Aug 2020 02:23:08 +0000 (22:23 -0400)
committerRich Felker <dalias@aerifal.cx>
Thu, 27 Aug 2020 22:36:45 +0000 (18:36 -0400)
commit3a5b9ae7cf656648c80fe155a5239d9b4fb4c485
treefaef753db71ebd66802f84034478dd5c982bdd92
parentea71a9004e08030a15d45186e263fd2b0c51cc25
deduplicate __pthread_self thread pointer adjustment out of each arch

the adjustment made is entirely a function of TLS_ABOVE_TP and
TP_OFFSET. aside from avoiding repetition of the TP_OFFSET value and
arithmetic, this change makes pthread_arch.h independent of the
definition of struct __pthread from pthread_impl.h. this in turn will
allow inclusion of pthread_arch.h to be moved to the top of
pthread_impl.h so that it can influence the definition of the
structure.

previously, arch files were very inconsistent about the type used for
the thread pointer. this change unifies the new __get_tp interface to
always use uintptr_t, which is the most correct when performing
arithmetic that may involve addresses outside the actual pointed-to
object (due to TP_OFFSET).
17 files changed:
arch/aarch64/pthread_arch.h
arch/arm/pthread_arch.h
arch/i386/pthread_arch.h
arch/m68k/pthread_arch.h
arch/microblaze/pthread_arch.h
arch/mips/pthread_arch.h
arch/mips64/pthread_arch.h
arch/mipsn32/pthread_arch.h
arch/or1k/pthread_arch.h
arch/powerpc/pthread_arch.h
arch/powerpc64/pthread_arch.h
arch/riscv64/pthread_arch.h
arch/s390x/pthread_arch.h
arch/sh/pthread_arch.h
arch/x32/pthread_arch.h
arch/x86_64/pthread_arch.h
src/internal/pthread_impl.h