track all live threads in an AS-safe, fully-consistent linked list

[musl] / src / thread / pthread_detach.c

diff --git a/src/thread/pthread_detach.c b/src/thread/pthread_detach.c
index 4e45463..77772af 100644 (file)
--- a/src/thread/pthread_detach.c
+++ b/src/thread/pthread_detach.c
@@ -1,15 +1,14 @@
 #include "pthread_impl.h"
+#include <threads.h>
 
-int __pthread_join(pthread_t, void **);
-
-int __pthread_detach(pthread_t t)
+static int __pthread_detach(pthread_t t)
 {
-       /* Cannot detach a thread that's already exiting */
-       if (a_swap(t->exitlock, 1))
+       /* If the cas fails, detach state is either already-detached
+        * or exiting/exited, and pthread_join will trap or cleanup. */
+       if (a_cas(&t->detach_state, DT_JOINABLE, DT_DETACHED) != DT_JOINABLE)
                return __pthread_join(t, 0);
-       t->detached = 2;
-       __unlock(t->exitlock);
        return 0;
 }
 
 weak_alias(__pthread_detach, pthread_detach);
+weak_alias(__pthread_detach, thrd_detach);