remove incorrect ESRCH error from pthread_kill

[musl] / src / thread / pthread_cond_timedwait.c

diff --git a/src/thread/pthread_cond_timedwait.c b/src/thread/pthread_cond_timedwait.c
index d28b478..ed8569c 100644 (file)
--- a/src/thread/pthread_cond_timedwait.c
+++ b/src/thread/pthread_cond_timedwait.c
@@ -29,8 +29,8 @@ int __pthread_setcancelstate(int, int *);
 
 struct waiter {
        struct waiter *prev, *next;
-       int state, barrier;
-       int *notify;
+       volatile int state, barrier;
+       volatile int *notify;
 };
 
 /* Self-synchronized-destruction-safe lock functions */
@@ -54,7 +54,7 @@ static inline void unlock_requeue(volatile int *l, volatile int *r, int w)
 {
        a_store(l, 0);
        if (w) __wake(l, 1, 1);
-       else __syscall(SYS_futex, l, FUTEX_REQUEUE|128, 0, 1, r) != -ENOSYS
+       else __syscall(SYS_futex, l, FUTEX_REQUEUE|FUTEX_PRIVATE, 0, 1, r) != -ENOSYS
                || __syscall(SYS_futex, l, FUTEX_REQUEUE, 0, 1, r);
 }
 
@@ -64,14 +64,11 @@ enum {
        LEAVING,
 };
 
-static void dummy(void *arg)
-{
-}
-
 int __pthread_cond_timedwait(pthread_cond_t *restrict c, pthread_mutex_t *restrict m, const struct timespec *restrict ts)
 {
        struct waiter node = { 0 };
-       int e, seq, *fut, clock = c->_c_clock, cs, shared=0, oldstate, tmp;
+       int e, seq, clock = c->_c_clock, cs, shared=0, oldstate, tmp;
+       volatile int *fut;
 
        if ((m->_m_type&15) && (m->_m_lock&INT_MAX) != __pthread_self()->tid)
                return EPERM;
@@ -103,8 +100,9 @@ int __pthread_cond_timedwait(pthread_cond_t *restrict c, pthread_mutex_t *restri
        __pthread_mutex_unlock(m);
 
        __pthread_setcancelstate(PTHREAD_CANCEL_MASKED, &cs);
+       if (cs == PTHREAD_CANCEL_DISABLE) __pthread_setcancelstate(cs, 0);
 
-       do e = __timedwait(fut, seq, clock, ts, dummy, 0, !shared);
+       do e = __timedwait_cp(fut, seq, clock, ts, !shared);
        while (*fut==seq && (!e || e==EINTR));
        if (e == EINTR) e = 0;
 
@@ -163,7 +161,7 @@ relock:
                a_dec(&m->_m_waiters);
 
        /* Since a signal was consumed, cancellation is not permitted. */
-       if (e = ECANCELED) e = 0;
+       if (e == ECANCELED) e = 0;
 
 done:
        __pthread_setcancelstate(cs, 0);
@@ -179,7 +177,8 @@ done:
 int __private_cond_signal(pthread_cond_t *c, int n)
 {
        struct waiter *p, *first=0;
-       int ref = 0, cur;
+       volatile int ref = 0;
+       int cur;
 
        lock(&c->_c_lock);
        for (p=c->_c_tail; n && p; p=p->prev) {