make all objects used with atomic operations volatile

[musl] / src / misc / getopt_long.c

diff --git a/src/misc/getopt_long.c b/src/misc/getopt_long.c
index 469ee92..480c001 100644 (file)
--- a/src/misc/getopt_long.c
+++ b/src/misc/getopt_long.c
@@ -2,6 +2,7 @@
 #include <stddef.h>
 #include <getopt.h>
 #include <stdio.h>
+#include <string.h>
 
 extern int __optpos, __optreset;
 
@@ -15,6 +16,8 @@ static void permute(char *const *argv, int dest, int src)
        av[dest] = tmp;
 }
 
+void __getopt_msg(const char *, const char *, const char *, size_t);
+
 static int __getopt_long_core(int argc, char *const *argv, const char *optstring, const struct option *longopts, int *idx, int longonly);
 
 static int __getopt_long(int argc, char *const *argv, const char *optstring, const struct option *longopts, int *idx, int longonly)
@@ -31,10 +34,7 @@ static int __getopt_long(int argc, char *const *argv, const char *optstring, con
                int i;
                for (i=optind; ; i++) {
                        if (i >= argc || !argv[i]) return -1;
-                       if (argv[i][0] != '-') continue;
-                       if (!argv[i][1]) continue;
-                       if (argv[i][1] == '-' && !argv[i][2]) return -1;
-                       break;
+                       if (argv[i][0] == '-' && argv[i][1]) break;
                }
                optind = i;
        }
@@ -51,11 +51,12 @@ static int __getopt_long(int argc, char *const *argv, const char *optstring, con
 
 static int __getopt_long_core(int argc, char *const *argv, const char *optstring, const struct option *longopts, int *idx, int longonly)
 {
-
-       if (argv[optind][0] == '-' &&
+       optarg = 0;
+       if (longopts && argv[optind][0] == '-' &&
                ((longonly && argv[optind][1]) ||
                 (argv[optind][1] == '-' && argv[optind][2])))
        {
+               int colon = optstring[optstring[0]=='+'||optstring[0]=='-']==':';
                int i, cnt, match;
                char *opt;
                for (cnt=i=0; longopts[i].name; i++) {
@@ -74,15 +75,29 @@ static int __getopt_long_core(int argc, char *const *argv, const char *optstring
                if (cnt==1) {
                        i = match;
                        optind++;
+                       optopt = longopts[i].val;
                        if (*opt == '=') {
-                               if (!longopts[i].has_arg) return '?';
+                               if (!longopts[i].has_arg) {
+                                       if (colon || !opterr)
+                                               return '?';
+                                       __getopt_msg(argv[0],
+                                               ": option does not take an argument: ",
+                                               longopts[i].name,
+                                               strlen(longopts[i].name));
+                                       return '?';
+                               }
                                optarg = opt+1;
-                       } else {
-                               if (longopts[i].has_arg == required_argument) {
-                                       if (!(optarg = argv[optind]))
-                                               return ':';
-                                       optind++;
-                               } else optarg = NULL;
+                       } else if (longopts[i].has_arg == required_argument) {
+                               if (!(optarg = argv[optind])) {
+                                       if (colon) return ':';
+                                       if (!opterr) return '?';
+                                       __getopt_msg(argv[0],
+                                               ": option requires an argument: ",
+                                               longopts[i].name,
+                                               strlen(longopts[i].name));
+                                       return '?';
+                               }
+                               optind++;
                        }
                        if (idx) *idx = i;
                        if (longopts[i].flag) {
@@ -92,6 +107,12 @@ static int __getopt_long_core(int argc, char *const *argv, const char *optstring
                        return longopts[i].val;
                }
                if (argv[optind][1] == '-') {
+                       if (!colon && opterr)
+                               __getopt_msg(argv[0], cnt ?
+                                       ": option is ambiguous: " :
+                                       ": unrecognized option: ",
+                                       argv[optind]+2,
+                                       strlen(argv[optind]+2));
                        optind++;
                        return '?';
                }