[epoint] Re: mailing list

From: <info_AT_x-dsl.hu>
Date: Sat, 28 Jan 2012 15:36:20 +0100

Hello Szabolcs,

This issue seems to have been around since the start:

func newDebitCert()

if oldcert.Balance > 0 && cert.Balance < 0 {
            return nil, fmt.Errorf("insufficient funds: %d",
oldcert.Balance)
}

This means that for a depleted (oldcert.Balance==0) holder account (for
a non-existent account different branch applies) it is possible to go
negative (we found empirically) !

My proposal is:
if oldcert.Balance >= 0 && ...

=============
Other proposals:
err = db.Set("certby/key.issuer.serial", fmt.Sprintf("%s.%09d",
w.account, cert.Serial),

%09d is an arbitrary choice, while unnecessary to choose any number.
%d seems to be more future proof, and less wasteful at the same time.

=============
const IntLimit = 1e15

I will deploy with
const IntLimit = 2e9
at least for now (which fits in signed 32 bits => means less testing
required), but this has no other consequence (except documentation,
maybe: we should probably advertise issue limit of 2 billion for now)
> ok i set up a mailing list and web page with git repo
> http://nsz.repo.hu/epoint/
>
Cool, now we have 2 mailing lists.

regards,
    Marcell
Received on Sat Jan 28 2012 - 15:36:20 CET

This archive was generated by hypermail 2.3.0 : Sat Sep 14 2013 - 19:00:01 CEST