From f305467aad4659e92fff84be6c89d4767b6f99d4 Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Wed, 20 Jun 2012 14:32:48 -0400 Subject: [PATCH] popen: handle issues with fd0/1 being closed also check for failure of dup2 and abort the child rather than reading/writing the wrong file. --- src/stdio/popen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/stdio/popen.c b/src/stdio/popen.c index 1d33e9d6..50765daa 100644 --- a/src/stdio/popen.c +++ b/src/stdio/popen.c @@ -31,9 +31,9 @@ FILE *popen(const char *cmd, const char *mode) close(p[1]); return NULL; case 0: - dup2(p[1-op], 1-op); - close(p[0]); - close(p[1]); + if (dup2(p[1-op], 1-op) < 0) _exit(127); + if (p[0] != 1-op) close(p[0]); + if (p[1] != 1-op) close(p[1]); execl("/bin/sh", "sh", "-c", cmd, (char *)0); _exit(127); } -- 2.20.1