From 52d4444f8eec1a4e7e0861859c705c3a558b4e2a Mon Sep 17 00:00:00 2001 From: Rich Felker Date: Wed, 26 Jun 2013 21:35:56 -0400 Subject: [PATCH] in sem_open, don't leak vm mapping if fstat fails fstat should not fail under normal circumstances, so this fix is mostly theoretical. --- src/thread/sem_open.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/thread/sem_open.c b/src/thread/sem_open.c index ed2353c8..8a72d4c6 100644 --- a/src/thread/sem_open.c +++ b/src/thread/sem_open.c @@ -82,8 +82,8 @@ sem_t *sem_open(const char *name, int flags, ...) if (flags != (O_CREAT|O_EXCL)) { fd = open(name, FLAGS); if (fd >= 0) { - if ((map = mmap(0, sizeof(sem_t), PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0)) == MAP_FAILED || - fstat(fd, &st) < 0) { + if (fstat(fd, &st) < 0 || + (map = mmap(0, sizeof(sem_t), PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0)) == MAP_FAILED) { close(fd); goto fail; } -- 2.20.1