musl
9 years agocleanup shared library build system to be more $HOME-local-install friendly
Rich Felker [Tue, 28 Jun 2011 01:38:11 +0000 (21:38 -0400)]
cleanup shared library build system to be more $HOME-local-install friendly

the path for the dynamic linker is now configurable, and failure to
install the symlink for it will not stop the build.

9 years agofurther fixup dlfcn.h
Rich Felker [Mon, 27 Jun 2011 05:02:28 +0000 (01:02 -0400)]
further fixup dlfcn.h

9 years agomatch LSB/glibc constants for dynamic loader
Rich Felker [Mon, 27 Jun 2011 05:01:19 +0000 (01:01 -0400)]
match LSB/glibc constants for dynamic loader

9 years agofix stale pointer issue in dynamic linker with dlopen
Rich Felker [Mon, 27 Jun 2011 02:39:34 +0000 (22:39 -0400)]
fix stale pointer issue in dynamic linker with dlopen

9 years agodon't leave the lock held on dlopen failure..
Rich Felker [Mon, 27 Jun 2011 02:09:32 +0000 (22:09 -0400)]
don't leave the lock held on dlopen failure..

9 years agoadd RTLD_DEFAULT support
Rich Felker [Mon, 27 Jun 2011 01:50:01 +0000 (21:50 -0400)]
add RTLD_DEFAULT support

9 years agoin dlopen: don't use null pointer
Rich Felker [Mon, 27 Jun 2011 01:36:44 +0000 (21:36 -0400)]
in dlopen: don't use null pointer

deps can be null if a library has no dependencies (such as libc itself)

9 years agofix resolving symbols in objects loaded in RTLD_LOCAL mode
Rich Felker [Mon, 27 Jun 2011 01:21:04 +0000 (21:21 -0400)]
fix resolving symbols in objects loaded in RTLD_LOCAL mode

basically we temporarily make the library and all its dependencies
part of the global namespace but only for the duration of performing
relocations, then return them to their former state.

9 years agoexperimental dlopen/dlsym and dynlink changes needed to support them
Rich Felker [Sun, 26 Jun 2011 23:23:28 +0000 (19:23 -0400)]
experimental dlopen/dlsym and dynlink changes needed to support them

9 years agotype directives for x86_64 math asm
Rich Felker [Sun, 26 Jun 2011 21:41:34 +0000 (17:41 -0400)]
type directives for x86_64 math asm

9 years agoerror handling in dynamic linking
Rich Felker [Sun, 26 Jun 2011 21:39:17 +0000 (17:39 -0400)]
error handling in dynamic linking

some of the code is not yet used, and is in preparation for dlopen
which needs to be able to handle failure loading libraries without
terminating the program.

9 years agofix useless use of potentially-uninitialized mode variable in sem_open
Rich Felker [Sun, 26 Jun 2011 20:34:05 +0000 (16:34 -0400)]
fix useless use of potentially-uninitialized mode variable in sem_open

9 years agoeliminate OOB array hacks in malloc
Rich Felker [Sun, 26 Jun 2011 20:12:43 +0000 (16:12 -0400)]
eliminate OOB array hacks in malloc

9 years agouse .type directives for math asm (needed for dynamic linking to work)
Rich Felker [Sun, 26 Jun 2011 19:52:37 +0000 (15:52 -0400)]
use .type directives for math asm (needed for dynamic linking to work)

9 years agofix some symbol resolution issues in dynamic linker
Rich Felker [Sun, 26 Jun 2011 02:36:21 +0000 (22:36 -0400)]
fix some symbol resolution issues in dynamic linker

1. search was wrongly beginning with lib itself rather than dso head
2. inconsistent resolution of function pointers for functions in plt

9 years agofix dynamic linker issue in musl-gcc wrapper
Rich Felker [Sat, 25 Jun 2011 22:57:17 +0000 (18:57 -0400)]
fix dynamic linker issue in musl-gcc wrapper

9 years agowordexp cannot use we_offs unless WRDE_DOOFFS flag is set
Rich Felker [Sat, 25 Jun 2011 22:54:33 +0000 (18:54 -0400)]
wordexp cannot use we_offs unless WRDE_DOOFFS flag is set

previously, a potentially-indeterminate value from we_offs was being
used, resulting in wrong we_wordc and subsequent crashes in the
caller.

9 years agoXSI search.h API implementation by Szabolcs Nagy
Rich Felker [Sat, 25 Jun 2011 22:18:57 +0000 (18:18 -0400)]
XSI search.h API implementation by Szabolcs Nagy

9 years agohandle library paths better (ignore empty path components, etc.)
Rich Felker [Sat, 25 Jun 2011 21:49:16 +0000 (17:49 -0400)]
handle library paths better (ignore empty path components, etc.)

9 years agomove all limits that don't vary out of bits/limits.h, into main limits.h
Rich Felker [Sat, 25 Jun 2011 19:38:00 +0000 (15:38 -0400)]
move all limits that don't vary out of bits/limits.h, into main limits.h

9 years agofix possible (questionable) strict aliasing violations and ptr arith
Rich Felker [Sat, 25 Jun 2011 16:26:08 +0000 (12:26 -0400)]
fix possible (questionable) strict aliasing violations and ptr arith

9 years agoconst correctness in mq_notify
Rich Felker [Sat, 25 Jun 2011 13:23:36 +0000 (09:23 -0400)]
const correctness in mq_notify

why did gcc allow this invalid assignment to compile in the first place?

9 years agoproper path searching for dynamic linker
Rich Felker [Sat, 25 Jun 2011 05:56:34 +0000 (01:56 -0400)]
proper path searching for dynamic linker

first, use $LD_LIBRARY_PATH unless suid. if that fails, read path from
/etc/ld-musl-$ARCH.path and fallback to a builtin default.

9 years agooptimize opendir using O_CLOEXEC
Rich Felker [Sat, 25 Jun 2011 05:38:25 +0000 (01:38 -0400)]
optimize opendir using O_CLOEXEC

9 years agodiscard dso descriptors after performing relocations
Rich Felker [Sat, 25 Jun 2011 04:47:28 +0000 (00:47 -0400)]
discard dso descriptors after performing relocations

eventually (once dlopen exists) this behavior will be conditional on
dlopen/dlsym not being reachable.

9 years agokeep track of which dsos have been relocated
Rich Felker [Sat, 25 Jun 2011 04:18:19 +0000 (00:18 -0400)]
keep track of which dsos have been relocated

9 years agouse soname in ld-musl.so to prevent filename appearing in DT_NEEDEDs
Rich Felker [Fri, 24 Jun 2011 22:32:30 +0000 (18:32 -0400)]
use soname in ld-musl.so to prevent filename appearing in DT_NEEDEDs

9 years agouse symlink rather than bogus linker script for libc.so
Rich Felker [Fri, 24 Jun 2011 18:02:47 +0000 (14:02 -0400)]
use symlink rather than bogus linker script for libc.so

the linker script caused a bogus DT_NEEDED entry

9 years agoadapt build/install/gcc-wrapper systems for dynamic linking support
Rich Felker [Fri, 24 Jun 2011 02:13:47 +0000 (22:13 -0400)]
adapt build/install/gcc-wrapper systems for dynamic linking support

9 years agoprepare support for LD_LIBRARY_PATH (checking suid/sgid safety)
Rich Felker [Fri, 24 Jun 2011 02:04:06 +0000 (22:04 -0400)]
prepare support for LD_LIBRARY_PATH (checking suid/sgid safety)

the use of this test will be much stricter than glibc and other
typical implementations; the environment will not be honored
whatsoever unless the program is confirmed non-suid/sgid by the aux
vector the kernel passed in. no fallback to slow syscall-based
checking is used if the kernel fails to provide the information; we
simply assume the worst (suid) in this case and refuse to honor
environment.

9 years agoinitial commit of prng implementation by Szabolcs Nagy
Rich Felker [Thu, 23 Jun 2011 22:02:23 +0000 (18:02 -0400)]
initial commit of prng implementation by Szabolcs Nagy

9 years agomake ldso asm more uniform with rest of codebase (no unnecessary suffixes)
Rich Felker [Mon, 20 Jun 2011 02:42:10 +0000 (22:42 -0400)]
make ldso asm more uniform with rest of codebase (no unnecessary suffixes)

9 years agox86_64: ensure that dtor pointer passed to app is 0 so it won't be used
Rich Felker [Sun, 19 Jun 2011 12:33:27 +0000 (08:33 -0400)]
x86_64: ensure that dtor pointer passed to app is 0 so it won't be used

leaving it uninitialized caused unpredictable crashes or worse due to
calling an indeterminate function pointer.

9 years agodynamic linker 64bit fix: hash table entries are always 32bit
Rich Felker [Sun, 19 Jun 2011 02:52:01 +0000 (22:52 -0400)]
dynamic linker 64bit fix: hash table entries are always 32bit

9 years agoexperimental dynamic linker!
Rich Felker [Sat, 18 Jun 2011 23:48:42 +0000 (19:48 -0400)]
experimental dynamic linker!

some notes:
- library search path is hard coded
- x86_64 code is untested and may not work
- dlopen/dlsym is not yet implemented
- relocations in read-only memory won't work

9 years agofix memory leak on failure in realpath
Rich Felker [Sat, 18 Jun 2011 11:41:14 +0000 (07:41 -0400)]
fix memory leak on failure in realpath

9 years agocopy-paste error in prctl.h
Rich Felker [Sat, 18 Jun 2011 11:39:05 +0000 (07:39 -0400)]
copy-paste error in prctl.h

9 years agofix some struct padding to match LSB/glibc ABI where it may be helpful
Rich Felker [Thu, 16 Jun 2011 21:11:35 +0000 (17:11 -0400)]
fix some struct padding to match LSB/glibc ABI where it may be helpful

9 years agoduplicate re_nsub in LSB/glibc ABI compatible location
Rich Felker [Thu, 16 Jun 2011 20:53:11 +0000 (16:53 -0400)]
duplicate re_nsub in LSB/glibc ABI compatible location

9 years agorestore use of .type in asm, but use modern @function (vs %function)
Rich Felker [Wed, 15 Jun 2011 03:15:08 +0000 (23:15 -0400)]
restore use of .type in asm, but use modern @function (vs %function)

this seems to be necessary to make the linker accept the functions in
a shared library (perhaps to generate PLT entries?)

strictly speaking libc-internal asm should not need it. i might clean
that up later.

9 years ago__syscall5 inline is having trouble with PIC; just use the function for now
Rich Felker [Wed, 15 Jun 2011 03:14:22 +0000 (23:14 -0400)]
__syscall5 inline is having trouble with PIC; just use the function for now

9 years agofix race condition in pthread_kill
Rich Felker [Tue, 14 Jun 2011 05:35:51 +0000 (01:35 -0400)]
fix race condition in pthread_kill

if thread id was reused by the kernel between the time pthread_kill
read it from the userspace pthread_t object and the time of the tgkill
syscall, a signal could be sent to the wrong thread. the tgkill
syscall was supposed to prevent this race (versus the old tkill
syscall) but it can't; it can only help in the case where the tid is
reused in a different process, but not when the tid is reused in the
same process.

the only solution i can see is an extra lock to prevent threads from
exiting while another thread is trying to pthread_kill them. it should
be very very cheap in the non-contended case.

9 years agorun dtors before taking the exit-lock in pthread exit
Rich Felker [Tue, 14 Jun 2011 05:25:17 +0000 (01:25 -0400)]
run dtors before taking the exit-lock in pthread exit

previously a long-running dtor could cause pthread_detach to block.

9 years agominor locking optimizations
Rich Felker [Tue, 14 Jun 2011 05:23:42 +0000 (01:23 -0400)]
minor locking optimizations

9 years agoavoid 64bit warnings when using pointers as entropy for temp names
Rich Felker [Tue, 14 Jun 2011 00:52:01 +0000 (20:52 -0400)]
avoid 64bit warnings when using pointers as entropy for temp names

9 years agofix sigset macro for 64-bit systems (<< was overflowing due to wrong type)
Rich Felker [Tue, 14 Jun 2011 00:37:52 +0000 (20:37 -0400)]
fix sigset macro for 64-bit systems (<< was overflowing due to wrong type)

9 years agoremove all .size and .type directives for functions from the asm
Rich Felker [Tue, 14 Jun 2011 00:28:14 +0000 (20:28 -0400)]
remove all .size and .type directives for functions from the asm

these are useless and have caused problems for users trying to build
with non-gnu tools like tcc's assembler.

9 years agoremove old useless timezone.s file (unused)
Rich Felker [Tue, 14 Jun 2011 00:21:21 +0000 (20:21 -0400)]
remove old useless timezone.s file (unused)

9 years agofix wrong type for wcsrchr argument 2
Rich Felker [Mon, 13 Jun 2011 18:06:04 +0000 (14:06 -0400)]
fix wrong type for wcsrchr argument 2

9 years agox86_64 fenv support (untested; at least known to build successfully)
Rich Felker [Mon, 13 Jun 2011 17:37:43 +0000 (13:37 -0400)]
x86_64 fenv support (untested; at least known to build successfully)

9 years agofix fesetround - it was writing to status word instead of control word
Rich Felker [Mon, 13 Jun 2011 17:37:16 +0000 (13:37 -0400)]
fix fesetround - it was writing to status word instead of control word

9 years agofloating point environment, untested
Rich Felker [Sun, 12 Jun 2011 19:58:15 +0000 (15:58 -0400)]
floating point environment, untested

at present the i386 code does not support sse floating point, which is
not part of the standard i386 abi. while it may be desirable to
support it later, doing so will reduce performance and require some
tricks to probe if sse support is present.

this first commit is i386-only, but it should be trivial to port the
asm to x86_64.

9 years agomalloc: cast size down to int in bin_index functions
Rich Felker [Sun, 12 Jun 2011 14:53:42 +0000 (10:53 -0400)]
malloc: cast size down to int in bin_index functions

even if size_t was 32-bit already, the fact that the value was
unsigned and that gcc is too stupid to figure out it would be positive
as a signed quantity (due to the immediately-prior arithmetic and
conditionals) results in gcc compiling the integer-to-float conversion
as zero extension to 64 bits followed by an "fildll" (64 bit)
instruction rather than a simple "fildl" (32 bit) instruction on x86.
reportedly fildll is very slow on certain p4-class machines; even if
not, the new code is slightly smaller.

9 years agoanother return value fix for mktemp...
Rich Felker [Sun, 12 Jun 2011 14:25:29 +0000 (10:25 -0400)]
another return value fix for mktemp...

9 years agoadd netpacket/packet.h
Rich Felker [Fri, 10 Jun 2011 01:47:24 +0000 (21:47 -0400)]
add netpacket/packet.h

looks like busybox is going to want it, and apparently some other
low-level network software does too...

9 years agoit's called getgrgid_r, not getgruid_r...
Rich Felker [Wed, 8 Jun 2011 20:47:08 +0000 (16:47 -0400)]
it's called getgrgid_r, not getgruid_r...

9 years agoimplement psignal and psiginfo
Rich Felker [Wed, 8 Jun 2011 20:41:44 +0000 (16:41 -0400)]
implement psignal and psiginfo

9 years agoisgreater etc. relation macros for math.h
Rich Felker [Wed, 8 Jun 2011 20:33:04 +0000 (16:33 -0400)]
isgreater etc. relation macros for math.h

9 years agomq names without leading / have impl-def behavior; allowing them is easier
Rich Felker [Tue, 7 Jun 2011 19:07:54 +0000 (15:07 -0400)]
mq names without leading / have impl-def behavior; allowing them is easier

9 years agodefine MQ_PRIO_MAX
Rich Felker [Tue, 7 Jun 2011 19:05:04 +0000 (15:05 -0400)]
define MQ_PRIO_MAX

9 years agouse __WCHAR_TYPE__ on i386 if it is defined
Rich Felker [Tue, 7 Jun 2011 15:26:42 +0000 (11:26 -0400)]
use __WCHAR_TYPE__ on i386 if it is defined

unfortunately traditional i386 practice was to use "long" rather than
"int" for wchar_t, despite the latter being much more natural and
logical. we followed this practice, but it seems some compilers (clang
and maybe certain gcc builds or others too..?) have switched to using
int, resulting in spurious pointer type mismatches when L"..." wide
strings are used. the best solution I could find is to use the
compiler's definition of wchar_t if it exists, and otherwise fallback
to the traditional definition.

there's no point in duplicating this approach on 64-bit archs, as
their only 32-bit type is int.

9 years agomq send/recv functions are cancellation points
Rich Felker [Tue, 7 Jun 2011 15:14:39 +0000 (11:14 -0400)]
mq send/recv functions are cancellation points

9 years agoimplement mq_notify
Rich Felker [Tue, 7 Jun 2011 06:42:55 +0000 (02:42 -0400)]
implement mq_notify

9 years agoadd support for POSIX message queues, except mq_notify
Rich Felker [Tue, 7 Jun 2011 05:52:27 +0000 (01:52 -0400)]
add support for POSIX message queues, except mq_notify

9 years agouse __attribute__((const)) for errno and pthread_self if __GNUC__ is defined
Rich Felker [Tue, 7 Jun 2011 00:12:42 +0000 (20:12 -0400)]
use __attribute__((const)) for errno and pthread_self if __GNUC__ is defined

this is not too ugly and should result in significant code size and
performance improvements for many programs.

9 years agouse volatile pointers for intentional-crash code.
Rich Felker [Mon, 6 Jun 2011 22:10:43 +0000 (18:10 -0400)]
use volatile pointers for intentional-crash code.

9 years agofix handling of d_name in struct dirent
Rich Felker [Mon, 6 Jun 2011 22:04:28 +0000 (18:04 -0400)]
fix handling of d_name in struct dirent

basically there are 3 choices for how to implement this variable-size
string member:
1. C99 flexible array member: breaks using dirent.h with pre-C99 compiler.
2. old way: length-1 string: generates array bounds warnings in caller.
3. new way: length-NAME_MAX string. no problems, simplifies all code.

of course the usable part in the pointer returned by readdir might be
shorter than NAME_MAX+1 bytes, but that is allowed by the standard and
doesn't hurt anything.

9 years agosafety fix for glob's vla usage: disallow patterns longer than PATH_MAX
Rich Felker [Sun, 5 Jun 2011 23:29:52 +0000 (19:29 -0400)]
safety fix for glob's vla usage: disallow patterns longer than PATH_MAX

this actually inadvertently disallows some valid patterns with
redundant / or * characters, but it's better than allowing unbounded
vla allocation.

eventually i'll write code to move the pattern to the stack and
eliminate redundancy to ensure that it fits in PATH_MAX at the
beginning of glob. this would also allow it to be modified in place
for passing to fnmatch rather than copied at each level of recursion.

9 years agoeliminate (harmless in this case) vla usage in fnmatch.c
Rich Felker [Sun, 5 Jun 2011 17:30:56 +0000 (13:30 -0400)]
eliminate (harmless in this case) vla usage in fnmatch.c

9 years agomissing prototypes for mbsnrtowcs and wcsnrtombs
Rich Felker [Mon, 30 May 2011 17:32:40 +0000 (13:32 -0400)]
missing prototypes for mbsnrtowcs and wcsnrtombs

9 years agoimplement pthread_[sg]etconcurrency.
Rich Felker [Mon, 30 May 2011 15:31:07 +0000 (11:31 -0400)]
implement pthread_[sg]etconcurrency.

there is a resource limit of 0 bits to store the concurrency level
requested. thus any positive level exceeds a resource limit, resulting
in EAGAIN. :-)

9 years agoimplement uselocale function (minimal)
Rich Felker [Mon, 30 May 2011 05:41:23 +0000 (01:41 -0400)]
implement uselocale function (minimal)

9 years agoadd useless, obsolescent function ulimit
Rich Felker [Sun, 29 May 2011 18:09:03 +0000 (14:09 -0400)]
add useless, obsolescent function ulimit

9 years agofix backwards posix_spawn file action order
Rich Felker [Sun, 29 May 2011 16:58:02 +0000 (12:58 -0400)]
fix backwards posix_spawn file action order

9 years agoadd accidentally-omitted file needed for posix_spawn file actions
Rich Felker [Sun, 29 May 2011 03:31:11 +0000 (23:31 -0400)]
add accidentally-omitted file needed for posix_spawn file actions

9 years agoadd file actions support to posix_spawn
Rich Felker [Sun, 29 May 2011 03:30:47 +0000 (23:30 -0400)]
add file actions support to posix_spawn

9 years agoposix_spawn: honor POSIX_SPAWN_SETSIGDEF flag
Rich Felker [Sat, 28 May 2011 22:39:43 +0000 (18:39 -0400)]
posix_spawn: honor POSIX_SPAWN_SETSIGDEF flag

9 years agoinitial implementation of posix_spawn
Rich Felker [Sat, 28 May 2011 22:36:30 +0000 (18:36 -0400)]
initial implementation of posix_spawn

file actions are not yet implemented, but everything else should be
mostly complete and roughly correct.

9 years agomodernize coding style in sjlj asm
Rich Felker [Fri, 27 May 2011 00:59:02 +0000 (20:59 -0400)]
modernize coding style in sjlj asm

9 years agofix strncat and wcsncat (double null termination)
Rich Felker [Mon, 23 May 2011 01:58:43 +0000 (21:58 -0400)]
fix strncat and wcsncat (double null termination)

also modify wcsncpy to use the same loop logic

9 years agofix wcsncpy writing past end of buffer
Rich Felker [Mon, 23 May 2011 01:54:42 +0000 (21:54 -0400)]
fix wcsncpy writing past end of buffer

9 years agofix brk/sbrk behavior to match the real legacy functions
Rich Felker [Sun, 22 May 2011 16:34:33 +0000 (12:34 -0400)]
fix brk/sbrk behavior to match the real legacy functions

9 years agorelease notes for 0.7.10
Rich Felker [Tue, 17 May 2011 18:13:06 +0000 (14:13 -0400)]
release notes for 0.7.10

9 years agofix the last known rounding bug in floating point printing
Rich Felker [Wed, 11 May 2011 23:58:03 +0000 (19:58 -0400)]
fix the last known rounding bug in floating point printing

the observed symptom was that the code was incorrectly rounding up
1.0625 to 1.063 despite the rounding mode being round-to-nearest with
ties broken by rounding to even last place. however, the code was just
not right in many respects, and i'm surprised it worked as well as it
did. this time i tested the values that end up in the variables round,
small, and the expression round+small, and all look good.

9 years agoeventfd syscall wrapper and read/write wrappers
Rich Felker [Sun, 8 May 2011 04:03:00 +0000 (00:03 -0400)]
eventfd syscall wrapper and read/write wrappers

9 years agooptimize out useless default-attribute object in pthread_create
Rich Felker [Sun, 8 May 2011 03:39:48 +0000 (23:39 -0400)]
optimize out useless default-attribute object in pthread_create

9 years agooptimize compound-literal sigset_t's not to contain useless hurd bits
Rich Felker [Sun, 8 May 2011 03:37:10 +0000 (23:37 -0400)]
optimize compound-literal sigset_t's not to contain useless hurd bits

9 years agooverhaul implementation-internal signal protections
Rich Felker [Sun, 8 May 2011 03:23:58 +0000 (23:23 -0400)]
overhaul implementation-internal signal protections

the new approach relies on the fact that the only ways to create
sigset_t objects without invoking UB are to use the sig*set()
functions, or from the masks returned by sigprocmask, sigaction, etc.
or in the ucontext_t argument to a signal handler. thus, as long as
sigfillset and sigaddset avoid adding the "protected" signals, there
is no way the application will ever obtain a sigset_t including these
bits, and thus no need to add the overhead of checking/clearing them
when sigprocmask or sigaction is called.

note that the old code actually *failed* to remove the bits from
sa_mask when sigaction was called.

the new implementations are also significantly smaller, simpler, and
faster due to ignoring the useless "GNU HURD signals" 65-1024, which
are not used and, if there's any sanity in the world, never will be
used.

9 years agoreduce some ridiculously large spin counts
Rich Felker [Sat, 7 May 2011 01:45:48 +0000 (21:45 -0400)]
reduce some ridiculously large spin counts

these should be tweaked according to testing. offhand i know 1000 is
too low and 5000 is likely to be sufficiently high. consider trying to
add futexes to file locking, too...

9 years agoremove debug code that was missed in barrier commit
Rich Felker [Sat, 7 May 2011 00:27:45 +0000 (20:27 -0400)]
remove debug code that was missed in barrier commit

9 years agocompletely new barrier implementation, addressing major correctness issues
Rich Felker [Sat, 7 May 2011 00:00:59 +0000 (20:00 -0400)]
completely new barrier implementation, addressing major correctness issues

the previous implementation had at least 2 problems:

1. the case where additional threads reached the barrier before the
first wave was finished leaving the barrier was untested and seemed
not to be working.

2. threads leaving the barrier continued to access memory within the
barrier object after other threads had successfully returned from
pthread_barrier_wait. this could lead to memory corruption or crashes
if the barrier object had automatic storage in one of the waiting
threads and went out of scope before all threads finished returning,
or if one thread unmapped the memory in which the barrier object
lived.

the new implementation avoids both problems by making the barrier
state essentially local to the first thread which enters the barrier
wait, and forces that thread to be the last to return.

9 years agoadd SA_NOMASK alias for SA_NODEFER with _GNU_SOURCE
Rich Felker [Thu, 5 May 2011 21:44:06 +0000 (17:44 -0400)]
add SA_NOMASK alias for SA_NODEFER with _GNU_SOURCE

9 years agofix fclose return status logic, again
Rich Felker [Mon, 2 May 2011 13:18:03 +0000 (09:18 -0400)]
fix fclose return status logic, again

the previous fix was incorrect, as it would prevent f->close(f) from
being called if fflush(f) failed. i believe this was the original
motivation for using | rather than ||. so now let's just use a second
statement to constrain the order of function calls, and to back to
using |.

9 years agofix undefined call order in fclose, possible lost output depending on compiler
Rich Felker [Mon, 2 May 2011 02:59:14 +0000 (22:59 -0400)]
fix undefined call order in fclose, possible lost output depending on compiler

pcc turned up this bug by calling f->close(f) before fflush(f),
resulting in lost output and error on flush.

9 years agoworkaround for preprocessor bug in pcc
Rich Felker [Mon, 2 May 2011 02:16:04 +0000 (22:16 -0400)]
workaround for preprocessor bug in pcc

with this patch, musl compiles and mostly works with pcc 1.0.0. a few
tests are still failing and i'm uncertain whether they are due to
portability problems in musl, or bugs in pcc, but i suspect the
latter.

9 years agominor optimization in puts: use inline putc_unlocked macro for newline
Rich Felker [Mon, 2 May 2011 00:12:51 +0000 (20:12 -0400)]
minor optimization in puts: use inline putc_unlocked macro for newline

9 years agoavoid crashing when nel==0 is passed to qsort
Rich Felker [Fri, 29 Apr 2011 15:14:55 +0000 (11:14 -0400)]
avoid crashing when nel==0 is passed to qsort

9 years agouse compiler builtins for variadic macros when available
Rich Felker [Thu, 28 Apr 2011 03:41:48 +0000 (23:41 -0400)]
use compiler builtins for variadic macros when available

this slightly cuts down on the degree musl "fights with" gcc, but more
importantly, it fixes a critical bug when gcc inlines a variadic
function and optimizes out the variadic arguments due to noticing that
they were "not used" (by __builtin_va_arg).

we leave the old code in place if __GNUC__ >= 3 is false; it seems
like it might be necessary at least for tinycc support and perhaps if
anyone ever gets around to fixing gcc 2.95.3 enough to make it work..

9 years agocorrect variadic prototypes for execl* family
Rich Felker [Wed, 27 Apr 2011 20:06:33 +0000 (16:06 -0400)]
correct variadic prototypes for execl* family

the old versions worked, but conflicted with programs which declared
their own prototypes and generated warnings with some versions of gcc.

9 years agoreplace heap sort with smoothsort implementation by Valentin Ochs
Rich Felker [Wed, 27 Apr 2011 17:27:04 +0000 (13:27 -0400)]
replace heap sort with smoothsort implementation by Valentin Ochs

Smoothsort is an adaptive variant of heapsort. This version was
written by Valentin Ochs (apo) specifically for inclusion in musl. I
worked with him to get it working in O(1) memory usage even with giant
array element widths, and to optimize it heavily for size and speed.
It's still roughly 4 times as large as the old heap sort
implementation, but roughly 20 times faster given an almost-sorted
array of 1M elements (20 being the base-2 log of 1M), i.e. it really
does reduce O(n log n) to O(n) in the mostly-sorted case. It's still
somewhat slower than glibc's Introsort for random input, but now
considerably faster than glibc when the input is already sorted, or
mostly sorted.