From: Rich Felker <dalias@aerifal.cx>
Date: Tue, 28 Feb 2023 17:18:43 +0000 (-0500)
Subject: fix pipe2 silently ignoring unknown flags on old kernels
X-Git-Url: http://nsz.repo.hu/git/?p=musl;a=commitdiff_plain;h=fb7fb5e4bd7ccb8efa691364404efc7804fad90c

fix pipe2 silently ignoring unknown flags on old kernels

kernels using the fallback have an inherent close-on-exec race
condition and as such support for them is only best-effort anyway.
however, ignoring potential new flags is still very bad behavior.
instead, fail with EINVAL.
---

diff --git a/src/unistd/pipe2.c b/src/unistd/pipe2.c
index f24f74fb..a096990b 100644
--- a/src/unistd/pipe2.c
+++ b/src/unistd/pipe2.c
@@ -8,6 +8,7 @@ int pipe2(int fd[2], int flag)
 	if (!flag) return pipe(fd);
 	int ret = __syscall(SYS_pipe2, fd, flag);
 	if (ret != -ENOSYS) return __syscall_ret(ret);
+	if (flag & ~(O_CLOEXEC|O_NONBLOCK)) return __syscall_ret(-EINVAL);
 	ret = pipe(fd);
 	if (ret) return ret;
 	if (flag & O_CLOEXEC) {