From: Rich Felker Date: Tue, 5 Mar 2013 00:22:14 +0000 (-0500) Subject: fix types for wctype_t and wctrans_t X-Git-Url: http://nsz.repo.hu/git/?p=musl;a=commitdiff_plain;h=da1442c9a8c58f8ad85a1bd96007f60bc372d157;hp=da1442c9a8c58f8ad85a1bd96007f60bc372d157;ds=sidebyside fix types for wctype_t and wctrans_t wctype_t was incorrectly "int" rather than "long" on x86_64. not only is this an ABI incompatibility; it's also a major design flaw if we ever wanted wctype_t to be implemented as a pointer, which would be necessary if locales support custom character classes, since int is too small to store a converted pointer. this commit fixes wctype_t to be unsigned long on all archs, matching the LSB ABI; this change does not matter for C code, but for C++ it affects mangling. the same issue applied to wctrans_t. glibc/LSB defines this type as const __int32_t *, but since no such definition is visible, I've just expanded the definition, int, everywhere. it would be nice if these types (which don't vary by arch) could be in wctype.h, but the OB XSI requirement in POSIX that wchar.h expose some types and functions from wctype.h precludes doing so. glibc works around this with some hideous hacks, but trying to duplicate that would go against the intent of musl's headers. ---