From: Rich Felker Date: Fri, 5 Aug 2011 10:43:45 +0000 (-0400) Subject: fix off-by-one bug in siglongjmp that caused unpredictable behavior X-Git-Url: http://nsz.repo.hu/git/?p=musl;a=commitdiff_plain;h=338b663ddb64ecf8a62ad0d1020a29587e0ca81b fix off-by-one bug in siglongjmp that caused unpredictable behavior if saved, signal mask would not be restored unless some low signals were masked. if not saved, signal mask could be wrongly restored to uninitialized values. in any, wrong mask would be restored. i believe this function was written for a very old version of the jmp_buf structure which did not contain a final 0 field for compatibility with siglongjmp, and never updated... --- diff --git a/src/signal/siglongjmp.c b/src/signal/siglongjmp.c index 17129175..600d560c 100644 --- a/src/signal/siglongjmp.c +++ b/src/signal/siglongjmp.c @@ -4,7 +4,7 @@ void siglongjmp(sigjmp_buf buf, int ret) { - unsigned long *flag = buf + sizeof(jmp_buf)/sizeof(long); + unsigned long *flag = buf + sizeof(jmp_buf)/sizeof(long) - 1; sigset_t *mask = (void *)(flag + 1); if (*flag) sigprocmask (SIG_SETMASK, mask, NULL);