fix off-by-one bug in siglongjmp that caused unpredictable behavior

if saved, signal mask would not be restored unless some low signals
were masked. if not saved, signal mask could be wrongly restored to
uninitialized values. in any, wrong mask would be restored.

i believe this function was written for a very old version of the
jmp_buf structure which did not contain a final 0 field for
compatibility with siglongjmp, and never updated...

diff --git a/src/signal/siglongjmp.c b/src/signal/siglongjmp.c
index 1712917..600d560 100644 (file)
--- a/src/signal/siglongjmp.c
+++ b/src/signal/siglongjmp.c
@@ -4,7 +4,7 @@
 
 void siglongjmp(sigjmp_buf buf, int ret)
 {
-       unsigned long *flag = buf + sizeof(jmp_buf)/sizeof(long);
+       unsigned long *flag = buf + sizeof(jmp_buf)/sizeof(long) - 1;
        sigset_t *mask = (void *)(flag + 1);
        if (*flag)
                sigprocmask (SIG_SETMASK, mask, NULL);