fix issue with longjmp out of signal handlers and cancellation
authorRich Felker <dalias@aerifal.cx>
Wed, 23 May 2012 19:45:41 +0000 (15:45 -0400)
committerRich Felker <dalias@aerifal.cx>
Wed, 23 May 2012 19:45:41 +0000 (15:45 -0400)
commit4da268f74b90696563db4f5d9d2b8e1c1351bdc6
tree6248d447902f2a011c70e2b207e600718bed77a4
parentcfd892fde9454e014d9b291a56ce5740d8bc4a78
fix issue with longjmp out of signal handlers and cancellation

stale state information indicating that a thread was possibly blocked
at a cancellation point could get left behind if longjmp was used to
exit a signal handler that interrupted a cancellation point.

to fix the issue, we throw away the state information entirely and
simply compare the saved instruction pointer to a range of code
addresses in the __syscall_cp_asm function. all the ugly PIC work
(which becomes minimal anyway with this approach) is defered to
cancellation time instead of happening at every syscall, which should
improve performance too.

this commit also fixes cancellation on arm, which was mildly broken
(race condition, not checking cancellation flag once inside the
cancellation point zone). apparently i forgot to implement that. the
new arm code is untested, but appears correct; i'll test and fix it
later if there are problems.
src/thread/arm/syscall_cp.s
src/thread/cancel_impl.c
src/thread/i386/syscall_cp.s
src/thread/x86_64/syscall_cp.s