X-Git-Url: http://nsz.repo.hu/git/?p=musl;a=blobdiff_plain;f=src%2Fthread%2Fsem_open.c;h=9a95d257172096f6bd933005adb1299bbecf00c9;hp=8a72d4c62a317314e077716c7569306a349a90c8;hb=7c20a11801fd56cbadac5a6e88ddddf8656ac1bc;hpb=52d4444f8eec1a4e7e0861859c705c3a558b4e2a diff --git a/src/thread/sem_open.c b/src/thread/sem_open.c index 8a72d4c6..9a95d257 100644 --- a/src/thread/sem_open.c +++ b/src/thread/sem_open.c @@ -67,15 +67,15 @@ sem_t *sem_open(const char *name, int flags, ...) flags &= (O_CREAT|O_EXCL); + pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &cs); + /* Early failure check for exclusive open; otherwise the case * where the semaphore already exists is expensive. */ if (flags == (O_CREAT|O_EXCL) && access(name, F_OK) == 0) { errno = EEXIST; - return SEM_FAILED; + goto fail; } - pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &cs); - for (;;) { /* If exclusive mode is not requested, try opening an * existing file first and fall back to creation. */ @@ -123,9 +123,9 @@ sem_t *sem_open(const char *name, int flags, ...) goto fail; } close(fd); - if (link(tmp, name) == 0) break; - e = errno; + e = link(tmp, name) ? errno : 0; unlink(tmp); + if (!e) break; /* Failure is only fatal when doing an exclusive open; * otherwise, next iteration will try to open the * existing file. */ @@ -153,6 +153,9 @@ sem_t *sem_open(const char *name, int flags, ...) fail: pthread_setcancelstate(cs, 0); + LOCK(lock); + semtab[slot].sem = 0; + UNLOCK(lock); return SEM_FAILED; }