X-Git-Url: http://nsz.repo.hu/git/?p=musl;a=blobdiff_plain;f=src%2Fthread%2Fpthread_cond_timedwait.c;h=1f25c8e7b52ff2d8658d5021f2491a4dffbce0c6;hp=e3dc8147c8b3ae89569a6f4d4a2751147ed5d9e4;hb=HEAD;hpb=1fa05210100caefc8546746e08358d81739f4b41 diff --git a/src/thread/pthread_cond_timedwait.c b/src/thread/pthread_cond_timedwait.c index e3dc8147..1f25c8e7 100644 --- a/src/thread/pthread_cond_timedwait.c +++ b/src/thread/pthread_cond_timedwait.c @@ -7,26 +7,26 @@ struct cm { static void unwait(pthread_cond_t *c, pthread_mutex_t *m) { - int w; - /* Removing a waiter is non-trivial if we could be using requeue * based broadcast signals, due to mutex access issues, etc. */ if (c->_c_mutex == (void *)-1) { a_dec(&c->_c_waiters); + if (c->_c_destroy) __wake(&c->_c_waiters, 1, 0); return; } while (a_swap(&c->_c_lock, 1)) __wait(&c->_c_lock, &c->_c_lockwait, 1, 1); - /* Atomically decrement waiters2 if positive, else mutex waiters. */ - do w = c->_c_waiters2; - while (w && a_cas(&c->_c_waiters2, w, w-1)!=w); - if (!w) a_dec(&m->_m_waiters); + if (c->_c_waiters2) c->_c_waiters2--; + else a_dec(&m->_m_waiters); a_store(&c->_c_lock, 0); if (c->_c_lockwait) __wake(&c->_c_lock, 1, 1); + + a_dec(&c->_c_waiters); + if (c->_c_destroy) __wake(&c->_c_waiters, 1, 1); } static void cleanup(void *p) @@ -36,24 +36,33 @@ static void cleanup(void *p) pthread_mutex_lock(cm->m); } -int pthread_cond_timedwait(pthread_cond_t *c, pthread_mutex_t *m, const struct timespec *ts) +int pthread_cond_timedwait(pthread_cond_t *restrict c, pthread_mutex_t *restrict m, const struct timespec *restrict ts) { struct cm cm = { .c=c, .m=m }; int r, e=0, seq; + if (m->_m_type && (m->_m_lock&INT_MAX) != pthread_self()->tid) + return EPERM; + if (ts && ts->tv_nsec >= 1000000000UL) return EINVAL; pthread_testcancel(); - if (c->_c_mutex != (void *)-1) c->_c_mutex = m; - a_inc(&c->_c_waiters); - a_inc(&c->_c_waiters2); + + if (c->_c_mutex != (void *)-1) { + c->_c_mutex = m; + while (a_swap(&c->_c_lock, 1)) + __wait(&c->_c_lock, &c->_c_lockwait, 1, 1); + c->_c_waiters2++; + a_store(&c->_c_lock, 0); + if (c->_c_lockwait) __wake(&c->_c_lock, 1, 1); + } seq = c->_c_seq; - if ((r=pthread_mutex_unlock(m))) return r; + pthread_mutex_unlock(m); do e = __timedwait(&c->_c_seq, seq, c->_c_clock, ts, cleanup, &cm, 0); while (c->_c_seq == seq && (!e || e==EINTR));