remove no-longer-needed unblocking of signals in pthread_create

[musl] / src / thread / pthread_create.c

diff --git a/src/thread/pthread_create.c b/src/thread/pthread_create.c
index 6545539..5b34e7e 100644 (file)
--- a/src/thread/pthread_create.c
+++ b/src/thread/pthread_create.c
@@ -1,33 +1,35 @@
 #include "pthread_impl.h"
+#include "stdio_impl.h"
 
 static void dummy_0()
 {
 }
-weak_alias(dummy_0, __rsyscall_lock);
-weak_alias(dummy_0, __rsyscall_unlock);
+weak_alias(dummy_0, __synccall_lock);
+weak_alias(dummy_0, __synccall_unlock);
 weak_alias(dummy_0, __pthread_tsd_run_dtors);
 
-#ifdef __pthread_unwind_next
-#undef __pthread_unwind_next
-#define __pthread_unwind_next __pthread_unwind_next_3
-#endif
-
-void __pthread_unwind_next(struct __ptcb *cb)
+void pthread_exit(void *result)
 {
        pthread_t self = pthread_self();
        int n;
 
-       if (cb->__next) {
-               self->cancelbuf = cb->__next->__next;
-               longjmp((void *)cb->__next->__jb, 1);
-       }
+       self->result = result;
 
-       LOCK(&self->exitlock);
+       while (self->cancelbuf) {
+               void (*f)(void *) = self->cancelbuf->__f;
+               void *x = self->cancelbuf->__x;
+               self->cancelbuf = self->cancelbuf->__next;
+               f(x);
+       }
 
        __pthread_tsd_run_dtors();
 
+       __lock(&self->exitlock);
+
        /* Mark this thread dead before decrementing count */
+       __lock(&self->killlock);
        self->dead = 1;
+       a_store(&self->killlock, 0);
 
        do n = libc.threads_minus_1;
        while (n && a_cas(&libc.threads_minus_1, n, n-1)!=n);
@@ -41,43 +43,68 @@ void __pthread_unwind_next(struct __ptcb *cb)
        __syscall(SYS_exit, 0);
 }
 
+void __do_cleanup_push(struct __ptcb *cb)
+{
+       struct pthread *self = pthread_self();
+       cb->__next = self->cancelbuf;
+       self->cancelbuf = cb;
+}
+
+void __do_cleanup_pop(struct __ptcb *cb)
+{
+       __pthread_self()->cancelbuf = cb->__next;
+}
+
 static int start(void *p)
 {
-       struct pthread *self = p;
+       pthread_t self = p;
        if (self->unblock_cancel)
-               __syscall(SYS_rt_sigprocmask, SIG_UNBLOCK, &SIGPT_SET, 0, 8);
+               __syscall(SYS_rt_sigprocmask, SIG_UNBLOCK, SIGPT_SET, 0, 8);
        pthread_exit(self->start(self->start_arg));
        return 0;
 }
 
-int __uniclone(void *, int (*)(), void *);
-
 #define ROUND(x) (((x)+PAGE_SIZE-1)&-PAGE_SIZE)
 
 /* pthread_key_create.c overrides this */
 static const size_t dummy = 0;
 weak_alias(dummy, __pthread_tsd_size);
 
+static FILE *const dummy_file = 0;
+weak_alias(dummy_file, __stdin_used);
+weak_alias(dummy_file, __stdout_used);
+weak_alias(dummy_file, __stderr_used);
+
+static void init_file_lock(FILE *f)
+{
+       if (f && f->lock<0) f->lock = 0;
+}
+
 int pthread_create(pthread_t *res, const pthread_attr_t *attr, void *(*entry)(void *), void *arg)
 {
        int ret;
-       size_t size, guard;
+       size_t size = DEFAULT_STACK_SIZE + DEFAULT_GUARD_SIZE;
+       size_t guard = DEFAULT_GUARD_SIZE;
        struct pthread *self = pthread_self(), *new;
        unsigned char *map, *stack, *tsd;
-       const pthread_attr_t default_attr = { 0 };
 
        if (!self) return ENOSYS;
        if (!libc.threaded) {
-               __syscall(SYS_rt_sigprocmask, SIG_UNBLOCK, &SIGPT_SET, 0, 8);
+               for (FILE *f=libc.ofl_head; f; f=f->next)
+                       init_file_lock(f);
+               init_file_lock(__stdin_used);
+               init_file_lock(__stdout_used);
+               init_file_lock(__stderr_used);
                libc.threaded = 1;
        }
 
-       if (!attr) attr = &default_attr;
-       guard = ROUND(attr->_a_guardsize + DEFAULT_GUARD_SIZE);
-       size = guard + ROUND(attr->_a_stacksize + DEFAULT_STACK_SIZE);
+       if (attr) {
+               guard = ROUND(attr->_a_guardsize + DEFAULT_GUARD_SIZE);
+               size = guard + ROUND(attr->_a_stacksize + DEFAULT_STACK_SIZE);
+       }
        size += __pthread_tsd_size;
-       map = mmap(0, size, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANON, -1, 0);
-       if (!map) return EAGAIN;
+       map = mmap(0, size, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANON, -1, 0);
+       if (map == MAP_FAILED) return EAGAIN;
        if (guard) mprotect(map, guard, PROT_NONE);
 
        tsd = map + size - __pthread_tsd_size;
@@ -90,19 +117,17 @@ int pthread_create(pthread_t *res, const pthread_attr_t *attr, void *(*entry)(vo
        new->start_arg = arg;
        new->self = new;
        new->tsd = (void *)tsd;
-       new->detached = attr->_a_detach;
-       new->attr = *attr;
+       if (attr) new->detached = attr->_a_detach;
        new->unblock_cancel = self->cancel;
-       memcpy(new->tlsdesc, self->tlsdesc, sizeof new->tlsdesc);
-       new->tlsdesc[1] = (uintptr_t)new;
-       stack = (void *)((uintptr_t)new-1 & ~(uintptr_t)15);
+       new->canary = self->canary ^ (uintptr_t)&new;
+       stack = (void *)new;
 
-       __rsyscall_lock();
+       __synccall_lock();
 
        a_inc(&libc.threads_minus_1);
-       ret = __uniclone(stack, start, new);
+       ret = __clone(start, stack, 0x7d8f00, new, &new->tid, new, &new->tid);
 
-       __rsyscall_unlock();
+       __synccall_unlock();
 
        if (ret < 0) {
                a_dec(&libc.threads_minus_1);
@@ -112,11 +137,3 @@ int pthread_create(pthread_t *res, const pthread_attr_t *attr, void *(*entry)(vo
        *res = new;
        return 0;
 }
-
-void pthread_exit(void *result)
-{
-       struct pthread *self = pthread_self();
-       struct __ptcb cb = { .__next = self->cancelbuf };
-       self->result = result;
-       __pthread_unwind_next(&cb);
-}