From 321ae93c651a24f17e2b7540e67a959db803c40d Mon Sep 17 00:00:00 2001
From: Daniel Grund <grund@cs.uni-saarland.de>
Date: Sat, 15 Jan 2005 16:31:17 +0000
Subject: [PATCH] Comments, beautify

---
 ir/be/bephiopt.c |  9 +++++----
 ir/be/phistat.c  | 25 ++++---------------------
 ir/be/phistat.h  | 20 ++++++++++++++++++++
 3 files changed, 29 insertions(+), 25 deletions(-)

diff --git a/ir/be/bephiopt.c b/ir/be/bephiopt.c
index 53de2bc01..31a7786ff 100644
--- a/ir/be/bephiopt.c
+++ b/ir/be/bephiopt.c
@@ -17,13 +17,14 @@
 #include "bephicoal_t.h"
 #include "phistat.h"
 
+#define DEBUG_LVL SET_LEVEL_1
+
 #define DO_PHI_STATISTICS
 #undef DUMP_IRG_PHI_STAT
-#define DUMP_ALL_PHI_STAT
-
-#define DEBUG_LVL 1
 
+#define DUMP_CUMULATIVE
 #define CUMULATIVE_FILE "all.phistat"
+
 #define ENV_PHI_STAT "PHI_STAT"
 
 static firm_dbg_module_t *dbgphi = NULL;
@@ -64,7 +65,7 @@ void be_phi_opt(ir_graph* irg) {
 		phi_stat_dump_pretty(buf);
 	}
 #endif
-#ifdef DUMP_ALL_PHI_STAT
+#ifdef DUMP_CUMULATIVE
 	phi_stat_update(CUMULATIVE_FILE);
 #endif
 	phi_stat_update(getenv(ENV_PHI_STAT));
diff --git a/ir/be/phistat.c b/ir/be/phistat.c
index 5d6ccc444..1a1802f5b 100644
--- a/ir/be/phistat.c
+++ b/ir/be/phistat.c
@@ -59,9 +59,6 @@ enum vals_t {
 static int curr_vals[ASIZE];
 
 
-/**
- * Resets the array holding the data
- */
 void phi_stat_reset(void) {
 	int i;
 
@@ -144,8 +141,8 @@ static void phi_class_stat(pset *pc) {
 		curr_vals[I_CLS_SIZE_S + size]++;
 
 	/* get an array of all members for double iterating */
-	members = (ir_node **) malloc(size * sizeof(ir_node*));
-	for (i=0, p = (ir_node *)pset_first(pc); p; p = (ir_node *)pset_next(pc))
+	members = malloc(size * sizeof(*members));
+	for (i = 0, p = pset_first(pc); p; p = pset_next(pc))
 		members[i++] = p;
 	assert(i == size);
 
@@ -174,9 +171,6 @@ static void phi_class_stat(pset *pc) {
 }
 
 
-/**
- * Collect all stat data
- */
 void phi_stat_collect(ir_graph *irg, pset *all_phi_nodes, pset *all_phi_classes) {
 	ir_node *n;
 	pset *pc;
@@ -184,10 +178,10 @@ void phi_stat_collect(ir_graph *irg, pset *all_phi_nodes, pset *all_phi_classes)
 	irg_walk_graph(irg, stat_walker, NULL, NULL);
 	curr_vals[I_BLOCKS] -= 2;
 
-	for (n = (ir_node *)pset_first(all_phi_nodes); n; n = (ir_node *)pset_next(all_phi_nodes))
+	for (n = pset_first(all_phi_nodes); n; n = pset_next(all_phi_nodes))
 		phi_node_stat(n);
 
-	for (pc = (pset *)pset_first(all_phi_classes); pc; pc = (pset *)pset_next(all_phi_classes))
+	for (pc = pset_first(all_phi_classes); pc; pc = pset_next(all_phi_classes))
 		phi_class_stat(pc);
 }
 
@@ -217,9 +211,6 @@ static void dump_file(char *filename, int stat[ASIZE]) {
 }
 
 
-/**
- * Updates a cumulative file with the current values.
- */
 void phi_stat_update(char *filename) {
     int i;
 	FILE *all;
@@ -255,20 +246,12 @@ void phi_stat_update(char *filename) {
 }
 
 
-/**
- * Dumps the current contents of the values array to a file.
- * Updates a cumulative file.
- */
 void phi_stat_dump(char *filename) {
 	if (filename)
 		dump_file(filename, curr_vals);
 }
 
 
-/**
- * Dumps the current contents of the values array
- * and annotations to a file.
- */
 void phi_stat_dump_pretty(char *filename) {
 	int i;
 	FILE *out;
diff --git a/ir/be/phistat.h b/ir/be/phistat.h
index 5cfe055a1..d700c86df 100644
--- a/ir/be/phistat.h
+++ b/ir/be/phistat.h
@@ -9,10 +9,30 @@
 #include "pset.h"
 #include "irgraph.h"
 
+/**
+ * Resets the array holding the data
+ */
 void phi_stat_reset(void);
+
+/**
+ * Collect all stat data
+ */
 void phi_stat_collect(ir_graph *irg, pset *all_phi_nodes, pset *all_phi_classes);
+
+/**
+ * Dumps the current contents of the internal values to a file.
+ */
 void phi_stat_dump(char *filename);
+
+/**
+ * Updates a cumulative file with the internal values.
+ */
 void phi_stat_update(char *filename);
+
+/**
+ * Dumps the current contents of the values array
+ * and annotations to a file.
+ */
 void phi_stat_dump_pretty(char *filename);
 
 #endif
-- 
2.20.1