From: Christoph Mallon <christoph.mallon@gmx.de>
Date: Wed, 24 Feb 2010 14:12:35 +0000 (+0000)
Subject: Fix a gammel-bug: try_create_Immediate() dropped the negation of Minus(Const()).... 
X-Git-Url: http://nsz.repo.hu/git/?a=commitdiff_plain;h=7d36daa87447b0ba9fbc4f0757c0f5e6c0c8493a;p=libfirm

Fix a gammel-bug: try_create_Immediate() dropped the negation of Minus(Const()). In practice this never occurs, because constant folding folds the Minus.

[r27209]
---

diff --git a/ir/be/ia32/ia32_common_transform.c b/ir/be/ia32/ia32_common_transform.c
index 39b806e67..1862615ec 100644
--- a/ir/be/ia32/ia32_common_transform.c
+++ b/ir/be/ia32/ia32_common_transform.c
@@ -1022,7 +1022,6 @@ int prevents_AM(ir_node *const block, ir_node *const am_candidate,
 ir_node *try_create_Immediate(ir_node *node, char immediate_constraint_type)
 {
 	int          minus         = 0;
-	tarval      *offset        = NULL;
 	int          offset_sign   = 0;
 	long         val = 0;
 	ir_entity   *symconst_ent  = NULL;
@@ -1083,7 +1082,9 @@ ir_node *try_create_Immediate(ir_node *node, char immediate_constraint_type)
 	}
 
 	if (cnst != NULL) {
-		offset = get_Const_tarval(cnst);
+		tarval *offset = get_Const_tarval(cnst);
+		if (offset_sign)
+			offset = tarval_neg(offset);
 		if (tarval_is_long(offset)) {
 			val = get_tarval_long(offset);
 		} else {
@@ -1105,17 +1106,11 @@ ir_node *try_create_Immediate(ir_node *node, char immediate_constraint_type)
 		if (symconst_sign)
 			return NULL;
 
-		if (get_SymConst_kind(symconst) != symconst_addr_ent)
-			return NULL;
-		symconst_ent = get_SymConst_entity(symconst);
+		symconst_ent = get_Global_entity(symconst);
 	}
 	if (cnst == NULL && symconst == NULL)
 		return NULL;
 
-	if (offset_sign && offset != NULL) {
-		offset = tarval_neg(offset);
-	}
-
 	new_node = ia32_create_Immediate(symconst_ent, symconst_sign, val);
 
 	return new_node;