From: Christoph Mallon <christoph.mallon@gmx.de>
Date: Thu, 21 Aug 2008 05:54:49 +0000 (+0000)
Subject: Warn about unnecessary static forward declarations.
X-Git-Url: http://nsz.repo.hu/git/?a=commitdiff_plain;h=52afdebcb3609ecc883c919797d8ccf8124a12ad;p=cparser

Warn about unnecessary static forward declarations.

[r21299]
---

diff --git a/parser.c b/parser.c
index 9293447..1697204 100644
--- a/parser.c
+++ b/parser.c
@@ -4108,6 +4108,16 @@ static declaration_t *internal_record_declaration(
 				return previous_declaration;
 			}
 
+			if (warning.redundant_decls                                     &&
+			    is_definition                                               &&
+			    previous_declaration->storage_class == STORAGE_CLASS_STATIC &&
+			    !(previous_declaration->modifiers & DM_USED)                &&
+			    !previous_declaration->used) {
+				warningf(&previous_declaration->source_position,
+				         "unnecessary static forward declaration for '%#T'",
+				         previous_declaration->type, symbol);
+			}
+
 			unsigned new_storage_class = declaration->storage_class;
 
 			if (is_type_incomplete(prev_type)) {