From: Érico Rolim <ericonr@disroot.org>
Date: Thu, 24 Dec 2020 04:18:04 +0000 (-0300)
Subject: fix possible fd leak via missing O_CLOEXEC in pthread_setname_np
X-Git-Url: http://nsz.repo.hu/git/?a=commitdiff_plain;h=074932c84d34273821e3bfc2511e60a5ce78b8d8;p=musl

fix possible fd leak via missing O_CLOEXEC in pthread_setname_np

the omission of the flag here seems to have been an oversight when the
function was added in 8fb28b0b3e7a5e958fb844722a4b2ef9bc244af1
---

diff --git a/src/thread/pthread_setname_np.c b/src/thread/pthread_setname_np.c
index 82d35e17..fc2d2306 100644
--- a/src/thread/pthread_setname_np.c
+++ b/src/thread/pthread_setname_np.c
@@ -19,7 +19,7 @@ int pthread_setname_np(pthread_t thread, const char *name)
 
 	snprintf(f, sizeof f, "/proc/self/task/%d/comm", thread->tid);
 	pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &cs);
-	if ((fd = open(f, O_WRONLY)) < 0 || write(fd, name, len) < 0) status = errno;
+	if ((fd = open(f, O_WRONLY|O_CLOEXEC)) < 0 || write(fd, name, len) < 0) status = errno;
 	if (fd >= 0) close(fd);
 	pthread_setcancelstate(cs, 0);
 	return status;