Use {} as replacement to avoid this warning.
.It Fl Werror
Treat warnings as errors, i.e. do not continue after parsing when a warning is encountered.
+.It Fl Werror-implicit-function-declaration
+Generate an error, when calling a function without a prior declaration.
.It Fl Wextra
Activate some more warnings.
In particular these are
if (entity == NULL) {
if (!strict_mode && look_ahead(1)->type == '(') {
/* an implicitly declared function */
- if (warning.implicit_function_declaration) {
- warningf(HERE, "implicit declaration of function '%Y'",
- symbol);
+ if (warning.error_implicit_function_declaration) {
+ errorf(HERE, "implicit declaration of function '%Y'", symbol);
+ } else if (warning.implicit_function_declaration) {
+ warningf(HERE, "implicit declaration of function '%Y'", symbol);
}
entity = create_implicit_function(symbol, HERE);
#include "warning.h"
warning_t warning = {
- .other = true,
+ .other = true,
- .address = true,
- .aggregate_return = false,
- .attribute = true,
- .cast_qual = false,
- .char_subscripts = true,
- .comment = false,
- .conversion = false,
- .declaration_after_statement = false,
- .deprecated_declarations = true,
- .div_by_zero = true,
- .empty_statement = false,
- .fatal_errors = false,
- .float_equal = false,
- .format = true,
- .implicit_function_declaration = true,
- .implicit_int = true,
- .init_self = true,
- .long_long = false,
- .main = true,
- .missing_declarations = false,
- .missing_noreturn = false,
- .missing_prototypes = false,
- .multichar = true,
- .nested_externs = false,
- .nonnull = true,
- .old_style_definition = false,
- .packed = false,
- .padded = false,
- .pointer_arith = true,
- .redundant_decls = true,
- .return_type = true,
- .s_are_errors = false,
- .shadow = false,
- .sign_compare = false,
- .strict_prototypes = true,
- .switch_default = false,
- .switch_enum = false,
- .traditional = false,
- .unknown_pragmas = true,
- .unreachable_code = false,
- .unused_function = false,
- .unused_label = false,
- .unused_parameter = false,
- .unused_value = true,
- .unused_variable = false,
- .write_strings = false
+ .address = true,
+ .aggregate_return = false,
+ .attribute = true,
+ .cast_qual = false,
+ .char_subscripts = true,
+ .comment = false,
+ .conversion = false,
+ .declaration_after_statement = false,
+ .deprecated_declarations = true,
+ .div_by_zero = true,
+ .empty_statement = false,
+ .error_implicit_function_declaration = false,
+ .fatal_errors = false,
+ .float_equal = false,
+ .format = true,
+ .implicit_function_declaration = true,
+ .implicit_int = true,
+ .init_self = true,
+ .long_long = false,
+ .main = true,
+ .missing_declarations = false,
+ .missing_noreturn = false,
+ .missing_prototypes = false,
+ .multichar = true,
+ .nested_externs = false,
+ .nonnull = true,
+ .old_style_definition = false,
+ .packed = false,
+ .padded = false,
+ .pointer_arith = true,
+ .redundant_decls = true,
+ .return_type = true,
+ .s_are_errors = false,
+ .shadow = false,
+ .sign_compare = false,
+ .strict_prototypes = true,
+ .switch_default = false,
+ .switch_enum = false,
+ .traditional = false,
+ .unknown_pragmas = true,
+ .unreachable_code = false,
+ .unused_function = false,
+ .unused_label = false,
+ .unused_parameter = false,
+ .unused_value = true,
+ .unused_variable = false,
+ .write_strings = false
};
void set_warning_opt(const char *const opt)
SET(unused_value);
SET(unused_variable);
}
- OPT("address", address);
- OPT("aggregate-return", aggregate_return);
- OPT("attribute", attribute);
- OPT("cast-qual", cast_qual);
- OPT("char-subscripts", char_subscripts);
- OPT("comment", comment);
- OPT("conversion", conversion);
- OPT("declaration-after-statement", declaration_after_statement);
- OPT("deprecated-declarations", deprecated_declarations);
- OPT("div-by-zero", div_by_zero);
- OPT("empty-statement", empty_statement);
- OPT("error", s_are_errors);
+ OPT("address", address);
+ OPT("aggregate-return", aggregate_return);
+ OPT("attribute", attribute);
+ OPT("cast-qual", cast_qual);
+ OPT("char-subscripts", char_subscripts);
+ OPT("comment", comment);
+ OPT("conversion", conversion);
+ OPT("declaration-after-statement", declaration_after_statement);
+ OPT("deprecated-declarations", deprecated_declarations);
+ OPT("div-by-zero", div_by_zero);
+ OPT("empty-statement", empty_statement);
+ OPT("error", s_are_errors);
+ OPT("error-implicit-function-declaration", error_implicit_function_declaration);
OPTX("extra") {
/* TODO */
// TODO SET(function_end_without_return);
SET(unused_parameter);
SET(unused_value);
}
- OPT("fatal-errors", fatal_errors);
- OPT("float-equal", float_equal);
+ OPT("fatal-errors", fatal_errors);
+ OPT("float-equal", float_equal);
OPTX("format") {
SET(format);
SET(nonnull);
SET(implicit_function_declaration);
SET(implicit_int);
}
- OPT("implicit-function-declaration", implicit_function_declaration);
- OPT("implicit-int", implicit_int);
- OPT("init-self", init_self);
- OPT("long-long", long_long);
- OPT("main", main);
- OPT("missing-declarations", missing_declarations);
- OPT("missing-noreturn", missing_noreturn);
- OPT("missing-prototypes", missing_prototypes);
- OPT("multichar", multichar);
- OPT("nested-externs", nested_externs);
- OPT("nonnull", nonnull);
- OPT("old-style-definition", old_style_definition);
- OPT("packed", packed);
- OPT("padded", padded);
- OPT("pointer-arith", pointer_arith);
- OPT("redundant-decls", redundant_decls);
- OPT("return-type", return_type);
- OPT("shadow", shadow);
- OPT("sign-compare", sign_compare);
- OPT("strict-prototypes", strict_prototypes);
- OPT("switch-default", switch_default);
- OPT("switch-enum", switch_enum);
- OPT("traditional", traditional);
- OPT("unknown-pragmas", unknown_pragmas);
- OPT("unreachable-code", unreachable_code);
+ OPT("implicit-function-declaration", implicit_function_declaration);
+ OPT("implicit-int", implicit_int);
+ OPT("init-self", init_self);
+ OPT("long-long", long_long);
+ OPT("main", main);
+ OPT("missing-declarations", missing_declarations);
+ OPT("missing-noreturn", missing_noreturn);
+ OPT("missing-prototypes", missing_prototypes);
+ OPT("multichar", multichar);
+ OPT("nested-externs", nested_externs);
+ OPT("nonnull", nonnull);
+ OPT("old-style-definition", old_style_definition);
+ OPT("packed", packed);
+ OPT("padded", padded);
+ OPT("pointer-arith", pointer_arith);
+ OPT("redundant-decls", redundant_decls);
+ OPT("return-type", return_type);
+ OPT("shadow", shadow);
+ OPT("sign-compare", sign_compare);
+ OPT("strict-prototypes", strict_prototypes);
+ OPT("switch-default", switch_default);
+ OPT("switch-enum", switch_enum);
+ OPT("traditional", traditional);
+ OPT("unknown-pragmas", unknown_pragmas);
+ OPT("unreachable-code", unreachable_code);
OPTX("unused") {
SET(unused_function);
SET(unused_label);
SET(unused_value);
SET(unused_variable);
}
- OPT("unused-function", unused_function);
- OPT("unused-label", unused_label);
- OPT("unused-parameter", unused_parameter);
- OPT("unused-value", unused_value);
- OPT("unused-variable", unused_variable);
- OPT("write-strings", write_strings);
+ OPT("unused-function", unused_function);
+ OPT("unused-label", unused_label);
+ OPT("unused-parameter", unused_parameter);
+ OPT("unused-value", unused_value);
+ OPT("unused-variable", unused_variable);
+ OPT("write-strings", write_strings);
#undef OPT
#undef SET
#undef OPT_X
void set_warning_opt(const char *opt);
typedef struct warning_t {
- bool other:1; /**< Warnings not covered by any option below */
+ bool other:1; /**< Warnings not covered by any option below */
- bool address:1; /**< Warn about suspicious uses of memory addresses */
- bool aggregate_return:1; /**< Warn if any functions that return structures or unions are defined or called */
- bool attribute:1; /**< Warn if an unexpected `__attribute__' is used or function attributes applied to variables, etc. */
+ bool address:1; /**< Warn about suspicious uses of memory addresses */
+ bool aggregate_return:1; /**< Warn if any functions that return structures or unions are defined or called */
+ bool attribute:1; /**< Warn if an unexpected `__attribute__' is used or function attributes applied to variables, etc. */
#if 0 // TODO
- bool bad_function_cast:1; /**< Warn whenever a function call is cast to a non-matching type */
- bool cast_align:1; /**< Warn whenever a pointer is cast such that the required alignment of the target is increased */
+ bool bad_function_cast:1; /**< Warn whenever a function call is cast to a non-matching type */
+ bool cast_align:1; /**< Warn whenever a pointer is cast such that the required alignment of the target is increased */
#endif
- bool cast_qual:1; /**< Warn whenever a pointer is cast so as to remove a type qualifier from the target type */
- bool char_subscripts:1; /**< Warn if an array subscript has the type 'char' */
- bool comment:1; /**< Warn whenever a comment-start sequence appears in a comment, or whenever a Backslash-Newline appears in a '//' comment. */
- bool conversion:1; /**< Warn if a prototype causes a type conversion that is different from what would happen to the same argument in the absence of a prototype */
+ bool cast_qual:1; /**< Warn whenever a pointer is cast so as to remove a type qualifier from the target type */
+ bool char_subscripts:1; /**< Warn if an array subscript has the type 'char' */
+ bool comment:1; /**< Warn whenever a comment-start sequence appears in a comment, or whenever a Backslash-Newline appears in a '//' comment. */
+ bool conversion:1; /**< Warn if a prototype causes a type conversion that is different from what would happen to the same argument in the absence of a prototype */
#if 0 // TODO
- bool cpp_compat:1; /**< Warn about ISO C constructs that are outside of the common subset of ISO C and ISO C++. */
+ bool cpp_compat:1; /**< Warn about ISO C constructs that are outside of the common subset of ISO C and ISO C++. */
#endif
- bool declaration_after_statement:1; /**< Warn when a declaration is found after a statement in a block */
- bool deprecated_declarations:1; /* TODO implement for types */ /**< Warn about uses of functions, variables and types marked as deprecated by using the 'deprecated' attribute */
- bool div_by_zero:1; /**< Warn about compile-time integer division by zero */
- bool empty_statement:1; /**< Warn about empty statements, i.e. lone ';' */
+ bool declaration_after_statement:1; /**< Warn when a declaration is found after a statement in a block */
+ bool deprecated_declarations:1; /* TODO implement for types */ /**< Warn about uses of functions, variables and types marked as deprecated by using the 'deprecated' attribute */
+ bool div_by_zero:1; /**< Warn about compile-time integer division by zero */
+ bool empty_statement:1; /**< Warn about empty statements, i.e. lone ';' */
#if 0 // TODO
- bool endif_labels:1; /**< Warn whenever an '#else' or an '#endif' are followed by text */
+ bool endif_labels:1; /**< Warn whenever an '#else' or an '#endif' are followed by text */
#endif
- bool fatal_errors:1; /**< First error stops the compilation */
- bool float_equal:1; /**< Warn if floating point values are used in equality comparisons */
- bool format:1; /**< Check printf-style format strings */
- bool implicit_function_declaration:1; /**< Warn whenever a function is used before being declared */
- bool implicit_int:1; /**< Warn when a declaration does not specify a type */
- bool init_self:1; /**< Warn about uninitialized variables which are initialized with themselves. */
+ bool error_implicit_function_declaration:1; /**< Generate an error, when calling a function without a prior declaration */
+ bool fatal_errors:1; /**< First error stops the compilation */
+ bool float_equal:1; /**< Warn if floating point values are used in equality comparisons */
+ bool format:1; /**< Check printf-style format strings */
+ bool implicit_function_declaration:1; /**< Warn whenever a function is used before being declared */
+ bool implicit_int:1; /**< Warn when a declaration does not specify a type */
+ bool init_self:1; /**< Warn about uninitialized variables which are initialized with themselves. */
#if 0 // TODO
- bool inline:1; /**< Warn if a function can not be inlined and it was declared as inline */
- bool int_to_pointer_cast:1; /**< Warn if cast from integer to pointer of different size. */
+ bool inline:1; /**< Warn if a function can not be inlined and it was declared as inline */
+ bool int_to_pointer_cast:1; /**< Warn if cast from integer to pointer of different size. */
#endif
- bool long_long:1; /**< Warn if 'long long' type is used */
- bool main:1; /**< Warn if the type of 'main' is suspicious */
+ bool long_long:1; /**< Warn if 'long long' type is used */
+ bool main:1; /**< Warn if the type of 'main' is suspicious */
#if 0 // TODO
- bool missing_braces:1; /**< Warn if an aggregate or union initializer is not fully bracketed */
+ bool missing_braces:1; /**< Warn if an aggregate or union initializer is not fully bracketed */
#endif
- bool missing_declarations:1; /**< Warn if a global function is defined without a previous declaration */
+ bool missing_declarations:1; /**< Warn if a global function is defined without a previous declaration */
#if 0 // TODO
- bool missing_field_initializers:1; /**< Warn if a structure's initializer has some fields missing. */
- bool missing_format_attribute:1; /**< If '-Wformat' is enabled, also warn about functions which might be candidates for 'format' attributes */
+ bool missing_field_initializers:1; /**< Warn if a structure's initializer has some fields missing. */
+ bool missing_format_attribute:1; /**< If '-Wformat' is enabled, also warn about functions which might be candidates for 'format' attributes */
#endif
- bool missing_noreturn:1; /**< Warn about functions which might be candidates for attribute 'noreturn' */
- bool missing_prototypes:1; /**< Warn if a global function is defined without a previous prototype declaration */
- bool multichar:1; /**< Warn if a multicharacter constant ('FOOF') is used. */
- bool nested_externs:1; /**< Warn if an 'extern' declaration is encountered within a function. */
- bool nonnull:1; /**< Warn about passing a null pointer for arguments marked nonnull. */
- bool old_style_definition:1; /**< Warn if an old-style function definition is used. */
- bool packed:1; /**< Warn if a structure is given the packed attribute, but the packed attribute has no effect on the layout or size of the structure */
- bool padded:1; /**< Warn if padding is included in a structure, either to align an element of the structure or to align the whole structure */
+ bool missing_noreturn:1; /**< Warn about functions which might be candidates for attribute 'noreturn' */
+ bool missing_prototypes:1; /**< Warn if a global function is defined without a previous prototype declaration */
+ bool multichar:1; /**< Warn if a multicharacter constant ('FOOF') is used. */
+ bool nested_externs:1; /**< Warn if an 'extern' declaration is encountered within a function. */
+ bool nonnull:1; /**< Warn about passing a null pointer for arguments marked nonnull. */
+ bool old_style_definition:1; /**< Warn if an old-style function definition is used. */
+ bool packed:1; /**< Warn if a structure is given the packed attribute, but the packed attribute has no effect on the layout or size of the structure */
+ bool padded:1; /**< Warn if padding is included in a structure, either to align an element of the structure or to align the whole structure */
#if 0 // TODO
- bool parentheses:1; /**< Warn if parentheses are omitted in certain contexts (assignment where truth value is expected, if-else-braces) */
+ bool parentheses:1; /**< Warn if parentheses are omitted in certain contexts (assignment where truth value is expected, if-else-braces) */
#endif
- bool pointer_arith:1; /**< Warn about anything that depends on the "size of" a function type or of 'void' */
+ bool pointer_arith:1; /**< Warn about anything that depends on the "size of" a function type or of 'void' */
#if 0 // TODO
- bool pointer_to_int_cast:1; /**< Warn if cast from pointer to integer of different size. */
+ bool pointer_to_int_cast:1; /**< Warn if cast from pointer to integer of different size. */
#endif
- bool redundant_decls:1; /**< Warn about redundant declarations */
- bool return_type:1; /* TODO not fully implemented */ /**< Warn about function definitions with a return-type that defaults to 'int'. Also warn about any 'return' statement with no return-value in a function whose return-type is not 'void'. */
- bool s_are_errors:1; /**< Treat warnings as errors */
+ bool redundant_decls:1; /**< Warn about redundant declarations */
+ bool return_type:1; /* TODO not fully implemented */ /**< Warn about function definitions with a return-type that defaults to 'int'. Also warn about any 'return' statement with no return-value in a function whose return-type is not 'void'. */
+ bool s_are_errors:1; /**< Treat warnings as errors */
#if 0 // TODO
- bool sequence_point:1; /**< Warn about code that may have undefined semantics because of violations of sequence point rules */
+ bool sequence_point:1; /**< Warn about code that may have undefined semantics because of violations of sequence point rules */
#endif
- bool shadow:1; /**< Warn whenever a local variable shadows another local variable, parameter or global variable or whenever a built-in function is shadowed */
- bool sign_compare:1; /**< Warn when a comparison between signed and unsigned values could produce an incorrect result when the signed value is converted to unsigned */
+ bool shadow:1; /**< Warn whenever a local variable shadows another local variable, parameter or global variable or whenever a built-in function is shadowed */
+ bool sign_compare:1; /**< Warn when a comparison between signed and unsigned values could produce an incorrect result when the signed value is converted to unsigned */
#if 0 // TODO
- bool strict_aliasing:1; /**< Warn about code which might break the strict aliasing rules that the compiler is using for optimization. */
+ bool strict_aliasing:1; /**< Warn about code which might break the strict aliasing rules that the compiler is using for optimization. */
#endif
- bool strict_prototypes:1; /**< Warn if a function declaration has an unspecified parameter list */
- bool switch_default:1; /**< Warn whenever a 'switch' statement does not have a 'default' case */
- bool switch_enum:1; /**< Warn about 'switch' statements with an enum as index type and missing case labels or case labels outside the enum range TODO has an alias -Wswitch? */
- bool traditional:1; /**< Warn about certain constructs that behave differently in traditional and ISO C */
+ bool strict_prototypes:1; /**< Warn if a function declaration has an unspecified parameter list */
+ bool switch_default:1; /**< Warn whenever a 'switch' statement does not have a 'default' case */
+ bool switch_enum:1; /**< Warn about 'switch' statements with an enum as index type and missing case labels or case labels outside the enum range TODO has an alias -Wswitch? */
+ bool traditional:1; /**< Warn about certain constructs that behave differently in traditional and ISO C */
#if 0 // TODO
- bool undef:1; /**< Warn if an undefined identifier is evaluated in an '#if' directive */
- bool uninitialized:1; /**< Warn if an automatic variable is used without being initialized or if a variable may be clobbered by a 'setjmp' call. */
+ bool undef:1; /**< Warn if an undefined identifier is evaluated in an '#if' directive */
+ bool uninitialized:1; /**< Warn if an automatic variable is used without being initialized or if a variable may be clobbered by a 'setjmp' call. */
#endif
- bool unknown_pragmas:1; /**< Warn when a #pragma directive is encountered which is not understood */
- bool unreachable_code:1; /**< Warn if the compiler detects that code will never be executed */
- bool unused_function:1; /**< Warn whenever a static function is declared but not defined or a non-inline static function is unused */
- bool unused_label:1; /**< Warn whenever a label is declared but not used */
- bool unused_parameter:1; /**< Warn whenever a function parameter is unused aside from its declaration */
- bool unused_value:1; /**< Warn whenever a statement computes a result that is explicitly not used */
- bool unused_variable:1; /**< Warn whenever a local variable or non-constant static variable is unused aside from its declaration */
- bool write_strings:1; /**< Give string constants the type 'const char[LENGTH]' so that copying the address of one into a 'char *' pointer will get a warning */
+ bool unknown_pragmas:1; /**< Warn when a #pragma directive is encountered which is not understood */
+ bool unreachable_code:1; /**< Warn if the compiler detects that code will never be executed */
+ bool unused_function:1; /**< Warn whenever a static function is declared but not defined or a non-inline static function is unused */
+ bool unused_label:1; /**< Warn whenever a label is declared but not used */
+ bool unused_parameter:1; /**< Warn whenever a function parameter is unused aside from its declaration */
+ bool unused_value:1; /**< Warn whenever a statement computes a result that is explicitly not used */
+ bool unused_variable:1; /**< Warn whenever a local variable or non-constant static variable is unused aside from its declaration */
+ bool write_strings:1; /**< Give string constants the type 'const char[LENGTH]' so that copying the address of one into a 'char *' pointer will get a warning */
} warning_t;
extern warning_t warning;