X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=src%2Ftime%2Ftimer_create.c;h=c107e150d12a66794cb274b3b4066af9e2b6fe0b;hb=28bde3b78746c4f773600c415fbc740efec4e311;hp=f02abb86a7a323f3ed74a1826d9171b3650fd0c4;hpb=f01d35184291c650f6a38f8b3da41693bfde0e70;p=musl

diff --git a/src/time/timer_create.c b/src/time/timer_create.c
index f02abb86..c107e150 100644
--- a/src/time/timer_create.c
+++ b/src/time/timer_create.c
@@ -13,15 +13,30 @@ struct start_args {
 	struct sigevent *sev;
 };
 
+static void dummy_1(pthread_t self)
+{
+}
+weak_alias(dummy_1, __pthread_tsd_run_dtors);
+
+static void cleanup_fromsig(void *p)
+{
+	pthread_t self = __pthread_self();
+	self->cancel = 0;
+	self->cancelbuf = 0;
+	__pthread_tsd_run_dtors(self);
+	longjmp(p, 1);
+}
+
 void __sigtimer_handler(pthread_t self)
 {
-	int st;
+	jmp_buf jb;
 	void (*notify)(union sigval) = (void (*)(union sigval))self->start;
 	union sigval val = { .sival_ptr = self->start_arg };
 
-	pthread_setcancelstate(PTHREAD_CANCEL_DISABLE, &st);
+	if (setjmp(jb)) return;
+	pthread_cleanup_push(cleanup_fromsig, jb);
 	notify(val);
-	pthread_setcancelstate(st, 0);
+	pthread_cleanup_pop(0);
 }
 
 static void *start(void *arg)
@@ -36,48 +51,42 @@ static void *start(void *arg)
 	self->result = (void *)-1;
 
 	pthread_barrier_wait(&args->b);
-	pthread_setcanceltype(PTHREAD_CANCEL_ASYNCHRONOUS, 0);
-	/* Loop on async-signal-safe cancellation point */
-	for (;;) sleep(1);
+	__wait(&self->delete_timer, 0, 0, 1);
+	__syscall(SYS_timer_delete, self->result);
 	return 0;
 }
 
 int timer_create(clockid_t clk, struct sigevent *evp, timer_t *res)
 {
-	struct sigevent sev = { 
-		.sigev_notify = SIGEV_SIGNAL,
-		.sigev_signo = SIGALRM
-	};
 	pthread_t td;
 	pthread_attr_t attr;
 	int r;
 	struct start_args args;
-	timer_t t;
-	struct ksigevent ksev;
+	struct ksigevent ksev, *ksevp=0;
 	int timerid;
 
-	if (evp) sev = *evp;
-
-	switch (sev.sigev_notify) {
+	switch (evp ? evp->sigev_notify : SIGEV_SIGNAL) {
 	case SIGEV_NONE:
 	case SIGEV_SIGNAL:
-		ksev.sigev_value = evp ? sev.sigev_value
-			: (union sigval){.sival_ptr=t};
-		ksev.sigev_signo = sev.sigev_signo;
-		ksev.sigev_notify = sev.sigev_notify;
-		ksev.sigev_tid = 0;
-		if (syscall(SYS_timer_create, clk, &ksev, &timerid) < 0)
+		if (evp) {
+			ksev.sigev_value = evp->sigev_value;
+			ksev.sigev_signo = evp->sigev_signo;
+			ksev.sigev_notify = evp->sigev_notify;
+			ksev.sigev_tid = 0;
+			ksevp = &ksev;
+		}
+		if (syscall(SYS_timer_create, clk, ksevp, &timerid) < 0)
 			return -1;
-		*res = (void *)(2*timerid+1);
+		*res = (void *)timerid;
 		break;
 	case SIGEV_THREAD:
-		if (sev.sigev_notify_attributes)
-			attr = *sev.sigev_notify_attributes;
+		if (evp->sigev_notify_attributes)
+			attr = *evp->sigev_notify_attributes;
 		else
 			pthread_attr_init(&attr);
 		pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
 		pthread_barrier_init(&args.b, 0, 2);
-		args.sev = &sev;
+		args.sev = evp;
 		r = pthread_create(&td, &attr, start, &args);
 		if (r) {
 			errno = r;