X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=src%2Fthread%2Fpthread_create.c;h=7494a486b2b3a4d4b4fee7c05d64538cb51e9eed;hb=29fae65780f4c5ccda3758828da7a83073297ccc;hp=b6c475d0ad7349c45acba92d8886f15b5ac22f45;hpb=e882756311c7b06e59fcc8e582f03852b7dcfd30;p=musl diff --git a/src/thread/pthread_create.c b/src/thread/pthread_create.c index b6c475d0..7494a486 100644 --- a/src/thread/pthread_create.c +++ b/src/thread/pthread_create.c @@ -10,9 +10,6 @@ void __pthread_unwind_next(struct __ptcb *cb) self = pthread_self(); if (self->cancel) self->result = PTHREAD_CANCELLED; - if (!a_fetch_add(&libc.threads_minus_1, -1)) - exit(0); - LOCK(&self->exitlock); not_finished = self->tsd_used; @@ -28,8 +25,16 @@ void __pthread_unwind_next(struct __ptcb *cb) } } - if (self->detached && self->map_base) + /* Mark this thread dead before decrementing count */ + self->dead = 1; + + if (!a_fetch_add(&libc.threads_minus_1, -1)) + exit(0); + + if (self->detached && self->map_base) { + syscall4(__NR_rt_sigprocmask, SIG_BLOCK, (long)(uint64_t[1]){-1},0,8); __unmapself(self->map_base, self->map_size); + } __syscall_exit(0); } @@ -43,6 +48,7 @@ static void docancel(struct pthread *self) static void cancel_handler(int sig, siginfo_t *si, void *ctx) { struct pthread *self = __pthread_self(); + if (si->si_code > 0 || si->si_pid != self->pid) return; self->cancel = 1; if (self->canceldisable || (!self->cancelasync && !self->cancelpoint)) return; @@ -73,7 +79,17 @@ static struct { static void rsyscall_handler(int sig, siginfo_t *si, void *ctx) { - if (rs.cnt == libc.threads_minus_1) return; + struct pthread *self = __pthread_self(); + + if (si->si_code > 0 || si->si_pid != self->pid || + rs.cnt == libc.threads_minus_1) return; + + /* Threads which have already decremented themselves from the + * thread count must not increment rs.cnt or otherwise act. */ + if (self->dead) { + __wait(&rs.hold, 0, 1, 1); + return; + } if (syscall6(rs.nr, rs.arg[0], rs.arg[1], rs.arg[2], rs.arg[3], rs.arg[4], rs.arg[5]) < 0 && !rs.err) rs.err=errno; @@ -134,6 +150,7 @@ static void init_threads() { struct sigaction sa = { .sa_flags = SA_SIGINFO | SA_RESTART }; libc.lock = __lock; + libc.lockfile = __lockfile; libc.cancelpt = cancelpt; libc.rsyscall = rsyscall; sa.sa_sigaction = cancel_handler; @@ -178,7 +195,7 @@ int pthread_create(pthread_t *res, const pthread_attr_t *attr, void *(*entry)(vo size += __pthread_tsd_size; map = mmap(0, size, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANON, -1, 0); if (!map) return EAGAIN; - mprotect(map, guard, PROT_NONE); + if (guard) mprotect(map, guard, PROT_NONE); tsd = map + size - __pthread_tsd_size; new = (void *)(tsd - sizeof *new - PAGE_SIZE%sizeof *new);