X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=src%2Fprocess%2Fposix_spawn.c;h=f675a13c37dbb59c2e912854ea854f35d0bc31c1;hb=8011614da008032642aa8292c3fd079bf7a8843d;hp=68cf795c5b2c267ea1361a5f526129c7a9f3c389;hpb=b06dc6663989f8b3c141e439fe89036a44eb7552;p=musl

diff --git a/src/process/posix_spawn.c b/src/process/posix_spawn.c
index 68cf795c..f675a13c 100644
--- a/src/process/posix_spawn.c
+++ b/src/process/posix_spawn.c
@@ -20,29 +20,43 @@ struct args {
 	char *const *argv, *const *envp;
 };
 
+void __get_handler_set(sigset_t *);
+
 static int child(void *args_vp)
 {
 	int i, ret;
-	struct sigaction sa;
+	struct sigaction sa = {0};
 	struct args *args = args_vp;
 	int p = args->p[1];
 	const posix_spawn_file_actions_t *fa = args->fa;
 	const posix_spawnattr_t *restrict attr = args->attr;
+	sigset_t hset;
 
 	close(args->p[0]);
 
 	/* All signal dispositions must be either SIG_DFL or SIG_IGN
 	 * before signals are unblocked. Otherwise a signal handler
 	 * from the parent might get run in the child while sharing
-	 * memory, with unpredictable and dangerous results. */
+	 * memory, with unpredictable and dangerous results. To
+	 * reduce overhead, sigaction has tracked for us which signals
+	 * potentially have a signal handler. */
+	__get_handler_set(&hset);
 	for (i=1; i<_NSIG; i++) {
-		__libc_sigaction(i, 0, &sa);
-		if (sa.sa_handler!=SIG_DFL && (sa.sa_handler!=SIG_IGN ||
-		    ((attr->__flags & POSIX_SPAWN_SETSIGDEF)
-		     && sigismember(&attr->__def, i) ))) {
+		if ((attr->__flags & POSIX_SPAWN_SETSIGDEF)
+		     && sigismember(&attr->__def, i)) {
 			sa.sa_handler = SIG_DFL;
-			__libc_sigaction(i, &sa, 0);
+		} else if (sigismember(&hset, i)) {
+			if (i-32<3U) {
+				sa.sa_handler = SIG_IGN;
+			} else {
+				__libc_sigaction(i, 0, &sa);
+				if (sa.sa_handler==SIG_IGN) continue;
+				sa.sa_handler = SIG_DFL;
+			}
+		} else {
+			continue;
 		}
+		__libc_sigaction(i, &sa, 0);
 	}
 
 	if (attr->__flags & POSIX_SPAWN_SETPGROUP)
@@ -105,6 +119,7 @@ static int child(void *args_vp)
 		? &attr->__mask : &args->oldmask, 0);
 
 	args->exec(args->path, args->argv, args->envp);
+	ret = -errno;
 
 fail:
 	/* Since sizeof errno < PIPE_BUF, the write is atomic. */
@@ -151,7 +166,7 @@ int __posix_spawnx(pid_t *restrict res, const char *restrict path,
 
 	close(args.p[0]);
 
-	if (!ec) *res = pid;
+	if (!ec && res) *res = pid;
 
 	pthread_sigmask(SIG_SETMASK, &args.oldmask, 0);
 	pthread_setcancelstate(cs, 0);