X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=parser.c;h=372c19e36454ecebb36bd44fd24c955a75f8ae3d;hb=cf80e941ca33006ab52321c2c74c6c30a7a4d10a;hp=531d07f3150366dddf563774096fb1009b138f63;hpb=245bf2db0e274757ccdacef3834ebf9aa1aac087;p=cparser diff --git a/parser.c b/parser.c index 531d07f..372c19e 100644 --- a/parser.c +++ b/parser.c @@ -67,7 +67,7 @@ struct declaration_specifiers_t { unsigned char alignment; /**< Alignment, 0 if not set. */ unsigned int is_inline : 1; unsigned int deprecated : 1; - decl_modifiers_t decl_modifiers; /**< MS __declspec extended modifier mask */ + decl_modifiers_t modifiers; /**< declaration modifiers */ gnu_attribute_t *gnu_attributes; /**< list of GNU attributes */ const char *deprecated_string; /**< can be set if declaration was marked deprecated. */ symbol_t *get_property_sym; /**< the name of the get property if set. */ @@ -104,6 +104,7 @@ static goto_statement_t *goto_first = NULL; static goto_statement_t *goto_last = NULL; static label_statement_t *label_first = NULL; static label_statement_t *label_last = NULL; +static translation_unit_t *unit = NULL; static struct obstack temp_obst; static source_position_t null_position = { NULL, 0 }; @@ -1096,7 +1097,6 @@ static gnu_attribute_t *allocate_gnu_attribute(gnu_attribute_kind_t kind) { attribute->have_arguments = false; return attribute; - return attribute; } /** @@ -1311,6 +1311,19 @@ end_error: attribute->u.value = true; } +static void check_no_argument(gnu_attribute_t *attribute, const char *name) +{ + if(!attribute->have_arguments) + return; + + /* should have no arguments */ + errorf(HERE, "wrong number of arguments specified for '%s' attribute", name); + eat_until_matching_token('('); + /* we have already consumed '(', so we stop before ')', eat it */ + eat(')'); + attribute->invalid = true; +} + /** * Parse one GNU attribute. * @@ -1387,10 +1400,11 @@ end_error: * interrupt( string literal ) * sentinel( constant expression ) */ -static void parse_gnu_attribute(gnu_attribute_t **attributes) +static decl_modifiers_t parse_gnu_attribute(gnu_attribute_t **attributes) { - gnu_attribute_t *head = *attributes; - gnu_attribute_t *last = *attributes; + gnu_attribute_t *head = *attributes; + gnu_attribute_t *last = *attributes; + decl_modifiers_t modifiers = 0; gnu_attribute_t *attribute; eat(T___attribute__); @@ -1457,20 +1471,11 @@ static void parse_gnu_attribute(gnu_attribute_t **attributes) case GNU_AK_STDCALL: case GNU_AK_FASTCALL: case GNU_AK_DEPRECATED: - case GNU_AK_NOINLINE: - case GNU_AK_NORETURN: case GNU_AK_NAKED: - case GNU_AK_PURE: - case GNU_AK_ALWAYS_INLINE: case GNU_AK_MALLOC: case GNU_AK_WEAK: - case GNU_AK_CONSTRUCTOR: - case GNU_AK_DESTRUCTOR: - case GNU_AK_NOTHROW: - case GNU_AK_TRANSPARENT_UNION: case GNU_AK_COMMON: case GNU_AK_NOCOMMON: - case GNU_AK_PACKED: case GNU_AK_SHARED: case GNU_AK_NOTSHARED: case GNU_AK_USED: @@ -1498,16 +1503,62 @@ static void parse_gnu_attribute(gnu_attribute_t **attributes) case GNU_AK_MAY_ALIAS: case GNU_AK_MS_STRUCT: case GNU_AK_GCC_STRUCT: + check_no_argument(attribute, name); + break; + + case GNU_AK_PURE: + check_no_argument(attribute, name); + modifiers |= DM_PURE; + break; + + case GNU_AK_ALWAYS_INLINE: + check_no_argument(attribute, name); + modifiers |= DM_FORCEINLINE; + break; + case GNU_AK_DLLIMPORT: + check_no_argument(attribute, name); + modifiers |= DM_DLLIMPORT; + break; + case GNU_AK_DLLEXPORT: - if(attribute->have_arguments) { - /* should have no arguments */ - errorf(HERE, "wrong number of arguments specified for '%s' attribute", name); - eat_until_matching_token('('); - /* we have already consumed '(', so we stop before ')', eat it */ - eat(')'); - attribute->invalid = true; - } + check_no_argument(attribute, name); + modifiers |= DM_DLLEXPORT; + break; + + case GNU_AK_PACKED: + check_no_argument(attribute, name); + modifiers |= DM_PACKED; + break; + + case GNU_AK_NOINLINE: + check_no_argument(attribute, name); + modifiers |= DM_NOINLINE; + break; + + case GNU_AK_NORETURN: + check_no_argument(attribute, name); + modifiers |= DM_NORETURN; + break; + + case GNU_AK_NOTHROW: + check_no_argument(attribute, name); + modifiers |= DM_NOTHROW; + break; + + case GNU_AK_TRANSPARENT_UNION: + check_no_argument(attribute, name); + modifiers |= DM_TRANSPARENT_UNION; + break; + + case GNU_AK_CONSTRUCTOR: + check_no_argument(attribute, name); + modifiers |= DM_CONSTRUCTOR; + break; + + case GNU_AK_DESTRUCTOR: + check_no_argument(attribute, name); + modifiers |= DM_DESTRUCTOR; break; case GNU_AK_ALIGNED: @@ -1611,17 +1662,21 @@ static void parse_gnu_attribute(gnu_attribute_t **attributes) expect(')'); end_error: *attributes = head; + + return modifiers; } /** * Parse GNU attributes. */ -static void parse_attributes(gnu_attribute_t **attributes) +static decl_modifiers_t parse_attributes(gnu_attribute_t **attributes) { + decl_modifiers_t modifiers = 0; + while(true) { switch(token.type) { case T___attribute__: { - parse_gnu_attribute(attributes); + modifiers |= parse_gnu_attribute(attributes); break; } case T_asm: @@ -1644,7 +1699,7 @@ static void parse_attributes(gnu_attribute_t **attributes) attributes_finished: end_error: - return; + return modifiers; } static designator_t *parse_designation(void) @@ -2187,6 +2242,9 @@ static initializer_t *parse_sub_initializer(type_path_t *path, = allocate_initializer_zero(INITIALIZER_DESIGNATOR); designator_initializer->designator.designator = designator; ARR_APP1(initializer_t*, initializers, designator_initializer); + + orig_type = path->top_type; + type = orig_type != NULL ? skip_typeref(orig_type) : NULL; } initializer_t *sub; @@ -2325,14 +2383,14 @@ error_parse_next: len * sizeof(initializers[0])); DEL_ARR_F(initializers); - ascend_to(path, top_path_level); + ascend_to(path, top_path_level+1); return result; end_error: skip_initializers(); DEL_ARR_F(initializers); - ascend_to(path, top_path_level); + ascend_to(path, top_path_level+1); return NULL; } @@ -2415,7 +2473,8 @@ static declaration_t *append_declaration(declaration_t *declaration); static declaration_t *parse_compound_type_specifier(bool is_struct) { - gnu_attribute_t *attributes = NULL; + gnu_attribute_t *attributes = NULL; + decl_modifiers_t modifiers = 0; if(is_struct) { eat(T_struct); } else { @@ -2426,7 +2485,7 @@ static declaration_t *parse_compound_type_specifier(bool is_struct) declaration_t *declaration = NULL; if (token.type == T___attribute__) { - parse_attributes(&attributes); + modifiers |= parse_attributes(&attributes); } if(token.type == T_IDENTIFIER) { @@ -2466,16 +2525,18 @@ static declaration_t *parse_compound_type_specifier(bool is_struct) if(token.type == '{') { if (declaration->init.complete) { assert(symbol != NULL); - errorf(HERE, "multiple definitions of '%s %Y'", - is_struct ? "struct" : "union", symbol); + errorf(HERE, "multiple definitions of '%s %Y' (previous definition at %P)", + is_struct ? "struct" : "union", symbol, + &declaration->source_position); declaration->scope.declarations = NULL; } declaration->init.complete = true; parse_compound_type_entries(declaration); - parse_attributes(&attributes); + modifiers |= parse_attributes(&attributes); } + declaration->modifiers |= modifiers; return declaration; } @@ -2715,7 +2776,7 @@ static bool check_elignment_value(long long intvalue) { static void parse_microsoft_extended_decl_modifier(declaration_specifiers_t *specifiers) { - decl_modifiers_t *modifiers = &specifiers->decl_modifiers; + decl_modifiers_t *modifiers = &specifiers->modifiers; while(true) { if(token.type == T_restrict) { @@ -2958,7 +3019,7 @@ static void parse_declaration_specifiers(declaration_specifiers_t *specifiers) case T__forceinline: /* only in microsoft mode */ - specifiers->decl_modifiers |= DM_FORCEINLINE; + specifiers->modifiers |= DM_FORCEINLINE; case T_inline: next_token(); @@ -3000,7 +3061,8 @@ static void parse_declaration_specifiers(declaration_specifiers_t *specifiers) break; case T___attribute__: - parse_attributes(&specifiers->gnu_attributes); + specifiers->modifiers + |= parse_attributes(&specifiers->gnu_attributes); break; case T_IDENTIFIER: { @@ -3519,7 +3581,9 @@ static construct_type_t *parse_inner_declarator(declaration_t *declaration, } /* TODO: find out if this is correct */ - parse_attributes(&attributes); + decl_modifiers_t modifiers = parse_attributes(&attributes); + if (declaration != NULL) + declaration->modifiers |= modifiers; construct_type_t *inner_types = NULL; @@ -3583,7 +3647,9 @@ static construct_type_t *parse_inner_declarator(declaration_t *declaration, } declarator_finished: - parse_attributes(&attributes); + modifiers = parse_attributes(&attributes); + if (declaration != NULL) + declaration->modifiers |= modifiers; /* append inner_types at the end of the list, we don't to set last anymore * as it's not needed anymore */ @@ -3694,7 +3760,7 @@ static declaration_t *parse_declarator( { declaration_t *const declaration = allocate_declaration_zero(); declaration->declared_storage_class = specifiers->declared_storage_class; - declaration->decl_modifiers = specifiers->decl_modifiers; + declaration->modifiers = specifiers->modifiers; declaration->deprecated = specifiers->deprecated; declaration->deprecated_string = specifiers->deprecated_string; declaration->get_property_sym = specifiers->get_property_sym; @@ -3815,11 +3881,15 @@ static declaration_t *internal_record_declaration( const symbol_t *const symbol = declaration->symbol; const namespace_t namespc = (namespace_t)declaration->namespc; + assert(declaration->symbol != NULL); + declaration_t *previous_declaration = get_declaration(symbol, namespc); + type_t *const orig_type = declaration->type; type_t *const type = skip_typeref(orig_type); if (is_type_function(type) && type->function.unspecified_parameters && - warning.strict_prototypes) { + warning.strict_prototypes && + previous_declaration == NULL) { warningf(&declaration->source_position, "function declaration '%#T' is not a prototype", orig_type, declaration->symbol); @@ -3829,105 +3899,103 @@ static declaration_t *internal_record_declaration( check_type_of_main(declaration, &type->function); } - assert(declaration->symbol != NULL); - declaration_t *previous_declaration = get_declaration(symbol, namespc); - assert(declaration != previous_declaration); - if (previous_declaration != NULL) { - if (previous_declaration->parent_scope == scope) { - /* can happen for K&R style declarations */ - if(previous_declaration->type == NULL) { - previous_declaration->type = declaration->type; + if (previous_declaration != NULL + && previous_declaration->parent_scope == scope) { + /* can happen for K&R style declarations */ + if (previous_declaration->type == NULL) { + previous_declaration->type = declaration->type; + } + + const type_t *prev_type = skip_typeref(previous_declaration->type); + if (!types_compatible(type, prev_type)) { + errorf(&declaration->source_position, + "declaration '%#T' is incompatible with '%#T' (declared %P)", + orig_type, symbol, previous_declaration->type, symbol, + &previous_declaration->source_position); + } else { + unsigned old_storage_class = previous_declaration->storage_class; + if (old_storage_class == STORAGE_CLASS_ENUM_ENTRY) { + errorf(&declaration->source_position, + "redeclaration of enum entry '%Y' (declared %P)", + symbol, &previous_declaration->source_position); + return previous_declaration; } - const type_t *prev_type = skip_typeref(previous_declaration->type); - if (!types_compatible(type, prev_type)) { - errorf(&declaration->source_position, - "declaration '%#T' is incompatible with '%#T' (declared %P)", - orig_type, symbol, previous_declaration->type, symbol, - &previous_declaration->source_position); - } else { - unsigned old_storage_class = previous_declaration->storage_class; - if(old_storage_class == STORAGE_CLASS_ENUM_ENTRY) { - errorf(&declaration->source_position, - "redeclaration of enum entry '%Y' (declared %P)", - symbol, &previous_declaration->source_position); - return previous_declaration; - } + unsigned new_storage_class = declaration->storage_class; - unsigned new_storage_class = declaration->storage_class; + if (is_type_incomplete(prev_type)) { + previous_declaration->type = type; + prev_type = type; + } - if(is_type_incomplete(prev_type)) { + /* pretend no storage class means extern for function + * declarations (except if the previous declaration is neither + * none nor extern) */ + if (is_type_function(type)) { + if (prev_type->function.unspecified_parameters) { previous_declaration->type = type; prev_type = type; } - /* pretend no storage class means extern for function - * declarations (except if the previous declaration is neither - * none nor extern) */ - if (is_type_function(type)) { - switch (old_storage_class) { - case STORAGE_CLASS_NONE: - old_storage_class = STORAGE_CLASS_EXTERN; - - case STORAGE_CLASS_EXTERN: - if (is_function_definition) { - if (warning.missing_prototypes && - prev_type->function.unspecified_parameters && - !is_sym_main(symbol)) { - warningf(&declaration->source_position, - "no previous prototype for '%#T'", - orig_type, symbol); - } - } else if (new_storage_class == STORAGE_CLASS_NONE) { - new_storage_class = STORAGE_CLASS_EXTERN; - } - break; - - default: break; + switch (old_storage_class) { + case STORAGE_CLASS_NONE: + old_storage_class = STORAGE_CLASS_EXTERN; + + case STORAGE_CLASS_EXTERN: + if (is_function_definition) { + if (warning.missing_prototypes && + prev_type->function.unspecified_parameters && + !is_sym_main(symbol)) { + warningf(&declaration->source_position, + "no previous prototype for '%#T'", + orig_type, symbol); + } + } else if (new_storage_class == STORAGE_CLASS_NONE) { + new_storage_class = STORAGE_CLASS_EXTERN; } + break; + + default: + break; } + } - if (old_storage_class == STORAGE_CLASS_EXTERN && - new_storage_class == STORAGE_CLASS_EXTERN) { + if (old_storage_class == STORAGE_CLASS_EXTERN && + new_storage_class == STORAGE_CLASS_EXTERN) { warn_redundant_declaration: - if (warning.redundant_decls) { - warningf(&declaration->source_position, - "redundant declaration for '%Y' (declared %P)", - symbol, &previous_declaration->source_position); - } - } else if (current_function == NULL) { - if (old_storage_class != STORAGE_CLASS_STATIC && - new_storage_class == STORAGE_CLASS_STATIC) { - errorf(&declaration->source_position, - "static declaration of '%Y' follows non-static declaration (declared %P)", - symbol, &previous_declaration->source_position); - } else { - if (old_storage_class != STORAGE_CLASS_EXTERN && !is_function_definition) { - goto warn_redundant_declaration; - } - if (new_storage_class == STORAGE_CLASS_NONE) { - previous_declaration->storage_class = STORAGE_CLASS_NONE; - previous_declaration->declared_storage_class = STORAGE_CLASS_NONE; - } - } - } else { - if (old_storage_class == new_storage_class) { - errorf(&declaration->source_position, - "redeclaration of '%Y' (declared %P)", - symbol, &previous_declaration->source_position); - } else { - errorf(&declaration->source_position, - "redeclaration of '%Y' with different linkage (declared %P)", - symbol, &previous_declaration->source_position); - } + if (warning.redundant_decls && strcmp(previous_declaration->source_position.input_name, "") != 0) { + warningf(&declaration->source_position, + "redundant declaration for '%Y' (declared %P)", + symbol, &previous_declaration->source_position); } + } else if (current_function == NULL) { + if (old_storage_class != STORAGE_CLASS_STATIC && + new_storage_class == STORAGE_CLASS_STATIC) { + errorf(&declaration->source_position, + "static declaration of '%Y' follows non-static declaration (declared %P)", + symbol, &previous_declaration->source_position); + } else if (old_storage_class != STORAGE_CLASS_EXTERN + && !is_function_definition) { + goto warn_redundant_declaration; + } else if (new_storage_class == STORAGE_CLASS_NONE) { + previous_declaration->storage_class = STORAGE_CLASS_NONE; + previous_declaration->declared_storage_class = STORAGE_CLASS_NONE; + } + } else if (old_storage_class == new_storage_class) { + errorf(&declaration->source_position, + "redeclaration of '%Y' (declared %P)", + symbol, &previous_declaration->source_position); + } else { + errorf(&declaration->source_position, + "redeclaration of '%Y' with different linkage (declared %P)", + symbol, &previous_declaration->source_position); } - - if (declaration->is_inline) - previous_declaration->is_inline = true; - return previous_declaration; } + + if (declaration->is_inline) + previous_declaration->is_inline = true; + return previous_declaration; } else if (is_function_definition) { if (declaration->storage_class != STORAGE_CLASS_STATIC) { if (warning.missing_prototypes && !is_sym_main(symbol)) { @@ -4045,7 +4113,7 @@ static void parse_anonymous_declaration_rest( declaration->type = specifiers->type; declaration->declared_storage_class = specifiers->declared_storage_class; declaration->source_position = specifiers->source_position; - declaration->decl_modifiers = specifiers->decl_modifiers; + declaration->modifiers = specifiers->modifiers; if (declaration->declared_storage_class != STORAGE_CLASS_NONE) { warningf(&declaration->source_position, @@ -4158,6 +4226,20 @@ static void parse_declaration(parsed_declaration_func finished_declaration) } } +static type_t *get_default_promoted_type(type_t *orig_type) +{ + type_t *result = orig_type; + + type_t *type = skip_typeref(orig_type); + if(is_type_integer(type)) { + result = promote_integer(type); + } else if(type == type_float) { + result = type_double; + } + + return result; +} + static void parse_kr_declaration_list(declaration_t *declaration) { type_t *type = skip_typeref(declaration->type); @@ -4216,6 +4298,11 @@ static void parse_kr_declaration_list(declaration_t *declaration) semantic_parameter(parameter_declaration); parameter_type = parameter_declaration->type; + /* + * we need the default promoted types for the function type + */ + parameter_type = get_default_promoted_type(parameter_type); + function_parameter_t *function_parameter = obstack_alloc(type_obst, sizeof(function_parameter[0])); memset(function_parameter, 0, sizeof(function_parameter[0])); @@ -4231,7 +4318,7 @@ static void parse_kr_declaration_list(declaration_t *declaration) /* § 6.9.1.7: A K&R style parameter list does NOT act as a function * prototype */ - new_type->function.parameters = parameters; + new_type->function.parameters = parameters; new_type->function.unspecified_parameters = true; type = typehash_insert(new_type); @@ -4314,64 +4401,6 @@ static void check_declarations(void) } } -/** - * check all returns vor matching type. - */ -static bool search_return_statements(statement_t *statement) { - switch(statement->kind) { - case STATEMENT_RETURN: - /* ok, found a return */ - return true; - case STATEMENT_IF: { - /* return must be found on then and else */ - if_statement_t *if_stat = &statement->ifs; - if(if_stat->true_statement != NULL && if_stat->false_statement != NULL) { - return search_return_statements(if_stat->true_statement) && - search_return_statements(if_stat->false_statement); - } - break; - } - case STATEMENT_DO_WHILE: { - do_while_statement_t *do_stmt = &statement->do_while; - if(do_stmt->body != NULL) { - if (search_return_statements(do_stmt->body)) - return true; - } - break; - } - case STATEMENT_COMPOUND: { - /* search the last statement */ - compound_statement_t *compound = &statement->compound; - statement_t *statement = compound->statements; - if(statement == NULL) - return false; - for( ; statement != NULL; statement = statement->base.next) { - if (search_return_statements(statement)) - return true; - } - break; - } - default: - break; - } - return false; -} - -/** - * Check returns of a function. - */ -static void check_return_type(declaration_t *declaration) { - function_type_t *function_type = &declaration->type->function; - type_t *ret_type = function_type->return_type; - - if (ret_type != type_void) { - if (! search_return_statements(declaration->init.statement)) { - warningf(HERE, "missing return statement at end of non-void function '%Y'", - declaration->symbol); - } - } -} - static void parse_external_declaration(void) { /* function-definitions and declarations both start with declaration @@ -4483,7 +4512,6 @@ static void parse_external_declaration(void) assert(current_function == declaration); current_function = old_current_function; label_pop_to(label_stack_top); - check_return_type(declaration); } end_of_parse_external_declaration: @@ -4562,7 +4590,7 @@ static void parse_compound_declarators(declaration_t *struct_declaration, declaration->declared_storage_class = STORAGE_CLASS_NONE; declaration->storage_class = STORAGE_CLASS_NONE; declaration->source_position = source_position; - declaration->decl_modifiers = specifiers->decl_modifiers; + declaration->modifiers = specifiers->modifiers; declaration->type = type; } else { declaration = parse_declarator(specifiers,/*may_be_abstract=*/true); @@ -5898,17 +5926,20 @@ static expression_t *parse_call_expression(unsigned precedence, rem_anchor_token(')'); expect(')'); - if(function_type != NULL) { - function_parameter_t *parameter = function_type->parameters; - call_argument_t *argument = call->arguments; + if(function_type == NULL) + return result; + + function_parameter_t *parameter = function_type->parameters; + call_argument_t *argument = call->arguments; + if (!function_type->unspecified_parameters) { for( ; parameter != NULL && argument != NULL; parameter = parameter->next, argument = argument->next) { type_t *expected_type = parameter->type; /* TODO report scope in error messages */ expression_t *const arg_expr = argument->expression; type_t *const res_type = semantic_assign(expected_type, arg_expr, - "function call", - &arg_expr->base.source_position); + "function call", + &arg_expr->base.source_position); if (res_type == NULL) { /* TODO improve error message */ errorf(&arg_expr->base.source_position, @@ -5918,37 +5949,26 @@ static expression_t *parse_call_expression(unsigned precedence, argument->expression = create_implicit_cast(argument->expression, expected_type); } } - /* too few parameters */ - if(parameter != NULL) { + + if (parameter != NULL) { errorf(HERE, "too few arguments to function '%E'", expression); - } else if(argument != NULL) { - /* too many parameters */ - if(!function_type->variadic - && !function_type->unspecified_parameters) { - errorf(HERE, "too many arguments to function '%E'", expression); - } else { - /* do default promotion */ - for( ; argument != NULL; argument = argument->next) { - type_t *type = argument->expression->base.type; - - type = skip_typeref(type); - if(is_type_integer(type)) { - type = promote_integer(type); - } else if(type == type_float) { - type = type_double; - } + } else if (argument != NULL && !function_type->variadic) { + errorf(HERE, "too many arguments to function '%E'", expression); + } + } - argument->expression - = create_implicit_cast(argument->expression, type); - } + /* do default promotion */ + for( ; argument != NULL; argument = argument->next) { + type_t *type = argument->expression->base.type; - check_format(&result->call); - } - } else { - check_format(&result->call); - } + type = get_default_promoted_type(type); + + argument->expression + = create_implicit_cast(argument->expression, type); } + check_format(&result->call); + return result; end_error: return create_invalid_expression(); @@ -6108,19 +6128,37 @@ end_error: return create_invalid_expression(); } +static void check_pointer_arithmetic(const source_position_t *source_position, + type_t *pointer_type, + type_t *orig_pointer_type) +{ + type_t *points_to = pointer_type->pointer.points_to; + points_to = skip_typeref(points_to); + + if (is_type_incomplete(points_to) && + (! (c_mode & _GNUC) + || !is_type_atomic(points_to, ATOMIC_TYPE_VOID))) { + errorf(source_position, + "arithmetic with pointer to incomplete type '%T' not allowed", + orig_pointer_type); + } else if (is_type_function(points_to)) { + errorf(source_position, + "arithmetic with pointer to function type '%T' not allowed", + orig_pointer_type); + } +} + static void semantic_incdec(unary_expression_t *expression) { type_t *const orig_type = expression->value->base.type; type_t *const type = skip_typeref(orig_type); - /* TODO !is_type_real && !is_type_pointer */ - if(!is_type_arithmetic(type) && type->kind != TYPE_POINTER) { - if (is_type_valid(type)) { - /* TODO: improve error message */ - errorf(HERE, "operation needs an arithmetic or pointer type"); - } - return; + if (is_type_pointer(type)) { + check_pointer_arithmetic(&expression->base.source_position, + type, orig_type); + } else if (!is_type_real(type) && is_type_valid(type)) { + /* TODO: improve error message */ + errorf(HERE, "operation needs an arithmetic or pointer type"); } - expression->base.type = orig_type; } @@ -6364,19 +6402,25 @@ static void semantic_add(binary_expression_t *expression) type_t *const type_left = skip_typeref(orig_type_left); type_t *const type_right = skip_typeref(orig_type_right); - /* § 5.6.5 */ - if(is_type_arithmetic(type_left) && is_type_arithmetic(type_right)) { + /* § 6.5.6 */ + if (is_type_arithmetic(type_left) && is_type_arithmetic(type_right)) { type_t *arithmetic_type = semantic_arithmetic(type_left, type_right); expression->left = create_implicit_cast(left, arithmetic_type); expression->right = create_implicit_cast(right, arithmetic_type); expression->base.type = arithmetic_type; return; - } else if(is_type_pointer(type_left) && is_type_integer(type_right)) { + } else if (is_type_pointer(type_left) && is_type_integer(type_right)) { + check_pointer_arithmetic(&expression->base.source_position, + type_left, orig_type_left); expression->base.type = type_left; - } else if(is_type_pointer(type_right) && is_type_integer(type_left)) { + } else if (is_type_pointer(type_right) && is_type_integer(type_left)) { + check_pointer_arithmetic(&expression->base.source_position, + type_right, orig_type_right); expression->base.type = type_right; } else if (is_type_valid(type_left) && is_type_valid(type_right)) { - errorf(HERE, "invalid operands to binary + ('%T', '%T')", orig_type_left, orig_type_right); + errorf(&expression->base.source_position, + "invalid operands to binary + ('%T', '%T')", + orig_type_left, orig_type_right); } } @@ -6397,6 +6441,8 @@ static void semantic_sub(binary_expression_t *expression) expression->base.type = arithmetic_type; return; } else if(is_type_pointer(type_left) && is_type_integer(type_right)) { + check_pointer_arithmetic(&expression->base.source_position, + type_left, orig_type_left); expression->base.type = type_left; } else if(is_type_pointer(type_left) && is_type_pointer(type_right)) { if(!pointers_compatible(type_left, type_right)) { @@ -6504,21 +6550,29 @@ static bool has_const_fields(const compound_type_t *type) return false; } +static bool is_lvalue(const expression_t *expression) +{ + switch (expression->kind) { + case EXPR_REFERENCE: + case EXPR_ARRAY_ACCESS: + case EXPR_SELECT: + case EXPR_UNARY_DEREFERENCE: + return true; + + default: + return false; + } +} + static bool is_valid_assignment_lhs(expression_t const* const left) { type_t *const orig_type_left = revert_automatic_type_conversion(left); type_t *const type_left = skip_typeref(orig_type_left); - switch (left->kind) { - case EXPR_REFERENCE: - case EXPR_ARRAY_ACCESS: - case EXPR_SELECT: - case EXPR_UNARY_DEREFERENCE: - break; - - default: - errorf(HERE, "left hand side '%E' of assignment is not an lvalue", left); - return false; + if (!is_lvalue(left)) { + errorf(HERE, "left hand side '%E' of assignment is not an lvalue", + left); + return false; } if (is_type_array(type_left)) { @@ -6595,6 +6649,8 @@ static void semantic_arithmetic_addsubb_assign(binary_expression_t *expression) expression->right = create_implicit_cast(right, arithmetic_type); expression->base.type = type_left; } else if (is_type_pointer(type_left) && is_type_integer(type_right)) { + check_pointer_arithmetic(&expression->base.source_position, + type_left, orig_type_left); expression->base.type = type_left; } else if (is_type_valid(type_left) && is_type_valid(type_right)) { errorf(HERE, "incompatible types '%T' and '%T' in assignment", orig_type_left, orig_type_right); @@ -6972,13 +7028,13 @@ static void init_expression_parsers(void) register_infix_parser(parse_EXPR_UNARY_POSTFIX_DECREMENT, T_MINUSMINUS, 30); - register_infix_parser(parse_EXPR_BINARY_MUL, '*', 16); - register_infix_parser(parse_EXPR_BINARY_DIV, '/', 16); - register_infix_parser(parse_EXPR_BINARY_MOD, '%', 16); - register_infix_parser(parse_EXPR_BINARY_SHIFTLEFT, T_LESSLESS, 16); - register_infix_parser(parse_EXPR_BINARY_SHIFTRIGHT, T_GREATERGREATER, 16); - register_infix_parser(parse_EXPR_BINARY_ADD, '+', 15); - register_infix_parser(parse_EXPR_BINARY_SUB, '-', 15); + register_infix_parser(parse_EXPR_BINARY_MUL, '*', 17); + register_infix_parser(parse_EXPR_BINARY_DIV, '/', 17); + register_infix_parser(parse_EXPR_BINARY_MOD, '%', 17); + register_infix_parser(parse_EXPR_BINARY_ADD, '+', 16); + register_infix_parser(parse_EXPR_BINARY_SUB, '-', 16); + register_infix_parser(parse_EXPR_BINARY_SHIFTLEFT, T_LESSLESS, 15); + register_infix_parser(parse_EXPR_BINARY_SHIFTRIGHT, T_GREATERGREATER, 15); register_infix_parser(parse_EXPR_BINARY_LESS, '<', 14); register_infix_parser(parse_EXPR_BINARY_GREATER, '>', 14); register_infix_parser(parse_EXPR_BINARY_LESSEQUAL, T_LESSEQUAL, 14); @@ -7029,40 +7085,44 @@ static void init_expression_parsers(void) } /** - * Parse a asm statement constraints specification. + * Parse a asm statement arguments specification. */ -static asm_constraint_t *parse_asm_constraints(void) +static asm_argument_t *parse_asm_arguments(bool is_out) { - asm_constraint_t *result = NULL; - asm_constraint_t *last = NULL; + asm_argument_t *result = NULL; + asm_argument_t *last = NULL; while(token.type == T_STRING_LITERAL || token.type == '[') { - asm_constraint_t *constraint = allocate_ast_zero(sizeof(constraint[0])); - memset(constraint, 0, sizeof(constraint[0])); + asm_argument_t *argument = allocate_ast_zero(sizeof(argument[0])); + memset(argument, 0, sizeof(argument[0])); if(token.type == '[') { eat('['); if(token.type != T_IDENTIFIER) { - parse_error_expected("while parsing asm constraint", + parse_error_expected("while parsing asm argument", T_IDENTIFIER, NULL); return NULL; } - constraint->symbol = token.v.symbol; + argument->symbol = token.v.symbol; expect(']'); } - constraint->constraints = parse_string_literals(); + argument->constraints = parse_string_literals(); expect('('); - constraint->expression = parse_expression(); + argument->expression = parse_expression(); + if (is_out && !is_lvalue(argument->expression)) { + errorf(&argument->expression->base.source_position, + "asm output argument is not an lvalue"); + } expect(')'); if(last != NULL) { - last->next = constraint; + last->next = argument; } else { - result = constraint; + result = argument; } - last = constraint; + last = argument; if(token.type != ',') break; @@ -7129,14 +7189,14 @@ static statement_t *parse_asm_statement(void) } eat(':'); - asm_statement->inputs = parse_asm_constraints(); + asm_statement->outputs = parse_asm_arguments(true); if(token.type != ':') { rem_anchor_token(':'); goto end_of_asm; } eat(':'); - asm_statement->outputs = parse_asm_constraints(); + asm_statement->inputs = parse_asm_arguments(false); if(token.type != ':') { rem_anchor_token(':'); goto end_of_asm; @@ -7544,7 +7604,7 @@ static statement_t *parse_goto(void) if(token.type != T_IDENTIFIER) { parse_error_expected("while parsing goto", T_IDENTIFIER, NULL); eat_statement(); - return NULL; + goto end_error; } symbol_t *symbol = token.v.symbol; next_token(); @@ -7737,7 +7797,8 @@ static statement_t *parse_return(void) } } /* check for returning address of a local var */ - if (return_value->base.kind == EXPR_UNARY_TAKE_ADDRESS) { + if (return_value != NULL && + return_value->base.kind == EXPR_UNARY_TAKE_ADDRESS) { const expression_t *expression = return_value->unary.value; if (is_local_variable(expression)) { warningf(&statement->base.source_position, @@ -8109,18 +8170,8 @@ static void check_unused_globals(void) /** * Parse a translation unit. */ -static translation_unit_t *parse_translation_unit(void) +static void parse_translation_unit(void) { - translation_unit_t *unit = allocate_ast_zero(sizeof(unit[0])); - - assert(global_scope == NULL); - global_scope = &unit->scope; - - assert(scope == NULL); - set_scope(&unit->scope); - - initialize_builtin_types(); - while(token.type != T_EOF) { if (token.type == ';') { /* TODO error in strict mode */ @@ -8130,16 +8181,6 @@ static translation_unit_t *parse_translation_unit(void) parse_external_declaration(); } } - - assert(scope == &unit->scope); - scope = NULL; - last_declaration = NULL; - - assert(global_scope == &unit->scope); - check_unused_globals(); - global_scope = NULL; - - return unit; } /** @@ -8147,7 +8188,7 @@ static translation_unit_t *parse_translation_unit(void) * * @return the translation unit or NULL if errors occurred. */ -translation_unit_t *parse(void) +void start_parsing(void) { environment_stack = NEW_ARR_F(stack_entry_t, 0); label_stack = NEW_ARR_F(stack_entry_t, 0); @@ -8158,16 +8199,43 @@ translation_unit_t *parse(void) type_set_output(stderr); ast_set_output(stderr); - lookahead_bufpos = 0; - for(int i = 0; i < MAX_LOOKAHEAD + 2; ++i) { - next_token(); - } - translation_unit_t *unit = parse_translation_unit(); + assert(unit == NULL); + unit = allocate_ast_zero(sizeof(unit[0])); + + assert(global_scope == NULL); + global_scope = &unit->scope; + + assert(scope == NULL); + set_scope(&unit->scope); + + initialize_builtin_types(); +} + +translation_unit_t *finish_parsing(void) +{ + assert(scope == &unit->scope); + scope = NULL; + last_declaration = NULL; + + assert(global_scope == &unit->scope); + check_unused_globals(); + global_scope = NULL; DEL_ARR_F(environment_stack); DEL_ARR_F(label_stack); - return unit; + translation_unit_t *result = unit; + unit = NULL; + return result; +} + +void parse(void) +{ + lookahead_bufpos = 0; + for(int i = 0; i < MAX_LOOKAHEAD + 2; ++i) { + next_token(); + } + parse_translation_unit(); } /**