X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=ir%2Fopt%2Fscalar_replace.c;h=9041a6998aa5240b911c095b58941860124f4d76;hb=8c9921a1fc166552f6e416434fd8394a4fc210a3;hp=67be0499311fca08097886be3bd398e4e4965fa3;hpb=15ad7ccd8dff64e1808e1d093d4a8d7cda5af33e;p=libfirm diff --git a/ir/opt/scalar_replace.c b/ir/opt/scalar_replace.c index 67be04993..9041a6998 100644 --- a/ir/opt/scalar_replace.c +++ b/ir/opt/scalar_replace.c @@ -21,11 +21,11 @@ * @file * @brief Scalar replacement of compounds. * @author Beyhan Veliev, Michael Beck - * @version $Id$ */ #include "config.h" #include +#include #include "iroptimize.h" #include "scalar_replace.h" @@ -42,13 +42,21 @@ #include "irgmod.h" #include "irnode_t.h" #include "irpass.h" -#include "irtools.h" +#include "util.h" #include "xmalloc.h" #include "debug.h" #include "error.h" +#include "opt_manage.h" -#define SET_VNUM(node, vnum) set_irn_link(node, INT_TO_PTR(vnum)) -#define GET_VNUM(node) (unsigned)PTR_TO_INT(get_irn_link(node)) +static unsigned get_vnum(const ir_node *node) +{ + return (unsigned)PTR_TO_INT(get_irn_link(node)); +} + +static void set_vnum(ir_node *node, unsigned vnum) +{ + set_irn_link(node, INT_TO_PTR(vnum)); +} /** * A path element entry: it is either an entity @@ -71,7 +79,10 @@ typedef struct path_t { } path_t; /** The size of a path in bytes. */ -#define PATH_SIZE(p) (sizeof(*(p)) + sizeof((p)->path[0]) * ((p)->path_len - 1)) +static size_t path_size(path_t *p) +{ + return sizeof(*p) + sizeof(p->path[0]) * (p->path_len-1); +} typedef struct scalars_t { ir_entity *ent; /**< A entity for scalar replacement. */ @@ -127,7 +138,7 @@ static unsigned path_hash(const path_t *path) * * @param sel the Sel node that will be checked */ -static int is_const_sel(ir_node *sel) +static bool is_const_sel(ir_node *sel) { int i, n = get_Sel_n_indexs(sel); @@ -135,9 +146,9 @@ static int is_const_sel(ir_node *sel) ir_node *idx = get_Sel_index(sel, i); if (!is_Const(idx)) - return 0; + return false; } - return 1; + return true; } /** @@ -157,24 +168,23 @@ static int is_const_sel(ir_node *sel) * @param mode the mode of the Load/Store * @param ent_mode the mode of the accessed entity */ -static int check_load_store_mode(ir_mode *mode, ir_mode *ent_mode) +static bool check_load_store_mode(ir_mode *mode, ir_mode *ent_mode) { if (ent_mode != mode) { if (ent_mode == NULL || get_mode_size_bits(ent_mode) != get_mode_size_bits(mode) || - get_mode_sort(ent_mode) != get_mode_sort(mode) || get_mode_arithmetic(ent_mode) != irma_twos_complement || get_mode_arithmetic(mode) != irma_twos_complement) - return 0; + return false; } - return 1; + return true; } /* * Returns non-zero, if the address of an entity * represented by a Sel node (or its successor Sels) is taken. */ -int is_address_taken(ir_node *sel) +bool is_address_taken(ir_node *sel) { int i, input_nr, k; ir_mode *emode, *mode; @@ -182,7 +192,7 @@ int is_address_taken(ir_node *sel) ir_entity *ent; if (! is_const_sel(sel)) - return 1; + return true; for (i = get_irn_n_outs(sel) - 1; i >= 0; --i) { ir_node *succ = get_irn_out(sel, i); @@ -191,29 +201,29 @@ int is_address_taken(ir_node *sel) case iro_Load: /* do not remove volatile variables */ if (get_Load_volatility(succ) == volatility_is_volatile) - return 1; + return true; /* check if this load is not a hidden conversion */ mode = get_Load_mode(succ); ent = get_Sel_entity(sel); emode = get_type_mode(get_entity_type(ent)); if (! check_load_store_mode(mode, emode)) - return 1; + return true; break; case iro_Store: /* check that Sel is not the Store's value */ value = get_Store_value(succ); if (value == sel) - return 1; + return true; /* do not remove volatile variables */ if (get_Store_volatility(succ) == volatility_is_volatile) - return 1; + return true; /* check if this Store is not a hidden conversion */ mode = get_irn_mode(value); ent = get_Sel_entity(sel); emode = get_type_mode(get_entity_type(ent)); if (! check_load_store_mode(mode, emode)) - return 1; + return true; break; case iro_Sel: { @@ -221,12 +231,12 @@ int is_address_taken(ir_node *sel) ir_entity *entity = get_Sel_entity(succ); /* we can't handle unions correctly yet -> address taken */ if (is_Union_type(get_entity_owner(entity))) - return 1; + return true; /* Check the Sel successor of Sel */ res = is_address_taken(succ); if (res) - return 1; + return true; break; } @@ -237,12 +247,12 @@ int is_address_taken(ir_node *sel) * One special case: If the Call type tells that it's a * value parameter, the address is NOT taken. */ - return 1; + return true; case iro_Id: { int res = is_address_taken(succ); if (res) - return 1; + return true; break; } @@ -259,7 +269,7 @@ int is_address_taken(ir_node *sel) if (is_Proj(proj) && get_Proj_proj(proj) == input_nr) { int res = is_address_taken(proj); if (res) - return 1; + return true; } } } @@ -268,10 +278,10 @@ int is_address_taken(ir_node *sel) default: /* another op, the address is taken */ - return 1; + return true; } } - return 0; + return false; } /** @@ -280,16 +290,17 @@ int is_address_taken(ir_node *sel) * @param ent the entity that will be scalar replaced * @param sel a Sel node that selects some fields of this entity */ -static int link_all_leave_sels(ir_entity *ent, ir_node *sel) +static bool link_all_leave_sels(ir_entity *ent, ir_node *sel) { - int i, is_leave = 1; + int i; + bool is_leave = true; for (i = get_irn_n_outs(sel) - 1; i >= 0; --i) { ir_node *succ = get_irn_out(sel, i); if (is_Sel(succ)) { /* the current leave has further Sel's, no leave */ - is_leave = 0; + is_leave = false; link_all_leave_sels(ent, succ); } else if (is_Id(succ)) { is_leave &= link_all_leave_sels(ent, succ); @@ -332,26 +343,29 @@ static int find_possible_replacements(ir_graph *irg) { ir_node *irg_frame; ir_type *frame_tp; - int i, j, k, static_link_arg; + size_t mem_idx; + int i; + long static_link_arg; int res = 0; /* * First, clear the link field of all interesting entities. */ frame_tp = get_irg_frame_type(irg); - for (i = get_class_n_members(frame_tp) - 1; i >= 0; --i) { - ir_entity *ent = get_class_member(frame_tp, i); + for (mem_idx = get_class_n_members(frame_tp); mem_idx > 0;) { + ir_entity *ent = get_class_member(frame_tp, --mem_idx); set_entity_link(ent, NULL); } /* check for inner functions: * FIXME: need a way to get the argument position for the static link */ static_link_arg = 0; - for (i = get_class_n_members(frame_tp) - 1; i >= 0; --i) { - ir_entity *ent = get_class_member(frame_tp, i); + for (mem_idx = get_class_n_members(frame_tp); mem_idx > 0;) { + ir_entity *ent = get_class_member(frame_tp, --mem_idx); if (is_method_entity(ent)) { ir_graph *inner_irg = get_entity_irg(ent); ir_node *args; + int j; assure_irg_outs(inner_irg); args = get_irg_args(inner_irg); @@ -359,6 +373,7 @@ static int find_possible_replacements(ir_graph *irg) ir_node *arg = get_irn_out(args, j); if (get_Proj_proj(arg) == static_link_arg) { + int k; for (k = get_irn_n_outs(arg) - 1; k >= 0; --k) { ir_node *succ = get_irn_out(arg, k); @@ -397,17 +412,6 @@ static int find_possible_replacements(ir_graph *irg) if (get_entity_link(ent) == ADDRESS_TAKEN) continue; - /* - * Beware: in rare cases even entities on the frame might be - * volatile. This might happen if the entity serves as a store - * to a value that must survive a exception. Do not optimize - * such entities away. - */ - if (get_entity_volatility(ent) == volatility_is_volatile) { - set_entity_link(ent, ADDRESS_TAKEN); - continue; - } - ent_type = get_entity_type(ent); /* we can handle arrays, structs and atomic types yet */ @@ -487,25 +491,24 @@ static unsigned allocate_value_numbers(pset *sels, ir_entity *ent, unsigned vnum DB((dbg, SET_LEVEL_3, " Visiting Sel nodes of entity %+F\n", ent)); /* visit all Sel nodes in the chain of the entity */ - for (sel = (ir_node*)get_entity_link(ent); sel != NULL; - sel = next) { + for (sel = (ir_node*)get_entity_link(ent); sel != NULL; sel = next) { next = (ir_node*)get_irn_link(sel); /* we must mark this sel for later */ pset_insert_ptr(sels, sel); key = find_path(sel, 0); - path = (path_t*)set_find(pathes, key, PATH_SIZE(key), path_hash(key)); + path = (path_t*)set_find(pathes, key, path_size(key), path_hash(key)); if (path) { - SET_VNUM(sel, path->vnum); + set_vnum(sel, path->vnum); DB((dbg, SET_LEVEL_3, " %+F represents value %u\n", sel, path->vnum)); } else { key->vnum = vnum++; - set_insert(pathes, key, PATH_SIZE(key), path_hash(key)); + set_insert(pathes, key, path_size(key), path_hash(key)); - SET_VNUM(sel, key->vnum); + set_vnum(sel, key->vnum); DB((dbg, SET_LEVEL_3, " %+F represents value %u\n", sel, key->vnum)); ARR_EXTO(ir_mode *, *modes, (key->vnum + 15) & ~15); @@ -537,52 +540,44 @@ static unsigned allocate_value_numbers(pset *sels, ir_entity *ent, unsigned vnum return vnum; } -/** - * A list entry for the fixing lists - */ -typedef struct list_entry_t { - ir_node *node; /**< the node that must be fixed */ - unsigned vnum; /**< the value number of this node */ -} list_entry_t; - /** * environment for memory walker */ typedef struct env_t { - int nvals; /**< number of values */ - ir_mode **modes; /**< the modes of the values */ - pset *sels; /**< A set of all Sel nodes that have a value number */ + unsigned nvals; /**< number of values */ + ir_mode **modes; /**< the modes of the values */ + pset *sels; /**< A set of all Sel nodes that have a value number */ } env_t; /** * topological post-walker. */ -static void topologic_walker(ir_node *node, void *ctx) +static void walker(ir_node *node, void *ctx) { env_t *env = (env_t*)ctx; ir_graph *irg = get_irn_irg(node); - ir_node *adr, *block, *mem, *val; + ir_node *addr, *block, *mem, *val; ir_mode *mode; unsigned vnum; if (is_Load(node)) { /* a load, check if we can resolve it */ - adr = get_Load_ptr(node); + addr = get_Load_ptr(node); DB((dbg, SET_LEVEL_3, " checking %+F for replacement ", node)); - if (! is_Sel(adr)) { - DB((dbg, SET_LEVEL_3, "no Sel input (%+F)\n", adr)); + if (! is_Sel(addr)) { + DB((dbg, SET_LEVEL_3, "no Sel input (%+F)\n", addr)); return; } - if (! pset_find_ptr(env->sels, adr)) { - DB((dbg, SET_LEVEL_3, "Sel %+F has no VNUM\n", adr)); + if (! pset_find_ptr(env->sels, addr)) { + DB((dbg, SET_LEVEL_3, "Sel %+F has no VNUM\n", addr)); return; } /* ok, we have a Load that will be replaced */ - vnum = GET_VNUM(adr); - assert(vnum < (unsigned)env->nvals); + vnum = get_vnum(addr); + assert(vnum < env->nvals); DB((dbg, SET_LEVEL_3, "replacing by value %u\n", vnum)); @@ -604,29 +599,29 @@ static void topologic_walker(ir_node *node, void *ctx) val = new_rd_Conv(get_irn_dbg_info(node), block, val, mode); mem = get_Load_mem(node); - turn_into_tuple(node, pn_Load_max); + turn_into_tuple(node, pn_Load_max+1); set_Tuple_pred(node, pn_Load_M, mem); set_Tuple_pred(node, pn_Load_res, val); set_Tuple_pred(node, pn_Load_X_regular, new_r_Jmp(block)); - set_Tuple_pred(node, pn_Load_X_except, new_r_Bad(irg)); + set_Tuple_pred(node, pn_Load_X_except, new_r_Bad(irg, mode_X)); } else if (is_Store(node)) { DB((dbg, SET_LEVEL_3, " checking %+F for replacement ", node)); /* a Store always can be replaced */ - adr = get_Store_ptr(node); + addr = get_Store_ptr(node); - if (! is_Sel(adr)) { - DB((dbg, SET_LEVEL_3, "no Sel input (%+F)\n", adr)); + if (! is_Sel(addr)) { + DB((dbg, SET_LEVEL_3, "no Sel input (%+F)\n", addr)); return; } - if (! pset_find_ptr(env->sels, adr)) { - DB((dbg, SET_LEVEL_3, "Sel %+F has no VNUM\n", adr)); + if (! pset_find_ptr(env->sels, addr)) { + DB((dbg, SET_LEVEL_3, "Sel %+F has no VNUM\n", addr)); return; } - vnum = GET_VNUM(adr); - assert(vnum < (unsigned)env->nvals); + vnum = get_vnum(addr); + assert(vnum < env->nvals); DB((dbg, SET_LEVEL_3, "replacing by value %u\n", vnum)); @@ -641,10 +636,10 @@ static void topologic_walker(ir_node *node, void *ctx) set_value(vnum, val); mem = get_Store_mem(node); - turn_into_tuple(node, pn_Store_max); + turn_into_tuple(node, pn_Store_max+1); set_Tuple_pred(node, pn_Store_M, mem); set_Tuple_pred(node, pn_Store_X_regular, new_r_Jmp(block)); - set_Tuple_pred(node, pn_Store_X_except, new_r_Bad(irg)); + set_Tuple_pred(node, pn_Store_X_except, new_r_Bad(irg, mode_X)); } } @@ -656,12 +651,12 @@ static void topologic_walker(ir_node *node, void *ctx) * @param modes A flexible array, containing all the modes of * the value numbers. */ -static void do_scalar_replacements(ir_graph *irg, pset *sels, int nvals, +static void do_scalar_replacements(ir_graph *irg, pset *sels, unsigned nvals, ir_mode **modes) { env_t env; - ssa_cons_start(irg, nvals); + ssa_cons_start(irg, (int)nvals); env.nvals = nvals; env.modes = modes; @@ -672,7 +667,7 @@ static void do_scalar_replacements(ir_graph *irg, pset *sels, int nvals, * and fill the array as much as possible. */ DB((dbg, SET_LEVEL_3, "Substituting Loads and Stores in %+F\n", irg)); - irg_walk_blkwise_graph(irg, NULL, topologic_walker, &env); + irg_walk_blkwise_graph(irg, NULL, walker, &env); ssa_cons_finish(irg); } @@ -682,7 +677,7 @@ static void do_scalar_replacements(ir_graph *irg, pset *sels, int nvals, * * @param irg The current ir graph. */ -int scalar_replacement_opt(ir_graph *irg) +static ir_graph_state_t do_scalar_replacement(ir_graph *irg) { unsigned nvals; int i; @@ -692,14 +687,10 @@ int scalar_replacement_opt(ir_graph *irg) set *set_ent; pset *sels; ir_type *ent_type, *frame_tp; - int res = 0; - - /* Call algorithm that computes the out edges */ - assure_irg_outs(irg); /* we use the link field to store the VNUM */ ir_reserve_resources(irg, IR_RESOURCE_IRN_LINK); - irp_reserve_resources(irp, IR_RESOURCE_ENTITY_LINK); + irp_reserve_resources(irp, IRP_RESOURCE_ENTITY_LINK); /* Find possible scalar replacements */ if (find_possible_replacements(irg)) { @@ -720,8 +711,9 @@ int scalar_replacement_opt(ir_graph *irg) ir_entity *ent = get_Sel_entity(succ); /* we are only interested in entities on the frame, NOT - on the value type */ - if (get_entity_owner(ent) != frame_tp) + parameters */ + if (get_entity_owner(ent) != frame_tp + || is_parameter_entity(ent)) continue; if (get_entity_link(ent) == NULL || get_entity_link(ent) == ADDRESS_TAKEN) @@ -763,10 +755,6 @@ int scalar_replacement_opt(ir_graph *irg) * neither changed control flow, cf-backedges should be still * consistent. */ - set_irg_outs_inconsistent(irg); - set_irg_loopinfo_inconsistent(irg); - - res = 1; } del_pset(sels); del_set(set_ent); @@ -774,9 +762,21 @@ int scalar_replacement_opt(ir_graph *irg) } ir_free_resources(irg, IR_RESOURCE_IRN_LINK); - irp_free_resources(irp, IR_RESOURCE_ENTITY_LINK); + irp_free_resources(irp, IRP_RESOURCE_ENTITY_LINK); - return res; + return 0; +} + +static optdesc_t opt_scalar_rep = { + "scalar-replace", + IR_GRAPH_STATE_NO_UNREACHABLE_CODE | IR_GRAPH_STATE_CONSISTENT_OUTS, + do_scalar_replacement, +}; + +int scalar_replacement_opt(ir_graph *irg) +{ + perform_irg_optimization(irg, &opt_scalar_rep); + return 1; } ir_graph_pass_t *scalar_replacement_opt_pass(const char *name)