X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=ir%2Fopt%2Fscalar_replace.c;h=09e70986ce7c40f4893705aa2a2313f4d143b8fd;hb=34e3b8d50bce639e760da7233524a4db85c80290;hp=a03fd5a421b50a2168667979a6f534126a0f77af;hpb=0a0fd5a9cfa2e1be8fd01c116e33ddfbe34ecb8d;p=libfirm diff --git a/ir/opt/scalar_replace.c b/ir/opt/scalar_replace.c index a03fd5a42..09e70986c 100644 --- a/ir/opt/scalar_replace.c +++ b/ir/opt/scalar_replace.c @@ -1,31 +1,17 @@ /* - * Copyright (C) 1995-2011 University of Karlsruhe. All right reserved. - * * This file is part of libFirm. - * - * This file may be distributed and/or modified under the terms of the - * GNU General Public License version 2 as published by the Free Software - * Foundation and appearing in the file LICENSE.GPL included in the - * packaging of this file. - * - * Licensees holding valid libFirm Professional Edition licenses may use - * this file in accordance with the libFirm Commercial License. - * Agreement provided with the Software. - * - * This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE - * WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR - * PURPOSE. + * Copyright (C) 2012 University of Karlsruhe. */ /** * @file * @brief Scalar replacement of compounds. * @author Beyhan Veliev, Michael Beck - * @version $Id$ */ #include "config.h" #include +#include #include "iroptimize.h" #include "scalar_replace.h" @@ -42,13 +28,20 @@ #include "irgmod.h" #include "irnode_t.h" #include "irpass.h" -#include "irtools.h" +#include "util.h" #include "xmalloc.h" #include "debug.h" #include "error.h" -#define SET_VNUM(node, vnum) set_irn_link(node, INT_TO_PTR(vnum)) -#define GET_VNUM(node) (unsigned)PTR_TO_INT(get_irn_link(node)) +static unsigned get_vnum(const ir_node *node) +{ + return (unsigned)PTR_TO_INT(get_irn_link(node)); +} + +static void set_vnum(ir_node *node, unsigned vnum) +{ + set_irn_link(node, INT_TO_PTR(vnum)); +} /** * A path element entry: it is either an entity @@ -71,7 +64,10 @@ typedef struct path_t { } path_t; /** The size of a path in bytes. */ -#define PATH_SIZE(p) (sizeof(*(p)) + sizeof((p)->path[0]) * ((p)->path_len - 1)) +static size_t path_size(path_t *p) +{ + return sizeof(*p) + sizeof(p->path[0]) * (p->path_len-1); +} typedef struct scalars_t { ir_entity *ent; /**< A entity for scalar replacement. */ @@ -127,7 +123,7 @@ static unsigned path_hash(const path_t *path) * * @param sel the Sel node that will be checked */ -static int is_const_sel(ir_node *sel) +static bool is_const_sel(ir_node *sel) { int i, n = get_Sel_n_indexs(sel); @@ -135,9 +131,9 @@ static int is_const_sel(ir_node *sel) ir_node *idx = get_Sel_index(sel, i); if (!is_Const(idx)) - return 0; + return false; } - return 1; + return true; } /** @@ -157,63 +153,62 @@ static int is_const_sel(ir_node *sel) * @param mode the mode of the Load/Store * @param ent_mode the mode of the accessed entity */ -static int check_load_store_mode(ir_mode *mode, ir_mode *ent_mode) +static bool check_load_store_mode(ir_mode *mode, ir_mode *ent_mode) { if (ent_mode != mode) { if (ent_mode == NULL || get_mode_size_bits(ent_mode) != get_mode_size_bits(mode) || - get_mode_sort(ent_mode) != get_mode_sort(mode) || get_mode_arithmetic(ent_mode) != irma_twos_complement || get_mode_arithmetic(mode) != irma_twos_complement) - return 0; + return false; } - return 1; + return true; } /* * Returns non-zero, if the address of an entity - * represented by a Sel node (or it's successor Sels) is taken. + * represented by a Sel node (or its successor Sels) is taken. */ -int is_address_taken(ir_node *sel) +bool is_address_taken(ir_node *sel) { - int i, input_nr, k; + int input_nr; ir_mode *emode, *mode; ir_node *value; ir_entity *ent; if (! is_const_sel(sel)) - return 1; + return true; - for (i = get_irn_n_outs(sel) - 1; i >= 0; --i) { + for (unsigned i = get_irn_n_outs(sel); i-- > 0; ) { ir_node *succ = get_irn_out(sel, i); switch (get_irn_opcode(succ)) { case iro_Load: /* do not remove volatile variables */ if (get_Load_volatility(succ) == volatility_is_volatile) - return 1; + return true; /* check if this load is not a hidden conversion */ mode = get_Load_mode(succ); ent = get_Sel_entity(sel); emode = get_type_mode(get_entity_type(ent)); if (! check_load_store_mode(mode, emode)) - return 1; + return true; break; case iro_Store: /* check that Sel is not the Store's value */ value = get_Store_value(succ); if (value == sel) - return 1; + return true; /* do not remove volatile variables */ if (get_Store_volatility(succ) == volatility_is_volatile) - return 1; + return true; /* check if this Store is not a hidden conversion */ mode = get_irn_mode(value); ent = get_Sel_entity(sel); emode = get_type_mode(get_entity_type(ent)); if (! check_load_store_mode(mode, emode)) - return 1; + return true; break; case iro_Sel: { @@ -221,12 +216,12 @@ int is_address_taken(ir_node *sel) ir_entity *entity = get_Sel_entity(succ); /* we can't handle unions correctly yet -> address taken */ if (is_Union_type(get_entity_owner(entity))) - return 1; + return true; /* Check the Sel successor of Sel */ res = is_address_taken(succ); if (res) - return 1; + return true; break; } @@ -237,12 +232,12 @@ int is_address_taken(ir_node *sel) * One special case: If the Call type tells that it's a * value parameter, the address is NOT taken. */ - return 1; + return true; case iro_Id: { int res = is_address_taken(succ); if (res) - return 1; + return true; break; } @@ -253,13 +248,13 @@ int is_address_taken(ir_node *sel) if (pred == sel) { /* we found one input */ - for (k = get_irn_n_outs(succ) - 1; k >= 0; --k) { + for (unsigned k = get_irn_n_outs(succ); k-- > 0; ) { ir_node *proj = get_irn_out(succ, k); if (is_Proj(proj) && get_Proj_proj(proj) == input_nr) { int res = is_address_taken(proj); if (res) - return 1; + return true; } } } @@ -268,10 +263,10 @@ int is_address_taken(ir_node *sel) default: /* another op, the address is taken */ - return 1; + return true; } } - return 0; + return false; } /** @@ -280,16 +275,16 @@ int is_address_taken(ir_node *sel) * @param ent the entity that will be scalar replaced * @param sel a Sel node that selects some fields of this entity */ -static int link_all_leave_sels(ir_entity *ent, ir_node *sel) +static bool link_all_leave_sels(ir_entity *ent, ir_node *sel) { - int i, is_leave = 1; + bool is_leave = true; - for (i = get_irn_n_outs(sel) - 1; i >= 0; --i) { + for (unsigned i = get_irn_n_outs(sel); i-- > 0; ) { ir_node *succ = get_irn_out(sel, i); if (is_Sel(succ)) { /* the current leave has further Sel's, no leave */ - is_leave = 0; + is_leave = false; link_all_leave_sels(ent, succ); } else if (is_Id(succ)) { is_leave &= link_all_leave_sels(ent, succ); @@ -321,7 +316,7 @@ static void *ADDRESS_TAKEN = &_x; * * This function finds variables on the (members of the) frame type * that can be scalar replaced, because their address is never taken. - * If such a variable is found, it's entity link will hold a list of all + * If such a variable is found, its entity link will hold a list of all * Sel nodes, that selects the atomic fields of this entity. * Otherwise, the link will be ADDRESS_TAKEN or NULL. * @@ -332,34 +327,35 @@ static int find_possible_replacements(ir_graph *irg) { ir_node *irg_frame; ir_type *frame_tp; - int i, j, k, static_link_arg; + size_t mem_idx; + long static_link_arg; int res = 0; /* * First, clear the link field of all interesting entities. */ frame_tp = get_irg_frame_type(irg); - for (i = get_class_n_members(frame_tp) - 1; i >= 0; --i) { - ir_entity *ent = get_class_member(frame_tp, i); + for (mem_idx = get_class_n_members(frame_tp); mem_idx > 0;) { + ir_entity *ent = get_class_member(frame_tp, --mem_idx); set_entity_link(ent, NULL); } /* check for inner functions: * FIXME: need a way to get the argument position for the static link */ static_link_arg = 0; - for (i = get_class_n_members(frame_tp) - 1; i >= 0; --i) { - ir_entity *ent = get_class_member(frame_tp, i); + for (mem_idx = get_class_n_members(frame_tp); mem_idx > 0;) { + ir_entity *ent = get_class_member(frame_tp, --mem_idx); if (is_method_entity(ent)) { ir_graph *inner_irg = get_entity_irg(ent); ir_node *args; - assure_irg_outs(inner_irg); + assure_irg_properties(inner_irg, IR_GRAPH_PROPERTY_CONSISTENT_OUTS); args = get_irg_args(inner_irg); - for (j = get_irn_n_outs(args) - 1; j >= 0; --j) { + for (unsigned j = get_irn_n_outs(args); j-- > 0; ) { ir_node *arg = get_irn_out(args, j); if (get_Proj_proj(arg) == static_link_arg) { - for (k = get_irn_n_outs(arg) - 1; k >= 0; --k) { + for (unsigned k = get_irn_n_outs(arg); k-- > 0; ) { ir_node *succ = get_irn_out(arg, k); if (is_Sel(succ)) { @@ -382,7 +378,7 @@ static int find_possible_replacements(ir_graph *irg) * equal ADDRESS_TAKEN. */ irg_frame = get_irg_frame(irg); - for (i = get_irn_n_outs(irg_frame) - 1; i >= 0; --i) { + for (unsigned i = get_irn_n_outs(irg_frame); i-- > 0; ) { ir_node *succ = get_irn_out(irg_frame, i); if (is_Sel(succ)) { @@ -397,17 +393,6 @@ static int find_possible_replacements(ir_graph *irg) if (get_entity_link(ent) == ADDRESS_TAKEN) continue; - /* - * Beware: in rare cases even entities on the frame might be - * volatile. This might happen if the entity serves as a store - * to a value that must survive a exception. Do not optimize - * such entities away. - */ - if (get_entity_volatility(ent) == volatility_is_volatile) { - set_entity_link(ent, ADDRESS_TAKEN); - continue; - } - ent_type = get_entity_type(ent); /* we can handle arrays, structs and atomic types yet */ @@ -431,7 +416,7 @@ static int find_possible_replacements(ir_graph *irg) } /** - * Return a path from the Sel node sel to it's root. + * Return a path from the Sel node "sel" to its root. * * @param sel the Sel node * @param len the length of the path so far @@ -487,28 +472,27 @@ static unsigned allocate_value_numbers(pset *sels, ir_entity *ent, unsigned vnum DB((dbg, SET_LEVEL_3, " Visiting Sel nodes of entity %+F\n", ent)); /* visit all Sel nodes in the chain of the entity */ - for (sel = (ir_node*)get_entity_link(ent); sel != NULL; - sel = next) { + for (sel = (ir_node*)get_entity_link(ent); sel != NULL; sel = next) { next = (ir_node*)get_irn_link(sel); /* we must mark this sel for later */ pset_insert_ptr(sels, sel); key = find_path(sel, 0); - path = (path_t*)set_find(pathes, key, PATH_SIZE(key), path_hash(key)); + path = set_find(path_t, pathes, key, path_size(key), path_hash(key)); if (path) { - SET_VNUM(sel, path->vnum); + set_vnum(sel, path->vnum); DB((dbg, SET_LEVEL_3, " %+F represents value %u\n", sel, path->vnum)); } else { key->vnum = vnum++; - set_insert(pathes, key, PATH_SIZE(key), path_hash(key)); + (void)set_insert(path_t, pathes, key, path_size(key), path_hash(key)); - SET_VNUM(sel, key->vnum); + set_vnum(sel, key->vnum); DB((dbg, SET_LEVEL_3, " %+F represents value %u\n", sel, key->vnum)); - ARR_EXTO(ir_mode *, *modes, (int)((key->vnum + 15) & ~15)); + ARR_EXTO(ir_mode *, *modes, (key->vnum + 15) & ~15); (*modes)[key->vnum] = get_type_mode(get_entity_type(get_Sel_entity(sel))); @@ -537,52 +521,44 @@ static unsigned allocate_value_numbers(pset *sels, ir_entity *ent, unsigned vnum return vnum; } -/** - * A list entry for the fixing lists - */ -typedef struct list_entry_t { - ir_node *node; /**< the node that must be fixed */ - unsigned vnum; /**< the value number of this node */ -} list_entry_t; - /** * environment for memory walker */ typedef struct env_t { - int nvals; /**< number of values */ - ir_mode **modes; /**< the modes of the values */ - pset *sels; /**< A set of all Sel nodes that have a value number */ + unsigned nvals; /**< number of values */ + ir_mode **modes; /**< the modes of the values */ + pset *sels; /**< A set of all Sel nodes that have a value number */ } env_t; /** * topological post-walker. */ -static void topologic_walker(ir_node *node, void *ctx) +static void walker(ir_node *node, void *ctx) { env_t *env = (env_t*)ctx; ir_graph *irg = get_irn_irg(node); - ir_node *adr, *block, *mem, *val; + ir_node *addr, *block, *mem, *val; ir_mode *mode; unsigned vnum; if (is_Load(node)) { /* a load, check if we can resolve it */ - adr = get_Load_ptr(node); + addr = get_Load_ptr(node); DB((dbg, SET_LEVEL_3, " checking %+F for replacement ", node)); - if (! is_Sel(adr)) { - DB((dbg, SET_LEVEL_3, "no Sel input (%+F)\n", adr)); + if (! is_Sel(addr)) { + DB((dbg, SET_LEVEL_3, "no Sel input (%+F)\n", addr)); return; } - if (! pset_find_ptr(env->sels, adr)) { - DB((dbg, SET_LEVEL_3, "Sel %+F has no VNUM\n", adr)); + if (! pset_find_ptr(env->sels, addr)) { + DB((dbg, SET_LEVEL_3, "Sel %+F has no VNUM\n", addr)); return; } /* ok, we have a Load that will be replaced */ - vnum = GET_VNUM(adr); - assert(vnum < (unsigned)env->nvals); + vnum = get_vnum(addr); + assert(vnum < env->nvals); DB((dbg, SET_LEVEL_3, "replacing by value %u\n", vnum)); @@ -604,29 +580,31 @@ static void topologic_walker(ir_node *node, void *ctx) val = new_rd_Conv(get_irn_dbg_info(node), block, val, mode); mem = get_Load_mem(node); - turn_into_tuple(node, pn_Load_max); - set_Tuple_pred(node, pn_Load_M, mem); - set_Tuple_pred(node, pn_Load_res, val); - set_Tuple_pred(node, pn_Load_X_regular, new_r_Jmp(block)); - set_Tuple_pred(node, pn_Load_X_except, new_r_Bad(irg)); + ir_node *const in[] = { + [pn_Load_M] = mem, + [pn_Load_res] = val, + [pn_Load_X_regular] = new_r_Jmp(block), + [pn_Load_X_except] = new_r_Bad(irg, mode_X), + }; + turn_into_tuple(node, ARRAY_SIZE(in), in); } else if (is_Store(node)) { DB((dbg, SET_LEVEL_3, " checking %+F for replacement ", node)); /* a Store always can be replaced */ - adr = get_Store_ptr(node); + addr = get_Store_ptr(node); - if (! is_Sel(adr)) { - DB((dbg, SET_LEVEL_3, "no Sel input (%+F)\n", adr)); + if (! is_Sel(addr)) { + DB((dbg, SET_LEVEL_3, "no Sel input (%+F)\n", addr)); return; } - if (! pset_find_ptr(env->sels, adr)) { - DB((dbg, SET_LEVEL_3, "Sel %+F has no VNUM\n", adr)); + if (! pset_find_ptr(env->sels, addr)) { + DB((dbg, SET_LEVEL_3, "Sel %+F has no VNUM\n", addr)); return; } - vnum = GET_VNUM(adr); - assert(vnum < (unsigned)env->nvals); + vnum = get_vnum(addr); + assert(vnum < env->nvals); DB((dbg, SET_LEVEL_3, "replacing by value %u\n", vnum)); @@ -641,10 +619,12 @@ static void topologic_walker(ir_node *node, void *ctx) set_value(vnum, val); mem = get_Store_mem(node); - turn_into_tuple(node, pn_Store_max); - set_Tuple_pred(node, pn_Store_M, mem); - set_Tuple_pred(node, pn_Store_X_regular, new_r_Jmp(block)); - set_Tuple_pred(node, pn_Store_X_except, new_r_Bad(irg)); + ir_node *const in[] = { + [pn_Store_M] = mem, + [pn_Store_X_regular] = new_r_Jmp(block), + [pn_Store_X_except] = new_r_Bad(irg, mode_X), + }; + turn_into_tuple(node, ARRAY_SIZE(in), in); } } @@ -656,12 +636,12 @@ static void topologic_walker(ir_node *node, void *ctx) * @param modes A flexible array, containing all the modes of * the value numbers. */ -static void do_scalar_replacements(ir_graph *irg, pset *sels, int nvals, +static void do_scalar_replacements(ir_graph *irg, pset *sels, unsigned nvals, ir_mode **modes) { env_t env; - ssa_cons_start(irg, nvals); + ssa_cons_start(irg, (int)nvals); env.nvals = nvals; env.modes = modes; @@ -672,7 +652,7 @@ static void do_scalar_replacements(ir_graph *irg, pset *sels, int nvals, * and fill the array as much as possible. */ DB((dbg, SET_LEVEL_3, "Substituting Loads and Stores in %+F\n", irg)); - irg_walk_blkwise_graph(irg, NULL, topologic_walker, &env); + irg_walk_blkwise_graph(irg, NULL, walker, &env); ssa_cons_finish(irg); } @@ -682,24 +662,23 @@ static void do_scalar_replacements(ir_graph *irg, pset *sels, int nvals, * * @param irg The current ir graph. */ -int scalar_replacement_opt(ir_graph *irg) +void scalar_replacement_opt(ir_graph *irg) { unsigned nvals; - int i; - scalars_t key, *value; + scalars_t key; ir_node *irg_frame; ir_mode **modes; set *set_ent; pset *sels; ir_type *ent_type, *frame_tp; - int res = 0; - /* Call algorithm that computes the out edges */ - assure_irg_outs(irg); + assure_irg_properties(irg, + IR_GRAPH_PROPERTY_NO_UNREACHABLE_CODE + | IR_GRAPH_PROPERTY_CONSISTENT_OUTS); /* we use the link field to store the VNUM */ ir_reserve_resources(irg, IR_RESOURCE_IRN_LINK); - irp_reserve_resources(irp, IR_RESOURCE_ENTITY_LINK); + irp_reserve_resources(irp, IRP_RESOURCE_ENTITY_LINK); /* Find possible scalar replacements */ if (find_possible_replacements(irg)) { @@ -713,15 +692,16 @@ int scalar_replacement_opt(ir_graph *irg) sels = pset_new_ptr(8); frame_tp = get_irg_frame_type(irg); - for (i = get_irn_n_outs(irg_frame) - 1; i >= 0; --i) { + for (unsigned i = get_irn_n_outs(irg_frame); i-- > 0; ) { ir_node *succ = get_irn_out(irg_frame, i); if (is_Sel(succ)) { ir_entity *ent = get_Sel_entity(succ); /* we are only interested in entities on the frame, NOT - on the value type */ - if (get_entity_owner(ent) != frame_tp) + parameters */ + if (get_entity_owner(ent) != frame_tp + || is_parameter_entity(ent)) continue; if (get_entity_link(ent) == NULL || get_entity_link(ent) == ADDRESS_TAKEN) @@ -730,7 +710,7 @@ int scalar_replacement_opt(ir_graph *irg) ent_type = get_entity_type(ent); key.ent = ent; - set_insert(set_ent, &key, sizeof(key), HASH_PTR(key.ent)); + (void)set_insert(scalars_t, set_ent, &key, sizeof(key), hash_ptr(key.ent)); #ifdef DEBUG_libfirm if (is_Array_type(ent_type)) { @@ -754,7 +734,7 @@ int scalar_replacement_opt(ir_graph *irg) if (nvals > 0) { do_scalar_replacements(irg, sels, nvals, modes); - foreach_set(set_ent, scalars_t*, value) { + foreach_set(set_ent, scalars_t, value) { free_entity(value->ent); } @@ -763,10 +743,6 @@ int scalar_replacement_opt(ir_graph *irg) * neither changed control flow, cf-backedges should be still * consistent. */ - set_irg_outs_inconsistent(irg); - set_irg_loopinfo_inconsistent(irg); - - res = 1; } del_pset(sels); del_set(set_ent); @@ -774,15 +750,14 @@ int scalar_replacement_opt(ir_graph *irg) } ir_free_resources(irg, IR_RESOURCE_IRN_LINK); - irp_free_resources(irp, IR_RESOURCE_ENTITY_LINK); + irp_free_resources(irp, IRP_RESOURCE_ENTITY_LINK); - return res; + confirm_irg_properties(irg, IR_GRAPH_PROPERTIES_NONE); } ir_graph_pass_t *scalar_replacement_opt_pass(const char *name) { - return def_graph_pass_ret(name ? name : "scalar_rep", - scalar_replacement_opt); + return def_graph_pass(name ? name : "scalar_rep", scalar_replacement_opt); } void firm_init_scalar_replace(void)