X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=ir%2Fopt%2Fconvopt.c;h=fac7e328dbcd72de405a54cc21a0a9652386fbf5;hb=ea68f3f7a13e0b7742bfaa643e109302bc023e9c;hp=4787c3f129a6410b32dc88d03eacae274d5a9534;hpb=cbe8608ae6f9a523d007919691104b444c92d004;p=libfirm diff --git a/ir/opt/convopt.c b/ir/opt/convopt.c index 4787c3f12..fac7e328d 100644 --- a/ir/opt/convopt.c +++ b/ir/opt/convopt.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 1995-2008 University of Karlsruhe. All right reserved. + * Copyright (C) 1995-2011 University of Karlsruhe. All right reserved. * * This file is part of libFirm. * @@ -21,7 +21,6 @@ * @file * @brief conv node optimisation * @author Matthias Braun, Christoph Mallon - * @version $Id$ * * Try to minimize the number of conv nodes by changing modes of operations. * The typical example is the following structure: @@ -47,6 +46,7 @@ #include "irgmod.h" #include "irgopt.h" #include "irnode_t.h" +#include "iropt_t.h" #include "iredges_t.h" #include "irgwalk.h" #include "irprintf.h" @@ -54,11 +54,11 @@ #include "tv.h" #include "vrp.h" -DEBUG_ONLY(static firm_dbg_module_t *dbg); +DEBUG_ONLY(static firm_dbg_module_t *dbg;) static inline int imin(int a, int b) { return a < b ? a : b; } -static bool is_optimizable_node(const ir_node *node) +static bool is_optimizable_node(const ir_node *node, ir_mode *dest_mode) { switch (get_irn_opcode(node)) { case iro_Add: @@ -69,15 +69,23 @@ static bool is_optimizable_node(const ir_node *node) case iro_Not: case iro_Or: case iro_Phi: - case iro_Shl: case iro_Sub: return true; + case iro_Shl: { + int modulo_shift = get_mode_modulo_shift(dest_mode); + int old_shift = get_mode_modulo_shift(get_irn_mode(node)); + /* bail out if modulo shift changes */ + if (modulo_shift != old_shift) + return false; + return true; + } + default: return false; } } -static tarval* conv_const_tv(const ir_node* cnst, ir_mode* dest_mode) +static ir_tarval* conv_const_tv(const ir_node* cnst, ir_mode* dest_mode) { return tarval_convert_to(get_Const_tarval(cnst), dest_mode); } @@ -93,15 +101,14 @@ static int is_downconv(ir_mode *src_mode, ir_mode *dest_mode) static int get_conv_costs(const ir_node *node, ir_mode *dest_mode) { ir_mode *mode = get_irn_mode(node); - size_t arity; - size_t i; + int arity; + int i; int costs; if (mode == dest_mode) return 0; if (is_Const(node)) { - /* TODO tarval module is incomplete and can't convert floats to ints */ return conv_const_tv(node, dest_mode) == tarval_bad ? 1 : 0; } @@ -116,12 +123,16 @@ static int get_conv_costs(const ir_node *node, ir_mode *dest_mode) return 1; } + if (ir_zero_when_converted(node, dest_mode)) { + return -1; + } + #if 0 // TODO /* Take the minimum of the conversion costs for Phi predecessors as only one * branch is actually executed at a time */ if (is_Phi(node)) { - size_t i; - size_t arity = get_Phi_n_preds(node); + int i; + int arity = get_Phi_n_preds(node); int costs; costs = get_conv_costs(get_Phi_pred(node, 0), dest_mode); @@ -143,13 +154,17 @@ static int get_conv_costs(const ir_node *node, ir_mode *dest_mode) ir_node *pred = get_Conv_op(node); ir_mode *pred_mode = get_irn_mode(pred); - if (!values_in_mode(dest_mode, pred_mode)) { + if (smaller_mode(pred_mode, dest_mode)) { + return get_conv_costs(get_Conv_op(node), dest_mode) - 1; + } + if (may_leave_out_middle_conv(pred_mode, mode, dest_mode)) { + return 0; + } else { return 1; } - return get_conv_costs(get_Conv_op(node), dest_mode) - 1; } - if (!is_optimizable_node(node)) { + if (!is_optimizable_node(node, dest_mode)) { return 1; } @@ -173,20 +188,23 @@ static ir_node *place_conv(ir_node *node, ir_mode *dest_mode) static ir_node *conv_transform(ir_node *node, ir_mode *dest_mode) { - ir_mode *mode = get_irn_mode(node); - size_t arity; - size_t i; + ir_mode *mode = get_irn_mode(node); + ir_graph *irg = get_irn_irg(node); + int arity; + int conv_arity; + int i; + ir_node *new_node; + ir_node **ins; if (mode == dest_mode) return node; if (is_Const(node)) { - /* TODO tarval module is incomplete and can't convert floats to ints */ - tarval *tv = conv_const_tv(node, dest_mode); + ir_tarval *tv = conv_const_tv(node, dest_mode); if (tv == tarval_bad) { return place_conv(node, dest_mode); } else { - return new_Const(tv); + return new_r_Const(irg, tv); } } @@ -208,19 +226,23 @@ static ir_node *conv_transform(ir_node *node, ir_mode *dest_mode) ir_node *pred = get_Conv_op(node); ir_mode *pred_mode = get_irn_mode(pred); - if (!values_in_mode(dest_mode, pred_mode)) { - return place_conv(node, dest_mode); + if (smaller_mode(pred_mode, dest_mode)) { + return conv_transform(get_Conv_op(node), dest_mode); } - return conv_transform(get_Conv_op(node), dest_mode); + return place_conv(node, dest_mode); } - if (!is_optimizable_node(node)) { + if (!is_optimizable_node(node, dest_mode)) { return place_conv(node, dest_mode); } + // We want to create a new node with the right mode + arity = get_irn_arity(node); + ins = ALLOCAN(ir_node *, arity); + // The shift count does not participate in the conv optimisation - arity = is_Shl(node) ? 1 : get_irn_arity(node); - for (i = 0; i < arity; i++) { + conv_arity = is_Shl(node) ? 1 : arity; + for (i = 0; i < conv_arity; i++) { ir_node *pred = get_irn_n(node, i); ir_node *transformed; if (get_conv_costs(pred, dest_mode) > 0) { @@ -228,24 +250,24 @@ static ir_node *conv_transform(ir_node *node, ir_mode *dest_mode) } else { transformed = conv_transform(pred, dest_mode); } - set_irn_n(node, i, transformed); + ins[i] = transformed; } - set_irn_mode(node, dest_mode); - return node; -} -/* TODO, backends (at least ia32) can't handle it at the moment, - and it's probably not more efficient on most archs */ -#if 0 -static void try_optimize_cmp(ir_node *node) -{ - ir_node *left = get_Cmp_left(node); - ir_node *right = get_Cmp_right(node); - ir_node *conv = NULL; + for (i = conv_arity; i < arity; i++) { + ins[i] = get_irn_n(node, i); + } + + new_node = new_ir_node(get_irn_dbg_info(node), + irg, + get_nodes_block(node), + get_irn_op(node), + dest_mode, + arity, + ins); + copy_node_attr(irg, node, new_node); - if (is_downconv + return new_node; } -#endif static void conv_opt_walker(ir_node *node, void *data) { @@ -254,14 +276,7 @@ static void conv_opt_walker(ir_node *node, void *data) ir_mode *pred_mode; ir_mode *mode; int costs; - bool *changed = data; - -#if 0 - if (is_Cmp(node)) { - try_optimize_cmp(node); - return; - } -#endif + bool *changed = (bool*)data; if (!is_Conv(node)) return; @@ -285,43 +300,35 @@ static void conv_opt_walker(ir_node *node, void *data) transformed = conv_transform(pred, mode); if (node != transformed) { exchange(node, transformed); - vrp_attr *vrp = vrp_get_info(transformed); - if (vrp && vrp->valid) { - vrp->range_type = VRP_VARYING; - vrp->bits_set = tarval_convert_to(vrp->bits_set, mode); - vrp->bits_not_set = tarval_convert_to(vrp->bits_not_set, mode); - } - *changed = true; } } -int conv_opt(ir_graph *irg) +void conv_opt(ir_graph *irg) { + bool global_changed = false; bool changed; - bool invalidate = false; FIRM_DBG_REGISTER(dbg, "firm.opt.conv"); + assure_irg_properties(irg, IR_GRAPH_PROPERTY_CONSISTENT_OUT_EDGES); + DB((dbg, LEVEL_1, "===> Performing conversion optimization on %+F\n", irg)); - edges_assure(irg); do { changed = false; irg_walk_graph(irg, NULL, conv_opt_walker, &changed); local_optimize_graph(irg); - invalidate |= changed; + global_changed |= changed; } while (changed); - if (invalidate) { - set_irg_outs_inconsistent(irg); - } - return invalidate; + confirm_irg_properties(irg, + global_changed ? IR_GRAPH_PROPERTIES_NONE : IR_GRAPH_PROPERTIES_ALL); } /* Creates an ir_graph pass for conv_opt. */ ir_graph_pass_t *conv_opt_pass(const char *name) { - ir_graph_pass_t *path = def_graph_pass_ret(name ? name : "conv_opt", conv_opt); + ir_graph_pass_t *path = def_graph_pass(name ? name : "conv_opt", conv_opt); /* safe to run parallel on all irgs */ ir_graph_pass_set_parallel(path, 1);