X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=ir%2Fopt%2Fconvopt.c;h=eb59084f9fb2360766c41e6324582bafd9181846;hb=a5d5f207f602198e3a9d809f431ea1855dc86fb7;hp=5d2785c6debdcb9838ece1a069983254e19618ff;hpb=2640a0fbb47b901fb6da69821564635adcca0ddc;p=libfirm diff --git a/ir/opt/convopt.c b/ir/opt/convopt.c index 5d2785c6d..eb59084f9 100644 --- a/ir/opt/convopt.c +++ b/ir/opt/convopt.c @@ -50,7 +50,9 @@ #include "iredges_t.h" #include "irgwalk.h" #include "irprintf.h" -#include "irpass.h" +#include "irpass_t.h" +#include "tv.h" +#include "vrp.h" DEBUG_ONLY(static firm_dbg_module_t *dbg); @@ -59,19 +61,19 @@ static inline int imin(int a, int b) { return a < b ? a : b; } static bool is_optimizable_node(const ir_node *node) { switch (get_irn_opcode(node)) { - case iro_Add: - case iro_And: - case iro_Eor: - case iro_Minus: - case iro_Mul: - case iro_Not: - case iro_Or: - case iro_Phi: - case iro_Shl: - case iro_Sub: - return 1; - - default: return 0; + case iro_Add: + case iro_And: + case iro_Eor: + case iro_Minus: + case iro_Mul: + case iro_Not: + case iro_Or: + case iro_Phi: + case iro_Shl: + case iro_Sub: + return true; + default: + return false; } } @@ -138,6 +140,12 @@ static int get_conv_costs(const ir_node *node, ir_mode *dest_mode) } if (is_Conv(node)) { + ir_node *pred = get_Conv_op(node); + ir_mode *pred_mode = get_irn_mode(pred); + + if (!values_in_mode(dest_mode, pred_mode)) { + return 1; + } return get_conv_costs(get_Conv_op(node), dest_mode) - 1; } @@ -197,6 +205,12 @@ static ir_node *conv_transform(ir_node *node, ir_mode *dest_mode) } if (is_Conv(node)) { + ir_node *pred = get_Conv_op(node); + ir_mode *pred_mode = get_irn_mode(pred); + + if (!values_in_mode(dest_mode, pred_mode)) { + return place_conv(node, dest_mode); + } return conv_transform(get_Conv_op(node), dest_mode); } @@ -229,12 +243,10 @@ static void try_optimize_cmp(ir_node *node) ir_node *right = get_Cmp_right(node); ir_node *conv = NULL; - if(is_downconv + if (is_downconv } #endif -static bool changed; - static void conv_opt_walker(ir_node *node, void *data) { ir_node *transformed; @@ -242,10 +254,10 @@ static void conv_opt_walker(ir_node *node, void *data) ir_mode *pred_mode; ir_mode *mode; int costs; - (void) data; + bool *changed = data; #if 0 - if(is_Cmp(node)) { + if (is_Cmp(node)) { try_optimize_cmp(node); return; } @@ -272,14 +284,24 @@ static void conv_opt_walker(ir_node *node, void *data) transformed = conv_transform(pred, mode); if (node != transformed) { + vrp_attr *vrp; + exchange(node, transformed); - changed = true; + vrp = vrp_get_info(transformed); + if (vrp && vrp->valid) { + vrp->range_type = VRP_VARYING; + vrp->bits_set = tarval_convert_to(vrp->bits_set, mode); + vrp->bits_not_set = tarval_convert_to(vrp->bits_not_set, mode); + } + + *changed = true; } } int conv_opt(ir_graph *irg) { - bool invalidate = 0; + bool changed; + bool invalidate = false; FIRM_DBG_REGISTER(dbg, "firm.opt.conv"); DB((dbg, LEVEL_1, "===> Performing conversion optimization on %+F\n", irg)); @@ -287,7 +309,7 @@ int conv_opt(ir_graph *irg) edges_assure(irg); do { changed = false; - irg_walk_graph(irg, NULL, conv_opt_walker, NULL); + irg_walk_graph(irg, NULL, conv_opt_walker, &changed); local_optimize_graph(irg); invalidate |= changed; } while (changed); @@ -301,5 +323,10 @@ int conv_opt(ir_graph *irg) /* Creates an ir_graph pass for conv_opt. */ ir_graph_pass_t *conv_opt_pass(const char *name) { - return def_graph_pass_ret(name ? name : "conv_opt", conv_opt); + ir_graph_pass_t *path = def_graph_pass_ret(name ? name : "conv_opt", conv_opt); + + /* safe to run parallel on all irgs */ + ir_graph_pass_set_parallel(path, 1); + + return path; }