X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=ir%2Fir%2Firgopt.c;h=7f7d6d7dfd3b36218393afcc6a2b8efc782cb791;hb=6b124543aff56817fcfe6d5b5ff181ac5c790e73;hp=5469cde65f03e2077873339e6bd940fe4e70d778;hpb=0fbcef83aa6060534172bb13e71cdadb04428806;p=libfirm

diff --git a/ir/ir/irgopt.c b/ir/ir/irgopt.c
index 5469cde65..7f7d6d7df 100644
--- a/ir/ir/irgopt.c
+++ b/ir/ir/irgopt.c
@@ -39,6 +39,7 @@
 
 #include "adt/pdeq.h"
 
+#include "irpass_t.h"
 #include "irflag_t.h"
 #include "iredges_t.h"
 #include "irtools.h"
@@ -50,7 +51,7 @@
 /**
  * A wrapper around optimize_inplace_2() to be called from a walker.
  */
-static void optimize_in_place_wrapper (ir_node *n, void *env) {
+static void optimize_in_place_wrapper(ir_node *n, void *env) {
 	ir_node *optimized = optimize_in_place_2(n);
 	(void) env;
 
@@ -67,7 +68,7 @@ static void optimize_in_place_wrapper (ir_node *n, void *env) {
  *
  * @note current_ir_graph must be set
  */
-static INLINE void do_local_optimize(ir_node *n) {
+static inline void do_local_optimize(ir_node *n) {
 	/* Handle graph state */
 	assert(get_irg_phase_state(current_ir_graph) != phase_building);
 
@@ -168,7 +169,7 @@ int optimize_graph_df(ir_graph *irg) {
 	pdeq     *waitq = new_pdeq();
 	ir_graph *rem = current_ir_graph;
 	ir_node  *end;
-	int      i, state, n_ka, changed;
+	int      state, changed;
 
 	current_ir_graph = irg;
 
@@ -191,32 +192,8 @@ int optimize_graph_df(ir_graph *irg) {
 
 	ir_reserve_resources(irg, IR_RESOURCE_IRN_LINK);
 
-	end  = get_irg_end(irg);
-	n_ka = get_End_n_keepalives(end);
-
 	/* walk over the graph, but don't touch keep-alives */
-	irg_walk(get_irg_end_block(irg), NULL, opt_walker, waitq);
-
-	/*
-	 * Optimize keep-alives by removing superfluous ones.
-	 * Beware: the last transformation might add new keep-alives
-	 * that keep blocks that are where visited! So, check only the
-	 * "old" keep-alives, not the new ones!
-	 *
-	 * FIXME: it might be better to completely remove this
-	 * optimization here ...
-	 */
-	for (i = n_ka - 1; i >= 0; --i) {
-		ir_node *ka = get_End_keepalive(end, i);
-
-		if (irn_visited(ka) && !is_irn_keep(ka)) {
-			/* this node can be regularly visited, no need to keep it */
-			set_End_keepalive(end, i, get_irg_bad(irg));
-		}
-	}
-	/* now walk again and visit all not yet visited nodes */
-	set_irg_visited(current_ir_graph, get_irg_visited(irg) - 1);
-	irg_walk(get_irg_end(irg), NULL, opt_walker, waitq);
+	irg_walk_graph(irg, NULL, opt_walker, waitq);
 
 	/* any optimized nodes are stored in the wait queue,
 	 * so if it's not empty, the graph has been changed */
@@ -236,6 +213,17 @@ int optimize_graph_df(ir_graph *irg) {
 	if (! state)
 		edges_deactivate(irg);
 
+	/* Finally kill BAD and doublets from the keep alives.
+	   Doing this AFTER edges where deactivated saves cycles */
+	end  = get_irg_end(irg);
+	remove_End_Bads_and_doublets(end);
+
 	current_ir_graph = rem;
 	return changed;
 }
+
+/* Creates an ir_graph pass for optimize_graph_df. */
+ir_graph_pass_t *optimize_graph_df_pass(const char *name)
+{
+	return def_graph_pass_ret(name ? name : "optimize_graph_df", optimize_graph_df);
+}  /* optimize_graph_df_pass */