X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=ir%2Fbe%2Fbespilldaemel.c;h=ef36c8f298b5eff9acd85f372fe7e433c6da054f;hb=b7dd849f8dd4bf73629adffec3fbe19bed0e458b;hp=e549aadd66ce9ff87c8f5f006cc2ccd2a6d6f9fe;hpb=cbcf8b93de62865b8564e6a47aca7a28790b65ad;p=libfirm diff --git a/ir/be/bespilldaemel.c b/ir/be/bespilldaemel.c index e549aadd6..ef36c8f29 100644 --- a/ir/be/bespilldaemel.c +++ b/ir/be/bespilldaemel.c @@ -1,5 +1,5 @@ /* - * Copyright (C) 1995-2008 University of Karlsruhe. All right reserved. + * Copyright (C) 1995-2011 University of Karlsruhe. All right reserved. * * This file is part of libFirm. * @@ -19,23 +19,21 @@ /** * @file - * @brief Naiv spilling algorithm + * @brief Naive spilling algorithm * @author Matthias Braun * @date 20.09.2005 * @version $Id: bespillbelady.c 13913 2007-05-18 12:48:56Z matze $ - * @summary - * This implements a naiv spilling algorithm. It is design to produce similar - * effects to the spill decisions produced by traditional graph coloring - * register allocators that spill while they are coloring the graph. + * @brief + * This implements a naive spilling algorithm. It is designed to produce + * similar effects to the spill decisions produced by traditional graph + * coloring register allocators that spill while they are coloring the graph. * * This spiller walks over all blocks and looks for places with too high * register pressure where it spills the values that are cheapest to spill. * Spilling in this context means placing a spill instruction behind the * definition of the value and a reload before each usage. */ -#ifdef HAVE_CONFIG_H #include "config.h" -#endif #include "debug.h" @@ -46,20 +44,20 @@ #include "error.h" #include "beirg.h" -#include "bespilloptions.h" #include "bespill.h" +#include "bespillutil.h" #include "bemodule.h" #include "besched.h" -#include "bearch_t.h" +#include "bearch.h" #include "be_t.h" -#include "benode_t.h" +#include "benode.h" #include "beirg.h" +#include "belive.h" DEBUG_ONLY(static firm_dbg_module_t *dbg = NULL;) static spill_env_t *spill_env; -static int n_regs; -static const arch_env_t *arch_env; +static unsigned n_regs; static const arch_register_class_t *cls; static const be_lv_t *lv; static bitset_t *spilled_nodes; @@ -72,8 +70,8 @@ struct spill_candidate_t { static int compare_spill_candidates_desc(const void *d1, const void *d2) { - const spill_candidate_t *c1 = d1; - const spill_candidate_t *c2 = d2; + const spill_candidate_t *c1 = (const spill_candidate_t*)d1; + const spill_candidate_t *c2 = (const spill_candidate_t*)d2; return (int) (c1->costs - c2->costs); } @@ -89,11 +87,11 @@ static double get_spill_costs(ir_node *node) ir_node *use = get_edge_src_irn(edge); /* keeps should be directly below the node */ - if(be_is_Keep(use)) { + if (be_is_Keep(use)) { continue; } - if(is_Phi(use)) { + if (is_Phi(use)) { int in = get_edge_src_pos(edge); ir_node *block = get_nodes_block(use); @@ -103,8 +101,6 @@ static double get_spill_costs(ir_node *node) } } - /* TODO cache costs? */ - return costs; } @@ -119,12 +115,12 @@ static void spill_node(ir_node *node) foreach_out_edge(node, edge) { ir_node *use = get_edge_src_irn(edge); - if(is_Anchor(use)) + if (is_Anchor(use)) continue; - if(be_is_Keep(use)) + if (be_is_Keep(use)) continue; - if(is_Phi(use)) { + if (is_Phi(use)) { int in = get_edge_src_pos(edge); ir_node *block = get_nodes_block(use); @@ -137,6 +133,12 @@ static void spill_node(ir_node *node) bitset_set(spilled_nodes, get_irn_idx(node)); } +static unsigned get_value_width(const ir_node *node) +{ + const arch_register_req_t *req = arch_get_register_req_out(node); + return req->width; +} + /** * spill @p n nodes from a nodeset. Removes the nodes from the nodeset and * sets the spilled bits in spilled_nodes. @@ -148,60 +150,52 @@ static void do_spilling(ir_nodeset_t *live_nodes, ir_node *node) size_t free_regs_needed = 0; spill_candidate_t *candidates; ir_nodeset_iterator_t iter; - size_t i, arity; + int i, arity; + size_t c; int spills_needed; size_t cand_idx; ir_node *n; + ir_node *value; - /* mode_T nodes define several values at once. Count them */ - if(get_irn_mode(node) == mode_T) { - const ir_edge_t *edge; - - foreach_out_edge(node, edge) { - const ir_node *proj = get_edge_src_irn(edge); - - if(arch_irn_consider_in_reg_alloc(arch_env, cls, proj)) { - ++values_defined; - } - } - } else if(arch_irn_consider_in_reg_alloc(arch_env, cls, node)) { - ++values_defined; - } + be_foreach_definition(node, cls, value, + assert(req_->width >= 1); + values_defined += req_->width; + ); /* we need registers for the non-live argument values */ arity = get_irn_arity(node); - for(i = 0; i < arity; ++i) { + for (i = 0; i < arity; ++i) { ir_node *pred = get_irn_n(node, i); - if(arch_irn_consider_in_reg_alloc(arch_env, cls, pred) + if (arch_irn_consider_in_reg_alloc(cls, pred) && !ir_nodeset_contains(live_nodes, pred)) { - ++free_regs_needed; + free_regs_needed += get_value_width(pred); } } /* we can reuse all reloaded values for the defined values, but we might - need even more registers */ - if(values_defined > free_regs_needed) + * need even more registers */ + if (values_defined > free_regs_needed) free_regs_needed = values_defined; spills_needed = (n_live_nodes + free_regs_needed) - n_regs; - if(spills_needed <= 0) + if (spills_needed <= 0) return; DBG((dbg, LEVEL_2, "\tspills needed after %+F: %d\n", node, spills_needed)); - candidates = alloca(n_live_nodes * sizeof(candidates[0])); + candidates = ALLOCAN(spill_candidate_t, n_live_nodes); /* construct array with spill candidates and calculate their costs */ - i = 0; + c = 0; foreach_ir_nodeset(live_nodes, n, iter) { - spill_candidate_t *candidate = & candidates[i]; + spill_candidate_t *candidate = & candidates[c]; assert(!bitset_is_set(spilled_nodes, get_irn_idx(n))); candidate->node = n; candidate->costs = get_spill_costs(n); - ++i; + ++c; } - assert(i == n_live_nodes); + assert(c == n_live_nodes); /* sort spill candidates */ qsort(candidates, n_live_nodes, sizeof(candidates[0]), @@ -209,39 +203,36 @@ static void do_spilling(ir_nodeset_t *live_nodes, ir_node *node) /* spill cheapest ones */ cand_idx = 0; - while(spills_needed > 0) { - spill_candidate_t *candidate; - ir_node *cand_node; - int is_use; + while (spills_needed > 0) { + bool is_use = false; + spill_candidate_t *candidate; + ir_node *cand_node; if (cand_idx >= n_live_nodes) { panic("can't spill enough values for node %+F", node); } - candidate = &candidates[cand_idx]; cand_node = candidate->node; ++cand_idx; - if(arch_irn_is(arch_env, cand_node, dont_spill)) + if (arch_irn_is(skip_Proj_const(cand_node), dont_spill)) continue; /* make sure the node is not an argument of the instruction */ - is_use = 0; for (i = 0; i < arity; ++i) { ir_node *in = get_irn_n(node, i); - if(in == cand_node) { - is_use = 1; + if (in == cand_node) { + is_use = true; break; } } - if(is_use) { + if (is_use) continue; - } spill_node(cand_node); ir_nodeset_remove(live_nodes, cand_node); - --spills_needed; + spills_needed -= get_value_width(cand_node); } } @@ -250,40 +241,28 @@ static void do_spilling(ir_nodeset_t *live_nodes, ir_node *node) */ static void remove_defs(ir_node *node, ir_nodeset_t *nodeset) { - /* You should better break out of your loop when hitting the first phi - * function. */ - assert(!is_Phi(node) && "liveness_transfer produces invalid results for phi nodes"); - - if (get_irn_mode(node) == mode_T) { - const ir_edge_t *edge; - - foreach_out_edge(node, edge) { - const ir_node *proj = get_edge_src_irn(edge); - - if (arch_irn_consider_in_reg_alloc(arch_env, cls, proj)) { - ir_nodeset_remove(nodeset, proj); - } - } - } + ir_node *value; + /* You must break out of your loop when hitting the first phi function. */ + assert(!is_Phi(node)); - if(arch_irn_consider_in_reg_alloc(arch_env, cls, node)) { - ir_nodeset_remove(nodeset, node); - } + be_foreach_definition(node, cls, value, + ir_nodeset_remove(nodeset, value); + ); } static void add_uses(ir_node *node, ir_nodeset_t *nodeset) { int i, arity; - arity = get_irn_arity(node); - for(i = 0; i < arity; ++i) { - ir_node *op = get_irn_n(node, i); + arity = get_irn_arity(node); + for (i = 0; i < arity; ++i) { + ir_node *op = get_irn_n(node, i); - if(arch_irn_consider_in_reg_alloc(arch_env, cls, op) - && !bitset_is_set(spilled_nodes, get_irn_idx(op))) { - ir_nodeset_insert(nodeset, op); + if (arch_irn_consider_in_reg_alloc(cls, op) && + !bitset_is_set(spilled_nodes, get_irn_idx(op))) { + ir_nodeset_insert(nodeset, op); } - } + } } static __attribute__((unused)) @@ -309,6 +288,7 @@ static void spill_block(ir_node *block, void *data) ir_node *node; int n_phi_values_spilled; int regpressure; + int live_nodes_pressure; int phi_spills_needed; (void) data; @@ -316,12 +296,12 @@ static void spill_block(ir_node *block, void *data) /* construct set of live nodes at end of block */ ir_nodeset_init(&live_nodes); - be_liveness_end_of_block(lv, arch_env, cls, block, &live_nodes); + be_liveness_end_of_block(lv, cls, block, &live_nodes); /* remove already spilled nodes from liveset */ foreach_ir_nodeset(&live_nodes, node, iter) { DBG((dbg, LEVEL_2, "\t%+F is live-end... ", node)); - if(bitset_is_set(spilled_nodes, get_irn_idx(node))) { + if (bitset_is_set(spilled_nodes, get_irn_idx(node))) { DBG((dbg, LEVEL_2, "but spilled; removing.\n")); ir_nodeset_remove_iterator(&live_nodes, &iter); } else { @@ -332,7 +312,7 @@ static void spill_block(ir_node *block, void *data) /* walk schedule backwards and spill until register pressure is fine at * each node */ sched_foreach_reverse(block, node) { - if(is_Phi(node)) + if (is_Phi(node)) break; remove_defs(node, &live_nodes); @@ -342,20 +322,24 @@ static void spill_block(ir_node *block, void *data) /* until now only the values of some phis have been spilled the phis itself * are still there and occupy registers, so we need to count them and might - * have to spill some of them. - */ + * have to spill some of them. */ n_phi_values_spilled = 0; sched_foreach(block, node) { - if(!is_Phi(node)) + if (!is_Phi(node)) break; - if(bitset_is_set(spilled_nodes, get_irn_idx(node))) { - ++n_phi_values_spilled; + if (bitset_is_set(spilled_nodes, get_irn_idx(node))) { + n_phi_values_spilled += get_value_width(node); } } + live_nodes_pressure = 0; + foreach_ir_nodeset(&live_nodes, node, iter) { + live_nodes_pressure += get_value_width(node); + } + /* calculate how many of the phis need to be spilled */ - regpressure = ir_nodeset_size(&live_nodes) + n_phi_values_spilled; + regpressure = live_nodes_pressure + n_phi_values_spilled; phi_spills_needed = regpressure - n_regs; DBG((dbg, LEVEL_3, "Regpressure before phis: %d phispills: %d\n", regpressure, phi_spills_needed)); @@ -364,35 +348,33 @@ static void spill_block(ir_node *block, void *data) /* TODO: we should really estimate costs of the phi spill as well... * and preferably spill phis with lower costs... */ sched_foreach(block, node) { - if(!is_Phi(node)) + if (!is_Phi(node)) break; - if(phi_spills_needed <= 0) + if (phi_spills_needed <= 0) break; - if(bitset_is_set(spilled_nodes, get_irn_idx(node))) { - be_spill_phi(spill_env, node); - --phi_spills_needed; - } + if (!bitset_is_set(spilled_nodes, get_irn_idx(node))) + continue; + + be_spill_phi(spill_env, node); + phi_spills_needed -= get_value_width(node); } assert(phi_spills_needed <= 0); ir_nodeset_destroy(&live_nodes); } -void be_spill_daemel(be_irg_t *birg, const arch_register_class_t *new_cls) +static void be_spill_daemel(ir_graph *irg, const arch_register_class_t *new_cls) { - ir_graph *irg = be_get_birg_irg(birg); - n_regs = new_cls->n_regs - be_put_ignore_regs(birg, new_cls, NULL); - - if(n_regs == 0) + n_regs = be_get_n_allocatable_regs(irg, new_cls); + if (n_regs == 0) return; - be_liveness_assure_sets(be_assure_liveness(birg)); + be_liveness_assure_sets(be_assure_liveness(irg)); - spill_env = be_new_spill_env(birg); - arch_env = be_get_birg_arch_env(birg); + spill_env = be_new_spill_env(irg); cls = new_cls; - lv = be_get_birg_liveness(birg); + lv = be_get_irg_liveness(irg); spilled_nodes = bitset_malloc(get_irg_last_idx(irg)); DBG((dbg, LEVEL_1, "*** RegClass %s\n", cls->name)); @@ -400,14 +382,12 @@ void be_spill_daemel(be_irg_t *birg, const arch_register_class_t *new_cls) irg_block_walk_graph(irg, spill_block, NULL, NULL); bitset_free(spilled_nodes); - spilled_nodes = NULL; be_insert_spills_reloads(spill_env); - be_delete_spill_env(spill_env); - spill_env = NULL; } +BE_REGISTER_MODULE_CONSTRUCTOR(be_init_daemelspill) void be_init_daemelspill(void) { static be_spiller_t daemel_spiller = { @@ -417,5 +397,3 @@ void be_init_daemelspill(void) be_register_spiller("daemel", &daemel_spiller); FIRM_DBG_REGISTER(dbg, "firm.be.spilldaemel"); } - -BE_REGISTER_MODULE_CONSTRUCTOR(be_init_daemelspill);