X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=ir%2Fbe%2Fbeabi.c;h=2bf684a81ddc55dd73ccdf71a1dbee2128763ad8;hb=df2faee01a5832057bb3ca0ba5f67e979c916e19;hp=1da1d04a8a6fe10c4a8acef9c64adca74e9fcb23;hpb=8fc8db570d845dc81cf4cfbd03f4350a87537583;p=libfirm diff --git a/ir/be/beabi.c b/ir/be/beabi.c index 1da1d04a8..2bf684a81 100644 --- a/ir/be/beabi.c +++ b/ir/be/beabi.c @@ -21,7 +21,6 @@ * @file * @brief Backend ABI implementation. * @author Sebastian Hack, Michael Beck - * @version $Id$ */ #include "config.h" @@ -35,19 +34,20 @@ #include "iredges_t.h" #include "irgmod.h" #include "irgwalk.h" -#include "irprintf_t.h" +#include "irprintf.h" #include "irgopt.h" -#include "irbitset.h" #include "iropt_t.h" +#include "irtools.h" #include "heights.h" #include "pdeq.h" -#include "irtools.h" +#include "util.h" #include "raw_bitset.h" #include "error.h" #include "pset_new.h" #include "be.h" #include "beabi.h" +#include "beabihelper.h" #include "bearch.h" #include "benode.h" #include "belive_t.h" @@ -61,8 +61,7 @@ DEBUG_ONLY(static firm_dbg_module_t *dbg;) typedef struct be_abi_call_arg_t { unsigned is_res : 1; /**< 1: the call argument is a return value. 0: it's a call parameter. */ - unsigned in_reg : 1; /**< 1: this argument is transmitted in registers. */ - unsigned on_stack : 1; /**< 1: this argument is transmitted on the stack. */ + unsigned in_reg : 1; /**< 1: this argument is transmitted 1: in registers, 0: on stack. */ unsigned callee : 1; /**< 1: someone called us. 0: We call another function */ int pos; @@ -75,12 +74,10 @@ typedef struct be_abi_call_arg_t { } be_abi_call_arg_t; struct be_abi_call_t { - be_abi_call_flags_t flags; /**< Flags describing the ABI behavior on calls */ - int pop; /**< number of bytes the stack frame is shrinked by the callee on return. */ - const be_abi_callbacks_t *cb; - ir_type *between_type; - set *params; - const arch_register_class_t *cls_addr; /**< register class of the call address */ + be_abi_call_flags_t flags; /**< Flags describing the ABI behavior on calls */ + int pop; /**< number of bytes the stack frame is shrinked by the callee on return. */ + const be_abi_callbacks_t *cb; + set *params; }; /** @@ -92,11 +89,8 @@ struct be_abi_irg_t { ir_node *init_sp; /**< The node representing the stack pointer at the start of the function. */ - ir_node *start; /**< The be_Start params node. */ pmap *regs; /**< A map of all callee-save and ignore regs to their Projs to the RegParams node. */ - int start_block_bias; /**< The stack bias at the end of the start block. */ - pmap *keep_map; /**< mapping blocks to keep nodes. */ ir_node **calls; /**< flexible array containing all be_Call nodes */ @@ -104,12 +98,9 @@ struct be_abi_irg_t { static ir_heights_t *ir_heights; -/** Flag: if set, try to omit the frame pointer in all routines. */ -static int be_omit_fp = 1; - static ir_node *be_abi_reg_map_get(pmap *map, const arch_register_t *reg) { - return (ir_node*)pmap_get(map, reg); + return pmap_get(ir_node, map, reg); } static void be_abi_reg_map_set(pmap *map, const arch_register_t* reg, @@ -186,7 +177,7 @@ static be_abi_call_arg_t *get_call_arg(be_abi_call_t *call, int is_res, int pos, hash = is_res * 128 + pos; - return (be_abi_call_arg_t*)set_find(call->params, &arg, sizeof(arg), hash); + return set_find(be_abi_call_arg_t, call->params, &arg, sizeof(arg), hash); } /** @@ -197,11 +188,11 @@ static void remember_call_arg(be_abi_call_arg_t *arg, be_abi_call_t *call, be_ab unsigned hash = arg->is_res * 128 + arg->pos; if (context & ABI_CONTEXT_CALLEE) { arg->callee = 1; - set_insert(call->params, arg, sizeof(*arg), hash); + (void)set_insert(be_abi_call_arg_t, call->params, arg, sizeof(*arg), hash); } if (context & ABI_CONTEXT_CALLER) { arg->callee = 0; - set_insert(call->params, arg, sizeof(*arg), hash); + (void)set_insert(be_abi_call_arg_t, call->params, arg, sizeof(*arg), hash); } } @@ -219,13 +210,6 @@ void be_abi_call_set_pop(be_abi_call_t *call, int pop) call->pop = pop; } -/* Set register class for call address */ -void be_abi_call_set_call_address_reg_class(be_abi_call_t *call, const arch_register_class_t *cls) -{ - call->cls_addr = cls; -} - - void be_abi_call_param_stack(be_abi_call_t *call, int arg_pos, ir_mode *load_mode, unsigned alignment, unsigned space_before, unsigned space_after, @@ -234,7 +218,6 @@ void be_abi_call_param_stack(be_abi_call_t *call, int arg_pos, be_abi_call_arg_t arg; memset(&arg, 0, sizeof(arg)); assert(alignment > 0 && "Alignment must be greater than 0"); - arg.on_stack = 1; arg.load_mode = load_mode; arg.alignment = alignment; arg.space_before = space_before; @@ -280,20 +263,15 @@ be_abi_call_flags_t be_abi_call_get_flags(const be_abi_call_t *call) /** * Constructor for a new ABI call object. * - * @param cls_addr register class of the call address - * * @return the new ABI call object */ -static be_abi_call_t *be_abi_call_new(const arch_register_class_t *cls_addr) +static be_abi_call_t *be_abi_call_new(void) { be_abi_call_t *call = XMALLOCZ(be_abi_call_t); - call->flags.val = 0; - call->params = new_set(cmp_call_arg, 16); - call->cb = NULL; - call->cls_addr = cls_addr; - - call->flags.bits.try_omit_fp = be_omit_fp; + call->params = new_set(cmp_call_arg, 16); + call->cb = NULL; + call->flags.try_omit_fp = be_options.omit_fp; return call; } @@ -314,13 +292,11 @@ static void be_abi_call_free(be_abi_call_t *call) * @param args the stack argument layout type * @param between the between layout type * @param locals the method frame type - * @param param_map an array mapping method argument positions to the stack argument type * * @return the initialized stack layout */ static be_stack_layout_t *stack_frame_init(be_stack_layout_t *frame, ir_type *args, - ir_type *between, ir_type *locals, - ir_entity *param_map[]) + ir_type *between, ir_type *locals) { frame->arg_type = args; frame->between_type = between; @@ -328,7 +304,6 @@ static be_stack_layout_t *stack_frame_init(be_stack_layout_t *frame, ir_type *ar frame->initial_offset = 0; frame->initial_bias = 0; frame->order[1] = between; - frame->param_map = param_map; /* typical decreasing stack: locals have the * lowest addresses, arguments the highest */ @@ -367,11 +342,9 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) ir_node *bl = get_nodes_block(irn); int stack_size = 0; const arch_register_t *sp = arch_env->sp; - be_abi_call_t *call = be_abi_call_new(sp->reg_class); + be_abi_call_t *call = be_abi_call_new(); ir_mode *mach_mode = sp->reg_class->mode; - int no_alloc = call->flags.bits.frame_is_setup_on_call; int n_res = get_method_n_ress(call_tp); - int do_seq = call->flags.bits.store_args_sequential && !no_alloc; ir_node *res_proj = NULL; int n_reg_params = 0; @@ -384,10 +357,9 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) ir_node **in; ir_node **res_projs; int n_reg_results = 0; - const ir_edge_t *edge; int *reg_param_idxs; int *stack_param_idx; - int i, n, destroy_all_regs; + int i, n; int throws_exception; size_t s; size_t p; @@ -397,12 +369,12 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) arch_env_get_call_abi(arch_env, call_tp, call); /* Insert code to put the stack arguments on the stack. */ - assert(get_Call_n_params(irn) == n_params); + assert((size_t)get_Call_n_params(irn) == n_params); stack_param_idx = ALLOCAN(int, n_params); for (p = 0; p < n_params; ++p) { be_abi_call_arg_t *arg = get_call_arg(call, 0, p, 0); assert(arg); - if (arg->on_stack) { + if (!arg->in_reg) { int arg_size = get_type_size_bytes(get_method_param_type(call_tp, p)); stack_size += round_up2(arg->space_before, arg->alignment); @@ -431,9 +403,7 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) * Note: we also have to do this for stack_size == 0, because we may have * to adjust stack alignment for the call. */ - if (!do_seq && !no_alloc) { - curr_sp = be_new_IncSP(sp, bl, curr_sp, stack_size, 1); - } + curr_sp = be_new_IncSP(sp, bl, curr_sp, stack_size, 1); dbgi = get_irn_dbg_info(irn); /* If there are some parameters which shall be passed on the stack. */ @@ -442,20 +412,8 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) ir_node **in = ALLOCAN(ir_node*, n_stack_params+1); unsigned n_in = 0; - /* push params in reverse direction because stack grows downwards */ - if (do_seq) { - for (i = 0; i < n_stack_params >> 1; ++i) { - int other = n_stack_params - i - 1; - int tmp = stack_param_idx[i]; - stack_param_idx[i] = stack_param_idx[other]; - stack_param_idx[other] = tmp; - } - } - curr_mem = get_Call_mem(irn); - if (! do_seq) { - in[n_in++] = curr_mem; - } + in[n_in++] = curr_mem; for (i = 0; i < n_stack_params; ++i) { int p = stack_param_idx[i]; @@ -471,30 +429,23 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) * the stack pointer for the next must be incremented, * and the memory value propagated. */ - if (do_seq) { - curr_ofs = 0; - addr = curr_sp = be_new_IncSP(sp, bl, curr_sp, - param_size + arg->space_before, 0); - add_irn_dep(curr_sp, curr_mem); - } else { - curr_ofs += arg->space_before; - curr_ofs = round_up2(curr_ofs, arg->alignment); - - /* Make the expression to compute the argument's offset. */ - if (curr_ofs > 0) { - ir_mode *constmode = mach_mode; - if (mode_is_reference(mach_mode)) { - constmode = mode_Is; - } - addr = new_r_Const_long(irg, constmode, curr_ofs); - addr = new_r_Add(bl, curr_sp, addr, mach_mode); + curr_ofs += arg->space_before; + curr_ofs = round_up2(curr_ofs, arg->alignment); + + /* Make the expression to compute the argument's offset. */ + if (curr_ofs > 0) { + ir_mode *constmode = mach_mode; + if (mode_is_reference(mach_mode)) { + constmode = mode_Is; } + addr = new_r_Const_long(irg, constmode, curr_ofs); + addr = new_r_Add(bl, curr_sp, addr, mach_mode); } /* Insert a store for primitive arguments. */ if (is_atomic_type(param_type)) { ir_node *nomem = get_irg_no_mem(irg); - ir_node *mem_input = do_seq ? curr_mem : nomem; + ir_node *mem_input = nomem; ir_node *store = new_rd_Store(dbgi, bl, mem_input, addr, param, cons_none); mem = new_r_Proj(store, mode_M, pn_Store_M); } else { @@ -508,36 +459,17 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) curr_ofs += param_size; - if (do_seq) - curr_mem = mem; - else - in[n_in++] = mem; + in[n_in++] = mem; } /* We need the sync only, if we didn't build the stores sequentially. */ - if (! do_seq) { - if (n_stack_params >= 1) { - curr_mem = new_r_Sync(bl, n_in, in); - } else { - curr_mem = get_Call_mem(irn); - } + if (n_stack_params >= 1) { + curr_mem = new_r_Sync(bl, n_in, in); + } else { + curr_mem = get_Call_mem(irn); } } - /* check for the return_twice property */ - destroy_all_regs = 0; - if (is_SymConst_addr_ent(call_ptr)) { - ir_entity *ent = get_SymConst_entity(call_ptr); - - if (get_entity_additional_properties(ent) & mtp_property_returns_twice) - destroy_all_regs = 1; - } else { - ir_type *call_tp = get_Call_type(irn); - - if (get_method_additional_properties(call_tp) & mtp_property_returns_twice) - destroy_all_regs = 1; - } - /* Put caller save into the destroyed set and state registers in the states * set */ for (i = 0, n = arch_env->n_register_classes; i < n; ++i) { @@ -558,11 +490,8 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) * checking */ continue; } - if (destroy_all_regs || arch_register_is_caller_save(arch_env, reg)) { - if (!(reg->type & arch_register_type_ignore)) { - ARR_APP1(const arch_register_t*, destroyed_regs, reg); - } - } + if (arch_register_is_caller_save(arch_env, reg)) + ARR_APP1(const arch_register_t*, destroyed_regs, reg); } } @@ -570,8 +499,7 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) res_projs = ALLOCANZ(ir_node*, n_res); foreach_out_edge(irn, edge) { - const ir_edge_t *res_edge; - ir_node *irn = get_edge_src_irn(edge); + ir_node *irn = get_edge_src_irn(edge); if (!is_Proj(irn) || get_Proj_proj(irn) != pn_Call_T_result) continue; @@ -615,15 +543,17 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) /* ins collected, build the call */ throws_exception = ir_throws_exception(irn); - if (env->call->flags.bits.call_has_imm && is_SymConst(call_ptr)) { + if (env->call->flags.call_has_imm && is_SymConst(call_ptr)) { /* direct call */ - low_call = be_new_Call(dbgi, irg, bl, curr_mem, curr_sp, curr_sp, + low_call = be_new_Call(dbgi, irg, bl, curr_mem, sp->single_req, curr_sp, + sp->single_req, curr_sp, n_reg_results + pn_be_Call_first_res + ARR_LEN(destroyed_regs), n_ins, in, get_Call_type(irn)); be_Call_set_entity(low_call, get_SymConst_entity(call_ptr)); } else { /* indirect call */ - low_call = be_new_Call(dbgi, irg, bl, curr_mem, curr_sp, call_ptr, + low_call = be_new_Call(dbgi, irg, bl, curr_mem, sp->single_req, curr_sp, + sp->reg_class->class_req, call_ptr, n_reg_results + pn_be_Call_first_res + ARR_LEN(destroyed_regs), n_ins, in, get_Call_type(irn)); } @@ -643,7 +573,6 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) for (i = 0; i < n_res; ++i) { ir_node *proj = res_projs[i]; be_abi_call_arg_t *arg = get_call_arg(call, 1, i, 0); - long pn = i + pn_be_Call_first_res; /* returns values on stack not supported yet */ assert(arg->in_reg); @@ -653,7 +582,7 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) unspeakable Proj_T from the Call. Therefore, all real argument Proj numbers must be increased by pn_be_Call_first_res */ - pn = i + pn_be_Call_first_res; + long pn = i + pn_be_Call_first_res; if (proj == NULL) { ir_type *res_type = get_method_res_type(call_tp, i); @@ -679,12 +608,6 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) } } - /* - Set the register class of the call address to - the backend provided class (default: stack pointer class) - */ - be_node_set_reg_class_in(low_call, n_be_Call_ptr, call->cls_addr); - DBG((dbg, LEVEL_3, "\tcreated backend call %+F\n", low_call)); /* Set the register classes and constraints of the Call parameters. */ @@ -758,7 +681,7 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) keep = be_new_Keep(bl, n, in); for (i = 0; i < n; ++i) { const arch_register_t *reg = (const arch_register_t*)get_irn_link(in[i]); - be_node_set_reg_class_in(keep, i, arch_register_get_class(reg)); + be_node_set_reg_class_in(keep, i, reg->reg_class); } } @@ -783,9 +706,7 @@ static ir_node *adjust_call(be_abi_irg_t *env, ir_node *irn, ir_node *curr_sp) } } /* Clean up the stack frame or revert alignment fixes if we allocated it */ - if (! no_alloc) { - curr_sp = be_new_IncSP(sp, bl, curr_sp, -stack_size, 0); - } + curr_sp = be_new_IncSP(sp, bl, curr_sp, -stack_size, 0); be_abi_call_free(call); @@ -842,7 +763,6 @@ static ir_node *adjust_alloc(be_abi_irg_t *env, ir_node *alloc, ir_node *curr_sp ir_type *type = get_Alloc_type(alloc); dbg_info *dbg; - const ir_edge_t *edge; ir_node *new_alloc; ir_node *count; ir_node *size; @@ -880,7 +800,7 @@ static ir_node *adjust_alloc(be_abi_irg_t *env, ir_node *alloc, ir_node *curr_sp count = get_Alloc_count(alloc); /* we might need to multiply the count with the element size */ - if (type != firm_unknown_type && get_type_size_bytes(type) != 1) { + if (!is_unknown_type(type) && get_type_size_bytes(type) != 1) { ir_mode *mode = get_irn_mode(count); ir_tarval *tv = new_tarval_from_long(get_type_size_bytes(type), mode); @@ -892,7 +812,7 @@ static ir_node *adjust_alloc(be_abi_irg_t *env, ir_node *alloc, ir_node *curr_sp /* The stack pointer will be modified in an unknown manner. We cannot omit it. */ - env->call->flags.bits.try_omit_fp = 0; + env->call->flags.try_omit_fp = 0; stack_alignment = 1 << arch_env->stack_alignment; size = adjust_alloc_size(stack_alignment, size, block, dbg); @@ -945,14 +865,14 @@ static ir_node *adjust_free(be_abi_irg_t *env, ir_node *free, ir_node *curr_sp) assert(get_Free_where(free) == stack_alloc); /* we might need to multiply the size with the element size */ - if (type != firm_unknown_type && get_type_size_bytes(type) != 1) { + if (!is_unknown_type(type) && get_type_size_bytes(type) != 1) { ir_tarval *tv = new_tarval_from_long(get_type_size_bytes(type), mode_Iu); ir_node *cnst = new_rd_Const(dbg, irg, tv); - ir_node *mul = new_rd_Mul(dbg, block, get_Free_size(free), + ir_node *mul = new_rd_Mul(dbg, block, get_Free_count(free), cnst, mode_Iu); size = mul; } else { - size = get_Free_size(free); + size = get_Free_count(free); } stack_alignment = 1 << arch_env->stack_alignment; @@ -960,7 +880,7 @@ static ir_node *adjust_free(be_abi_irg_t *env, ir_node *free, ir_node *curr_sp) /* The stack pointer will be modified in an unknown manner. We cannot omit it. */ - env->call->flags.bits.try_omit_fp = 0; + env->call->flags.try_omit_fp = 0; subsp = be_new_SubSP(arch_env->sp, block, curr_sp, size); set_irn_dbg_info(subsp, dbg); @@ -1030,7 +950,6 @@ static int cmp_call_dependency(const void *c1, const void *c2) /** * Walker: links all Call/Alloc/Free nodes to the Block they are contained. - * Clears the irg_is_leaf flag if a Call is detected. */ static void link_ops_in_block_walker(ir_node *irn, void *data) { @@ -1043,9 +962,6 @@ static void link_ops_in_block_walker(ir_node *irn, void *data) ir_node *bl = get_nodes_block(irn); void *save = get_irn_link(bl); - if (code == iro_Call) - env->call->flags.bits.irg_is_leaf = 0; - set_irn_link(irn, save); set_irn_link(bl, irn); } @@ -1056,7 +972,7 @@ static void link_ops_in_block_walker(ir_node *irn, void *data) unsigned long value = get_tarval_long(tv); /* use ebp, so the climbframe algo works... */ if (value > 0) { - env->call->flags.bits.try_omit_fp = 0; + env->call->flags.try_omit_fp = 0; } } } @@ -1103,10 +1019,6 @@ static void process_ops_in_block(ir_node *bl, void *data) DBG((dbg, LEVEL_3, "\tprocessing call %+F\n", irn)); switch (get_irn_opcode(irn)) { case iro_Call: - if (! be_omit_fp) { - /* The stack pointer will be modified due to a call. */ - env->call->flags.bits.try_omit_fp = 0; - } curr_sp = adjust_call(env, irn, curr_sp); break; case iro_Alloc: @@ -1138,11 +1050,8 @@ static void process_ops_in_block(ir_node *bl, void *data) /** * Adjust all call nodes in the graph to the ABI conventions. */ -static void process_calls(ir_graph *irg) +static void process_calls(ir_graph *const irg, be_abi_irg_t *const abi) { - be_abi_irg_t *abi = be_get_irg_abi(irg); - - abi->call->flags.bits.irg_is_leaf = 1; irg_walk_graph(irg, firm_clear_link, link_ops_in_block_walker, abi); ir_heights = heights_new(irg); @@ -1157,26 +1066,23 @@ static void process_calls(ir_graph *irg) * * @param call the current call ABI * @param method_type the method type - * @param param_map an array mapping method arguments to the stack layout - * type * * @return the stack argument layout type */ static ir_type *compute_arg_type(ir_graph *irg, be_abi_call_t *call, - ir_type *method_type, ir_entity ***param_map) + ir_type *method_type) { struct obstack *obst = be_get_be_obst(irg); - ir_type *frame_type = get_irg_frame_type(irg); - size_t n_params = get_method_n_params(method_type); - size_t n_frame_members = get_compound_n_members(frame_type); + ir_type *frame_type = get_irg_frame_type(irg); + size_t n_params = get_method_n_params(method_type); + size_t n_frame_members = get_compound_n_members(frame_type); + ir_entity *va_start_entity = NULL; size_t f; int ofs = 0; ir_type *res; size_t i; - ir_entity **map; - - *param_map = map = OALLOCNZ(obst, ir_entity*, n_params); + ir_entity **map = OALLOCNZ(obst, ir_entity*, n_params); res = new_type_struct(new_id_from_chars("arg_type", 8)); /* collect existing entities for value_param_types */ @@ -1188,11 +1094,17 @@ static ir_type *compute_arg_type(ir_graph *irg, be_abi_call_t *call, if (!is_parameter_entity(entity)) continue; num = get_entity_parameter_number(entity); + if (num == IR_VA_START_PARAMETER_NUMBER) { + /* move entity to new arg_type */ + set_entity_owner(entity, res); + va_start_entity = entity; + continue; + } assert(num < n_params); if (map[num] != NULL) panic("multiple entities for parameter %u in %+F found", f, irg); - if (!get_call_arg(call, 0, num, 1)->on_stack) { + if (num != n_params && get_call_arg(call, 0, num, 1)->in_reg) { /* don't move this entity */ continue; } @@ -1207,9 +1119,8 @@ static ir_type *compute_arg_type(ir_graph *irg, be_abi_call_t *call, ir_type *param_type = get_method_param_type(method_type, i); ir_entity *entity; - if (!arg->on_stack) { + if (arg->in_reg) continue; - } entity = map[i]; if (entity == NULL) { /* create a new entity */ @@ -1222,37 +1133,34 @@ static ir_type *compute_arg_type(ir_graph *irg, be_abi_call_t *call, ofs += get_type_size_bytes(param_type); arg->stack_ent = entity; } + if (va_start_entity != NULL) { + set_entity_offset(va_start_entity, ofs); + } set_type_size_bytes(res, ofs); set_type_state(res, layout_fixed); + return res; } -typedef struct { - const arch_register_t *reg; - ir_node *irn; -} reg_node_map_t; - static int cmp_regs(const void *a, const void *b) { - const reg_node_map_t *p = (const reg_node_map_t*)a; - const reg_node_map_t *q = (const reg_node_map_t*)b; + arch_register_t const *const p = *(arch_register_t const**)a; + arch_register_t const *const q = *(arch_register_t const**)b; - if (p->reg->reg_class == q->reg->reg_class) - return p->reg->index - q->reg->index; + if (p->reg_class == q->reg_class) + return p->index - q->index; else - return p->reg->reg_class < q->reg->reg_class ? -1 : +1; + return p->reg_class < q->reg_class ? -1 : +1; } -static void reg_map_to_arr(reg_node_map_t *res, pmap *reg_map) +static void reg_map_to_arr(arch_register_t const **const res, pmap *const reg_map) { pmap_entry *ent; size_t n = pmap_count(reg_map); size_t i = 0; foreach_pmap(reg_map, ent) { - res[i].reg = (const arch_register_t*)ent->key; - res[i].irn = (ir_node*)ent->value; - i++; + res[i++] = (arch_register_t const*)ent->key; } qsort(res, n, sizeof(res[0]), cmp_regs); @@ -1262,24 +1170,18 @@ static void reg_map_to_arr(reg_node_map_t *res, pmap *reg_map) * Creates a be_Return for a Return node. * * @param @env the abi environment - * @param irn the Return node or NULL if there was none - * @param bl the block where the be_Retun should be placed - * @param mem the current memory - * @param n_res number of return results + * @param irn the Return node */ -static ir_node *create_be_return(be_abi_irg_t *env, ir_node *irn, ir_node *bl, - ir_node *mem, int n_res) +static ir_node *create_be_return(be_abi_irg_t *const env, ir_node *const irn) { + ir_node *const bl = get_nodes_block(irn); be_abi_call_t *call = env->call; ir_graph *irg = get_Block_irg(bl); const arch_env_t *arch_env = be_get_irg_arch_env(irg); - dbg_info *dbgi; pmap *reg_map = pmap_create(); - ir_node *keep = (ir_node*)pmap_get(env->keep_map, bl); + ir_node *keep = pmap_get(ir_node, env->keep_map, bl); size_t in_max; - ir_node *ret; int i, n; - unsigned pop; ir_node **in; ir_node *stack; const arch_register_t **regs; @@ -1299,6 +1201,7 @@ static ir_node *create_be_return(be_abi_irg_t *env, ir_node *irn, ir_node *bl, remove_End_keepalive(get_irg_end(irg), keep); } + int const n_res = get_Return_n_ress(irn); /* Insert results for Return into the register map. */ for (i = 0; i < n_res; ++i) { ir_node *res = get_Return_res(irn, i); @@ -1310,7 +1213,7 @@ static ir_node *create_be_return(be_abi_irg_t *env, ir_node *irn, ir_node *bl, /* Add uses of the callee save registers. */ foreach_pmap(env->regs, ent) { const arch_register_t *reg = (const arch_register_t*)ent->key; - if ((reg->type & arch_register_type_ignore) || arch_register_is_callee_save(arch_env, reg)) + if (arch_register_is_callee_save(arch_env, reg)) pmap_insert(reg_map, ent->key, ent->value); } @@ -1325,7 +1228,7 @@ static ir_node *create_be_return(be_abi_irg_t *env, ir_node *irn, ir_node *bl, in = ALLOCAN(ir_node*, in_max); regs = ALLOCAN(arch_register_t const*, in_max); - in[0] = mem; + in[0] = get_Return_mem(irn); in[1] = be_abi_reg_map_get(reg_map, arch_env->sp); regs[0] = NULL; regs[1] = arch_env->sp; @@ -1352,14 +1255,8 @@ static ir_node *create_be_return(be_abi_irg_t *env, ir_node *irn, ir_node *bl, } /* The in array for the new back end return is now ready. */ - if (irn != NULL) { - dbgi = get_irn_dbg_info(irn); - } else { - dbgi = NULL; - } - /* we have to pop the shadow parameter in in case of struct returns */ - pop = call->pop; - ret = be_new_Return(dbgi, irg, bl, n_res, pop, n, in); + dbg_info *const dbgi = get_irn_dbg_info(irn); + ir_node *const ret = be_new_Return(dbgi, irg, bl, n_res, call->pop, n, in); /* Set the register classes of the return's parameter accordingly. */ for (i = 0; i < n; ++i) { @@ -1378,9 +1275,6 @@ static ir_node *create_be_return(be_abi_irg_t *env, ir_node *irn, ir_node *bl, typedef struct lower_frame_sels_env_t { ir_node *frame; /**< the current frame */ const arch_register_class_t *sp_class; /**< register class of the stack pointer */ - const arch_register_class_t *link_class; /**< register class of the link pointer */ - ir_type *frame_tp; /**< the frame type */ - int static_link_pos; /**< argument number of the hidden static link */ } lower_frame_sels_env_t; /** @@ -1423,7 +1317,6 @@ static void fix_start_block(ir_graph *irg) /* merge start block with successor if possible */ { - const ir_edge_t *edge; foreach_out_edge(jmp, edge) { ir_node *succ = get_edge_src_irn(edge); if (!is_Block(succ)) @@ -1440,9 +1333,8 @@ static void fix_start_block(ir_graph *irg) /** * Modify the irg itself and the frame type. */ -static void modify_irg(ir_graph *irg) +static void modify_irg(ir_graph *const irg, be_abi_irg_t *const env) { - be_abi_irg_t *env = be_get_irg_abi(irg); be_abi_call_t *call = env->call; const arch_env_t *arch_env = be_get_irg_arch_env(irg); const arch_register_t *sp = arch_env->sp; @@ -1458,18 +1350,14 @@ static void modify_irg(ir_graph *irg) int n_params; int i, n; unsigned j; - unsigned frame_size; - reg_node_map_t *rm; const arch_register_t *fp_reg; ir_node *frame_pointer; ir_node *start_bl; ir_node **args; ir_node *arg_tuple; - const ir_edge_t *edge; ir_type *arg_type, *bet_type; lower_frame_sels_env_t ctx; - ir_entity **param_map; DBG((dbg, LEVEL_1, "introducing abi on %+F\n", irg)); @@ -1477,24 +1365,22 @@ static void modify_irg(ir_graph *irg) irp_reserve_resources(irp, IRP_RESOURCE_ENTITY_LINK); - arg_type = compute_arg_type(irg, call, method_type, ¶m_map); + arg_type = compute_arg_type(irg, call, method_type); /* Convert the Sel nodes in the irg to frame addr nodes: */ - ctx.frame = get_irg_frame(irg); - ctx.sp_class = arch_env->sp->reg_class; - ctx.link_class = arch_env->link_class; - ctx.frame_tp = get_irg_frame_type(irg); + ctx.frame = get_irg_frame(irg); + ctx.sp_class = arch_env->sp->reg_class; + ir_type *const frame_tp = get_irg_frame_type(irg); /* layout the stackframe now */ - if (get_type_state(ctx.frame_tp) == layout_undefined) { - default_layout_compound_type(ctx.frame_tp); + if (get_type_state(frame_tp) == layout_undefined) { + default_layout_compound_type(frame_tp); } - /* align stackframe to 4 byte */ - frame_size = get_type_size_bytes(ctx.frame_tp); - if (frame_size % 4 != 0) { - set_type_size_bytes(ctx.frame_tp, frame_size + 4 - (frame_size % 4)); - } + /* align stackframe */ + unsigned const alignment = 1U << arch_env->stack_alignment; + unsigned const frame_size = round_up2(get_type_size_bytes(frame_tp), alignment); + set_type_size_bytes(frame_tp, frame_size); env->regs = pmap_create(); @@ -1518,10 +1404,10 @@ static void modify_irg(ir_graph *irg) } } - stack_layout->sp_relative = call->flags.bits.try_omit_fp; + stack_layout->sp_relative = call->flags.try_omit_fp; bet_type = call->cb->get_between_type(irg); stack_frame_init(stack_layout, arg_type, bet_type, - get_irg_frame_type(irg), param_map); + get_irg_frame_type(irg)); /* Count the register params and add them to the number of Projs for the RegParams node */ for (i = 0; i < n_params; ++i) { @@ -1547,7 +1433,7 @@ static void modify_irg(ir_graph *irg) } } - fp_reg = call->flags.bits.try_omit_fp ? arch_env->sp : arch_env->bp; + fp_reg = call->flags.try_omit_fp ? arch_env->sp : arch_env->bp; rbitset_clear(birg->allocatable_regs, fp_reg->global_index); /* handle start block here (place a jump in the block) */ @@ -1556,8 +1442,8 @@ static void modify_irg(ir_graph *irg) pmap_insert(env->regs, (void *) sp, NULL); pmap_insert(env->regs, (void *) arch_env->bp, NULL); start_bl = get_irg_start_block(irg); - env->start = be_new_Start(NULL, start_bl, pmap_count(env->regs) + 1); - set_irg_start(irg, env->start); + ir_node *const start = be_new_Start(NULL, start_bl, pmap_count(env->regs) + 1); + set_irg_start(irg, start); /* * make proj nodes for the callee save registers. @@ -1566,10 +1452,10 @@ static void modify_irg(ir_graph *irg) * Note, that if a register corresponds to an argument, the regs map * contains the old Proj from start for that argument. */ - rm = ALLOCAN(reg_node_map_t, pmap_count(env->regs)); - reg_map_to_arr(rm, env->regs); + arch_register_t const **const regs = ALLOCAN(arch_register_t const*, pmap_count(env->regs)); + reg_map_to_arr(regs, env->regs); for (i = 0, n = pmap_count(env->regs); i < n; ++i) { - const arch_register_t *reg = rm[i].reg; + const arch_register_t *reg = regs[i]; ir_mode *mode = reg->reg_class->mode; long nr = i; arch_register_req_type_t add_type = arch_register_req_type_none; @@ -1582,9 +1468,9 @@ static void modify_irg(ir_graph *irg) } assert(nr >= 0); - proj = new_r_Proj(env->start, mode, nr + 1); + proj = new_r_Proj(start, mode, nr + 1); pmap_insert(env->regs, (void *) reg, proj); - be_set_constr_single_reg_out(env->start, nr + 1, reg, add_type); + be_set_constr_single_reg_out(start, nr + 1, reg, add_type); arch_set_irn_register(proj, reg); DBG((dbg, LEVEL_2, "\tregister save proj #%d -> reg %s\n", nr, reg->name)); @@ -1592,8 +1478,8 @@ static void modify_irg(ir_graph *irg) /* create a new initial memory proj */ assert(is_Proj(old_mem)); - arch_set_irn_register_req_out(env->start, 0, arch_no_register_req); - new_mem_proj = new_r_Proj(env->start, mode_M, 0); + arch_set_irn_register_req_out(start, 0, arch_no_register_req); + new_mem_proj = new_r_Proj(start, mode_M, 0); mem = new_mem_proj; set_irg_initial_mem(irg, mem); @@ -1627,8 +1513,8 @@ static void modify_irg(ir_graph *irg) param_type = get_method_param_type(method_type, nr); if (arg->in_reg) { - repl = (ir_node*)pmap_get(env->regs, arg->reg); - } else if (arg->on_stack) { + repl = pmap_get(ir_node, env->regs, arg->reg); + } else { ir_node *addr = be_new_FrameAddr(sp->reg_class, start_bl, frame_pointer, arg->stack_ent); /* For atomic parameters which are actually used, we create a Load node. */ @@ -1674,9 +1560,7 @@ static void modify_irg(ir_graph *irg) ir_node *irn = get_Block_cfgpred(end, i); if (is_Return(irn)) { - ir_node *blk = get_nodes_block(irn); - ir_node *mem = get_Return_mem(irn); - ir_node *ret = create_be_return(env, irn, blk, mem, get_Return_n_ress(irn)); + ir_node *const ret = create_be_return(env, irn); exchange(irn, ret); } } @@ -1686,9 +1570,8 @@ static void modify_irg(ir_graph *irg) } /** Fix the state inputs of calls that still hang on unknowns */ -static void fix_call_state_inputs(ir_graph *irg) +static void fix_call_state_inputs(ir_graph *const irg, be_abi_irg_t *const env) { - be_abi_irg_t *env = be_get_irg_abi(irg); const arch_env_t *arch_env = be_get_irg_arch_env(irg); int i, n, n_states; arch_register_t **stateregs = NEW_ARR_F(arch_register_t*, 0); @@ -1748,7 +1631,7 @@ static ir_entity *create_trampoline(be_main_env_t *be, ir_entity *method) */ static ir_entity *get_trampoline(be_main_env_t *env, ir_entity *method) { - ir_entity *result = (ir_entity*)pmap_get(env->ent_trampoline_map, method); + ir_entity *result = pmap_get(ir_entity, env->ent_trampoline_map, method); if (result == NULL) { result = create_trampoline(env, method); pmap_insert(env->ent_trampoline_map, method, result); @@ -1773,7 +1656,7 @@ static ir_entity *create_pic_symbol(be_main_env_t *be, ir_entity *entity) static ir_entity *get_pic_symbol(be_main_env_t *env, ir_entity *entity) { - ir_entity *result = (ir_entity*)pmap_get(env->ent_pic_symbol_map, entity); + ir_entity *result = pmap_get(ir_entity, env->ent_pic_symbol_map, entity); if (result == NULL) { result = create_pic_symbol(env, entity); pmap_insert(env->ent_pic_symbol_map, entity, result); @@ -1789,8 +1672,7 @@ static ir_entity *get_pic_symbol(be_main_env_t *env, ir_entity *entity) */ static int can_address_relative(ir_entity *entity) { - return get_entity_visibility(entity) != ir_visibility_external - && !(get_entity_linkage(entity) & IR_LINKAGE_MERGE); + return entity_has_definition(entity) && !(get_entity_linkage(entity) & IR_LINKAGE_MERGE); } static ir_node *get_pic_base(ir_graph *irg) @@ -1880,9 +1762,7 @@ static void fix_pic_symconsts(ir_node *node, void *data) void be_abi_introduce(ir_graph *irg) { - be_abi_irg_t *env = XMALLOCZ(be_abi_irg_t); ir_node *old_frame = get_irg_frame(irg); - be_options_t *options = be_get_irg_options(irg); const arch_env_t *arch_env = be_get_irg_arch_env(irg); ir_entity *entity = get_irg_entity(irg); ir_type *method_type = get_entity_type(entity); @@ -1902,62 +1782,44 @@ void be_abi_introduce(ir_graph *irg) } } - /* break here if backend provides a custom API. - * Note: we shouldn't have to setup any be_abi_irg_t* stuff at all, - * but need more cleanup to make this work - */ - be_set_irg_abi(irg, env); - - be_omit_fp = options->omit_fp; + /* Break here if backend provides a custom API. */ - env->keep_map = pmap_create(); - env->call = be_abi_call_new(arch_env->sp->reg_class); - arch_env_get_call_abi(arch_env, method_type, env->call); + be_abi_irg_t env; + env.keep_map = pmap_create(); + env.call = be_abi_call_new(); + arch_env_get_call_abi(arch_env, method_type, env.call); - env->init_sp = dummy; - env->calls = NEW_ARR_F(ir_node*, 0); + env.init_sp = dummy; + env.calls = NEW_ARR_F(ir_node*, 0); - edges_assure(irg); + assure_edges(irg); - if (options->pic) { - irg_walk_graph(irg, fix_pic_symconsts, NULL, env); + if (be_options.pic) { + irg_walk_graph(irg, fix_pic_symconsts, NULL, NULL); } /* Lower all call nodes in the IRG. */ - process_calls(irg); + process_calls(irg, &env); /* Process the IRG */ - modify_irg(irg); + modify_irg(irg, &env); /* fix call inputs for state registers */ - fix_call_state_inputs(irg); + fix_call_state_inputs(irg, &env); + + be_abi_call_free(env.call); /* We don't need the keep map anymore. */ - pmap_destroy(env->keep_map); - env->keep_map = NULL; + pmap_destroy(env.keep_map); /* calls array is not needed anymore */ - DEL_ARR_F(env->calls); - env->calls = NULL; + DEL_ARR_F(env.calls); /* reroute the stack origin of the calls to the true stack origin. */ - exchange(dummy, env->init_sp); + exchange(dummy, env.init_sp); exchange(old_frame, get_irg_frame(irg)); - pmap_destroy(env->regs); - env->regs = NULL; -} - -void be_abi_free(ir_graph *irg) -{ - be_abi_irg_t *env = be_get_irg_abi(irg); - - if (env->call != NULL) - be_abi_call_free(env->call); - assert(env->regs == NULL); - free(env); - - be_set_irg_abi(irg, NULL); + pmap_destroy(env.regs); } void be_put_allocatable_regs(const ir_graph *irg,