X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=diagnostic.c;h=65ba4490bfdd44f794d4e7dabc70aab24f525ebb;hb=0a880c90fd6d1ec23c4ec1956f3b92694ec0a139;hp=5174308617b10fe939a35c287e545f721169d527;hpb=d6b73cf5a5ea248432191eda4f1ee63c49140f6b;p=cparser

diff --git a/diagnostic.c b/diagnostic.c
index 5174308..65ba449 100644
--- a/diagnostic.c
+++ b/diagnostic.c
@@ -29,13 +29,12 @@
 #include "type.h"
 #include "warning.h"
 
-/** Number of occurred diagnostics. */
-unsigned diagnostic_count    = 0;
 /** Number of occurred errors. */
-unsigned error_count         = 0;
+unsigned error_count             = 0;
 /** Number of occurred warnings. */
-unsigned warning_count       = 0;
-bool     show_column         = true;
+unsigned warning_count           = 0;
+bool     show_column             = true;
+bool     diagnostics_show_option = true;
 
 static const source_position_t *curr_pos = NULL;
 
@@ -46,7 +45,7 @@ static void print_source_position(FILE *out, const source_position_t *pos)
 {
 	fprintf(out, "at line %u", pos->lineno);
 	if (show_column)
-		fprintf(out, ":%u", pos->colno);
+		fprintf(out, ":%u", (unsigned)pos->colno);
 	if (curr_pos == NULL || curr_pos->input_name != pos->input_name)
 		fprintf(out, " of \"%s\"", pos->input_name);
 }
@@ -54,157 +53,172 @@ static void print_source_position(FILE *out, const source_position_t *pos)
 /**
  * Issue a diagnostic message.
  */
-static void diagnosticvf(const char *const fmt, va_list ap)
+static void diagnosticvf(char const *fmt, va_list ap)
 {
-	for (const char* f = fmt; *f != '\0'; ++f) {
-		if (*f == '%') {
-			++f;
+	for (char const *f; (f = strchr(fmt, '%')); fmt = f) {
+		fwrite(fmt, sizeof(*fmt), f - fmt, stderr); // Print till '%'.
+		++f; // Skip '%'.
 
-			bool extended = false;
-			if (*f == '#') {
-				extended = true;
-				++f;
+		bool extended  = false;
+		bool flag_zero = false;
+		for (;; ++f) {
+			switch (*f) {
+			case '#': extended  = true; break;
+			case '0': flag_zero = true; break;
+			default:  goto done_flags;
 			}
+		}
+done_flags:;
 
-			switch (*f) {
-				case '%':
-					fputc(*f, stderr);
-					break;
-
-				case 'c': {
-					const unsigned char val = (unsigned char) va_arg(ap, int);
-					fputc(val, stderr);
-					break;
-				}
+		int field_width = 0;
+		if (*f == '*') {
+			++f;
+			field_width = va_arg(ap, int);
+		}
 
-				case 'd': {
-					const int val = va_arg(ap, int);
-					fprintf(stderr, "%d", val);
-					break;
-				}
+		switch (*f++) {
+		case '%':
+			fputc('%', stderr);
+			break;
 
-				case 's': {
-					const char* const str = va_arg(ap, const char*);
-					fputs(str, stderr);
-					break;
-				}
+		case 'c': {
+			const unsigned char val = (unsigned char) va_arg(ap, int);
+			fputc(val, stderr);
+			break;
+		}
 
-				case 'S': {
-					const string_t *str = va_arg(ap, const string_t*);
-					for (size_t i = 0; i < str->size; ++i) {
-						fputc(str->begin[i], stderr);
-					}
-					break;
-				}
+		case 'd': {
+			const int val = va_arg(ap, int);
+			fprintf(stderr, "%d", val);
+			break;
+		}
 
-				case 'u': {
-					const unsigned int val = va_arg(ap, unsigned int);
-					fprintf(stderr, "%u", val);
-					break;
-				}
+		case 's': {
+			const char* const str = va_arg(ap, const char*);
+			fputs(str, stderr);
+			break;
+		}
 
-				case 'Y': {
-					const symbol_t *const symbol = va_arg(ap, const symbol_t*);
-					if (symbol == NULL)
-						fputs("(null)", stderr);
-					else
-						fputs(symbol->string, stderr);
-					break;
-				}
+		case 'S': {
+			const string_t *str = va_arg(ap, const string_t*);
+			for (size_t i = 0; i < str->size; ++i) {
+				fputc(str->begin[i], stderr);
+			}
+			break;
+		}
 
-				case 'E': {
-					const expression_t* const expr = va_arg(ap, const expression_t*);
-					print_expression(expr);
-					break;
-				}
+		case 'u': {
+			const unsigned int val = va_arg(ap, unsigned int);
+			fprintf(stderr, "%u", val);
+			break;
+		}
 
-				case 'Q': {
-					const unsigned qualifiers = va_arg(ap, unsigned);
-					print_type_qualifiers(qualifiers, QUAL_SEP_NONE);
-					break;
-				}
+		case 'X': {
+			unsigned int const val = va_arg(ap, unsigned int);
+			char const  *const fmt = flag_zero ? "%0*X" : "%*X";
+			fprintf(stderr, fmt, field_width, val);
+			break;
+		}
 
-				case 'T': {
-					const type_t* const type = va_arg(ap, const type_t*);
-					const symbol_t*     sym  = NULL;
-					if (extended) {
-						sym = va_arg(ap, const symbol_t*);
-					}
-					print_type_ext(type, sym, NULL);
-					break;
-				}
+		case 'Y': {
+			const symbol_t *const symbol = va_arg(ap, const symbol_t*);
+			if (symbol == NULL)
+				fputs("(null)", stderr);
+			else
+				fputs(symbol->string, stderr);
+			break;
+		}
 
-				case 't': {
-					const token_t *const token = va_arg(ap, const token_t*);
-					print_pp_token(stderr, token);
-					break;
-				}
+		case 'E': {
+			const expression_t* const expr = va_arg(ap, const expression_t*);
+			print_expression(expr);
+			break;
+		}
 
-				case 'K': {
-					const token_t* const token = va_arg(ap, const token_t*);
-					print_token(stderr, token);
-					break;
-				}
+		case 'Q': {
+			const unsigned qualifiers = va_arg(ap, unsigned);
+			print_type_qualifiers(qualifiers, QUAL_SEP_NONE);
+			break;
+		}
 
-				case 'k': {
-					if (extended) {
-						bool              first     = true;
-						va_list*          toks      = va_arg(ap, va_list*);
-						const char* const delimiter = va_arg(ap, const char*);
-						for (;;) {
-							const token_type_t tok = va_arg(*toks, token_type_t);
-							if (tok == 0)
-								break;
-							if (first) {
-								first = false;
-							} else {
-								fputs(delimiter, stderr);
-							}
-							print_token_type(stderr, tok);
-						}
-					} else {
-						const token_type_t token = va_arg(ap, token_type_t);
-						print_token_type(stderr, token);
-					}
-					break;
-				}
+		case 'T': {
+			const type_t* const type = va_arg(ap, const type_t*);
+			const symbol_t*     sym  = NULL;
+			if (extended) {
+				sym = va_arg(ap, const symbol_t*);
+			}
+			print_type_ext(type, sym, NULL);
+			break;
+		}
+
+		case 't': {
+			const token_t *const token = va_arg(ap, const token_t*);
+			print_pp_token(stderr, token);
+			break;
+		}
 
-				case 'N': {
-					entity_t const *const ent = va_arg(ap, entity_t const*);
-					if (extended && is_declaration(ent)) {
-						print_type_ext(ent->declaration.type, ent->base.symbol, NULL);
+		case 'K': {
+			const token_t* const token = va_arg(ap, const token_t*);
+			print_token(stderr, token);
+			break;
+		}
+
+		case 'k': {
+			if (extended) {
+				bool              first     = true;
+				va_list*          toks      = va_arg(ap, va_list*);
+				const char* const delimiter = va_arg(ap, const char*);
+				for (;;) {
+					const token_kind_t tok = va_arg(*toks, token_kind_t);
+					if (tok == 0)
+						break;
+					if (first) {
+						first = false;
 					} else {
-						char     const *const kind = get_entity_kind_name(ent->kind);
-						symbol_t const *const sym  = ent->base.symbol;
-						if (sym) {
-							fprintf(stderr, "%s %s", kind, sym->string);
-						} else {
-							fprintf(stderr, "anonymous %s", kind);
-						}
+						fputs(delimiter, stderr);
 					}
-					break;
+					print_token_kind(stderr, tok);
 				}
+			} else {
+				const token_kind_t token = va_arg(ap, token_kind_t);
+				print_token_kind(stderr, token);
+			}
+			break;
+		}
 
-				case 'P': {
-					const source_position_t *pos = va_arg(ap, const source_position_t *);
-					print_source_position(stderr, pos);
-					break;
+		case 'N': {
+			entity_t const *const ent = va_arg(ap, entity_t const*);
+			if (extended && is_declaration(ent)) {
+				print_type_ext(ent->declaration.type, ent->base.symbol, NULL);
+			} else {
+				char     const *const kind = get_entity_kind_name(ent->kind);
+				symbol_t const *const sym  = ent->base.symbol;
+				if (sym) {
+					fprintf(stderr, "%s %s", kind, sym->string);
+				} else {
+					fprintf(stderr, "anonymous %s", kind);
 				}
-
-				default:
-					panic("unknown format specifier");
 			}
-		} else {
-			fputc(*f, stderr);
+			break;
+		}
+
+		case 'P': {
+			const source_position_t *pos = va_arg(ap, const source_position_t *);
+			print_source_position(stderr, pos);
+			break;
+		}
+
+		default:
+			panic("unknown format specifier");
 		}
 	}
+	fputs(fmt, stderr); // Print rest.
 }
 
 void diagnosticf(const char *const fmt, ...)
 {
 	va_list ap;
 	va_start(ap, fmt);
-	++diagnostic_count;
 	curr_pos = NULL;
 	diagnosticvf(fmt, ap);
 	va_end(ap);
@@ -215,7 +229,7 @@ static void diagnosticposvf(source_position_t const *const pos, char const *cons
 	FILE *const out = stderr;
 	fprintf(out, "%s:%u:", pos->input_name, pos->lineno);
 	if (show_column)
-		fprintf(out, "%u:", pos->colno);
+		fprintf(out, "%u:", (unsigned)pos->colno);
 	fprintf(out, " %s: ", kind);
 	curr_pos = pos;
 	diagnosticvf(fmt, ap);
@@ -245,7 +259,7 @@ void warningf(warning_t const warn, source_position_t const* pos, char const *co
 	va_list ap;
 	va_start(ap, fmt);
 	warning_switch_t const *const s = get_warn_switch(warn);
-	switch (s->state) {
+	switch ((unsigned) s->state) {
 			char const* kind;
 		case WARN_STATE_ON:
 			if (is_warn_on(WARN_ERROR)) {
@@ -258,7 +272,8 @@ void warningf(warning_t const warn, source_position_t const* pos, char const *co
 				kind = "warning";
 			}
 			diagnosticposvf(pos, kind, fmt, ap);
-			fprintf(stderr, " [-W%s]\n", s->name);
+			if (diagnostics_show_option)
+				fprintf(stderr, " [-W%s]\n", s->name);
 			break;
 
 		default: