X-Git-Url: http://nsz.repo.hu/git/?a=blobdiff_plain;f=ast2firm.c;h=de449ffea6c50bcabaca79f44eb1a00706dd8c92;hb=2ee1c58e7b47126ee3bd7566b7aadd0bc6d9e95e;hp=746fbf63a07259e396c1578c99daaa9346854764;hpb=f94de3742059853f3e07ecb478b71fb151d5679b;p=cparser diff --git a/ast2firm.c b/ast2firm.c index 746fbf6..de449ff 100644 --- a/ast2firm.c +++ b/ast2firm.c @@ -35,6 +35,7 @@ #include "adt/array.h" #include "adt/strutil.h" #include "adt/util.h" +#include "jump_target.h" #include "symbol_t.h" #include "token_t.h" #include "type_t.h" @@ -63,8 +64,6 @@ fp_model_t firm_fp_model = fp_model_precise; static const backend_params *be_params; static ir_type *ir_type_char; -static ir_type *ir_type_const_char; -static ir_type *ir_type_wchar_t; /* architecture specific floating point arithmetic mode (if any) */ static ir_mode *mode_float_arithmetic; @@ -72,15 +71,36 @@ static ir_mode *mode_float_arithmetic; /* alignment of stack parameters */ static unsigned stack_param_align; -static int next_value_number_function; -static ir_node *continue_label; -static ir_node *break_label; -static ir_node *current_switch; -static bool saw_default_label; -static label_t **all_labels; -static entity_t **inner_functions; -static ir_node *ijmp_list; -static bool constant_folding; +static int next_value_number_function; +static jump_target continue_target; +static jump_target break_target; +static ir_node *current_switch; +static bool saw_default_label; +static entity_t **inner_functions; +static jump_target ijmp_target; +static ir_node **ijmp_ops; +static ir_node **ijmp_blocks; +static bool constant_folding; + +#define PUSH_BREAK(val) \ + jump_target const old_break_target = break_target; \ + (init_jump_target(&break_target, (val))) +#define POP_BREAK() \ + ((void)(break_target = old_break_target)) + +#define PUSH_CONTINUE(val) \ + jump_target const old_continue_target = continue_target; \ + (init_jump_target(&continue_target, (val))) +#define POP_CONTINUE() \ + ((void)(continue_target = old_continue_target)) + +#define PUSH_IRG(val) \ + ir_graph *const old_irg = current_ir_graph; \ + ir_graph *const new_irg = (val); \ + ((void)(current_ir_graph = new_irg)) + +#define POP_IRG() \ + (assert(current_ir_graph == new_irg), (void)(current_ir_graph = old_irg)) static const entity_t *current_function_entity; static ir_node *current_function_name; @@ -175,7 +195,6 @@ ir_mode *atomic_modes[ATOMIC_TYPE_LAST+1]; static ir_node *_expression_to_firm(const expression_t *expression); static ir_node *expression_to_firm(const expression_t *expression); -static void create_local_declaration(entity_t *entity); static unsigned decide_modulo_shift(unsigned type_size) { @@ -192,12 +211,10 @@ static ir_mode *init_atomic_ir_mode(atomic_type_kind_t kind) unsigned size = get_atomic_type_size(kind); if ((flags & ATOMIC_TYPE_FLAG_FLOAT) && !(flags & ATOMIC_TYPE_FLAG_COMPLEX)) { - if (size == 4) { - return get_modeF(); - } else if (size == 8) { - return get_modeD(); - } else { - panic("unexpected kind"); + switch (size) { + case 4: return get_modeF(); + case 8: return get_modeD(); + default: panic("unexpected kind"); } } else if (flags & ATOMIC_TYPE_FLAG_INTEGER) { char name[64]; @@ -507,12 +524,11 @@ static ir_type *create_bitfield_type(const entity_t *entity) { assert(entity->kind == ENTITY_COMPOUND_MEMBER); type_t *base = skip_typeref(entity->declaration.type); - assert(base->kind == TYPE_ATOMIC || base->kind == TYPE_ENUM); + assert(is_type_integer(base)); ir_type *irbase = get_ir_type(base); unsigned bit_size = entity->compound_member.bit_size; - assert(!is_type_float(base)); if (is_type_signed(base)) { return get_signed_int_type_for_bit_size(irbase, bit_size, base); } else { @@ -520,16 +536,10 @@ static ir_type *create_bitfield_type(const entity_t *entity) } } -enum { - COMPOUND_IS_STRUCT = false, - COMPOUND_IS_UNION = true -}; - /** * Construct firm type from ast struct type. */ -static ir_type *create_compound_type(compound_type_t *type, - bool incomplete, bool is_union) +static ir_type *create_compound_type(compound_type_t *const type, bool const incomplete) { compound_t *compound = type->compound; @@ -537,6 +547,8 @@ static ir_type *create_compound_type(compound_type_t *type, return compound->irtype; } + bool const is_union = type->base.kind == TYPE_COMPOUND_UNION; + symbol_t *type_symbol = compound->base.symbol; ident *id; if (type_symbol != NULL) { @@ -582,8 +594,7 @@ static ir_type *create_compound_type(compound_type_t *type, /* anonymous bitfield member, skip */ if (entry->compound_member.bitfield) continue; - assert(entry_type->kind == TYPE_COMPOUND_STRUCT - || entry_type->kind == TYPE_COMPOUND_UNION); + assert(is_type_compound(entry_type)); ident = id_unique("anon.%u"); } else { ident = new_id_from_str(symbol->string); @@ -615,9 +626,7 @@ static ir_type *create_compound_type(compound_type_t *type, return irtype; } -static ir_tarval *fold_constant_to_tarval(expression_t const *); - -static void determine_enum_values(enum_type_t *const type) +void determine_enum_values(enum_type_t *const type) { ir_mode *const mode = atomic_modes[type->base.akind]; ir_tarval *const one = get_mode_one(mode); @@ -646,27 +655,21 @@ static ir_type *create_enum_type(enum_type_t *const type) static ir_type *get_ir_type_incomplete(type_t *type) { - assert(type != NULL); type = skip_typeref(type); if (type->base.firm_type != NULL) { return type->base.firm_type; } - switch (type->kind) { - case TYPE_COMPOUND_STRUCT: - return create_compound_type(&type->compound, true, COMPOUND_IS_STRUCT); - case TYPE_COMPOUND_UNION: - return create_compound_type(&type->compound, true, COMPOUND_IS_UNION); - default: + if (is_type_compound(type)) { + return create_compound_type(&type->compound, true); + } else { return get_ir_type(type); } } ir_type *get_ir_type(type_t *type) { - assert(type != NULL); - type = skip_typeref(type); if (type->base.firm_type != NULL) { @@ -697,10 +700,8 @@ ir_type *get_ir_type(type_t *type) firm_type = create_array_type(&type->array); break; case TYPE_COMPOUND_STRUCT: - firm_type = create_compound_type(&type->compound, false, COMPOUND_IS_STRUCT); - break; case TYPE_COMPOUND_UNION: - firm_type = create_compound_type(&type->compound, false, COMPOUND_IS_UNION); + firm_type = create_compound_type(&type->compound, false); break; case TYPE_ENUM: firm_type = create_enum_type(&type->enumt); @@ -864,6 +865,27 @@ void set_create_ld_ident(ident *(*func)(entity_t*)) create_ld_ident = func; } +static bool declaration_is_definition(const entity_t *entity) +{ + switch (entity->kind) { + case ENTITY_VARIABLE: + return entity->declaration.storage_class != STORAGE_CLASS_EXTERN; + case ENTITY_FUNCTION: + return entity->function.body != NULL; + case ENTITY_PARAMETER: + case ENTITY_COMPOUND_MEMBER: + return false; + case ENTITY_TYPEDEF: + case ENTITY_ENUM: + case ENTITY_ENUM_VALUE: + case ENTITY_NAMESPACE: + case ENTITY_LABEL: + case ENTITY_LOCAL_LABEL: + break; + } + panic("entity is not a declaration"); +} + /** * Handle GNU attributes for entities * @@ -876,17 +898,25 @@ static void handle_decl_modifiers(ir_entity *irentity, entity_t *entity) decl_modifiers_t modifiers = entity->declaration.modifiers; if (is_method_entity(irentity)) { - if (modifiers & DM_PURE) { - set_entity_additional_properties(irentity, mtp_property_pure); - } - if (modifiers & DM_CONST) { + if (modifiers & DM_PURE) + add_entity_additional_properties(irentity, mtp_property_pure); + if (modifiers & DM_CONST) add_entity_additional_properties(irentity, mtp_property_const); - } - } - if (modifiers & DM_USED) { + if (modifiers & DM_NOINLINE) + add_entity_additional_properties(irentity, mtp_property_noinline); + if (modifiers & DM_FORCEINLINE) + add_entity_additional_properties(irentity, mtp_property_always_inline); + if (modifiers & DM_NAKED) + add_entity_additional_properties(irentity, mtp_property_naked); + if (entity->kind == ENTITY_FUNCTION && entity->function.is_inline) + add_entity_additional_properties(irentity, + mtp_property_inline_recommended); + } + if ((modifiers & DM_USED) && declaration_is_definition(entity)) { add_entity_linkage(irentity, IR_LINKAGE_HIDDEN_USER); } - if (modifiers & DM_WEAK) { + if ((modifiers & DM_WEAK) && declaration_is_definition(entity) + && entity->declaration.storage_class != STORAGE_CLASS_EXTERN) { add_entity_linkage(irentity, IR_LINKAGE_WEAK); } } @@ -929,29 +959,13 @@ static ir_entity *get_function_entity(entity_t *entity, ir_type *owner_type) return NULL; } - if (is_main(entity)) { - /* force main to C linkage */ - type_t *type = entity->declaration.type; - assert(is_type_function(type)); - if (type->function.linkage != LINKAGE_C) { - type_t *new_type = duplicate_type(type); - new_type->function.linkage = LINKAGE_C; - type = identify_new_type(new_type); - entity->declaration.type = type; - } - } - symbol_t *symbol = entity->base.symbol; ident *id = new_id_from_str(symbol->string); /* already an entity defined? */ ir_entity *irentity = entitymap_get(&entitymap, symbol); - bool const has_body = entity->function.statement != NULL; + bool const has_body = entity->function.body != NULL; if (irentity != NULL) { - if (get_entity_visibility(irentity) == ir_visibility_external - && has_body) { - set_entity_visibility(irentity, ir_visibility_default); - } goto entity_created; } @@ -980,24 +994,22 @@ static ir_entity *get_function_entity(entity_t *entity, ir_type *owner_type) handle_decl_modifiers(irentity, entity); if (! nested_function) { - /* static inline => local - * extern inline => local - * inline without definition => local - * inline with definition => external_visible */ storage_class_tag_t const storage_class = (storage_class_tag_t) entity->declaration.storage_class; - bool const is_inline = entity->function.is_inline; - - if (is_inline && storage_class == STORAGE_CLASS_NONE && has_body) { - set_entity_visibility(irentity, ir_visibility_default); - } else if (storage_class == STORAGE_CLASS_STATIC || - (is_inline && has_body)) { + if (storage_class == STORAGE_CLASS_STATIC) { set_entity_visibility(irentity, ir_visibility_local); - } else if (has_body) { - set_entity_visibility(irentity, ir_visibility_default); } else { set_entity_visibility(irentity, ir_visibility_external); } + + bool const is_inline = entity->function.is_inline; + if (is_inline && has_body) { + if (((c_mode & _C99) && storage_class == STORAGE_CLASS_NONE) + || ((c_mode & _C99) == 0 + && storage_class == STORAGE_CLASS_EXTERN)) { + add_entity_linkage(irentity, IR_LINKAGE_NO_CODEGEN); + } + } } else { /* nested functions are always local */ set_entity_visibility(irentity, ir_visibility_local); @@ -1108,47 +1120,6 @@ static ir_node *create_conv(dbg_info *dbgi, ir_node *value, ir_mode *dest_mode) return new_d_Conv(dbgi, value, dest_mode); } -/** - * Creates a SymConst node representing a wide string literal. - * - * @param literal the wide string literal - */ -static ir_node *wide_string_literal_to_firm( - const string_literal_expression_t *literal) -{ - ir_type *const global_type = get_glob_type(); - ir_type *const elem_type = ir_type_wchar_t; - dbg_info *const dbgi = get_dbg_info(&literal->base.source_position); - ir_type *const type = new_type_array(1, elem_type); - - ident *const id = id_unique("str.%u"); - ir_entity *const entity = new_d_entity(global_type, id, type, dbgi); - set_entity_ld_ident(entity, id); - set_entity_visibility(entity, ir_visibility_private); - add_entity_linkage(entity, IR_LINKAGE_CONSTANT); - - ir_mode *const mode = get_type_mode(elem_type); - const size_t slen = wstrlen(&literal->value); - - set_array_lower_bound_int(type, 0, 0); - set_array_upper_bound_int(type, 0, slen); - set_type_size_bytes(type, slen * get_mode_size_bytes(mode)); - set_type_state(type, layout_fixed); - - ir_initializer_t *initializer = create_initializer_compound(slen); - const char *p = literal->value.begin; - for (size_t i = 0; i < slen; ++i) { - assert(p < literal->value.begin + literal->value.size); - utf32 v = read_utf8_char(&p); - ir_tarval *tv = new_tarval_from_long(v, mode); - ir_initializer_t *val = create_initializer_tarval(tv); - set_initializer_compound_value(initializer, i, val); - } - set_entity_initializer(entity, initializer); - - return create_symconst(dbgi, entity); -} - /** * Creates a SymConst node representing a string constant. * @@ -1156,53 +1127,74 @@ static ir_node *wide_string_literal_to_firm( * @param id_prefix a prefix for the name of the generated string constant * @param value the value of the string constant */ -static ir_node *string_to_firm(const source_position_t *const src_pos, - const char *const id_prefix, - const string_t *const value) -{ - ir_type *const global_type = get_glob_type(); - dbg_info *const dbgi = get_dbg_info(src_pos); - ir_type *const type = new_type_array(1, ir_type_const_char); - - ident *const id = id_unique(id_prefix); - ir_entity *const entity = new_d_entity(global_type, id, type, dbgi); - set_entity_ld_ident(entity, id); - set_entity_visibility(entity, ir_visibility_private); - add_entity_linkage(entity, IR_LINKAGE_CONSTANT); - - ir_type *const elem_type = ir_type_const_char; - ir_mode *const mode = get_type_mode(elem_type); +static ir_node *string_to_firm(source_position_t const *const src_pos, char const *const id_prefix, string_t const *const value) +{ + size_t const slen = get_string_len(value) + 1; + ir_initializer_t *const initializer = create_initializer_compound(slen); + ir_type * elem_type; + switch (value->encoding) { + case STRING_ENCODING_CHAR: + case STRING_ENCODING_UTF8: { + elem_type = ir_type_char; + + ir_mode *const mode = get_type_mode(elem_type); + char const *p = value->begin; + for (size_t i = 0; i < slen; ++i) { + ir_tarval *tv = new_tarval_from_long(*p++, mode); + ir_initializer_t *val = create_initializer_tarval(tv); + set_initializer_compound_value(initializer, i, val); + } + goto finish; + } - const char* const string = value->begin; - const size_t slen = value->size; + { + type_t *type; + case STRING_ENCODING_CHAR16: type = type_char16_t; goto init_wide; + case STRING_ENCODING_CHAR32: type = type_char32_t; goto init_wide; + case STRING_ENCODING_WIDE: type = type_wchar_t; goto init_wide; +init_wide:; + elem_type = get_ir_type(type); + + ir_mode *const mode = get_type_mode(elem_type); + char const *p = value->begin; + for (size_t i = 0; i < slen; ++i) { + assert(p <= value->begin + value->size); + utf32 v = read_utf8_char(&p); + ir_tarval *tv = new_tarval_from_long(v, mode); + ir_initializer_t *val = create_initializer_tarval(tv); + set_initializer_compound_value(initializer, i, val); + } + goto finish; + } + } + panic("invalid string encoding"); - set_array_lower_bound_int(type, 0, 0); - set_array_upper_bound_int(type, 0, slen); - set_type_size_bytes(type, slen); - set_type_state(type, layout_fixed); +finish:; + ir_type *const type = new_type_array(1, elem_type); + set_array_bounds_int(type, 0, 0, slen); + set_type_size_bytes( type, slen * get_type_size_bytes(elem_type)); + set_type_state( type, layout_fixed); - ir_initializer_t *initializer = create_initializer_compound(slen); - for (size_t i = 0; i < slen; ++i) { - ir_tarval *tv = new_tarval_from_long(string[i], mode); - ir_initializer_t *val = create_initializer_tarval(tv); - set_initializer_compound_value(initializer, i, val); - } + ir_type *const global_type = get_glob_type(); + ident *const id = id_unique(id_prefix); + dbg_info *const dbgi = get_dbg_info(src_pos); + ir_entity *const entity = new_d_entity(global_type, id, type, dbgi); + set_entity_ld_ident( entity, id); + set_entity_visibility( entity, ir_visibility_private); + add_entity_linkage( entity, IR_LINKAGE_CONSTANT); set_entity_initializer(entity, initializer); return create_symconst(dbgi, entity); } -static bool try_create_integer(literal_expression_t *literal, - type_t *type, unsigned char base) +static bool try_create_integer(literal_expression_t *literal, type_t *type) { - const char *string = literal->value.begin; - size_t size = literal->value.size; - assert(type->kind == TYPE_ATOMIC); atomic_type_kind_t akind = type->atomic.akind; - ir_mode *mode = atomic_modes[akind]; - ir_tarval *tv = new_integer_tarval_from_str(string, size, 1, base, mode); + ir_mode *const mode = atomic_modes[akind]; + char const *const str = literal->value.begin; + ir_tarval *const tv = new_tarval_from_str(str, literal->suffix - str, mode); if (tv == tarval_bad) return false; @@ -1211,55 +1203,39 @@ static bool try_create_integer(literal_expression_t *literal, return true; } -static void create_integer_tarval(literal_expression_t *literal) +void determine_literal_type(literal_expression_t *const literal) { - unsigned us = 0; - unsigned ls = 0; - const string_t *suffix = &literal->suffix; - /* parse suffix */ - if (suffix->size > 0) { - for (const char *c = suffix->begin; *c != '\0'; ++c) { - if (*c == 'u' || *c == 'U') { ++us; } - if (*c == 'l' || *c == 'L') { ++ls; } - } - } + assert(literal->base.kind == EXPR_LITERAL_INTEGER); - unsigned base; - switch (literal->base.kind) { - case EXPR_LITERAL_INTEGER_OCTAL: base = 8; break; - case EXPR_LITERAL_INTEGER: base = 10; break; - case EXPR_LITERAL_INTEGER_HEXADECIMAL: base = 16; break; - default: panic("invalid literal kind"); - } + /* -1: signed only, 0: any, 1: unsigned only */ + int const sign = + !is_type_signed(literal->base.type) ? 1 : + literal->value.begin[0] == '0' ? 0 : + -1; /* Decimal literals only try signed types. */ tarval_int_overflow_mode_t old_mode = tarval_get_integer_overflow_mode(); + tarval_set_integer_overflow_mode(TV_OVERFLOW_BAD); + + if (try_create_integer(literal, literal->base.type)) + goto finished; /* now try if the constant is small enough for some types */ - tarval_set_integer_overflow_mode(TV_OVERFLOW_BAD); - if (ls < 1) { - if (us == 0 && try_create_integer(literal, type_int, base)) - goto finished; - if ((us == 1 || base != 10) - && try_create_integer(literal, type_unsigned_int, base)) - goto finished; - } - if (ls < 2) { - if (us == 0 && try_create_integer(literal, type_long, base)) - goto finished; - if ((us == 1 || base != 10) - && try_create_integer(literal, type_unsigned_long, base)) - goto finished; - } + if (sign >= 0 && try_create_integer(literal, type_unsigned_int)) + goto finished; + if (sign <= 0 && try_create_integer(literal, type_long)) + goto finished; + if (sign >= 0 && try_create_integer(literal, type_unsigned_long)) + goto finished; /* last try? then we should not report tarval_bad */ - if (us != 1 && base == 10) + if (sign < 0) tarval_set_integer_overflow_mode(TV_OVERFLOW_WRAP); - if (us == 0 && try_create_integer(literal, type_long_long, base)) + if (sign <= 0 && try_create_integer(literal, type_long_long)) goto finished; /* last try */ - assert(us == 1 || base != 10); + assert(sign >= 0); tarval_set_integer_overflow_mode(TV_OVERFLOW_WRAP); - bool res = try_create_integer(literal, type_unsigned_long_long, base); + bool res = try_create_integer(literal, type_unsigned_long_long); if (!res) panic("internal error when parsing number literal"); @@ -1267,23 +1243,51 @@ finished: tarval_set_integer_overflow_mode(old_mode); } -void determine_literal_type(literal_expression_t *literal) +/** + * Creates a Const node representing a constant. + */ +static ir_node *literal_to_firm(const literal_expression_t *literal) { + type_t *type = skip_typeref(literal->base.type); + ir_mode *mode = get_ir_mode_storage(type); + const char *string = literal->value.begin; + size_t size = literal->value.size; + ir_tarval *tv; + switch (literal->base.kind) { case EXPR_LITERAL_INTEGER: - case EXPR_LITERAL_INTEGER_OCTAL: - case EXPR_LITERAL_INTEGER_HEXADECIMAL: - create_integer_tarval(literal); - return; - default: + assert(literal->target_value != NULL); + tv = literal->target_value; + break; + + case EXPR_LITERAL_FLOATINGPOINT: + tv = new_tarval_from_str(string, size, mode); + break; + + case EXPR_LITERAL_BOOLEAN: + if (string[0] == 't') { + tv = get_mode_one(mode); + } else { + assert(string[0] == 'f'); + case EXPR_LITERAL_MS_NOOP: + tv = get_mode_null(mode); + } break; + + default: + panic("invalid literal kind"); } + + dbg_info *dbgi = get_dbg_info(&literal->base.source_position); + ir_node *res = new_d_Const(dbgi, tv); + ir_mode *mode_arith = get_ir_mode_arithmetic(type); + return create_conv(dbgi, res, mode_arith); } /** - * Creates a Const node representing a constant. + * Creates a Const node representing a character constant. */ -static ir_node *literal_to_firm(const literal_expression_t *literal) +static ir_node *char_literal_to_firm(string_literal_expression_t const *literal) { type_t *type = skip_typeref(literal->base.type); ir_mode *mode = get_ir_mode_storage(type); @@ -1291,16 +1295,17 @@ static ir_node *literal_to_firm(const literal_expression_t *literal) size_t size = literal->value.size; ir_tarval *tv; - switch (literal->base.kind) { - case EXPR_LITERAL_WIDE_CHARACTER: { + switch (literal->value.encoding) { + case STRING_ENCODING_WIDE: { utf32 v = read_utf8_char(&string); char buf[128]; size_t len = snprintf(buf, sizeof(buf), UTF32_PRINTF_FORMAT, v); tv = new_tarval_from_str(buf, len, mode); - goto make_const; + break; } - case EXPR_LITERAL_CHARACTER: { + + case STRING_ENCODING_CHAR: { long long int v; bool char_is_signed = get_atomic_type_flags(ATOMIC_TYPE_CHAR) & ATOMIC_TYPE_FLAG_SIGNED; @@ -1316,41 +1321,13 @@ static ir_node *literal_to_firm(const literal_expression_t *literal) size_t len = snprintf(buf, sizeof(buf), "%lld", v); tv = new_tarval_from_str(buf, len, mode); - goto make_const; - } - case EXPR_LITERAL_INTEGER: - case EXPR_LITERAL_INTEGER_OCTAL: - case EXPR_LITERAL_INTEGER_HEXADECIMAL: - assert(literal->target_value != NULL); - tv = literal->target_value; - goto make_const; - case EXPR_LITERAL_FLOATINGPOINT: - tv = new_tarval_from_str(string, size, mode); - goto make_const; - case EXPR_LITERAL_FLOATINGPOINT_HEXADECIMAL: { - char buffer[size + 2]; - memcpy(buffer, "0x", 2); - memcpy(buffer+2, string, size); - tv = new_tarval_from_str(buffer, size+2, mode); - goto make_const; + break; } - case EXPR_LITERAL_BOOLEAN: - if (string[0] == 't') { - tv = get_mode_one(mode); - } else { - assert(string[0] == 'f'); - tv = get_mode_null(mode); - } - goto make_const; - case EXPR_LITERAL_MS_NOOP: - tv = get_mode_null(mode); - goto make_const; + default: - break; + panic("invalid literal kind"); } - panic("Invalid literal kind found"); -make_const: ; dbg_info *dbgi = get_dbg_info(&literal->base.source_position); ir_node *res = new_d_Const(dbgi, tv); ir_mode *mode_arith = get_ir_mode_arithmetic(type); @@ -1474,32 +1451,6 @@ static ir_node *deref_address(dbg_info *const dbgi, type_t *const type, return create_conv(dbgi, load_res, mode_arithmetic); } -/** - * Creates a strict Conv (to the node's mode) if necessary. - * - * @param dbgi debug info - * @param node the node to strict conv - */ -static ir_node *do_strict_conv(dbg_info *dbgi, ir_node *node) -{ - ir_mode *mode = get_irn_mode(node); - - if (!(get_irg_fp_model(current_ir_graph) & fp_explicit_rounding)) - return node; - if (!mode_is_float(mode)) - return node; - - /* check if there is already a Conv */ - if (is_Conv(node)) { - /* convert it into a strict Conv */ - set_Conv_strict(node, 1); - return node; - } - - /* otherwise create a new one */ - return new_d_strictConv(dbgi, node, mode); -} - /** * Returns the correct base address depending on whether it is a parameter or a * normal local variable. @@ -1517,16 +1468,13 @@ static ir_node *get_local_frame(ir_entity *const ent) } /** - * Keep all memory edges of the given block. + * Keep the current block and memory. + * This is necessary for all loops, because they could become infinite. */ -static void keep_all_memory(ir_node *block) +static void keep_loop(void) { - ir_node *old = get_cur_block(); - - set_cur_block(block); + keep_alive(get_cur_block()); keep_alive(get_store()); - /* TODO: keep all memory edges from restricted pointers */ - set_cur_block(old); } static ir_node *enum_constant_to_firm(reference_expression_t const *const ref) @@ -1541,15 +1489,11 @@ static ir_node *enum_constant_to_firm(reference_expression_t const *const ref) return new_Const(entity->enum_value.tv); } -static ir_node *reference_expression_to_firm(const reference_expression_t *ref) +static ir_node *reference_addr(const reference_expression_t *ref) { dbg_info *dbgi = get_dbg_info(&ref->base.source_position); entity_t *entity = ref->entity; assert(is_declaration(entity)); - type_t *type = skip_typeref(entity->declaration.type); - - /* make sure the type is constructed */ - (void) get_ir_type(type); if (entity->kind == ENTITY_FUNCTION && entity->function.btk != BUILTIN_NONE) { @@ -1558,8 +1502,7 @@ static ir_node *reference_expression_to_firm(const reference_expression_t *ref) * builtins which don't have entities */ if (irentity == NULL) { source_position_t const *const pos = &ref->base.source_position; - symbol_t const *const sym = ref->entity->base.symbol; - warningf(WARN_OTHER, pos, "taking address of builtin '%Y'", sym); + warningf(WARN_OTHER, pos, "taking address of builtin '%N'", ref->entity); /* simply create a NULL pointer */ ir_mode *mode = get_ir_mode_arithmetic(type_void_ptr); @@ -1569,68 +1512,6 @@ static ir_node *reference_expression_to_firm(const reference_expression_t *ref) } } - switch ((declaration_kind_t) entity->declaration.kind) { - case DECLARATION_KIND_UNKNOWN: - break; - - case DECLARATION_KIND_LOCAL_VARIABLE: { - ir_mode *const mode = get_ir_mode_storage(type); - ir_node *const value = get_value(entity->variable.v.value_number, mode); - return create_conv(NULL, value, get_ir_mode_arithmetic(type)); - } - case DECLARATION_KIND_PARAMETER: { - ir_mode *const mode = get_ir_mode_storage(type); - ir_node *const value = get_value(entity->parameter.v.value_number,mode); - return create_conv(NULL, value, get_ir_mode_arithmetic(type)); - } - case DECLARATION_KIND_FUNCTION: { - return create_symconst(dbgi, entity->function.irentity); - } - case DECLARATION_KIND_INNER_FUNCTION: { - ir_mode *const mode = get_ir_mode_storage(type); - if (!entity->function.goto_to_outer && !entity->function.need_closure) { - /* inner function not using the closure */ - return create_symconst(dbgi, entity->function.irentity); - } else { - /* need trampoline here */ - return create_trampoline(dbgi, mode, entity->function.irentity); - } - } - case DECLARATION_KIND_GLOBAL_VARIABLE: { - const variable_t *variable = &entity->variable; - ir_node *const addr = create_symconst(dbgi, variable->v.entity); - return deref_address(dbgi, variable->base.type, addr); - } - - case DECLARATION_KIND_LOCAL_VARIABLE_ENTITY: { - ir_entity *irentity = entity->variable.v.entity; - ir_node *frame = get_local_frame(irentity); - ir_node *sel = new_d_simpleSel(dbgi, new_NoMem(), frame, irentity); - return deref_address(dbgi, entity->declaration.type, sel); - } - case DECLARATION_KIND_PARAMETER_ENTITY: { - ir_entity *irentity = entity->parameter.v.entity; - ir_node *frame = get_local_frame(irentity); - ir_node *sel = new_d_simpleSel(dbgi, new_NoMem(), frame, irentity); - return deref_address(dbgi, entity->declaration.type, sel); - } - - case DECLARATION_KIND_VARIABLE_LENGTH_ARRAY: - return entity->variable.v.vla_base; - - case DECLARATION_KIND_COMPOUND_MEMBER: - panic("not implemented reference type"); - } - - panic("reference to declaration with unknown type found"); -} - -static ir_node *reference_addr(const reference_expression_t *ref) -{ - dbg_info *dbgi = get_dbg_info(&ref->base.source_position); - entity_t *entity = ref->entity; - assert(is_declaration(entity)); - switch((declaration_kind_t) entity->declaration.kind) { case DECLARATION_KIND_UNKNOWN: break; @@ -1643,18 +1524,12 @@ static ir_node *reference_addr(const reference_expression_t *ref) ir_node *const addr = create_symconst(dbgi, entity->variable.v.entity); return addr; } - case DECLARATION_KIND_LOCAL_VARIABLE_ENTITY: { - ir_entity *irentity = entity->variable.v.entity; - ir_node *frame = get_local_frame(irentity); - ir_node *sel = new_d_simpleSel(dbgi, new_NoMem(), frame, irentity); - return sel; - } + case DECLARATION_KIND_LOCAL_VARIABLE_ENTITY: case DECLARATION_KIND_PARAMETER_ENTITY: { - ir_entity *irentity = entity->parameter.v.entity; + ir_entity *irentity = entity->variable.v.entity; ir_node *frame = get_local_frame(irentity); ir_node *sel = new_d_simpleSel(dbgi, new_NoMem(), frame, irentity); - return sel; } @@ -1681,7 +1556,29 @@ static ir_node *reference_addr(const reference_expression_t *ref) panic("not implemented reference type"); } - panic("reference to declaration with unknown type found"); + panic("reference to declaration with unknown type"); +} + +static ir_node *reference_expression_to_firm(const reference_expression_t *ref) +{ + dbg_info *const dbgi = get_dbg_info(&ref->base.source_position); + entity_t *const entity = ref->entity; + assert(is_declaration(entity)); + + switch ((declaration_kind_t)entity->declaration.kind) { + case DECLARATION_KIND_LOCAL_VARIABLE: + case DECLARATION_KIND_PARAMETER: { + type_t *const type = skip_typeref(entity->declaration.type); + ir_mode *const mode = get_ir_mode_storage(type); + ir_node *const value = get_value(entity->variable.v.value_number, mode); + return create_conv(dbgi, value, get_ir_mode_arithmetic(type)); + } + + default: { + ir_node *const addr = reference_addr(ref); + return deref_address(dbgi, entity->declaration.type, addr); + } + } } /** @@ -1773,7 +1670,7 @@ static ir_node *process_builtin_call(const call_expression_t *call) case BUILTIN_LIBC_CHECK: panic("builtin did not produce an entity"); } - panic("invalid builtin found"); + panic("invalid builtin"); } /** @@ -1862,9 +1759,8 @@ static ir_node *call_expression_to_firm(const call_expression_t *const call) type_t *arg_type = skip_typeref(expression->base.type); if (!is_type_compound(arg_type)) { - ir_mode *mode = get_ir_mode_storage(expression->base.type); - arg_node = create_conv(dbgi, arg_node, mode); - arg_node = do_strict_conv(dbgi, arg_node); + ir_mode *const mode = get_ir_mode_storage(arg_type); + arg_node = create_conv(dbgi, arg_node, mode); } in[n] = arg_node; @@ -1929,9 +1825,7 @@ static ir_node *statement_to_firm(statement_t *statement); static ir_node *compound_statement_to_firm(compound_statement_t *compound); static ir_node *expression_to_addr(const expression_t *expression); -static ir_node *create_condition_evaluation(const expression_t *expression, - ir_node *true_block, - ir_node *false_block); +static ir_node *create_condition_evaluation(expression_t const *expression, jump_target *true_target, jump_target *false_target); static void assign_value(dbg_info *dbgi, ir_node *addr, type_t *type, ir_node *value) @@ -1939,7 +1833,6 @@ static void assign_value(dbg_info *dbgi, ir_node *addr, type_t *type, if (!is_type_compound(type)) { ir_mode *mode = get_ir_mode_storage(type); value = create_conv(dbgi, value, mode); - value = do_strict_conv(dbgi, value); } ir_node *memory = get_store(); @@ -2104,7 +1997,6 @@ static ir_node *set_value_for_expression_addr(const expression_t *expression, if (!is_type_compound(type)) { ir_mode *mode = get_ir_mode_storage(type); value = create_conv(dbgi, value, mode); - value = do_strict_conv(dbgi, value); } if (expression->kind == EXPR_REFERENCE) { @@ -2113,12 +2005,10 @@ static ir_node *set_value_for_expression_addr(const expression_t *expression, entity_t *entity = ref->entity; assert(is_declaration(entity)); assert(entity->declaration.kind != DECLARATION_KIND_UNKNOWN); - if (entity->declaration.kind == DECLARATION_KIND_LOCAL_VARIABLE) { + if (entity->declaration.kind == DECLARATION_KIND_LOCAL_VARIABLE || + entity->declaration.kind == DECLARATION_KIND_PARAMETER) { set_value(entity->variable.v.value_number, value); return value; - } else if (entity->declaration.kind == DECLARATION_KIND_PARAMETER) { - set_value(entity->parameter.v.value_number, value); - return value; } } @@ -2164,20 +2054,14 @@ static ir_node *get_value_from_lvalue(const expression_t *expression, || entity->kind == ENTITY_PARAMETER); assert(entity->declaration.kind != DECLARATION_KIND_UNKNOWN); int value_number; - if (entity->declaration.kind == DECLARATION_KIND_LOCAL_VARIABLE) { + if (entity->declaration.kind == DECLARATION_KIND_LOCAL_VARIABLE || + entity->declaration.kind == DECLARATION_KIND_PARAMETER) { value_number = entity->variable.v.value_number; assert(addr == NULL); type_t *type = skip_typeref(expression->base.type); ir_mode *mode = get_ir_mode_storage(type); ir_node *res = get_value(value_number, mode); return create_conv(NULL, res, get_ir_mode_arithmetic(type)); - } else if (entity->declaration.kind == DECLARATION_KIND_PARAMETER) { - value_number = entity->parameter.v.value_number; - assert(addr == NULL); - type_t *type = skip_typeref(expression->base.type); - ir_mode *mode = get_ir_mode_storage(type); - ir_node *res = get_value(value_number, mode); - return create_conv(NULL, res, get_ir_mode_arithmetic(type)); } } @@ -2236,7 +2120,7 @@ static ir_node *create_incdec(const unary_expression_t *expression) store_value = result; break; default: - panic("no incdec expr in create_incdec"); + panic("no incdec expr"); } set_value_for_expression_addr(value_expr, store_value, addr); @@ -2275,7 +2159,7 @@ static ir_relation get_relation(const expression_kind_t kind) default: break; } - panic("trying to get pn_Cmp from non-comparison binexpr type"); + panic("trying to get ir_relation from non-comparison binexpr type"); } /** @@ -2385,7 +2269,7 @@ static ir_node *create_cast(dbg_info *dbgi, ir_node *value_node, if (from_var != NULL) { ir_node *const addr = create_symconst(dbgi, from_var->v.entity); ir_node *const base = deref_address(dbgi, from_var->base.type, addr); - value_node = new_d_Add(dbgi, value_node, base, get_ir_mode_storage(from_type)); + value_node = new_d_Add(dbgi, value_node, base, mode); } if (to_var != NULL) { ir_node *const addr = create_symconst(dbgi, to_var->v.entity); @@ -2403,7 +2287,6 @@ static ir_node *create_cast(dbg_info *dbgi, ir_node *value_node, ir_mode *mode_arith = get_ir_mode_arithmetic(type); ir_node *node = create_conv(dbgi, value_node, mode); - node = do_strict_conv(dbgi, node); node = create_conv(dbgi, node, mode_arith); return node; @@ -2469,7 +2352,7 @@ static ir_node *unary_expression_to_firm(const unary_expression_t *expression) default: break; } - panic("invalid UNEXPR type found"); + panic("invalid unary expression type"); } /** @@ -2478,23 +2361,36 @@ static ir_node *unary_expression_to_firm(const unary_expression_t *expression) static ir_node *produce_condition_result(const expression_t *expression, ir_mode *mode, dbg_info *dbgi) { - ir_node *const one_block = new_immBlock(); - ir_node *const zero_block = new_immBlock(); - create_condition_evaluation(expression, one_block, zero_block); - mature_immBlock(one_block); - mature_immBlock(zero_block); + jump_target true_target; + jump_target false_target; + init_jump_target(&true_target, NULL); + init_jump_target(&false_target, NULL); + create_condition_evaluation(expression, &true_target, &false_target); - ir_node *const jmp_one = new_rd_Jmp(dbgi, one_block); - ir_node *const jmp_zero = new_rd_Jmp(dbgi, zero_block); - ir_node *const in_cf[2] = { jmp_one, jmp_zero }; - ir_node *const block = new_Block(lengthof(in_cf), in_cf); - set_cur_block(block); + ir_node *val = NULL; + jump_target exit_target; + init_jump_target(&exit_target, NULL); - ir_node *const one = new_Const(get_mode_one(mode)); - ir_node *const zero = new_Const(get_mode_null(mode)); - ir_node *const in[2] = { one, zero }; - ir_node *const val = new_d_Phi(dbgi, lengthof(in), in, mode); + if (enter_jump_target(&true_target)) { + val = new_Const(get_mode_one(mode)); + jump_to_target(&exit_target); + } + + if (enter_jump_target(&false_target)) { + ir_node *const zero = new_Const(get_mode_null(mode)); + jump_to_target(&exit_target); + if (val) { + ir_node *const in[] = { val, zero }; + val = new_rd_Phi(dbgi, exit_target.block, lengthof(in), in, mode); + } else { + val = zero; + } + } + if (!enter_jump_target(&exit_target)) { + set_cur_block(new_Block(0, NULL)); + val = new_Unknown(mode); + } return val; } @@ -2612,7 +2508,6 @@ normal_node: case EXPR_BINARY_MOD: case EXPR_BINARY_MOD_ASSIGN: { ir_node *pin = new_Pin(new_NoMem()); - assert(!mode_is_float(mode)); ir_node *op = new_d_Mod(dbgi, pin, left, right, mode, op_pin_state_floats); ir_node *res = new_d_Proj(dbgi, op, mode, pn_Mod_res); @@ -2669,7 +2564,6 @@ static ir_node *create_assign_binop(const binary_expression_t *expression) ir_node *result = create_op(dbgi, expression, left, right); result = create_cast(dbgi, result, expression->right->base.type, type); - result = do_strict_conv(dbgi, result); result = set_value_for_expression_addr(left_expr, result, left_addr); @@ -2753,7 +2647,7 @@ static ir_node *binary_expression_to_firm(const binary_expression_t *expression) case EXPR_BINARY_SHIFTRIGHT_ASSIGN: return create_assign_binop(expression); default: - panic("TODO binexpr type"); + panic("invalid binexpr type"); } } @@ -2798,12 +2692,7 @@ static long get_offsetof_offset(const offsetof_expression_t *expression) compound_t *compound = type->compound.compound; entity_t *iter = compound->members.entities; - for ( ; iter != NULL; iter = iter->base.next) { - if (iter->base.symbol == symbol) { - break; - } - } - assert(iter != NULL); + for (; iter->base.symbol != symbol; iter = iter->base.next) {} assert(iter->kind == ENTITY_COMPOUND_MEMBER); assert(iter->declaration.kind == DECLARATION_KIND_COMPOUND_MEMBER); @@ -2849,13 +2738,9 @@ static ir_entity *create_initializer_entity(dbg_info *dbgi, type_t *type) { /* create the ir_initializer */ - ir_graph *const old_current_ir_graph = current_ir_graph; - current_ir_graph = get_const_code_irg(); - + PUSH_IRG(get_const_code_irg()); ir_initializer_t *irinitializer = create_ir_initializer(initializer, type); - - assert(current_ir_graph == get_const_code_irg()); - current_ir_graph = old_current_ir_graph; + POP_IRG(); ident *const id = id_unique("initializer.%u"); ir_type *const irtype = get_ir_type(type); @@ -2954,12 +2839,7 @@ static ir_node *alignof_to_firm(const typeprop_expression_t *expression) if (tp_expression != NULL) { entity_t *entity = get_expression_entity(tp_expression); if (entity != NULL) { - if (entity->kind == ENTITY_FUNCTION) { - /* a gnu-extension */ - alignment = 1; - } else { - alignment = get_cparser_entity_alignment(entity); - } + alignment = get_cparser_entity_alignment(entity); } } @@ -2976,7 +2856,7 @@ static ir_node *alignof_to_firm(const typeprop_expression_t *expression) static void init_ir_types(void); -static ir_tarval *fold_constant_to_tarval(const expression_t *expression) +ir_tarval *fold_constant_to_tarval(const expression_t *expression) { assert(is_constant_expression(expression) == EXPR_CLASS_CONSTANT); @@ -2989,11 +2869,10 @@ static ir_tarval *fold_constant_to_tarval(const expression_t *expression) init_ir_types(); - ir_graph *old_current_ir_graph = current_ir_graph; - current_ir_graph = get_const_code_irg(); + PUSH_IRG(get_const_code_irg()); + ir_node *const cnst = _expression_to_firm(expression); + POP_IRG(); - ir_node *cnst = expression_to_firm(expression); - current_ir_graph = old_current_ir_graph; set_optimize(old_optimize); set_opt_constant_folding(old_constant_folding); @@ -3003,7 +2882,9 @@ static ir_tarval *fold_constant_to_tarval(const expression_t *expression) constant_folding = constant_folding_old; - return get_Const_tarval(cnst); + ir_tarval *const tv = get_Const_tarval(cnst); + ir_mode *const mode = get_ir_mode_arithmetic(skip_typeref(expression->base.type)); + return tarval_convert_to(tv, mode); } /* this function is only used in parser.c, but it relies on libfirm functionality */ @@ -3031,8 +2912,6 @@ bool fold_constant_to_bool(const expression_t *expression) static ir_node *conditional_to_firm(const conditional_expression_t *expression) { - dbg_info *const dbgi = get_dbg_info(&expression->base.source_position); - /* first try to fold a constant condition */ if (is_constant_expression(expression->condition) == EXPR_CLASS_CONSTANT) { bool val = fold_constant_to_bool(expression->condition); @@ -3046,43 +2925,47 @@ static ir_node *conditional_to_firm(const conditional_expression_t *expression) } } - ir_node *const true_block = new_immBlock(); - ir_node *const false_block = new_immBlock(); - ir_node *const cond_expr = create_condition_evaluation(expression->condition, true_block, false_block); - mature_immBlock(true_block); - mature_immBlock(false_block); - - set_cur_block(true_block); - ir_node *true_val; - if (expression->true_expression != NULL) { - true_val = expression_to_firm(expression->true_expression); - } else if (cond_expr != NULL && get_irn_mode(cond_expr) != mode_b) { - true_val = cond_expr; - } else { - /* Condition ended with a short circuit (&&, ||, !) operation or a - * comparison. Generate a "1" as value for the true branch. */ - true_val = new_Const(get_mode_one(mode_Is)); - } - ir_node *const true_jmp = new_d_Jmp(dbgi); + jump_target true_target; + jump_target false_target; + init_jump_target(&true_target, NULL); + init_jump_target(&false_target, NULL); + ir_node *const cond_expr = create_condition_evaluation(expression->condition, &true_target, &false_target); - set_cur_block(false_block); - ir_node *const false_val = expression_to_firm(expression->false_expression); - ir_node *const false_jmp = new_d_Jmp(dbgi); + ir_node *val = NULL; + jump_target exit_target; + init_jump_target(&exit_target, NULL); - /* create the common block */ - ir_node *const in_cf[2] = { true_jmp, false_jmp }; - ir_node *const block = new_Block(lengthof(in_cf), in_cf); - set_cur_block(block); - - /* TODO improve static semantics, so either both or no values are NULL */ - if (true_val == NULL || false_val == NULL) - return NULL; + if (enter_jump_target(&true_target)) { + if (expression->true_expression) { + val = expression_to_firm(expression->true_expression); + } else if (cond_expr && get_irn_mode(cond_expr) != mode_b) { + val = cond_expr; + } else { + /* Condition ended with a short circuit (&&, ||, !) operation or a + * comparison. Generate a "1" as value for the true branch. */ + val = new_Const(get_mode_one(mode_Is)); + } + jump_to_target(&exit_target); + } - ir_node *const in[2] = { true_val, false_val }; - type_t *const type = skip_typeref(expression->base.type); - ir_mode *const mode = get_ir_mode_arithmetic(type); - ir_node *const val = new_d_Phi(dbgi, lengthof(in), in, mode); + if (enter_jump_target(&false_target)) { + ir_node *const false_val = expression_to_firm(expression->false_expression); + jump_to_target(&exit_target); + if (val) { + ir_node *const in[] = { val, false_val }; + dbg_info *const dbgi = get_dbg_info(&expression->base.source_position); + val = new_rd_Phi(dbgi, exit_target.block, lengthof(in), in, get_irn_mode(val)); + } else { + val = false_val; + } + } + if (!enter_jump_target(&exit_target)) { + set_cur_block(new_Block(0, NULL)); + type_t *const type = skip_typeref(expression->base.type); + if (!is_type_void(type)) + val = new_Unknown(get_ir_mode_arithmetic(type)); + } return val; } @@ -3169,11 +3052,6 @@ static ir_node *classify_type_to_firm(const classify_type_expression_t *const ex case TYPE_ATOMIC: { const atomic_type_t *const atomic_type = &type->atomic; switch (atomic_type->akind) { - /* should not be reached */ - case ATOMIC_TYPE_INVALID: - tc = no_type_class; - goto make_const; - /* gcc cannot do that */ case ATOMIC_TYPE_VOID: tc = void_type_class; @@ -3201,7 +3079,7 @@ static ir_node *classify_type_to_firm(const classify_type_expression_t *const ex tc = real_type_class; goto make_const; } - panic("Unexpected atomic type in classify_type_to_firm()."); + panic("Unexpected atomic type."); } case TYPE_COMPLEX: tc = complex_type_class; goto make_const; @@ -3224,7 +3102,7 @@ static ir_node *classify_type_to_firm(const classify_type_expression_t *const ex case TYPE_ERROR: break; } - panic("unexpected TYPE classify_type_to_firm()."); + panic("unexpected type."); } make_const:; @@ -3242,18 +3120,18 @@ static ir_node *function_name_to_firm( case FUNCNAME_PRETTY_FUNCTION: case FUNCNAME_FUNCDNAME: if (current_function_name == NULL) { - const source_position_t *const src_pos = &expr->base.source_position; - const char *name = current_function_entity->base.symbol->string; - const string_t string = { name, strlen(name) + 1 }; + source_position_t const *const src_pos = &expr->base.source_position; + char const *const name = current_function_entity->base.symbol->string; + string_t const string = { name, strlen(name), STRING_ENCODING_CHAR }; current_function_name = string_to_firm(src_pos, "__func__.%u", &string); } return current_function_name; case FUNCNAME_FUNCSIG: if (current_funcsig == NULL) { - const source_position_t *const src_pos = &expr->base.source_position; - ir_entity *ent = get_irg_entity(current_ir_graph); - const char *const name = get_entity_ld_name(ent); - const string_t string = { name, strlen(name) + 1 }; + source_position_t const *const src_pos = &expr->base.source_position; + ir_entity *const ent = get_irg_entity(current_ir_graph); + char const *const name = get_entity_ld_name(ent); + string_t const string = { name, strlen(name), STRING_ENCODING_CHAR }; current_funcsig = string_to_firm(src_pos, "__FUNCSIG__.%u", &string); } return current_funcsig; @@ -3371,24 +3249,14 @@ static ir_node *builtin_types_compatible_to_firm( return create_Const_from_bool(mode, value); } -static ir_node *get_label_block(label_t *label) +static void prepare_label_target(label_t *const label) { - if (label->block != NULL) - return label->block; - - /* beware: might be called from create initializer with current_ir_graph - * set to const_code_irg. */ - ir_graph *rem = current_ir_graph; - current_ir_graph = current_function; - - ir_node *block = new_immBlock(); - - label->block = block; - - ARR_APP1(label_t *, all_labels, label); - - current_ir_graph = rem; - return block; + if (label->address_taken && !label->indirect_block) { + ir_node *const iblock = new_immBlock(); + label->indirect_block = iblock; + ARR_APP1(ir_node*, ijmp_blocks, iblock); + jump_from_block_to_target(&label->target, iblock); + } } /** @@ -3397,12 +3265,15 @@ static ir_node *get_label_block(label_t *label) */ static ir_node *label_address_to_firm(const label_address_expression_t *label) { - dbg_info *dbgi = get_dbg_info(&label->base.source_position); - ir_node *block = get_label_block(label->label); - ir_entity *entity = create_Block_entity(block); + /* Beware: Might be called from create initializer with current_ir_graph + * set to const_code_irg. */ + PUSH_IRG(current_function); + prepare_label_target(label->label); + POP_IRG(); symconst_symbol value; - value.entity_p = entity; + value.entity_p = create_Block_entity(label->label->indirect_block); + dbg_info *const dbgi = get_dbg_info(&label->base.source_position); return new_d_SymConst(dbgi, mode_P_code, value, symconst_addr_ent); } @@ -3433,6 +3304,7 @@ static ir_node *_expression_to_firm(expression_t const *const expr) case EXPR_FUNCNAME: return function_name_to_firm( &expr->funcname); case EXPR_LABEL_ADDRESS: return label_address_to_firm( &expr->label_address); case EXPR_LITERAL_CASES: return literal_to_firm( &expr->literal); + case EXPR_LITERAL_CHARACTER: return char_literal_to_firm( &expr->string_literal); case EXPR_OFFSETOF: return offsetof_to_firm( &expr->offsetofe); case EXPR_REFERENCE: return reference_expression_to_firm( &expr->reference); case EXPR_ENUM_CONSTANT: return enum_constant_to_firm( &expr->reference); @@ -3443,13 +3315,12 @@ static ir_node *_expression_to_firm(expression_t const *const expr) case EXPR_VA_ARG: return va_arg_expression_to_firm( &expr->va_arge); case EXPR_VA_COPY: return va_copy_expression_to_firm( &expr->va_copye); case EXPR_VA_START: return va_start_expression_to_firm( &expr->va_starte); - case EXPR_WIDE_STRING_LITERAL: return wide_string_literal_to_firm( &expr->string_literal); - case EXPR_STRING_LITERAL: return string_to_firm(&expr->base.source_position, "str.%u", &expr->literal.value); + case EXPR_STRING_LITERAL: return string_to_firm(&expr->base.source_position, "str.%u", &expr->string_literal.value); case EXPR_ERROR: break; } - panic("invalid expression found"); + panic("invalid expression"); } /** @@ -3512,13 +3383,7 @@ static ir_node *expression_to_firm(const expression_t *expression) } if (is_constant_expression(expression) == EXPR_CLASS_CONSTANT) { - bool const constant_folding_old = constant_folding; - constant_folding = true; - ir_node *res = _expression_to_firm(expression); - constant_folding = constant_folding_old; - ir_mode *mode = get_ir_mode_arithmetic(expression->base.type); - assert(is_Const(res)); - return create_Const_from_bool(mode, !is_Const_null(res)); + return new_Const(fold_constant_to_tarval(expression)); } /* we have to produce a 0/1 from the mode_b expression */ @@ -3531,65 +3396,61 @@ static ir_node *expression_to_firm(const expression_t *expression) * create a short-circuit expression evaluation that tries to construct * efficient control flow structures for &&, || and ! expressions */ -static ir_node *create_condition_evaluation(const expression_t *expression, - ir_node *true_block, - ir_node *false_block) +static ir_node *create_condition_evaluation(expression_t const *const expression, jump_target *const true_target, jump_target *const false_target) { switch(expression->kind) { case EXPR_UNARY_NOT: { const unary_expression_t *unary_expression = &expression->unary; - create_condition_evaluation(unary_expression->value, false_block, - true_block); + create_condition_evaluation(unary_expression->value, false_target, true_target); return NULL; } case EXPR_BINARY_LOGICAL_AND: { - const binary_expression_t *binary_expression = &expression->binary; - - ir_node *extra_block = new_immBlock(); - create_condition_evaluation(binary_expression->left, extra_block, - false_block); - mature_immBlock(extra_block); - set_cur_block(extra_block); - create_condition_evaluation(binary_expression->right, true_block, - false_block); + jump_target extra_target; + init_jump_target(&extra_target, NULL); + create_condition_evaluation(expression->binary.left, &extra_target, false_target); + if (enter_jump_target(&extra_target)) + create_condition_evaluation(expression->binary.right, true_target, false_target); return NULL; } case EXPR_BINARY_LOGICAL_OR: { - const binary_expression_t *binary_expression = &expression->binary; - - ir_node *extra_block = new_immBlock(); - create_condition_evaluation(binary_expression->left, true_block, - extra_block); - mature_immBlock(extra_block); - set_cur_block(extra_block); - create_condition_evaluation(binary_expression->right, true_block, - false_block); + jump_target extra_target; + init_jump_target(&extra_target, NULL); + create_condition_evaluation(expression->binary.left, true_target, &extra_target); + if (enter_jump_target(&extra_target)) + create_condition_evaluation(expression->binary.right, true_target, false_target); return NULL; } default: break; } - dbg_info *dbgi = get_dbg_info(&expression->base.source_position); - ir_node *cond_expr = _expression_to_firm(expression); - ir_node *condition = create_conv(dbgi, cond_expr, mode_b); - ir_node *cond = new_d_Cond(dbgi, condition); - ir_node *true_proj = new_d_Proj(dbgi, cond, mode_X, pn_Cond_true); - ir_node *false_proj = new_d_Proj(dbgi, cond, mode_X, pn_Cond_false); - - /* set branch prediction info based on __builtin_expect */ - if (is_builtin_expect(expression) && is_Cond(cond)) { - call_argument_t *argument = expression->call.arguments->next; - if (is_constant_expression(argument->expression) == EXPR_CLASS_CONSTANT) { - bool const cnst = fold_constant_to_bool(argument->expression); - cond_jmp_predicate const pred = cnst ? COND_JMP_PRED_TRUE : COND_JMP_PRED_FALSE; - set_Cond_jmp_pred(cond, pred); + ir_node *cond_expr = _expression_to_firm(expression); + if (is_Const(cond_expr)) { + if (tarval_is_null(get_Const_tarval(cond_expr))) { + jump_to_target(false_target); + } else { + jump_to_target(true_target); + } + } else { + dbg_info *dbgi = get_dbg_info(&expression->base.source_position); + ir_node *condition = create_conv(dbgi, cond_expr, mode_b); + ir_node *cond = new_d_Cond(dbgi, condition); + ir_node *true_proj = new_d_Proj(dbgi, cond, mode_X, pn_Cond_true); + ir_node *false_proj = new_d_Proj(dbgi, cond, mode_X, pn_Cond_false); + + /* set branch prediction info based on __builtin_expect */ + if (is_builtin_expect(expression) && is_Cond(cond)) { + call_argument_t *argument = expression->call.arguments->next; + if (is_constant_expression(argument->expression) == EXPR_CLASS_CONSTANT) { + bool const cnst = fold_constant_to_bool(argument->expression); + cond_jmp_predicate const pred = cnst ? COND_JMP_PRED_TRUE : COND_JMP_PRED_FALSE; + set_Cond_jmp_pred(cond, pred); + } } - } - - add_immBlock_pred(true_block, true_proj); - add_immBlock_pred(false_block, false_proj); + add_pred_to_jump_target(true_target, true_proj); + add_pred_to_jump_target(false_target, false_proj); + } set_unreachable_now(); return cond_expr; } @@ -3778,13 +3639,8 @@ static void walk_designator(type_path_t *path, const designator_t *designator) compound_t *compound = type->compound.compound; entity_t *iter = compound->members.entities; - for ( ; iter != NULL; iter = iter->base.next, ++index) { - if (iter->base.symbol == symbol) { - assert(iter->kind == ENTITY_COMPOUND_MEMBER); - break; - } - } - assert(iter != NULL); + for (; iter->base.symbol != symbol; iter = iter->base.next, ++index) {} + assert(iter->kind == ENTITY_COMPOUND_MEMBER); /* revert previous initialisations of other union elements */ if (type->kind == TYPE_COMPOUND_UNION) { @@ -3813,17 +3669,10 @@ static void walk_designator(type_path_t *path, const designator_t *designator) orig_type = iter->declaration.type; } else { expression_t *array_index = designator->array_index; - assert(designator->array_index != NULL); assert(is_type_array(type)); long index = fold_constant_to_int(array_index); - assert(index >= 0); -#ifndef NDEBUG - if (type->array.size_constant) { - long array_size = type->array.size; - assert(index < array_size); - } -#endif + assert(0 <= index && (!type->array.size_constant || (size_t)index < type->array.size)); top->type = orig_type; top->index = (size_t) index; @@ -3843,7 +3692,7 @@ static void advance_current_object(type_path_t *path) { if (path->invalid) { /* TODO: handle this... */ - panic("invalid initializer in ast2firm (excessive elements)"); + panic("invalid initializer (excessive elements)"); } type_path_entry_t *top = get_type_path_top(path); @@ -3888,11 +3737,20 @@ static void advance_current_object(type_path_t *path) static ir_initializer_t *create_ir_initializer_value( const initializer_value_t *initializer) { - if (is_type_compound(initializer->value->base.type)) { - panic("initializer creation for compounds not implemented yet"); - } - type_t *type = initializer->value->base.type; expression_t *expr = initializer->value; + type_t *type = expr->base.type; + + if (is_type_compound(type)) { + if (expr->kind == EXPR_UNARY_CAST) { + expr = expr->unary.value; + type = expr->base.type; + } + /* must be a compound literal... */ + if (expr->kind != EXPR_COMPOUND_LITERAL) + panic("initializer creation for compounds needs compound literals"); + return create_ir_initializer(expr->compound_literal.initializer, type); + } + ir_node *value = expression_to_firm(expr); ir_mode *mode = get_ir_mode_storage(type); value = create_conv(NULL, value, mode); @@ -3902,15 +3760,10 @@ static ir_initializer_t *create_ir_initializer_value( /** test wether type can be initialized by a string constant */ static bool is_string_type(type_t *type) { - type_t *inner; - if (is_type_pointer(type)) { - inner = skip_typeref(type->pointer.points_to); - } else if(is_type_array(type)) { - inner = skip_typeref(type->array.element_type); - } else { + if (!is_type_array(type)) return false; - } + type_t *const inner = skip_typeref(type->array.element_type); return is_type_integer(inner); } @@ -3933,18 +3786,18 @@ static ir_initializer_t *create_ir_initializer_list( } if (sub_initializer->kind == INITIALIZER_VALUE) { - /* we might have to descend into types until we're at a scalar - * type */ + const expression_t *expr = sub_initializer->value.value; + const type_t *expr_type = skip_typeref(expr->base.type); + /* we might have to descend into types until the types match */ while(true) { type_t *orig_top_type = path.top_type; type_t *top_type = skip_typeref(orig_top_type); - if (is_type_scalar(top_type)) + if (types_compatible(top_type, expr_type)) break; descend_into_subtype(&path); } - } else if (sub_initializer->kind == INITIALIZER_STRING - || sub_initializer->kind == INITIALIZER_WIDE_STRING) { + } else if (sub_initializer->kind == INITIALIZER_STRING) { /* we might have to descend into types until we're at a scalar * type */ while (true) { @@ -3977,58 +3830,42 @@ static ir_initializer_t *create_ir_initializer_list( return result; } -static ir_initializer_t *create_ir_initializer_string( - const initializer_string_t *initializer, type_t *type) +static ir_initializer_t *create_ir_initializer_string(initializer_t const *const init, type_t *type) { type = skip_typeref(type); - size_t string_len = initializer->string.size; - assert(type->kind == TYPE_ARRAY); - assert(type->array.size_constant); - size_t len = type->array.size; - ir_initializer_t *irinitializer = create_initializer_compound(len); - - const char *string = initializer->string.begin; - ir_mode *mode = get_ir_mode_storage(type->array.element_type); - - for (size_t i = 0; i < len; ++i) { - char c = 0; - if (i < string_len) - c = string[i]; - - ir_tarval *tv = new_tarval_from_long(c, mode); - ir_initializer_t *char_initializer = create_initializer_tarval(tv); - - set_initializer_compound_value(irinitializer, i, char_initializer); - } - - return irinitializer; -} - -static ir_initializer_t *create_ir_initializer_wide_string( - const initializer_wide_string_t *initializer, type_t *type) -{ assert(type->kind == TYPE_ARRAY); assert(type->array.size_constant); - size_t len = type->array.size; - size_t string_len = wstrlen(&initializer->string); - ir_initializer_t *irinitializer = create_initializer_compound(len); - - const char *p = initializer->string.begin; - ir_mode *mode = get_type_mode(ir_type_wchar_t); - - for (size_t i = 0; i < len; ++i) { - utf32 c = 0; - if (i < string_len) { - c = read_utf8_char(&p); + string_literal_expression_t const *const str = get_init_string(init); + size_t const str_len = str->value.size; + size_t const arr_len = type->array.size; + ir_initializer_t *const irinit = create_initializer_compound(arr_len); + ir_mode *const mode = get_ir_mode_storage(type->array.element_type); + char const * p = str->value.begin; + switch (str->value.encoding) { + case STRING_ENCODING_CHAR: + case STRING_ENCODING_UTF8: + for (size_t i = 0; i != arr_len; ++i) { + char const c = i < str_len ? *p++ : 0; + ir_tarval *const tv = new_tarval_from_long(c, mode); + ir_initializer_t *const tvinit = create_initializer_tarval(tv); + set_initializer_compound_value(irinit, i, tvinit); } - ir_tarval *tv = new_tarval_from_long(c, mode); - ir_initializer_t *char_initializer = create_initializer_tarval(tv); + break; - set_initializer_compound_value(irinitializer, i, char_initializer); + case STRING_ENCODING_CHAR16: + case STRING_ENCODING_CHAR32: + case STRING_ENCODING_WIDE: + for (size_t i = 0; i != arr_len; ++i) { + utf32 const c = i < str_len ? read_utf8_char(&p) : 0; + ir_tarval *const tv = new_tarval_from_long(c, mode); + ir_initializer_t *const tvinit = create_initializer_tarval(tv); + set_initializer_compound_value(irinit, i, tvinit); + } + break; } - return irinitializer; + return irinit; } static ir_initializer_t *create_ir_initializer( @@ -4036,11 +3873,7 @@ static ir_initializer_t *create_ir_initializer( { switch(initializer->kind) { case INITIALIZER_STRING: - return create_ir_initializer_string(&initializer->string, type); - - case INITIALIZER_WIDE_STRING: - return create_ir_initializer_wide_string(&initializer->wide_string, - type); + return create_ir_initializer_string(initializer, type); case INITIALIZER_LIST: return create_ir_initializer_list(&initializer->list, type); @@ -4049,7 +3882,7 @@ static ir_initializer_t *create_ir_initializer( return create_ir_initializer_value(&initializer->value); case INITIALIZER_DESIGNATOR: - panic("unexpected designator initializer found"); + panic("unexpected designator initializer"); } panic("unknown initializer"); } @@ -4198,7 +4031,7 @@ static void create_dynamic_initializer_sub(ir_initializer_t *initializer, } } - panic("invalid IR_INITIALIZER found"); + panic("invalid ir_initializer"); } static void create_dynamic_initializer(ir_initializer_t *initializer, @@ -4276,10 +4109,8 @@ static void create_variable_initializer(entity_t *entity) type_qualifiers_t tq = get_type_qualifier(type, true); if (initializer->kind == INITIALIZER_VALUE) { - initializer_value_t *initializer_value = &initializer->value; - dbg_info *dbgi = get_dbg_info(&entity->base.source_position); - expression_t *value = initializer_value->value; - type_t *init_type = skip_typeref(value->base.type); + expression_t * value = initializer->value.value; + type_t *const init_type = skip_typeref(value->base.type); if (!is_type_scalar(init_type)) { /* skip convs */ @@ -4292,11 +4123,10 @@ static void create_variable_initializer(entity_t *entity) goto have_initializer; } - ir_node *node = expression_to_firm(initializer_value->value); - - ir_mode *mode = get_ir_mode_storage(init_type); + ir_node * node = expression_to_firm(value); + dbg_info *const dbgi = get_dbg_info(&entity->base.source_position); + ir_mode *const mode = get_ir_mode_storage(init_type); node = create_conv(dbgi, node, mode); - node = do_strict_conv(dbgi, node); if (declaration_kind == DECLARATION_KIND_LOCAL_VARIABLE) { set_value(entity->variable.v.value_number, node); @@ -4363,6 +4193,14 @@ static void allocate_variable_length_array(entity_t *entity) entity->variable.v.vla_base = addr; } +static bool var_needs_entity(variable_t const *const var) +{ + if (var->address_taken) + return true; + type_t *const type = skip_typeref(var->base.type); + return !is_type_scalar(type) || type->base.qualifiers & TYPE_QUALIFIER_VOLATILE; +} + /** * Creates a Firm local variable from a declaration. */ @@ -4371,31 +4209,23 @@ static void create_local_variable(entity_t *entity) assert(entity->kind == ENTITY_VARIABLE); assert(entity->declaration.kind == DECLARATION_KIND_UNKNOWN); - bool needs_entity = entity->variable.address_taken; - type_t *type = skip_typeref(entity->declaration.type); + if (!var_needs_entity(&entity->variable)) { + entity->declaration.kind = DECLARATION_KIND_LOCAL_VARIABLE; + entity->variable.v.value_number = next_value_number_function; + set_irg_loc_description(current_ir_graph, next_value_number_function, entity); + ++next_value_number_function; + return; + } /* is it a variable length array? */ + type_t *const type = skip_typeref(entity->declaration.type); if (is_type_array(type) && !type->array.size_constant) { create_variable_length_array(entity); return; - } else if (is_type_array(type) || is_type_compound(type)) { - needs_entity = true; - } else if (type->base.qualifiers & TYPE_QUALIFIER_VOLATILE) { - needs_entity = true; } - if (needs_entity) { - ir_type *frame_type = get_irg_frame_type(current_ir_graph); - create_variable_entity(entity, - DECLARATION_KIND_LOCAL_VARIABLE_ENTITY, - frame_type); - } else { - entity->declaration.kind = DECLARATION_KIND_LOCAL_VARIABLE; - entity->variable.v.value_number = next_value_number_function; - set_irg_loc_description(current_ir_graph, next_value_number_function, - entity); - ++next_value_number_function; - } + ir_type *const frame_type = get_irg_frame_type(current_ir_graph); + create_variable_entity(entity, DECLARATION_KIND_LOCAL_VARIABLE_ENTITY, frame_type); } static void create_local_static_variable(entity_t *entity) @@ -4425,13 +4255,14 @@ static void create_local_static_variable(entity_t *entity) set_entity_ld_ident(irentity, id); set_entity_visibility(irentity, ir_visibility_local); - ir_graph *const old_current_ir_graph = current_ir_graph; - current_ir_graph = get_const_code_irg(); + if (entity->variable.initializer == NULL) { + ir_initializer_t *null_init = get_initializer_null(); + set_entity_initializer(irentity, null_init); + } + PUSH_IRG(get_const_code_irg()); create_variable_initializer(entity); - - assert(current_ir_graph == get_const_code_irg()); - current_ir_graph = old_current_ir_graph; + POP_IRG(); } @@ -4450,7 +4281,6 @@ static ir_node *return_statement_to_firm(return_statement_t *statement) ir_mode *const mode = get_ir_mode_storage(type); if (res) { res = create_conv(dbgi, res, mode); - res = do_strict_conv(dbgi, res); } else { res = new_Unknown(mode); } @@ -4478,15 +4308,11 @@ static ir_node *expression_statement_to_firm(expression_statement_t *statement) return expression_to_firm(statement->expression); } +static void create_local_declarations(entity_t*); + static ir_node *compound_statement_to_firm(compound_statement_t *compound) { - entity_t *entity = compound->scope.entities; - for ( ; entity != NULL; entity = entity->base.next) { - if (!is_declaration(entity)) - continue; - - create_local_declaration(entity); - } + create_local_declarations(compound->scope.entities); ir_node *result = NULL; statement_t *statement = compound->statements; @@ -4499,36 +4325,44 @@ static ir_node *compound_statement_to_firm(compound_statement_t *compound) static void create_global_variable(entity_t *entity) { - ir_linkage linkage = IR_LINKAGE_DEFAULT; - ir_visibility visibility = ir_visibility_default; - ir_entity *irentity; + ir_linkage linkage = IR_LINKAGE_DEFAULT; + ir_visibility visibility = ir_visibility_external; + storage_class_tag_t storage + = (storage_class_tag_t)entity->declaration.storage_class; + decl_modifiers_t modifiers = entity->declaration.modifiers; assert(entity->kind == ENTITY_VARIABLE); - switch ((storage_class_tag_t)entity->declaration.storage_class) { + switch (storage) { case STORAGE_CLASS_EXTERN: visibility = ir_visibility_external; break; case STORAGE_CLASS_STATIC: visibility = ir_visibility_local; break; - case STORAGE_CLASS_NONE: - visibility = ir_visibility_default; - /* uninitialized globals get merged in C */ - if (entity->variable.initializer == NULL) - linkage |= IR_LINKAGE_MERGE; - break; + case STORAGE_CLASS_NONE: visibility = ir_visibility_external; break; case STORAGE_CLASS_TYPEDEF: case STORAGE_CLASS_AUTO: case STORAGE_CLASS_REGISTER: panic("invalid storage class for global var"); } + /* "common" symbols */ + if (storage == STORAGE_CLASS_NONE + && entity->variable.initializer == NULL + && !entity->variable.thread_local + && (modifiers & DM_WEAK) == 0) { + linkage |= IR_LINKAGE_MERGE; + } + ir_type *var_type = get_glob_type(); if (entity->variable.thread_local) { var_type = get_tls_type(); - /* LINKAGE_MERGE not supported by current linkers */ - linkage &= ~IR_LINKAGE_MERGE; } create_variable_entity(entity, DECLARATION_KIND_GLOBAL_VARIABLE, var_type); - irentity = entity->variable.v.entity; + ir_entity *irentity = entity->variable.v.entity; add_entity_linkage(irentity, linkage); set_entity_visibility(irentity, visibility); + if (entity->variable.initializer == NULL + && storage != STORAGE_CLASS_EXTERN) { + ir_initializer_t *null_init = get_initializer_null(); + set_entity_initializer(irentity, null_init); + } } static void create_local_declaration(entity_t *entity) @@ -4551,7 +4385,7 @@ static void create_local_declaration(entity_t *entity) return; case STORAGE_CLASS_EXTERN: if (entity->kind == ENTITY_FUNCTION) { - assert(entity->function.statement == NULL); + assert(entity->function.body == NULL); (void)get_function_entity(entity, NULL); } else { create_global_variable(entity); @@ -4562,7 +4396,7 @@ static void create_local_declaration(entity_t *entity) case STORAGE_CLASS_AUTO: case STORAGE_CLASS_REGISTER: if (entity->kind == ENTITY_FUNCTION) { - if (entity->function.statement != NULL) { + if (entity->function.body != NULL) { ir_type *owner = get_irg_frame_type(current_ir_graph); (void)get_function_entity(entity, owner); entity->declaration.kind = DECLARATION_KIND_INNER_FUNCTION; @@ -4577,7 +4411,15 @@ static void create_local_declaration(entity_t *entity) case STORAGE_CLASS_TYPEDEF: break; } - panic("invalid storage class found"); + panic("invalid storage class"); +} + +static void create_local_declarations(entity_t *e) +{ + for (; e; e = e->base.next) { + if (is_declaration(e)) + create_local_declaration(e); + } } static void initialize_local_declaration(entity_t *entity) @@ -4643,175 +4485,74 @@ static ir_node *declaration_statement_to_firm(declaration_statement_t *statement static ir_node *if_statement_to_firm(if_statement_t *statement) { + create_local_declarations(statement->scope.entities); + /* Create the condition. */ - ir_node *true_block = NULL; - ir_node *false_block = NULL; - if (currently_reachable()) { - true_block = new_immBlock(); - false_block = new_immBlock(); - create_condition_evaluation(statement->condition, true_block, false_block); - mature_immBlock(true_block); - mature_immBlock(false_block); - } + jump_target true_target; + jump_target false_target; + init_jump_target(&true_target, NULL); + init_jump_target(&false_target, NULL); + if (currently_reachable()) + create_condition_evaluation(statement->condition, &true_target, &false_target); + + jump_target exit_target; + init_jump_target(&exit_target, NULL); /* Create the true statement. */ - set_cur_block(true_block); + enter_jump_target(&true_target); statement_to_firm(statement->true_statement); - ir_node *fallthrough_block = get_cur_block(); + jump_to_target(&exit_target); /* Create the false statement. */ - set_cur_block(false_block); - if (statement->false_statement != NULL) { + enter_jump_target(&false_target); + if (statement->false_statement) statement_to_firm(statement->false_statement); - } - - /* Handle the block after the if-statement. Minor simplification and - * optimisation: Reuse the false/true block as fallthrough block, if the - * true/false statement does not pass control to the fallthrough block, e.g. - * in the typical if (x) return; pattern. */ - if (fallthrough_block) { - if (currently_reachable()) { - ir_node *const t_jump = new_r_Jmp(fallthrough_block); - ir_node *const f_jump = new_Jmp(); - ir_node *const in[] = { t_jump, f_jump }; - fallthrough_block = new_Block(2, in); - } - set_cur_block(fallthrough_block); - } + jump_to_target(&exit_target); + enter_jump_target(&exit_target); return NULL; } -/** - * Add an unconditional jump to the target block. If the source block is not - * reachable, then a Bad predecessor is created to prevent Phi-less unreachable - * loops. This is necessary if the jump potentially enters a loop. - */ -static void jump_to(ir_node *const target_block) -{ - ir_node *const pred = currently_reachable() ? new_Jmp() : new_Bad(mode_X); - add_immBlock_pred(target_block, pred); -} - -/** - * Add an unconditional jump to the target block, if the current block is - * reachable and do nothing otherwise. This is only valid if the jump does not - * enter a loop (a back edge is ok). - */ -static void jump_if_reachable(ir_node *const target_block) +static ir_node *do_while_statement_to_firm(do_while_statement_t *statement) { - if (currently_reachable()) - add_immBlock_pred(target_block, new_Jmp()); -} + create_local_declarations(statement->scope.entities); -static ir_node *while_statement_to_firm(while_statement_t *statement) -{ - /* Create the header block */ - ir_node *const header_block = new_immBlock(); - jump_to(header_block); + PUSH_BREAK(NULL); + PUSH_CONTINUE(NULL); - /* Create the condition. */ - ir_node * body_block; - ir_node * false_block; expression_t *const cond = statement->condition; - if (is_constant_expression(cond) == EXPR_CLASS_CONSTANT && - fold_constant_to_bool(cond)) { - /* Shortcut for while (true). */ - body_block = header_block; - false_block = NULL; - - keep_alive(header_block); - keep_all_memory(header_block); + /* Avoid an explicit body block in case of do ... while (0);. */ + if (is_constant_expression(cond) == EXPR_CLASS_CONSTANT && !fold_constant_to_bool(cond)) { + /* do ... while (0);. */ + statement_to_firm(statement->body); + jump_to_target(&continue_target); + enter_jump_target(&continue_target); + jump_to_target(&break_target); } else { - body_block = new_immBlock(); - false_block = new_immBlock(); - - set_cur_block(header_block); - create_condition_evaluation(cond, body_block, false_block); - mature_immBlock(body_block); - } - - ir_node *const old_continue_label = continue_label; - ir_node *const old_break_label = break_label; - continue_label = header_block; - break_label = false_block; - - /* Create the loop body. */ - set_cur_block(body_block); - statement_to_firm(statement->body); - jump_if_reachable(header_block); - - mature_immBlock(header_block); - assert(false_block == NULL || false_block == break_label); - false_block = break_label; - if (false_block != NULL) { - mature_immBlock(false_block); - } - set_cur_block(false_block); - - assert(continue_label == header_block); - continue_label = old_continue_label; - break_label = old_break_label; - return NULL; -} - -static ir_node *get_break_label(void) -{ - if (break_label == NULL) { - break_label = new_immBlock(); - } - return break_label; -} - -static ir_node *do_while_statement_to_firm(do_while_statement_t *statement) -{ - /* create the header block */ - ir_node *header_block = new_immBlock(); - - /* the loop body */ - ir_node *body_block = new_immBlock(); - jump_to(body_block); - - ir_node *old_continue_label = continue_label; - ir_node *old_break_label = break_label; - continue_label = header_block; - break_label = NULL; - - set_cur_block(body_block); - statement_to_firm(statement->body); - ir_node *const false_block = get_break_label(); - - assert(continue_label == header_block); - continue_label = old_continue_label; - break_label = old_break_label; - - jump_if_reachable(header_block); - - /* create the condition */ - mature_immBlock(header_block); - set_cur_block(header_block); - - create_condition_evaluation(statement->condition, body_block, false_block); - mature_immBlock(body_block); - mature_immBlock(false_block); - - set_cur_block(false_block); + jump_target body_target; + init_jump_target(&body_target, NULL); + jump_to_target(&body_target); + enter_immature_jump_target(&body_target); + keep_loop(); + statement_to_firm(statement->body); + jump_to_target(&continue_target); + if (enter_jump_target(&continue_target)) + create_condition_evaluation(statement->condition, &body_target, &break_target); + enter_jump_target(&body_target); + } + enter_jump_target(&break_target); + + POP_CONTINUE(); + POP_BREAK(); return NULL; } static ir_node *for_statement_to_firm(for_statement_t *statement) { - /* create declarations */ - entity_t *entity = statement->scope.entities; - for ( ; entity != NULL; entity = entity->base.next) { - if (!is_declaration(entity)) - continue; - - create_local_declaration(entity); - } + create_local_declarations(statement->scope.entities); if (currently_reachable()) { - entity = statement->scope.entities; + entity_t *entity = statement->scope.entities; for ( ; entity != NULL; entity = entity->base.next) { if (!is_declaration(entity)) continue; @@ -4825,77 +4566,40 @@ static ir_node *for_statement_to_firm(for_statement_t *statement) } /* Create the header block */ - ir_node *const header_block = new_immBlock(); - jump_to(header_block); + jump_target header_target; + init_jump_target(&header_target, NULL); + jump_to_target(&header_target); + enter_immature_jump_target(&header_target); + keep_loop(); - /* Create the condition. */ - ir_node *body_block; - ir_node *false_block; - if (statement->condition != NULL) { - body_block = new_immBlock(); - false_block = new_immBlock(); - - set_cur_block(header_block); - create_condition_evaluation(statement->condition, body_block, false_block); - mature_immBlock(body_block); - } else { - /* for-ever. */ - body_block = header_block; - false_block = NULL; - - keep_alive(header_block); - keep_all_memory(header_block); - } + expression_t *const step = statement->step; + PUSH_BREAK(NULL); + PUSH_CONTINUE(step ? NULL : header_target.block); - /* Create the step block, if necessary. */ - ir_node * step_block = header_block; - expression_t *const step = statement->step; - if (step != NULL) { - step_block = new_immBlock(); + /* Create the condition. */ + expression_t *const cond = statement->condition; + if (cond && (is_constant_expression(cond) != EXPR_CLASS_CONSTANT || !fold_constant_to_bool(cond))) { + jump_target body_target; + init_jump_target(&body_target, NULL); + create_condition_evaluation(cond, &body_target, &break_target); + enter_jump_target(&body_target); } - ir_node *const old_continue_label = continue_label; - ir_node *const old_break_label = break_label; - continue_label = step_block; - break_label = false_block; - /* Create the loop body. */ - set_cur_block(body_block); statement_to_firm(statement->body); - jump_if_reachable(step_block); + jump_to_target(&continue_target); /* Create the step code. */ - if (step != NULL) { - mature_immBlock(step_block); - set_cur_block(step_block); + if (step && enter_jump_target(&continue_target)) { expression_to_firm(step); - jump_if_reachable(header_block); + jump_to_target(&header_target); } - mature_immBlock(header_block); - assert(false_block == NULL || false_block == break_label); - false_block = break_label; - if (false_block != NULL) { - mature_immBlock(false_block); - } - set_cur_block(false_block); + enter_jump_target(&header_target); + enter_jump_target(&break_target); - assert(continue_label == step_block); - continue_label = old_continue_label; - break_label = old_break_label; - return NULL; -} - -static ir_node *create_jump_statement(const statement_t *statement, ir_node *target_block) -{ - if (!currently_reachable()) - return NULL; - - dbg_info *dbgi = get_dbg_info(&statement->base.source_position); - ir_node *jump = new_d_Jmp(dbgi); - add_immBlock_pred(target_block, jump); - - set_unreachable_now(); + POP_CONTINUE(); + POP_BREAK(); return NULL; } @@ -4923,11 +4627,9 @@ static ir_switch_table *create_switch_table(const switch_statement_t *statement) } if (l->is_empty_range) continue; - ir_tarval *min = fold_constant_to_tarval(l->expression); - ir_tarval *max = min; + ir_tarval *min = l->first_case; + ir_tarval *max = l->last_case; long pn = (long) i+1; - if (l->end_range != NULL) - max = fold_constant_to_tarval(l->end_range); ir_switch_table_set(res, i++, min, max, pn); l->pn = pn; } @@ -4949,53 +4651,44 @@ static ir_node *switch_statement_to_firm(switch_statement_t *statement) set_unreachable_now(); + PUSH_BREAK(NULL); ir_node *const old_switch = current_switch; - ir_node *const old_break_label = break_label; const bool old_saw_default_label = saw_default_label; saw_default_label = false; current_switch = switch_node; - break_label = NULL; statement_to_firm(statement->body); - - if (currently_reachable()) { - add_immBlock_pred(get_break_label(), new_Jmp()); - } + jump_to_target(&break_target); if (!saw_default_label && switch_node) { ir_node *proj = new_d_Proj(dbgi, switch_node, mode_X, pn_Switch_default); - add_immBlock_pred(get_break_label(), proj); + add_pred_to_jump_target(&break_target, proj); } - if (break_label != NULL) { - mature_immBlock(break_label); - } - set_cur_block(break_label); + enter_jump_target(&break_target); assert(current_switch == switch_node); current_switch = old_switch; - break_label = old_break_label; saw_default_label = old_saw_default_label; + POP_BREAK(); return NULL; } static ir_node *case_label_to_firm(const case_label_statement_t *statement) { - if (statement->is_empty_range) - return NULL; + if (current_switch != NULL && !statement->is_empty_range) { + jump_target case_target; + init_jump_target(&case_target, NULL); - if (current_switch != NULL) { - ir_node *block = new_immBlock(); /* Fallthrough from previous case */ - jump_if_reachable(block); + jump_to_target(&case_target); - ir_node *const proj = new_Proj(current_switch, mode_X, statement->pn); - add_immBlock_pred(block, proj); + ir_node *const proj = new_Proj(current_switch, mode_X, statement->pn); + add_pred_to_jump_target(&case_target, proj); if (statement->expression == NULL) saw_default_label = true; - mature_immBlock(block); - set_cur_block(block); + enter_jump_target(&case_target); } return statement_to_firm(statement->statement); @@ -5003,42 +4696,46 @@ static ir_node *case_label_to_firm(const case_label_statement_t *statement) static ir_node *label_to_firm(const label_statement_t *statement) { - ir_node *block = get_label_block(statement->label); - jump_to(block); - - set_cur_block(block); - keep_alive(block); - keep_all_memory(block); + label_t *const label = statement->label; + prepare_label_target(label); + jump_to_target(&label->target); + if (--label->n_users == 0) { + enter_jump_target(&label->target); + } else { + enter_immature_jump_target(&label->target); + keep_loop(); + } return statement_to_firm(statement->statement); } -static ir_node *computed_goto_to_firm(computed_goto_statement_t const *const statement) +static ir_node *goto_statement_to_firm(goto_statement_t *const stmt) { - if (!currently_reachable()) - return NULL; - - ir_node *const irn = expression_to_firm(statement->expression); - dbg_info *const dbgi = get_dbg_info(&statement->base.source_position); - ir_node *const ijmp = new_d_IJmp(dbgi, irn); - - set_irn_link(ijmp, ijmp_list); - ijmp_list = ijmp; - + label_t *const label = stmt->label; + prepare_label_target(label); + jump_to_target(&label->target); + if (--label->n_users == 0) + enter_jump_target(&label->target); set_unreachable_now(); return NULL; } -static ir_node *asm_statement_to_firm(const asm_statement_t *statement) +static ir_node *computed_goto_to_firm(computed_goto_statement_t const *const statement) { - bool needs_memory = false; - - if (statement->is_volatile) { - needs_memory = true; + if (currently_reachable()) { + ir_node *const op = expression_to_firm(statement->expression); + ARR_APP1(ir_node*, ijmp_ops, op); + jump_to_target(&ijmp_target); + set_unreachable_now(); } + return NULL; +} - size_t n_clobbers = 0; - asm_clobber_t *clobber = statement->clobbers; +static ir_node *asm_statement_to_firm(const asm_statement_t *statement) +{ + bool needs_memory = statement->is_volatile; + size_t n_clobbers = 0; + asm_clobber_t *clobber = statement->clobbers; for ( ; clobber != NULL; clobber = clobber->next) { const char *clobber_str = clobber->clobber.begin; @@ -5147,7 +4844,7 @@ static ir_node *asm_statement_to_firm(const asm_statement_t *statement) constraint.mode = mode_M; tmp_in_constraints[in_size] = constraint; - ins[in_size] = expression_to_addr(expr); + ins[in_size] = expression_to_addr(expr); ++in_size; continue; } else { @@ -5224,16 +4921,7 @@ static ir_node *asm_statement_to_firm(const asm_statement_t *statement) ins[in_size++] = input; } - if (needs_memory) { - ir_asm_constraint constraint; - constraint.pos = next_pos++; - constraint.constraint = new_id_from_str(""); - constraint.mode = mode_M; - - obstack_grow(&asm_obst, &constraint, sizeof(constraint)); - ins[in_size++] = get_store(); - } - + ir_node *mem = needs_memory ? get_store() : new_NoMem(); assert(obstack_object_size(&asm_obst) == in_size * sizeof(ir_asm_constraint)); ir_asm_constraint *input_constraints = obstack_finish(&asm_obst); @@ -5243,7 +4931,7 @@ static ir_node *asm_statement_to_firm(const asm_statement_t *statement) ident *asm_text = new_id_from_str(statement->asm_text.begin); - ir_node *node = new_d_ASM(dbgi, in_size, ins, input_constraints, + ir_node *node = new_d_ASM(dbgi, mem, in_size, ins, input_constraints, out_size, output_constraints, n_clobbers, clobbers, asm_text); @@ -5307,19 +4995,25 @@ static ir_node *statement_to_firm(statement_t *const stmt) case STATEMENT_EMPTY: return NULL; /* nothing */ case STATEMENT_EXPRESSION: return expression_statement_to_firm( &stmt->expression); case STATEMENT_FOR: return for_statement_to_firm( &stmt->fors); + case STATEMENT_GOTO: return goto_statement_to_firm( &stmt->gotos); case STATEMENT_IF: return if_statement_to_firm( &stmt->ifs); case STATEMENT_LABEL: return label_to_firm( &stmt->label); case STATEMENT_LEAVE: return leave_statement_to_firm( &stmt->leave); case STATEMENT_MS_TRY: return ms_try_statement_to_firm( &stmt->ms_try); case STATEMENT_RETURN: return return_statement_to_firm( &stmt->returns); case STATEMENT_SWITCH: return switch_statement_to_firm( &stmt->switchs); - case STATEMENT_WHILE: return while_statement_to_firm( &stmt->whiles); - case STATEMENT_BREAK: return create_jump_statement(stmt, get_break_label()); - case STATEMENT_CONTINUE: return create_jump_statement(stmt, continue_label); - case STATEMENT_GOTO: return create_jump_statement(stmt, get_label_block(stmt->gotos.label)); + { + jump_target *tgt; + case STATEMENT_BREAK: tgt = &break_target; goto jump; + case STATEMENT_CONTINUE: tgt = &continue_target; goto jump; +jump: + jump_to_target(tgt); + set_unreachable_now(); + return NULL; + } - case STATEMENT_ERROR: panic("error statement found"); + case STATEMENT_ERROR: panic("error statement"); } panic("statement not implemented"); } @@ -5330,20 +5024,8 @@ static int count_local_variables(const entity_t *entity, int count = 0; entity_t const *const end = last != NULL ? last->base.next : NULL; for (; entity != end; entity = entity->base.next) { - type_t *type; - bool address_taken; - - if (entity->kind == ENTITY_VARIABLE) { - type = skip_typeref(entity->declaration.type); - address_taken = entity->variable.address_taken; - } else if (entity->kind == ENTITY_PARAMETER) { - type = skip_typeref(entity->declaration.type); - address_taken = entity->parameter.address_taken; - } else { - continue; - } - - if (!address_taken && is_type_scalar(type)) + if ((entity->kind == ENTITY_VARIABLE || entity->kind == ENTITY_PARAMETER) && + !var_needs_entity(&entity->variable)) ++count; } return count; @@ -5382,7 +5064,7 @@ static int get_function_n_local_vars(entity_t *entity) count += count_local_variables(function->parameters.entities, NULL); /* count local variables declared in body */ - walk_statements(function->statement, count_local_variables_in_stmt, &count); + walk_statements(function->body, count_local_variables_in_stmt, &count); return count; } @@ -5419,64 +5101,31 @@ static void initialize_function_parameters(entity_t *entity) assert(parameter->declaration.kind == DECLARATION_KIND_UNKNOWN); type_t *type = skip_typeref(parameter->declaration.type); - bool needs_entity = parameter->parameter.address_taken; - assert(!is_type_array(type)); - if (is_type_compound(type)) { - needs_entity = true; - } - - ir_type *param_irtype = get_method_param_type(function_irtype, n); - if (needs_entity) { + dbg_info *const dbgi = get_dbg_info(¶meter->base.source_position); + ir_type *const param_irtype = get_method_param_type(function_irtype, n); + if (var_needs_entity(¶meter->variable)) { ir_type *frame_type = get_irg_frame_type(irg); ir_entity *param - = new_parameter_entity(frame_type, n, param_irtype); - parameter->declaration.kind - = DECLARATION_KIND_PARAMETER_ENTITY; - parameter->parameter.v.entity = param; + = new_d_parameter_entity(frame_type, n, param_irtype, dbgi); + parameter->declaration.kind = DECLARATION_KIND_PARAMETER_ENTITY; + parameter->variable.v.entity = param; continue; } ir_mode *param_mode = get_type_mode(param_irtype); long pn = n; - ir_node *value = new_r_Proj(args, param_mode, pn); + ir_node *value = new_rd_Proj(dbgi, args, param_mode, pn); ir_mode *mode = get_ir_mode_storage(type); value = create_conv(NULL, value, mode); - value = do_strict_conv(NULL, value); - parameter->declaration.kind = DECLARATION_KIND_PARAMETER; - parameter->parameter.v.value_number = next_value_number_function; + parameter->declaration.kind = DECLARATION_KIND_PARAMETER; + parameter->variable.v.value_number = next_value_number_function; set_irg_loc_description(current_ir_graph, next_value_number_function, parameter); ++next_value_number_function; - set_value(parameter->parameter.v.value_number, value); - } -} - -/** - * Handle additional decl modifiers for IR-graphs - * - * @param irg the IR-graph - * @param dec_modifiers additional modifiers - */ -static void handle_decl_modifier_irg(ir_graph *irg, - decl_modifiers_t decl_modifiers) -{ - if (decl_modifiers & DM_NAKED) { - /* TRUE if the declaration includes the Microsoft - __declspec(naked) specifier. */ - add_irg_additional_properties(irg, mtp_property_naked); - } - if (decl_modifiers & DM_FORCEINLINE) { - /* TRUE if the declaration includes the - Microsoft __forceinline specifier. */ - set_irg_inline_property(irg, irg_inline_forced); - } - if (decl_modifiers & DM_NOINLINE) { - /* TRUE if the declaration includes the Microsoft - __declspec(noinline) specifier. */ - set_irg_inline_property(irg, irg_inline_forbidden); + set_value(parameter->variable.v.value_number, value); } } @@ -5503,17 +5152,6 @@ static void add_function_pointer(ir_type *segment, ir_entity *method, set_atomic_ent_value(ptr, val); } -/** - * Generate possible IJmp branches to a given label block. - */ -static void gen_ijmp_branches(ir_node *block) -{ - ir_node *ijmp; - for (ijmp = ijmp_list; ijmp != NULL; ijmp = get_irn_link(ijmp)) { - add_immBlock_pred(block, ijmp); - } -} - /** * Create code for a function and all inner functions. * @@ -5524,7 +5162,7 @@ static void create_function(entity_t *entity) assert(entity->kind == ENTITY_FUNCTION); ir_entity *function_entity = get_function_entity(entity, current_outer_frame); - if (entity->function.statement == NULL) + if (entity->function.body == NULL) return; inner_functions = NULL; @@ -5543,9 +5181,11 @@ static void create_function(entity_t *entity) current_function_name = NULL; current_funcsig = NULL; - assert(all_labels == NULL); - all_labels = NEW_ARR_F(label_t *, 0); - ijmp_list = NULL; + assert(!ijmp_ops); + assert(!ijmp_blocks); + init_jump_target(&ijmp_target, NULL); + ijmp_ops = NEW_ARR_F(ir_node*, 0); + ijmp_blocks = NEW_ARR_F(ir_node*, 0); int n_local_vars = get_function_n_local_vars(entity); ir_graph *irg = new_ir_graph(function_entity, n_local_vars); @@ -5562,16 +5202,11 @@ static void create_function(entity_t *entity) set_irn_dbg_info(get_irg_start_block(irg), get_entity_dbg_info(function_entity)); - /* set inline flags */ - if (entity->function.is_inline) - set_irg_inline_property(irg, irg_inline_recomended); - handle_decl_modifier_irg(irg, entity->declaration.modifiers); - next_value_number_function = 0; initialize_function_parameters(entity); current_static_link = entity->function.static_link; - statement_to_firm(entity->function.statement); + statement_to_firm(entity->function.body); ir_node *end_block = get_irg_end_block(irg); @@ -5599,16 +5234,22 @@ static void create_function(entity_t *entity) add_immBlock_pred(end_block, ret); } - for (int i = ARR_LEN(all_labels) - 1; i >= 0; --i) { - label_t *label = all_labels[i]; - if (label->address_taken) { - gen_ijmp_branches(label->block); + if (enter_jump_target(&ijmp_target)) { + keep_loop(); + size_t const n = ARR_LEN(ijmp_ops); + ir_node *const op = n == 1 ? ijmp_ops[0] : new_Phi(n, ijmp_ops, get_irn_mode(ijmp_ops[0])); + ir_node *const ijmp = new_IJmp(op); + for (size_t i = ARR_LEN(ijmp_blocks); i-- != 0;) { + ir_node *const block = ijmp_blocks[i]; + add_immBlock_pred(block, ijmp); + mature_immBlock(block); } - mature_immBlock(label->block); } - DEL_ARR_F(all_labels); - all_labels = NULL; + DEL_ARR_F(ijmp_ops); + DEL_ARR_F(ijmp_blocks); + ijmp_ops = NULL; + ijmp_blocks = NULL; irg_finalize_cons(irg); @@ -5726,9 +5367,7 @@ static void init_ir_types(void) return; ir_types_initialized = 1; - ir_type_char = get_ir_type(type_char); - ir_type_const_char = get_ir_type(type_const_char); - ir_type_wchar_t = get_ir_type(type_wchar_t); + ir_type_char = get_ir_type(type_char); be_params = be_get_backend_param(); mode_float_arithmetic = be_params->mode_float_arithmetic; @@ -5748,13 +5387,8 @@ static void global_asm_to_firm(statement_t *s) assert(s->kind == STATEMENT_ASM); char const *const text = s->asms.asm_text.begin; - size_t size = s->asms.asm_text.size; - - /* skip the last \0 */ - if (text[size - 1] == '\0') - --size; - - ident *const id = new_id_from_chars(text, size); + size_t const size = s->asms.asm_text.size; + ident *const id = new_id_from_chars(text, size); add_irp_asm(id); } } @@ -5762,8 +5396,9 @@ static void global_asm_to_firm(statement_t *s) static const char *get_cwd(void) { static char buf[1024]; - if (buf[0] == '\0') - getcwd(buf, sizeof(buf)); + if (buf[0] == '\0') { + return getcwd(buf, sizeof(buf)); + } return buf; } @@ -5778,15 +5413,18 @@ void translation_unit_to_firm(translation_unit_t *unit) } else { be_dwarf_set_source_language(DW_LANG_C); } - be_dwarf_set_compilation_directory(get_cwd()); + const char *cwd = get_cwd(); + if (cwd != NULL) { + be_dwarf_set_compilation_directory(cwd); + } /* initialize firm arithmetic */ tarval_set_integer_overflow_mode(TV_OVERFLOW_WRAP); ir_set_uninitialized_local_variable_func(uninitialized_local_var); /* just to be sure */ - continue_label = NULL; - break_label = NULL; + init_jump_target(&break_target, NULL); + init_jump_target(&continue_target, NULL); current_switch = NULL; current_translation_unit = unit;