issue a warning if returning the address of a local variable

[cparser] / type.c

diff --git a/type.c b/type.c
index 4346a8a..ddfb8d0 100644 (file)
--- a/type.c
+++ b/type.c
@@ -159,6 +159,13 @@ static void print_array_type_post(const array_type_t *type)
        intern_print_type_post(type->element_type, false);
 }
 
+static void print_bitfield_type_post(const bitfield_type_t *type)
+{
+       fputs(" : ", out);
+       print_expression(type->size);
+       intern_print_type_post(type->base, false);
+}
+
 void print_enum_definition(const declaration_t *declaration)
 {
        fputs("{\n", out);
@@ -236,6 +243,7 @@ static void print_compound_type(const compound_type_t *type)
 
 static void print_typedef_type_pre(const typedef_type_t *const type)
 {
+       print_type_qualifiers(type->type.qualifiers);
        fputs(type->declaration->symbol->string, out);
 }
 
@@ -276,6 +284,9 @@ static void intern_print_type_pre(const type_t *const type, const bool top)
        case TYPE_POINTER:
                print_pointer_type_pre(&type->pointer);
                return;
+       case TYPE_BITFIELD:
+               intern_print_type_pre(type->bitfield.base, top);
+               return;
        case TYPE_ARRAY:
                print_array_type_pre(&type->array);
                return;
@@ -301,6 +312,9 @@ static void intern_print_type_post(const type_t *const type, const bool top)
        case TYPE_ARRAY:
                print_array_type_post(&type->array);
                return;
+       case TYPE_BITFIELD:
+               print_bitfield_type_post(&type->bitfield);
+               return;
        case TYPE_INVALID:
        case TYPE_ATOMIC:
        case TYPE_ENUM:
@@ -351,6 +365,7 @@ static size_t get_type_size(type_t *type)
        case TYPE_BUILTIN:         return sizeof(builtin_type_t);
        case TYPE_TYPEDEF:         return sizeof(typedef_type_t);
        case TYPE_TYPEOF:          return sizeof(typeof_type_t);
+       case TYPE_BITFIELD:        return sizeof(bitfield_type_t);
        case TYPE_INVALID:         panic("invalid type found");
        }
        panic("unknown type found");
@@ -498,6 +513,9 @@ bool is_type_arithmetic(const type_t *type)
 {
        assert(!is_typeref(type));
 
+       if(type->kind == TYPE_BITFIELD)
+               return true;
+
        if(is_type_integer(type) || is_type_floating(type))
                return true;
 
@@ -511,7 +529,7 @@ bool is_type_scalar(const type_t *type)
        switch (type->kind) {
                case TYPE_POINTER: return true;
                case TYPE_BUILTIN: return is_type_scalar(type->builtin.real_type);
-               default:           break;
+               default:            break;
        }
 
        return is_type_arithmetic(type);
@@ -528,6 +546,7 @@ bool is_type_incomplete(const type_t *type)
                declaration_t         *declaration   = compound_type->declaration;
                return !declaration->init.is_defined;
        }
+       case TYPE_BITFIELD:
        case TYPE_FUNCTION:
                return true;
 
@@ -535,6 +554,8 @@ bool is_type_incomplete(const type_t *type)
                return type->array.size == NULL;
 
        case TYPE_ATOMIC:
+               return type->atomic.atype == ATOMIC_TYPE_VOID;
+
        case TYPE_POINTER:
        case TYPE_ENUM:
        case TYPE_BUILTIN:
@@ -553,7 +574,9 @@ bool is_type_incomplete(const type_t *type)
 static bool function_types_compatible(const function_type_t *func1,
                                       const function_type_t *func2)
 {
-       if(!types_compatible(func1->return_type, func2->return_type))
+       const type_t* const ret1 = skip_typeref(func1->return_type);
+       const type_t* const ret2 = skip_typeref(func2->return_type);
+       if (!types_compatible(ret1, ret2))
                return false;
 
        /* can parameters be compared? */
@@ -595,7 +618,7 @@ static bool array_types_compatible(const array_type_t *array1,
                return false;
 
        if(array1->size != NULL && array2->size != NULL) {
-               /* TODO: check if size expression evaulate to the same value
+               /* TODO: check if size expression evaluate to the same value
                 * if they are constant */
        }
 
@@ -623,9 +646,13 @@ bool types_compatible(const type_t *type1, const type_t *type2)
                return type1->atomic.atype == type2->atomic.atype;
        case TYPE_ARRAY:
                return array_types_compatible(&type1->array, &type2->array);
-       case TYPE_POINTER:
-               return types_compatible(type1->pointer.points_to,
-                                       type2->pointer.points_to);
+
+       case TYPE_POINTER: {
+               const type_t *const to1 = skip_typeref(type1->pointer.points_to);
+               const type_t *const to2 = skip_typeref(type2->pointer.points_to);
+               return types_compatible(to1, to2);
+       }
+
        case TYPE_COMPOUND_STRUCT:
        case TYPE_COMPOUND_UNION:
        case TYPE_ENUM:
@@ -633,6 +660,11 @@ bool types_compatible(const type_t *type1, const type_t *type2)
                /* TODO: not implemented */
                break;
 
+       case TYPE_BITFIELD:
+               /* not sure if this makes sense or is even needed, implement it if you
+                * really need it! */
+               panic("type compatibility check for bitfield type");
+
        case TYPE_INVALID:
                panic("invalid type found in compatible types");
        case TYPE_TYPEDEF:
@@ -657,9 +689,9 @@ bool pointers_compatible(const type_t *type1, const type_t *type2)
 
 type_t *skip_typeref(type_t *type)
 {
-       unsigned qualifiers = type->base.qualifiers;
+       unsigned qualifiers = TYPE_QUALIFIER_NONE;
 
-       while(1) {
+       while(true) {
                switch(type->kind) {
                case TYPE_TYPEDEF: {
                        qualifiers |= type->base.qualifiers;
@@ -686,6 +718,16 @@ type_t *skip_typeref(type_t *type)
                break;
        }
 
+       if (qualifiers != TYPE_QUALIFIER_NONE) {
+               type_t *const copy     = duplicate_type(type);
+               copy->base.qualifiers |= qualifiers;
+
+               type = typehash_insert(copy);
+               if (type != copy) {
+                       obstack_free(type_obst, copy);
+               }
+       }
+
        return type;
 }