preprocessor: backslash is not a punctuator token
[cparser] / preprocessor.c
index 967f5c3..92d4f37 100644 (file)
@@ -218,17 +218,18 @@ static inline void put_back(utf32 const pc)
        --input.position.colno;
 }
 
-#define MATCH_NEWLINE(code)                   \
-       case '\r':                                \
-               next_char();                          \
-               if (input.c == '\n') {                \
-       case '\n':                                \
-                       next_char();                      \
-               }                                     \
-               info.whitespace = 0;                  \
-               ++input.position.lineno;              \
-               input.position.colno = 1;             \
-               code
+#define NEWLINE \
+       '\r': \
+               next_char(); \
+               if (input.c == '\n') { \
+       case '\n': \
+                       next_char(); \
+               } \
+               info.whitespace = 0; \
+               ++input.position.lineno; \
+               input.position.colno = 1; \
+               goto newline; \
+               newline // Let it look like an ordinary case label.
 
 #define eat(c_type) (assert(input.c == c_type), next_char())
 
@@ -237,9 +238,8 @@ static void maybe_concat_lines(void)
        eat('\\');
 
        switch (input.c) {
-       MATCH_NEWLINE(
+       case NEWLINE:
                return;
-       )
 
        default:
                break;
@@ -451,162 +451,87 @@ static const char *identify_string(char *string)
        return result;
 }
 
-static string_t make_string(char *string, size_t len)
+static string_t sym_make_string(string_encoding_t const enc)
 {
-       const char *result = identify_string(string);
-       return (string_t) {result, len};
+       obstack_1grow(&symbol_obstack, '\0');
+       size_t      const len    = obstack_object_size(&symbol_obstack) - 1;
+       char       *const string = obstack_finish(&symbol_obstack);
+       char const *const result = identify_string(string);
+       return (string_t){ result, len, enc };
 }
 
-static void parse_string_literal(string_encoding_t const enc)
+static void parse_string(utf32 const delimiter, preprocessor_token_kind_t const kind, string_encoding_t const enc, char const *const context)
 {
        const unsigned start_linenr = input.position.lineno;
 
-       eat('"');
+       eat(delimiter);
 
        while (true) {
                switch (input.c) {
                case '\\': {
-                       utf32 tc;
                        if (resolve_escape_sequences) {
-                               tc = parse_escape_sequence();
-                               obstack_1grow(&symbol_obstack, (char) tc);
+                               utf32 const tc = parse_escape_sequence();
+                               if (enc == STRING_ENCODING_CHAR) {
+                                       if (tc >= 0x100) {
+                                               warningf(WARN_OTHER, &pp_token.base.source_position, "escape sequence out of range");
+                                       }
+                                       obstack_1grow(&symbol_obstack, tc);
+                               } else {
+                                       obstack_grow_symbol(&symbol_obstack, tc);
+                               }
                        } else {
-                               obstack_1grow(&symbol_obstack, (char) input.c);
+                               obstack_1grow(&symbol_obstack, (char)input.c);
                                next_char();
-                               obstack_1grow(&symbol_obstack, (char) input.c);
+                               obstack_1grow(&symbol_obstack, (char)input.c);
                                next_char();
                        }
                        break;
                }
 
+               case NEWLINE:
+                       errorf(&pp_token.base.source_position, "newline while parsing %s", context);
+                       break;
+
                case EOF: {
                        source_position_t source_position;
                        source_position.input_name = pp_token.base.source_position.input_name;
                        source_position.lineno     = start_linenr;
-                       errorf(&source_position, "string has no end");
+                       errorf(&source_position, "EOF while parsing %s", context);
                        goto end_of_string;
                }
 
-               case '"':
-                       next_char();
-                       goto end_of_string;
-
                default:
-                       obstack_grow_symbol(&symbol_obstack, input.c);
-                       next_char();
-                       break;
+                       if (input.c == delimiter) {
+                               next_char();
+                               goto end_of_string;
+                       } else {
+                               obstack_grow_symbol(&symbol_obstack, input.c);
+                               next_char();
+                               break;
+                       }
                }
        }
 
 end_of_string:
-       /* add finishing 0 to the string */
-       obstack_1grow(&symbol_obstack, '\0');
-       const size_t size   = (size_t)obstack_object_size(&symbol_obstack);
-       char *const  string = obstack_finish(&symbol_obstack);
-
-       pp_token.kind            = TP_STRING_LITERAL;
-       pp_token.string.encoding = enc;
-       pp_token.string.string   = make_string(string, size);
+       pp_token.kind           = kind;
+       pp_token.literal.string = sym_make_string(enc);
 }
 
-static void parse_wide_character_constant(void)
+static void parse_string_literal(string_encoding_t const enc)
 {
-       eat('\'');
-
-       while (true) {
-               switch (input.c) {
-               case '\\': {
-                       const utf32 tc = parse_escape_sequence();
-                       obstack_grow_symbol(&symbol_obstack, tc);
-                       break;
-               }
-
-               MATCH_NEWLINE(
-                       parse_error("newline while parsing character constant");
-                       break;
-               )
-
-               case '\'':
-                       next_char();
-                       goto end_of_wide_char_constant;
-
-               case EOF:
-                       parse_error("EOF while parsing character constant");
-                       goto end_of_wide_char_constant;
-
-               default:
-                       obstack_grow_symbol(&symbol_obstack, input.c);
-                       next_char();
-                       break;
-               }
-       }
-
-end_of_wide_char_constant:
-       obstack_1grow(&symbol_obstack, '\0');
-       size_t  size = (size_t) obstack_object_size(&symbol_obstack)-1;
-       char   *string = obstack_finish(&symbol_obstack);
-       pp_token.kind          = TP_WIDE_CHARACTER_CONSTANT;
-       pp_token.string.string = make_string(string, size);
-
-       if (size == 0) {
-               parse_error("empty character constant");
-       }
+       parse_string('"', TP_STRING_LITERAL, enc, "string literal");
 }
 
-static void parse_character_constant(void)
+static void parse_character_constant(string_encoding_t const enc)
 {
-       const unsigned start_linenr = input.position.lineno;
-
-       eat('\'');
-
-       int tc;
-       while (true) {
-               switch (input.c) {
-               case '\\':
-                       tc = parse_escape_sequence();
-                       obstack_1grow(&symbol_obstack, (char) tc);
-                       break;
-
-               MATCH_NEWLINE(
-                       parse_error("newline while parsing character constant");
-                       break;
-               )
-
-               case EOF: {
-                       source_position_t source_position;
-                       source_position.input_name = pp_token.base.source_position.input_name;
-                       source_position.lineno     = start_linenr;
-                       errorf(&source_position, "EOF while parsing character constant");
-                       goto end_of_char_constant;
-               }
-
-               case '\'':
-                       next_char();
-                       goto end_of_char_constant;
-
-               default:
-                       obstack_1grow(&symbol_obstack, (char) input.c);
-                       next_char();
-                       break;
-
-               }
-       }
-
-end_of_char_constant:;
-       obstack_1grow(&symbol_obstack, '\0');
-       const size_t size   = (size_t)obstack_object_size(&symbol_obstack);
-       char *const  string = obstack_finish(&symbol_obstack);
-
-       pp_token.kind          = TP_CHARACTER_CONSTANT;
-       pp_token.string.string = make_string(string, size);
-
-       if (size == 0) {
+       parse_string('\'', TP_CHARACTER_CONSTANT, enc, "character constant");
+       if (pp_token.literal.string.size == 0) {
                parse_error("empty character constant");
        }
 }
 
-#define SYMBOL_CHARS_WITHOUT_E_P \
-       case 'a': \
+#define SYMBOL_CASES_WITHOUT_E_P \
+            'a': \
        case 'b': \
        case 'c': \
        case 'd': \
@@ -654,17 +579,17 @@ end_of_char_constant:;
        case 'X': \
        case 'Y': \
        case 'Z': \
-       case '_':
+       case '_'
 
-#define SYMBOL_CHARS \
-       SYMBOL_CHARS_WITHOUT_E_P \
+#define SYMBOL_CASES \
+            SYMBOL_CASES_WITHOUT_E_P: \
        case 'e': \
        case 'p': \
        case 'E': \
-       case 'P':
+       case 'P'
 
-#define DIGITS \
-       case '0':  \
+#define DIGIT_CASES \
+            '0':  \
        case '1':  \
        case '2':  \
        case '3':  \
@@ -673,7 +598,7 @@ end_of_char_constant:;
        case '6':  \
        case '7':  \
        case '8':  \
-       case '9':
+       case '9'
 
 /**
  * returns next final token from a preprocessor macro expansion
@@ -761,9 +686,8 @@ static void skip_multiline_comment(void)
                        }
                        break;
 
-               MATCH_NEWLINE(
+               case NEWLINE:
                        break;
-               )
 
                case EOF: {
                        source_position_t source_position;
@@ -789,10 +713,9 @@ static void skip_whitespace(void)
                        next_char();
                        continue;
 
-               MATCH_NEWLINE(
+               case NEWLINE:
                        info.at_line_begin = true;
                        return;
-               )
 
                case '/':
                        next_char();
@@ -829,8 +752,8 @@ static void parse_symbol(void)
 
        while (true) {
                switch (input.c) {
-               DIGITS
-               SYMBOL_CHARS
+               case DIGIT_CASES:
+               case SYMBOL_CASES:
                        obstack_1grow(&symbol_obstack, (char) input.c);
                        next_char();
                        break;
@@ -851,7 +774,7 @@ end_symbol:
                return;
        } else if (input.c == '\'' && string[0] == 'L' && string[1] == '\0') {
                obstack_free(&symbol_obstack, string);
-               parse_wide_character_constant();
+               parse_character_constant(STRING_ENCODING_WIDE);
                return;
        }
 
@@ -875,8 +798,8 @@ static void parse_number(void)
        while (true) {
                switch (input.c) {
                case '.':
-               DIGITS
-               SYMBOL_CHARS_WITHOUT_E_P
+               case DIGIT_CASES:
+               case SYMBOL_CASES_WITHOUT_E_P:
                        obstack_1grow(&symbol_obstack, (char) input.c);
                        next_char();
                        break;
@@ -899,12 +822,8 @@ static void parse_number(void)
        }
 
 end_number:
-       obstack_1grow(&symbol_obstack, '\0');
-       size_t  size   = obstack_object_size(&symbol_obstack);
-       char   *string = obstack_finish(&symbol_obstack);
-
-       pp_token.kind          = TP_NUMBER;
-       pp_token.number.number = make_string(string, size);
+       pp_token.kind           = TP_NUMBER;
+       pp_token.literal.string = sym_make_string(STRING_ENCODING_CHAR);
 }
 
 
@@ -952,17 +871,16 @@ restart:
                next_char();
                goto restart;
 
-       MATCH_NEWLINE(
+       case NEWLINE:
                info.at_line_begin = true;
                info.had_whitespace = true;
                goto restart;
-       )
 
-       SYMBOL_CHARS
+       case SYMBOL_CASES:
                parse_symbol();
                return;
 
-       DIGITS
+       case DIGIT_CASES:
                parse_number();
                return;
 
@@ -971,7 +889,7 @@ restart:
                return;
 
        case '\'':
-               parse_character_constant();
+               parse_character_constant(STRING_ENCODING_CHAR);
                return;
 
        case '.':
@@ -1106,7 +1024,6 @@ restart:
        case '~':
        case ';':
        case ',':
-       case '\\':
                pp_token.kind = input.c;
                next_char();
                return;
@@ -1215,20 +1132,20 @@ static void emit_pp_token(void)
                fputs(pp_token.base.symbol->string, out);
                break;
        case TP_NUMBER:
-               fputs(pp_token.number.number.begin, out);
+               fputs(pp_token.literal.string.begin, out);
                break;
 
        case TP_STRING_LITERAL:
-               fputs(get_string_encoding_prefix(pp_token.string.encoding), out);
+               fputs(get_string_encoding_prefix(pp_token.literal.string.encoding), out);
                fputc('"', out);
-               fputs(pp_token.string.string.begin, out);
+               fputs(pp_token.literal.string.begin, out);
                fputc('"', out);
                break;
-       case TP_WIDE_CHARACTER_CONSTANT:
-               fputc('L', out);
+
        case TP_CHARACTER_CONSTANT:
+               fputs(get_string_encoding_prefix(pp_token.literal.string.encoding), out);
                fputc('\'', out);
-               fputs(pp_token.string.string.begin, out);
+               fputs(pp_token.literal.string.begin, out);
                fputc('\'', out);
                break;
        default:
@@ -1272,7 +1189,7 @@ static bool pp_tokens_equal(const token_t *token1, const token_t *token2)
        case TP_NUMBER:
        case TP_CHARACTER_CONSTANT:
        case TP_STRING_LITERAL:
-               return strings_equal(&token1->string.string, &token2->string.string);
+               return strings_equal(&token1->literal.string, &token2->literal.string);
 
        default:
                return true;
@@ -1422,16 +1339,16 @@ static void parse_undef_directive(void)
        eat_pp_directive();
 }
 
+/** behind an #include we can have the special headername lexems.
+ * They're only allowed behind an #include so they're not recognized
+ * by the normal next_preprocessing_token. We handle them as a special
+ * exception here */
 static void parse_headername(void)
 {
        const source_position_t start_position = input.position;
-       string_t                string         = {NULL, 0};
+       string_t                string         = { NULL, 0, STRING_ENCODING_CHAR };
        assert(obstack_object_size(&symbol_obstack) == 0);
 
-       /* behind an #include we can have the special headername lexems.
-        * They're only allowed behind an #include so they're not recognized
-        * by the normal next_preprocessing_token. We handle them as a special
-        * exception here */
        if (info.at_line_begin) {
                parse_error("expected headername after #include");
                goto finish_error;
@@ -1439,43 +1356,32 @@ static void parse_headername(void)
 
        /* check wether we have a "... or <... headername */
        switch (input.c) {
-       case '<':
+       {
+               utf32 delimiter;
+       case '<': delimiter = '>'; goto parse_name;
+       case '"': delimiter = '"'; goto parse_name;
+parse_name:
                next_char();
                while (true) {
                        switch (input.c) {
+                       case NEWLINE:
                        case EOF:
-                               /* fallthrough */
-                       MATCH_NEWLINE(
-                               parse_error("header name without closing '>'");
+                               errorf(&pp_token.base.source_position, "header name without closing '%c'", (char)delimiter);
                                goto finish_error;
-                       )
-                       case '>':
-                               next_char();
-                               goto finished_headername;
-                       }
-                       obstack_1grow(&symbol_obstack, (char) input.c);
-                       next_char();
-               }
-               /* we should never be here */
 
-       case '"':
-               next_char();
-               while (true) {
-                       switch (input.c) {
-                       case EOF:
-                               /* fallthrough */
-                       MATCH_NEWLINE(
-                               parse_error("header name without closing '>'");
-                               goto finish_error;
-                       )
-                       case '"':
-                               next_char();
-                               goto finished_headername;
+                       default:
+                               if (input.c == delimiter) {
+                                       next_char();
+                                       goto finished_headername;
+                               } else {
+                                       obstack_1grow(&symbol_obstack, (char)input.c);
+                                       next_char();
+                               }
+                               break;
                        }
-                       obstack_1grow(&symbol_obstack, (char) input.c);
-                       next_char();
                }
                /* we should never be here */
+       }
 
        default:
                /* TODO: do normal pp_token parsing and concatenate results */
@@ -1483,15 +1389,12 @@ static void parse_headername(void)
        }
 
 finished_headername:
-       obstack_1grow(&symbol_obstack, '\0');
-       const size_t size       = (size_t)obstack_object_size(&symbol_obstack);
-       char *const  headername = obstack_finish(&symbol_obstack);
-       string                  = make_string(headername, size);
+       string = sym_make_string(STRING_ENCODING_CHAR);
 
 finish_error:
        pp_token.base.source_position = start_position;
        pp_token.kind                 = TP_HEADERNAME;
-       pp_token.string.string        = string;
+       pp_token.literal.string       = string;
 }
 
 static bool do_include(bool system_include, const char *headername)
@@ -1548,9 +1451,7 @@ static void skip_till_newline(void)
        /* skip till newline */
        while (true) {
                switch (input.c) {
-               MATCH_NEWLINE(
-                       return;
-               )
+               case NEWLINE:
                case EOF:
                        return;
                }
@@ -1565,7 +1466,7 @@ static bool parse_include_directive(void)
        skip_whitespace();
        bool system_include = input.c == '<';
        parse_headername();
-       string_t headername = pp_token.string.string;
+       string_t headername = pp_token.literal.string;
        if (headername.begin == NULL) {
                eat_pp_directive();
                return false;
@@ -1588,10 +1489,9 @@ static bool parse_include_directive(void)
        /* switch inputs */
        emit_newlines();
        push_input();
-       bool res = do_include(system_include, pp_token.string.string.begin);
+       bool res = do_include(system_include, pp_token.literal.string.begin);
        if (!res) {
-               errorf(&pp_token.base.source_position,
-                      "failed including '%S': %s", pp_token.string, strerror(errno));
+               errorf(&pp_token.base.source_position, "failed including '%S': %s", &pp_token.literal, strerror(errno));
                pop_restore_input();
                return false;
        }
@@ -1655,7 +1555,7 @@ static void parse_ifdef_ifndef_directive(void)
                condition = true;
        } else {
                /* evaluate wether we are in true or false case */
-               condition = !pp_token.base.symbol->pp_definition == is_ifndef;
+               condition = (bool)!pp_token.base.symbol->pp_definition == is_ifndef;
 
                next_preprocessing_token();
 
@@ -1696,7 +1596,7 @@ static void parse_else_directive(void)
        if (conditional->in_else) {
                errorf(&pp_token.base.source_position,
                       "#else after #else (condition started %P)",
-                      conditional->source_position);
+                      &conditional->source_position);
                skip_mode = true;
                return;
        }