bool must_be_constant;
} parse_initializer_env_t;
-typedef declaration_t* (*parsed_declaration_func) (declaration_t *declaration);
+typedef declaration_t* (*parsed_declaration_func) (declaration_t *declaration, bool is_definition);
static token_t token;
static token_t lookahead_buffer[MAX_LOOKAHEAD];
static scope_t *scope = NULL;
static declaration_t *last_declaration = NULL;
static declaration_t *current_function = NULL;
+static declaration_t *current_init_decl = NULL;
static switch_statement_t *current_switch = NULL;
static statement_t *current_loop = NULL;
static statement_t *current_parent = NULL;
static void parse_compound_type_entries(declaration_t *compound_declaration);
static declaration_t *parse_declarator(
const declaration_specifiers_t *specifiers, bool may_be_abstract);
-static declaration_t *record_declaration(declaration_t *declaration);
+static declaration_t *record_declaration(declaration_t *declaration, bool is_definition);
static void semantic_comparison(binary_expression_t *expression);
declaration->type = type;
declaration->symbol = symbol;
declaration->source_position = builtin_source_position;
+ declaration->implicit = true;
- record_declaration(declaration);
+ record_declaration(declaration, false);
type_t *typedef_type = allocate_type_zero(TYPE_TYPEDEF, &builtin_source_position);
typedef_type->typedeft.declaration = declaration;
/* TODO semantic */
}
- record_declaration(entry);
+ record_declaration(entry, false);
if (token.type != ',')
break;
return;
}
+static declaration_t *create_error_declaration(symbol_t *symbol, storage_class_tag_t storage_class)
+{
+ declaration_t *const decl = allocate_declaration_zero();
+ decl->source_position = *HERE;
+ decl->declared_storage_class = storage_class;
+ decl->storage_class =
+ storage_class != STORAGE_CLASS_NONE || scope == global_scope ?
+ storage_class : STORAGE_CLASS_AUTO;
+ decl->symbol = symbol;
+ decl->implicit = true;
+ record_declaration(decl, false);
+ return decl;
+}
+
+/**
+ * Finish the construction of a struct type by calculating
+ * its size, offsets, alignment.
+ */
+static void finish_struct_type(compound_type_t *type) {
+ if (type->declaration == NULL)
+ return;
+ declaration_t *struct_decl = type->declaration;
+ if (! struct_decl->init.complete)
+ return;
+
+ il_size_t size = 0;
+ il_size_t new_size;
+ il_alignment_t alignment = 1;
+ bool need_pad = false;
+
+ declaration_t *entry = struct_decl->scope.declarations;
+ for (; entry != NULL; entry = entry->next) {
+ if (entry->namespc != NAMESPACE_NORMAL)
+ continue;
+
+ type_t *m_type = skip_typeref(entry->type);
+ il_alignment_t m_alignment = m_type->base.alignment;
+
+ new_size = (size + m_alignment - 1) & -m_alignment;
+ if (m_alignment > alignment)
+ alignment = m_alignment;
+ if (new_size > size)
+ need_pad = true;
+ entry->offset = new_size;
+ size = new_size + m_type->base.size;
+ }
+ if (type->base.alignment != 0) {
+ alignment = type->base.alignment;
+ }
+
+ new_size = (size + alignment - 1) & -alignment;
+ if (new_size > size)
+ need_pad = true;
+
+ if (warning.padded && need_pad) {
+ warningf(&struct_decl->source_position,
+ "'%#T' needs padding", type, struct_decl->symbol);
+ }
+ if (warning.packed && !need_pad) {
+ warningf(&struct_decl->source_position,
+ "superfluous packed attribute on '%#T'",
+ type, struct_decl->symbol);
+ }
+
+ type->base.size = new_size;
+ type->base.alignment = alignment;
+}
+
+/**
+ * Finish the construction of an union type by calculating
+ * its size and alignment.
+ */
+static void finish_union_type(compound_type_t *type) {
+ if (type->declaration == NULL)
+ return;
+ declaration_t *union_decl = type->declaration;
+ if (! union_decl->init.complete)
+ return;
+
+ il_size_t size = 0;
+ il_alignment_t alignment = 1;
+
+ declaration_t *entry = union_decl->scope.declarations;
+ for (; entry != NULL; entry = entry->next) {
+ if (entry->namespc != NAMESPACE_NORMAL)
+ continue;
+
+ type_t *m_type = skip_typeref(entry->type);
+
+ entry->offset = 0;
+ if (m_type->base.size > size)
+ size = m_type->base.size;
+ if (m_type->base.alignment > alignment)
+ alignment = m_type->base.alignment;
+ }
+ if (type->base.alignment != 0) {
+ alignment = type->base.alignment;
+ }
+ size = (size + alignment - 1) & -alignment;
+ type->base.size = size;
+ type->base.alignment = alignment;
+}
+
static void parse_declaration_specifiers(declaration_specifiers_t *specifiers)
{
type_t *type = NULL;
type = allocate_type_zero(TYPE_COMPOUND_STRUCT, HERE);
type->compound.declaration = parse_compound_type_specifier(true);
+ finish_struct_type(&type->compound);
break;
}
case T_union: {
if (type->compound.declaration->modifiers & DM_TRANSPARENT_UNION)
modifiers |= TYPE_MODIFIER_TRANSPARENT_UNION;
break;
+ finish_union_type(&type->compound);
}
case T_enum:
type = parse_enum_specifier();
switch (la1_type) {
DECLARATION_START
case T_IDENTIFIER:
- case '*':
+ case '*': {
errorf(HERE, "%K does not name a type", &token);
+
+ declaration_t *const decl =
+ create_error_declaration(token.v.symbol, STORAGE_CLASS_TYPEDEF);
+
+ type = allocate_type_zero(TYPE_TYPEDEF, HERE);
+ type->typedeft.declaration = decl;
+
next_token();
saw_error = true;
if (la1_type == '*')
goto finish_specifiers;
continue;
+ }
default:
goto finish_specifiers;
}
finish_specifiers:
-
- if (type == NULL) {
+ if (type == NULL || (saw_error && type_specifiers != 0)) {
atomic_type_kind_t atomic_type;
/* match valid basic types */
declaration->type = type;
if (is_type_incomplete(skip_typeref(type))) {
- errorf(pos, "incomplete type '%T' not allowed for parameter '%Y'",
+ errorf(pos, "parameter '%#T' is of incomplete type",
orig_type, declaration->symbol);
}
}
add_anchor_token(')');
int saved_comma_state = save_and_reset_anchor_state(',');
- if (token.type == T_IDENTIFIER) {
- symbol_t *symbol = token.v.symbol;
- if (!is_typedef_symbol(symbol)) {
+ if (token.type == T_IDENTIFIER &&
+ !is_typedef_symbol(token.v.symbol)) {
+ token_type_t la1_type = (token_type_t)look_ahead(1)->type;
+ if (la1_type == ',' || la1_type == ')') {
type->kr_style_parameters = true;
declarations = parse_identifier_list();
goto parameters_finished;
return strcmp(sym->string, "main") == 0;
}
-static declaration_t *internal_record_declaration(
+static declaration_t *record_declaration(
declaration_t *const declaration,
const bool is_definition)
{
return append_declaration(declaration);
}
-static declaration_t *record_declaration(declaration_t *declaration)
-{
- return internal_record_declaration(declaration, false);
-}
-
-static declaration_t *record_definition(declaration_t *declaration)
-{
- return internal_record_declaration(declaration, true);
-}
-
static void parser_error_multiple_definition(declaration_t *declaration,
const source_position_t *source_position)
{
must_be_constant = true;
}
+ if (is_type_function(type)) {
+ errorf(&declaration->source_position,
+ "function '%#T' is initialized like a variable",
+ orig_type, declaration->symbol);
+ orig_type = type_error_type;
+ }
+
parse_initializer_env_t env;
env.type = orig_type;
env.must_be_constant = must_be_constant;
- env.declaration = declaration;
+ env.declaration = current_init_decl = declaration;
initializer_t *initializer = parse_initializer(&env);
+ current_init_decl = NULL;
- if (env.type != orig_type) {
- orig_type = env.type;
- type = skip_typeref(orig_type);
- declaration->type = env.type;
- }
-
- if (is_type_function(type)) {
- errorf(&declaration->source_position,
- "initializers not allowed for function types at declator '%Y' (type '%T')",
- declaration->symbol, orig_type);
- } else {
+ if (!is_type_function(type)) {
+ /* ยง 6.7.5 (22) array initializers for arrays with unknown size determine
+ * the array type size */
+ declaration->type = env.type;
declaration->init.initializer = initializer;
}
}
/* parse rest of a declaration without any declarator */
static void parse_anonymous_declaration_rest(
- const declaration_specifiers_t *specifiers,
- parsed_declaration_func finished_declaration)
+ const declaration_specifiers_t *specifiers)
{
eat(';');
break;
}
- finished_declaration(declaration);
+ append_declaration(declaration);
}
static void parse_declaration_rest(declaration_t *ndeclaration,
add_anchor_token('=');
add_anchor_token(',');
while(true) {
- declaration_t *declaration = finished_declaration(ndeclaration);
+ declaration_t *declaration =
+ finished_declaration(ndeclaration, token.type == '=');
type_t *orig_type = declaration->type;
type_t *type = skip_typeref(orig_type);
rem_anchor_token(',');
}
-static declaration_t *finished_kr_declaration(declaration_t *declaration)
+static declaration_t *finished_kr_declaration(declaration_t *declaration, bool is_definition)
{
symbol_t *symbol = declaration->symbol;
if (symbol == NULL) {
}
namespace_t namespc = (namespace_t) declaration->namespc;
if (namespc != NAMESPACE_NORMAL) {
- return record_declaration(declaration);
+ return record_declaration(declaration, false);
}
declaration_t *previous_declaration = get_declaration(symbol, namespc);
return declaration;
}
+ if (is_definition) {
+ errorf(HERE, "parameter %Y is initialised", declaration->symbol);
+ }
+
if (previous_declaration->type == NULL) {
previous_declaration->type = declaration->type;
previous_declaration->declared_storage_class = declaration->declared_storage_class;
previous_declaration->parent_scope = scope;
return previous_declaration;
} else {
- return record_declaration(declaration);
+ return record_declaration(declaration, false);
}
}
parse_declaration_specifiers(&specifiers);
if (token.type == ';') {
- parse_anonymous_declaration_rest(&specifiers, append_declaration);
+ parse_anonymous_declaration_rest(&specifiers);
} else {
declaration_t *declaration = parse_declarator(&specifiers, /*may_be_abstract=*/false);
parse_declaration_rest(declaration, &specifiers, finished_declaration);
break;
}
- case STATEMENT_MS_TRY:
- case STATEMENT_LEAVE:
- panic("unimplemented");
+ case STATEMENT_MS_TRY: {
+ ms_try_statement_t const *const ms_try = &stmt->ms_try;
+ check_reachable(ms_try->try_statement);
+ next = ms_try->final_statement;
+ break;
+ }
+
+ case STATEMENT_LEAVE: {
+ statement_t *parent = stmt;
+ for (;;) {
+ parent = parent->base.parent;
+ if (parent == NULL) /* __leave not within __try */
+ return;
+
+ if (parent->kind == STATEMENT_MS_TRY) {
+ last = parent;
+ next = parent->ms_try.final_statement;
+ break;
+ }
+ }
+ break;
+ }
}
while (next == NULL) {
}
case STATEMENT_MS_TRY:
- panic("unimplemented");
+ last = next;
+ next = next->ms_try.final_statement;
+ break;
}
}
}
}
- check_unreachable(stmt->fors.body);
+ check_unreachable(fors->body);
break;
}
- case STATEMENT_MS_TRY:
- panic("unimplemented");
+ case STATEMENT_MS_TRY: {
+ ms_try_statement_t const *const ms_try = &stmt->ms_try;
+ check_unreachable(ms_try->try_statement);
+ check_unreachable(ms_try->final_statement);
+ }
}
if (stmt->base.next)
/* must be a declaration */
if (token.type == ';') {
- parse_anonymous_declaration_rest(&specifiers, append_declaration);
+ parse_anonymous_declaration_rest(&specifiers);
return;
}
switch (token.type) {
case ',':
case ';':
- parse_declaration_rest(ndeclaration, &specifiers, record_declaration);
- return;
-
case '=':
- parse_declaration_rest(ndeclaration, &specifiers, record_definition);
+ parse_declaration_rest(ndeclaration, &specifiers, record_declaration);
return;
}
warningf(HERE, "function '%Y' returns an aggregate",
ndeclaration->symbol);
}
+ if (warning.traditional && !type->function.unspecified_parameters) {
+ warningf(HERE, "traditional C rejects ISO C style function definition of function '%Y'",
+ ndeclaration->symbol);
+ }
+ if (warning.old_style_definition && type->function.unspecified_parameters) {
+ warningf(HERE, "old-style function definition '%Y'",
+ ndeclaration->symbol);
+ }
/* ยง 6.7.5.3 (14) a function definition with () means no
* parameters (and not unspecified parameters) */
ndeclaration->type = type;
}
- declaration_t *const declaration = record_definition(ndeclaration);
+ declaration_t *const declaration = record_declaration(ndeclaration, true);
if (ndeclaration != declaration) {
declaration->scope = ndeclaration->scope;
}
{
declaration_t *last_declaration = struct_declaration->scope.declarations;
if (last_declaration != NULL) {
- while(last_declaration->next != NULL) {
+ while (last_declaration->next != NULL) {
last_declaration = last_declaration->next;
}
}
- while(1) {
+ while (true) {
declaration_t *declaration;
if (token.type == ':') {
expression_t *size = parse_constant_expression();
if (!is_type_integer(type)) {
- errorf(HERE, "bitfield base type '%T' is not an "
- "integer type", orig_type);
+ errorf(HERE, "bitfield base type '%T' is not an integer type",
+ orig_type);
}
type_t *bitfield_type = make_bitfield_type(orig_type, size, &source_position);
"compound member '%Y' has incomplete type '%T'",
declaration->symbol, orig_type);
} else if (is_type_function(type)) {
- errorf(HERE, "compound member '%Y' must not have function "
- "type '%T'", declaration->symbol, orig_type);
+ errorf(HERE, "compound member '%Y' must not have function type '%T'",
+ declaration->symbol, orig_type);
}
}
}
eat('{');
add_anchor_token('}');
- while(token.type != '}' && token.type != T_EOF) {
+ while (token.type != '}' && token.type != T_EOF) {
declaration_specifiers_t specifiers;
memset(&specifiers, 0, sizeof(specifiers));
parse_declaration_specifiers(&specifiers);
declaration->type = type;
declaration->symbol = symbol;
declaration->source_position = *source_position;
+ declaration->implicit = true;
bool strict_prototypes_old = warning.strict_prototypes;
warning.strict_prototypes = false;
- record_declaration(declaration);
+ record_declaration(declaration, false);
warning.strict_prototypes = strict_prototypes_old;
return declaration;
{
switch (expression->kind) {
case EXPR_REFERENCE: return expression->reference.declaration->type;
- case EXPR_SELECT: return expression->select.compound_entry->type;
+
+ case EXPR_SELECT:
+ return get_qualified_type(expression->select.compound_entry->type,
+ expression->base.type->base.qualifiers);
case EXPR_UNARY_DEREFERENCE: {
const expression_t *const value = expression->unary.value;
next_token();
if (declaration == NULL) {
- if (! strict_mode && token.type == '(') {
- /* an implicitly defined function */
- if (warning.implicit_function_declaration) {
+ if (token.type == '(') {
+ /* an implicitly declared function */
+ if (strict_mode) {
+ errorf(HERE, "unknown symbol '%Y' found.", symbol);
+ } else if (warning.implicit_function_declaration) {
warningf(HERE, "implicit declaration of function '%Y'",
symbol);
}
&source_position);
} else {
errorf(HERE, "unknown symbol '%Y' found.", symbol);
- return create_invalid_expression();
+ declaration = create_error_declaration(symbol, STORAGE_CLASS_NONE);
}
}
- type_t *type = declaration->type;
+ type_t *type = declaration->type;
/* we always do the auto-type conversions; the & and sizeof parser contains
* code to revert this! */
declaration->symbol, &declaration->source_position);
}
}
+ if (warning.init_self && declaration == current_init_decl) {
+ current_init_decl = NULL;
+ warningf(&source_position,
+ "variable '%#T' is initialized by itself",
+ declaration->type, declaration->symbol);
+ }
return expression;
}
-static bool semantic_cast(expression_t *expression, type_t *orig_dest_type)
+static bool semantic_cast(expression_t *cast)
{
+ expression_t *expression = cast->unary.value;
+ type_t *orig_dest_type = cast->base.type;
type_t *orig_type_right = expression->base.type;
- type_t const *dest_type = skip_typeref(orig_dest_type);
- type_t const *orig_type = skip_typeref(orig_type_right);
- source_position_t const *pos = &expression->base.source_position;
+ type_t const *dst_type = skip_typeref(orig_dest_type);
+ type_t const *src_type = skip_typeref(orig_type_right);
+ source_position_t const *pos = &cast->base.source_position;
/* ยง6.5.4 A (void) cast is explicitly permitted, more for documentation than for utility. */
- if (dest_type == type_void)
+ if (dst_type == type_void)
return true;
- if (is_type_pointer(dest_type)) {
- /* only integer and pointer can be casted to pointer */
- if (!is_type_pointer(orig_type) &&
- !is_type_integer(orig_type) &&
- is_type_valid(orig_type)) {
- errorf(pos, "cannot convert type '%T' to a pointer type", orig_type_right);
- return false;
- }
+ /* only integer and pointer can be casted to pointer */
+ if (is_type_pointer(dst_type) &&
+ !is_type_pointer(src_type) &&
+ !is_type_integer(src_type) &&
+ is_type_valid(src_type)) {
+ errorf(pos, "cannot convert type '%T' to a pointer type", orig_type_right);
+ return false;
}
- if (!is_type_scalar(dest_type) && is_type_valid(dest_type)) {
+ if (!is_type_scalar(dst_type) && is_type_valid(dst_type)) {
errorf(pos, "conversion to non-scalar type '%T' requested", orig_dest_type);
return false;
}
- if (!is_type_scalar(orig_type) && is_type_valid(orig_type)) {
+ if (!is_type_scalar(src_type) && is_type_valid(src_type)) {
errorf(pos, "conversion from non-scalar type '%T' requested", orig_type_right);
return false;
}
if (warning.cast_qual &&
- is_type_pointer(orig_type) &&
- is_type_pointer(dest_type)) {
- type_t *src = skip_typeref(orig_type->pointer.points_to);
- type_t *dst = skip_typeref(dest_type->pointer.points_to);
+ is_type_pointer(src_type) &&
+ is_type_pointer(dst_type)) {
+ type_t *src = skip_typeref(src_type->pointer.points_to);
+ type_t *dst = skip_typeref(dst_type->pointer.points_to);
unsigned missing_qualifiers =
src->base.qualifiers & ~dst->base.qualifiers;
if (missing_qualifiers != 0) {
warningf(pos,
"cast discards qualifiers '%Q' in pointer target type of '%T'",
- missing_qualifiers, orig_type_right);
+ missing_qualifiers, orig_type_right);
}
}
return true;
cast->base.source_position = source_position;
expression_t *value = parse_sub_expression(20);
-
- if (! semantic_cast(value, type))
- goto end_error;
-
cast->base.type = type;
cast->unary.value = value;
+ if (! semantic_cast(cast)) {
+ /* TODO: record the error in the AST. else it is impossible to detect it */
+ }
+
return cast;
end_error:
return create_invalid_expression();
parse_error_expected("while parsing select", T_IDENTIFIER, NULL);
return select;
}
- symbol_t *symbol = token.v.symbol;
- select->select.symbol = symbol;
+ symbol_t *symbol = token.v.symbol;
next_token();
type_t *const orig_type = compound->base.type;
type_t *const type = skip_typeref(orig_type);
- type_t *type_left = type;
- if (is_pointer) {
- if (!is_type_pointer(type)) {
- if (is_type_valid(type)) {
- errorf(HERE, "left hand side of '->' is not a pointer, but '%T'", orig_type);
- }
- return create_invalid_expression();
+ type_t *type_left;
+ bool saw_error = false;
+ if (is_type_pointer(type)) {
+ if (!is_pointer) {
+ errorf(HERE,
+ "request for member '%Y' in something not a struct or union, but '%T'",
+ symbol, orig_type);
+ saw_error = true;
}
- type_left = type->pointer.points_to;
- }
- type_left = skip_typeref(type_left);
-
- if (type_left->kind != TYPE_COMPOUND_STRUCT &&
- type_left->kind != TYPE_COMPOUND_UNION) {
- if (is_type_valid(type_left)) {
- errorf(HERE, "request for member '%Y' in something not a struct or "
- "union, but '%T'", symbol, type_left);
+ type_left = skip_typeref(type->pointer.points_to);
+ } else {
+ if (is_pointer && is_type_valid(type)) {
+ errorf(HERE, "left hand side of '->' is not a pointer, but '%T'", orig_type);
+ saw_error = true;
}
- return create_invalid_expression();
+ type_left = type;
}
- declaration_t *const declaration = type_left->compound.declaration;
+ declaration_t *entry;
+ if (type_left->kind == TYPE_COMPOUND_STRUCT ||
+ type_left->kind == TYPE_COMPOUND_UNION) {
+ declaration_t *const declaration = type_left->compound.declaration;
- if (!declaration->init.complete) {
- errorf(HERE, "request for member '%Y' of incomplete type '%T'",
- symbol, type_left);
- return create_invalid_expression();
- }
+ if (!declaration->init.complete) {
+ errorf(HERE, "request for member '%Y' of incomplete type '%T'",
+ symbol, type_left);
+ return create_invalid_expression();
+ }
- declaration_t *iter = find_compound_entry(declaration, symbol);
- if (iter == NULL) {
- errorf(HERE, "'%T' has no member named '%Y'", orig_type, symbol);
- return create_invalid_expression();
+ entry = find_compound_entry(declaration, symbol);
+ if (entry == NULL) {
+ errorf(HERE, "'%T' has no member named '%Y'", orig_type, symbol);
+ goto create_error_entry;
+ }
+ } else {
+ if (is_type_valid(type_left) && !saw_error) {
+ errorf(HERE,
+ "request for member '%Y' in something not a struct or union, but '%T'",
+ symbol, type_left);
+ }
+create_error_entry:
+ entry = allocate_declaration_zero();
+ entry->symbol = symbol;
}
+ select->select.compound_entry = entry;
+
+ type_t *const res_type =
+ get_qualified_type(entry->type, type_left->base.qualifiers);
+
/* we always do the auto-type conversions; the & and sizeof parser contains
* code to revert this! */
- type_t *expression_type = automatic_type_conversion(iter->type);
-
- select->select.compound_entry = iter;
- select->base.type = expression_type;
+ select->base.type = automatic_type_conversion(res_type);
- type_t *skipped = skip_typeref(iter->type);
+ type_t *skipped = skip_typeref(res_type);
if (skipped->kind == TYPE_BITFIELD) {
select->base.type = skipped->bitfield.base_type;
}
}
static void check_call_argument(const function_parameter_t *parameter,
- call_argument_t *argument)
+ call_argument_t *argument, unsigned pos)
{
type_t *expected_type = parameter->type;
type_t *expected_type_skip = skip_typeref(expected_type);
assign_error_t error = ASSIGN_ERROR_INCOMPATIBLE;
expression_t *arg_expr = argument->expression;
+ type_t *arg_type = skip_typeref(arg_expr->base.type);
/* handle transparent union gnu extension */
if (is_type_union(expected_type_skip)
argument->expression = create_implicit_cast(argument->expression,
expected_type);
- /* TODO report exact scope in error messages (like "in 3rd parameter") */
- report_assign_error(error, expected_type, arg_expr, "function call",
- &arg_expr->base.source_position);
+ if (error != ASSIGN_SUCCESS) {
+ /* report exact scope in error messages (like "in argument 3") */
+ char buf[64];
+ snprintf(buf, sizeof(buf), "call argument %u", pos);
+ report_assign_error(error, expected_type, arg_expr, buf,
+ &arg_expr->base.source_position);
+ } else if (warning.traditional | warning.conversion) {
+ if (
+ /* passing as integer instead of float or complex */
+ (is_type_integer(expected_type) &&
+ (is_type_float(arg_type) || is_type_complex(arg_type))) ||
+ /* passing as complex instead of integer or float */
+ (is_type_complex(expected_type) &&
+ (is_type_integer(arg_type) || is_type_float(arg_type))) ||
+ /* passing as float instead of integer or complex */
+ (is_type_float(expected_type) &&
+ (is_type_integer(arg_type) || is_type_complex(arg_type))) ||
+ /* passing as float instead of double */
+ (is_type_float(expected_type) && expected_type != type_double &&
+ is_type_float(arg_type))) {
+ warningf(&arg_expr->base.source_position,
+ "passing call argument %u as '%T' rather than '%T' due to prototype",
+ pos, expected_type, arg_type);
+ }
+ if (is_type_integer(expected_type) && is_type_integer(arg_type)) {
+ /* TODO check for size HERE */
+ }
+ }
}
/**
if (token.type != ')') {
call_argument_t *last_argument = NULL;
- while(true) {
+ while (true) {
call_argument_t *argument = allocate_ast_zero(sizeof(argument[0]));
argument->expression = parse_assignment_expression();
function_parameter_t *parameter = function_type->parameters;
call_argument_t *argument = call->arguments;
if (!function_type->unspecified_parameters) {
- for( ; parameter != NULL && argument != NULL;
+ for (unsigned pos = 0; parameter != NULL && argument != NULL;
parameter = parameter->next, argument = argument->next) {
- check_call_argument(parameter, argument);
+ check_call_argument(parameter, argument, ++pos);
}
if (parameter != NULL) {
to = type_void;
}
- type_t *const copy = duplicate_type(to);
- copy->base.qualifiers = to1->base.qualifiers | to2->base.qualifiers;
-
- type_t *const type = typehash_insert(copy);
- if (type != copy)
- free_type(copy);
-
+ type_t *const type =
+ get_qualified_type(to, to1->base.qualifiers | to2->base.qualifiers);
result_type = make_pointer_type(type, TYPE_QUALIFIER_NONE);
} else if (is_type_integer(other_type)) {
warningf(&conditional->base.source_position,
return true;
}
+static bool is_lvalue(const expression_t *expression)
+{
+ switch (expression->kind) {
+ case EXPR_REFERENCE:
+ case EXPR_ARRAY_ACCESS:
+ case EXPR_SELECT:
+ case EXPR_UNARY_DEREFERENCE:
+ return true;
+
+ default:
+ return false;
+ }
+}
+
static void semantic_incdec(unary_expression_t *expression)
{
type_t *const orig_type = expression->value->base.type;
"operation needs an arithmetic or pointer type");
return;
}
+ if (!is_lvalue(expression->value)) {
+ /* TODO: improve error message */
+ errorf(&expression->base.source_position, "lvalue required as operand");
+ }
expression->base.type = orig_type;
}
if (is_type_valid(type)) {
/* TODO: improve error message */
errorf(&expression->base.source_position,
- "operation needs an arithmetic type");
+ "operation needs an arithmetic type");
}
return;
}
expression->base.type = orig_type;
}
+static void semantic_unexpr_plus(unary_expression_t *expression)
+{
+ semantic_unexpr_arithmetic(expression);
+ if (warning.traditional)
+ warningf(&expression->base.source_position,
+ "traditional C rejects the unary plus operator");
+}
+
static void semantic_not(unary_expression_t *expression)
{
type_t *const orig_type = expression->value->base.type;
expression->base.type = result_type;
}
+/**
+ * Record that an address is taken (expression represents an lvalue).
+ *
+ * @param expression the expression
+ * @param may_be_register if true, the expression might be an register
+ */
static void set_address_taken(expression_t *expression, bool may_be_register)
{
if (expression->kind != EXPR_REFERENCE)
CREATE_UNARY_EXPRESSION_PARSER('-', EXPR_UNARY_NEGATE,
semantic_unexpr_arithmetic)
CREATE_UNARY_EXPRESSION_PARSER('+', EXPR_UNARY_PLUS,
- semantic_unexpr_arithmetic)
+ semantic_unexpr_plus)
CREATE_UNARY_EXPRESSION_PARSER('!', EXPR_UNARY_NOT,
semantic_not)
CREATE_UNARY_EXPRESSION_PARSER('*', EXPR_UNARY_DEREFERENCE,
return false;
}
-static bool is_lvalue(const expression_t *expression)
-{
- switch (expression->kind) {
- case EXPR_REFERENCE:
- case EXPR_ARRAY_ACCESS:
- case EXPR_SELECT:
- case EXPR_UNARY_DEREFERENCE:
- return true;
-
- default:
- return false;
- }
-}
-
static bool is_valid_assignment_lhs(expression_t const* const left)
{
type_t *const orig_type_left = revert_automatic_type_conversion(left);
expression_t *left = expression->left;
type_t *orig_type_left = left->base.type;
- type_t *type_left = revert_automatic_type_conversion(left);
- type_left = skip_typeref(orig_type_left);
-
if (!is_valid_assignment_lhs(left))
return;
type_t * type = skip_typeref(expr->base.type);
if (is_type_integer(type)) {
type = promote_integer(type);
+ if (warning.traditional) {
+ if (get_rank(type) >= get_akind_rank(ATOMIC_TYPE_LONG)) {
+ warningf(&expr->base.source_position,
+ "'%T' switch expression not converted to '%T' in ISO C",
+ type, type_int);
+ }
+ }
} else if (is_type_valid(type)) {
errorf(&expr->base.source_position,
"switch quantity is not an integer, but '%T'", type);
*/
static statement_t *parse_continue(void)
{
- statement_t *statement;
if (current_loop == NULL) {
errorf(HERE, "continue statement not within loop");
- statement = create_invalid_statement();
- } else {
- statement = allocate_statement_zero(STATEMENT_CONTINUE);
-
- statement->base.source_position = token.source_position;
}
+ statement_t *statement = allocate_statement_zero(STATEMENT_CONTINUE);
+ statement->base.source_position = token.source_position;
+
eat(T_continue);
expect(';');
- return statement;
end_error:
- return create_invalid_statement();
+ return statement;
}
/**
*/
static statement_t *parse_break(void)
{
- statement_t *statement;
if (current_switch == NULL && current_loop == NULL) {
errorf(HERE, "break statement not within loop or switch");
- statement = create_invalid_statement();
- } else {
- statement = allocate_statement_zero(STATEMENT_BREAK);
-
- statement->base.source_position = token.source_position;
}
+ statement_t *statement = allocate_statement_zero(STATEMENT_BREAK);
+ statement->base.source_position = token.source_position;
+
eat(T_break);
expect(';');
- return statement;
end_error:
- return create_invalid_statement();
+ return statement;
}
/**
*/
static statement_t *parse_leave(void)
{
- statement_t *statement;
if (current_try == NULL) {
errorf(HERE, "__leave statement not within __try");
- statement = create_invalid_statement();
- } else {
- statement = allocate_statement_zero(STATEMENT_LEAVE);
-
- statement->base.source_position = token.source_position;
}
+ statement_t *statement = allocate_statement_zero(STATEMENT_LEAVE);
+ statement->base.source_position = token.source_position;
+
eat(T___leave);
expect(';');
- return statement;
end_error:
- return create_invalid_statement();
+ return statement;
}
/**
if (token.type != ';') {
return_value = parse_expression();
}
- expect(';');
const type_t *const func_type = current_function->type;
assert(is_type_function(func_type));
}
statement->returns.value = return_value;
- return statement;
+ expect(';');
+
end_error:
- return create_invalid_statement();
+ return statement;
}
/**
expect(';');
- return statement;
end_error:
- return create_invalid_statement();
+ return statement;
}
/**
static statement_t *parse_ms_try_statment(void)
{
statement_t *statement = allocate_statement_zero(STATEMENT_MS_TRY);
-
statement->base.source_position = token.source_position;
eat(T___try);
+ PUSH_PARENT(statement);
+
ms_try_statement_t *rem = current_try;
current_try = &statement->ms_try;
statement->ms_try.try_statement = parse_compound_statement(false);
current_try = rem;
+ POP_PARENT;
+
if (token.type == T___except) {
eat(T___except);
expect('(');
/* declaration or statement */
add_anchor_token(';');
switch (token.type) {
- case T_IDENTIFIER:
- if (look_ahead(1)->type == ':') {
+ case T_IDENTIFIER: {
+ token_type_t la1_type = (token_type_t)look_ahead(1)->type;
+ if (la1_type == ':') {
statement = parse_label_statement();
} else if (is_typedef_symbol(token.v.symbol)) {
statement = parse_declaration_statement();
- } else {
- statement = parse_expression_statement();
+ } else switch (la1_type) {
+ DECLARATION_START
+ case T_IDENTIFIER:
+ case '*':
+ statement = parse_declaration_statement();
+ break;
+
+ default:
+ statement = parse_expression_statement();
+ break;
}
break;
+ }
case T___extension__:
/* This can be a prefix to a declaration or an expression statement.