Implement __builtin_types_compatible_p().
[cparser] / parser.c
index 0eb90d5..b993871 100644 (file)
--- a/parser.c
+++ b/parser.c
@@ -42,7 +42,7 @@
 #include "adt/array.h"
 
 //#define PRINT_TOKENS
-#define MAX_LOOKAHEAD 2
+#define MAX_LOOKAHEAD 1
 
 typedef struct {
        entity_t           *old_entity;
@@ -65,7 +65,7 @@ struct gnu_attribute_t {
        union {
                size_t              value;
                string_t            string;
-               atomic_type_kind_t  akind;
+               symbol_t           *symbol;
                long                argument;  /**< Single argument. */
                argument_list_t    *arguments; /**< List of argument expressions. */
        } u;
@@ -113,7 +113,7 @@ static token_t              token;
 /** The lookahead ring-buffer. */
 static token_t              lookahead_buffer[MAX_LOOKAHEAD];
 /** Position of the next token in the lookahead buffer. */
-static int                  lookahead_bufpos;
+static size_t               lookahead_bufpos;
 static stack_entry_t       *environment_stack = NULL;
 static stack_entry_t       *label_stack       = NULL;
 static scope_t             *file_scope        = NULL;
@@ -351,7 +351,7 @@ static size_t get_entity_struct_size(entity_kind_t kind)
                [ENTITY_LOCAL_LABEL]     = sizeof(label_t),
                [ENTITY_NAMESPACE]       = sizeof(namespace_t)
        };
-       assert(kind < sizeof(sizes) / sizeof(sizes[0]));
+       assert(kind < lengthof(sizes));
        assert(sizes[kind] != 0);
        return sizes[kind];
 }
@@ -396,7 +396,7 @@ static size_t get_statement_struct_size(statement_kind_t kind)
                [STATEMENT_MS_TRY]      = sizeof(ms_try_statement_t),
                [STATEMENT_LEAVE]       = sizeof(leave_statement_t)
        };
-       assert(kind < sizeof(sizes) / sizeof(sizes[0]));
+       assert(kind < lengthof(sizes));
        assert(sizes[kind] != 0);
        return sizes[kind];
 }
@@ -409,33 +409,34 @@ static size_t get_statement_struct_size(statement_kind_t kind)
 static size_t get_expression_struct_size(expression_kind_t kind)
 {
        static const size_t sizes[] = {
-               [EXPR_INVALID]                 = sizeof(expression_base_t),
-               [EXPR_REFERENCE]               = sizeof(reference_expression_t),
-               [EXPR_REFERENCE_ENUM_VALUE]    = sizeof(reference_expression_t),
-               [EXPR_CONST]                   = sizeof(const_expression_t),
-               [EXPR_CHARACTER_CONSTANT]      = sizeof(const_expression_t),
-               [EXPR_WIDE_CHARACTER_CONSTANT] = sizeof(const_expression_t),
-               [EXPR_STRING_LITERAL]          = sizeof(string_literal_expression_t),
-               [EXPR_WIDE_STRING_LITERAL]     = sizeof(wide_string_literal_expression_t),
-               [EXPR_COMPOUND_LITERAL]        = sizeof(compound_literal_expression_t),
-               [EXPR_CALL]                    = sizeof(call_expression_t),
-               [EXPR_UNARY_FIRST]             = sizeof(unary_expression_t),
-               [EXPR_BINARY_FIRST]            = sizeof(binary_expression_t),
-               [EXPR_CONDITIONAL]             = sizeof(conditional_expression_t),
-               [EXPR_SELECT]                  = sizeof(select_expression_t),
-               [EXPR_ARRAY_ACCESS]            = sizeof(array_access_expression_t),
-               [EXPR_SIZEOF]                  = sizeof(typeprop_expression_t),
-               [EXPR_ALIGNOF]                 = sizeof(typeprop_expression_t),
-               [EXPR_CLASSIFY_TYPE]           = sizeof(classify_type_expression_t),
-               [EXPR_FUNCNAME]                = sizeof(funcname_expression_t),
-               [EXPR_BUILTIN_SYMBOL]          = sizeof(builtin_symbol_expression_t),
-               [EXPR_BUILTIN_CONSTANT_P]      = sizeof(builtin_constant_expression_t),
-               [EXPR_BUILTIN_PREFETCH]        = sizeof(builtin_prefetch_expression_t),
-               [EXPR_OFFSETOF]                = sizeof(offsetof_expression_t),
-               [EXPR_VA_START]                = sizeof(va_start_expression_t),
-               [EXPR_VA_ARG]                  = sizeof(va_arg_expression_t),
-               [EXPR_STATEMENT]               = sizeof(statement_expression_t),
-               [EXPR_LABEL_ADDRESS]           = sizeof(label_address_expression_t),
+               [EXPR_INVALID]                    = sizeof(expression_base_t),
+               [EXPR_REFERENCE]                  = sizeof(reference_expression_t),
+               [EXPR_REFERENCE_ENUM_VALUE]       = sizeof(reference_expression_t),
+               [EXPR_CONST]                      = sizeof(const_expression_t),
+               [EXPR_CHARACTER_CONSTANT]         = sizeof(const_expression_t),
+               [EXPR_WIDE_CHARACTER_CONSTANT]    = sizeof(const_expression_t),
+               [EXPR_STRING_LITERAL]             = sizeof(string_literal_expression_t),
+               [EXPR_WIDE_STRING_LITERAL]        = sizeof(wide_string_literal_expression_t),
+               [EXPR_COMPOUND_LITERAL]           = sizeof(compound_literal_expression_t),
+               [EXPR_CALL]                       = sizeof(call_expression_t),
+               [EXPR_UNARY_FIRST]                = sizeof(unary_expression_t),
+               [EXPR_BINARY_FIRST]               = sizeof(binary_expression_t),
+               [EXPR_CONDITIONAL]                = sizeof(conditional_expression_t),
+               [EXPR_SELECT]                     = sizeof(select_expression_t),
+               [EXPR_ARRAY_ACCESS]               = sizeof(array_access_expression_t),
+               [EXPR_SIZEOF]                     = sizeof(typeprop_expression_t),
+               [EXPR_ALIGNOF]                    = sizeof(typeprop_expression_t),
+               [EXPR_CLASSIFY_TYPE]              = sizeof(classify_type_expression_t),
+               [EXPR_FUNCNAME]                   = sizeof(funcname_expression_t),
+               [EXPR_BUILTIN_SYMBOL]             = sizeof(builtin_symbol_expression_t),
+               [EXPR_BUILTIN_CONSTANT_P]         = sizeof(builtin_constant_expression_t),
+               [EXPR_BUILTIN_TYPES_COMPATIBLE_P] = sizeof(builtin_types_compatible_expression_t),
+               [EXPR_BUILTIN_PREFETCH]           = sizeof(builtin_prefetch_expression_t),
+               [EXPR_OFFSETOF]                   = sizeof(offsetof_expression_t),
+               [EXPR_VA_START]                   = sizeof(va_start_expression_t),
+               [EXPR_VA_ARG]                     = sizeof(va_arg_expression_t),
+               [EXPR_STATEMENT]                  = sizeof(statement_expression_t),
+               [EXPR_LABEL_ADDRESS]              = sizeof(label_address_expression_t),
        };
        if (kind >= EXPR_UNARY_FIRST && kind <= EXPR_UNARY_LAST) {
                return sizes[EXPR_UNARY_FIRST];
@@ -443,7 +444,7 @@ static size_t get_expression_struct_size(expression_kind_t kind)
        if (kind >= EXPR_BINARY_FIRST && kind <= EXPR_BINARY_LAST) {
                return sizes[EXPR_BINARY_FIRST];
        }
-       assert(kind < sizeof(sizes) / sizeof(sizes[0]));
+       assert(kind < lengthof(sizes));
        assert(sizes[kind] != 0);
        return sizes[kind];
 }
@@ -526,7 +527,7 @@ static size_t get_type_struct_size(type_kind_t kind)
                [TYPE_TYPEDEF]         = sizeof(typedef_type_t),
                [TYPE_TYPEOF]          = sizeof(typeof_type_t),
        };
-       assert(sizeof(sizes) / sizeof(sizes[0]) == (int) TYPE_TYPEOF + 1);
+       assert(lengthof(sizes) == (int)TYPE_TYPEOF + 1);
        assert(kind <= TYPE_TYPEOF);
        assert(sizes[kind] != 0);
        return sizes[kind];
@@ -562,7 +563,7 @@ static size_t get_initializer_size(initializer_kind_t kind)
                [INITIALIZER_LIST]        = sizeof(initializer_list_t),
                [INITIALIZER_DESIGNATOR]  = sizeof(initializer_designator_t)
        };
-       assert(kind < sizeof(sizes) / sizeof(*sizes));
+       assert(kind < lengthof(sizes));
        assert(sizes[kind] != 0);
        return sizes[kind];
 }
@@ -604,7 +605,7 @@ static inline void next_token(void)
        lookahead_buffer[lookahead_bufpos] = lexer_token;
        lexer_next_token();
 
-       lookahead_bufpos = (lookahead_bufpos+1) % MAX_LOOKAHEAD;
+       lookahead_bufpos = (lookahead_bufpos + 1) % MAX_LOOKAHEAD;
 
 #ifdef PRINT_TOKENS
        print_token(stderr, &token);
@@ -615,10 +616,10 @@ static inline void next_token(void)
 /**
  * Return the next token with a given lookahead.
  */
-static inline const token_t *look_ahead(int num)
+static inline const token_t *look_ahead(size_t num)
 {
-       assert(num > 0 && num <= MAX_LOOKAHEAD);
-       int pos = (lookahead_bufpos+num-1) % MAX_LOOKAHEAD;
+       assert(0 < num && num <= MAX_LOOKAHEAD);
+       size_t pos = (lookahead_bufpos + num - 1) % MAX_LOOKAHEAD;
        return &lookahead_buffer[pos];
 }
 
@@ -749,7 +750,7 @@ static void eat_block(void)
                next_token();
 }
 
-#define eat(token_type)  do { assert(token.type == (token_type)); next_token(); } while (0)
+#define eat(token_type) (assert(token.type == (token_type)), next_token())
 
 /**
  * Report a parse error because an expected token was not found.
@@ -969,13 +970,8 @@ static int get_akind_rank(atomic_type_kind_t akind)
 static int get_rank(const type_t *type)
 {
        assert(!is_typeref(type));
-       /* The C-standard allows promoting enums to int or unsigned int (see § 7.2.2
-        * and esp. footnote 108). However we can't fold constants (yet), so we
-        * can't decide whether unsigned int is possible, while int always works.
-        * (unsigned int would be preferable when possible... for stuff like
-        *  struct { enum { ... } bla : 4; } ) */
        if (type->kind == TYPE_ENUM)
-               return get_akind_rank(ATOMIC_TYPE_INT);
+               return get_akind_rank(type->enumt.akind);
 
        assert(type->kind == TYPE_ATOMIC);
        return get_akind_rank(type->atomic.akind);
@@ -1465,35 +1461,13 @@ static void parse_gnu_attribute_model_arg(gnu_attribute_t *attribute)
  */
 static void parse_gnu_attribute_mode_arg(gnu_attribute_t *attribute)
 {
-       /* TODO: find out what is allowed here... */
-
-       /* at least: byte, word, pointer, list of machine modes
-        * __XXX___ is interpreted as XXX */
        add_anchor_token(')');
 
        if (token.type != T_IDENTIFIER) {
                expect(T_IDENTIFIER, end_error);
        }
 
-       /* This isn't really correct, the backend should provide a list of machine
-        * specific modes (according to gcc philosophy that is...) */
-       const char *symbol_str = token.v.symbol->string;
-       if (strcmp_underscore("QI",   symbol_str) == 0 ||
-           strcmp_underscore("byte", symbol_str) == 0) {
-               attribute->u.akind = ATOMIC_TYPE_CHAR;
-       } else if (strcmp_underscore("HI", symbol_str) == 0) {
-               attribute->u.akind = ATOMIC_TYPE_SHORT;
-       } else if (strcmp_underscore("SI",      symbol_str) == 0
-               || strcmp_underscore("word",    symbol_str) == 0
-               || strcmp_underscore("pointer", symbol_str) == 0) {
-               attribute->u.akind = ATOMIC_TYPE_INT;
-       } else if (strcmp_underscore("DI", symbol_str) == 0) {
-               attribute->u.akind = ATOMIC_TYPE_LONGLONG;
-       } else {
-               if (warning.other)
-                       warningf(HERE, "ignoring unknown mode '%s'", symbol_str);
-               attribute->invalid = true;
-       }
+       attribute->u.symbol = token.v.symbol;
        next_token();
 
        rem_anchor_token(')');
@@ -2166,6 +2140,7 @@ unary:
                case EXPR_FUNCNAME:
                case EXPR_BUILTIN_SYMBOL:
                case EXPR_BUILTIN_CONSTANT_P:
+               case EXPR_BUILTIN_TYPES_COMPATIBLE_P:
                case EXPR_BUILTIN_PREFETCH:
                case EXPR_OFFSETOF:
                case EXPR_STATEMENT: // TODO
@@ -2274,6 +2249,7 @@ static initializer_t *initializer_from_expression(type_t *orig_type,
                                                return initializer_from_string(array_type,
                                                        &expression->string.value);
                                        }
+                                       break;
 
                                case EXPR_WIDE_STRING_LITERAL: {
                                        type_t *bare_wchar_type = skip_typeref(type_wchar_t);
@@ -2281,6 +2257,7 @@ static initializer_t *initializer_from_expression(type_t *orig_type,
                                                return initializer_from_wide_string(array_type,
                                                        &expression->wide_string.value);
                                        }
+                                       break;
                                }
 
                                default:
@@ -2934,7 +2911,7 @@ static initializer_t *parse_initializer(parse_initializer_env_t *env)
                result = parse_scalar_initializer(type, env->must_be_constant);
        }
 
-       /* § 6.7.8 (22) array initializers for arrays with unknown size determine
+       /* § 6.7.8:22 array initializers for arrays with unknown size determine
         * the array type size */
        if (is_type_array(type) && type->array.size_expression == NULL
                        && result != NULL) {
@@ -3167,6 +3144,7 @@ static type_t *parse_enum_specifier(void)
 
        type_t *const type = allocate_type_zero(TYPE_ENUM);
        type->enumt.enume  = &entity->enume;
+       type->enumt.akind  = ATOMIC_TYPE_INT;
 
        if (token.type == '{') {
                if (symbol != NULL) {
@@ -3610,54 +3588,63 @@ static void finish_union_type(compound_type_t *type)
        type->base.alignment = alignment;
 }
 
-static type_t *handle_mode_attribute(const gnu_attribute_t *attribute,
+static type_t *handle_attribute_mode(const gnu_attribute_t *attribute,
                                      type_t *orig_type)
 {
        type_t *type = skip_typeref(orig_type);
-       if (type->kind != TYPE_ATOMIC) {
-               errorf(HERE,
-                          "__attribute__(mode)) only allowed for atomic types");
+
+       /* at least: byte, word, pointer, list of machine modes
+        * __XXX___ is interpreted as XXX */
+
+       /* This isn't really correct, the backend should provide a list of machine
+        * specific modes (according to gcc philosophy that is...) */
+       const char         *symbol_str = attribute->u.symbol->string;
+       bool                sign       = is_type_signed(type);
+       atomic_type_kind_t  akind;
+       if (strcmp_underscore("QI",   symbol_str) == 0 ||
+           strcmp_underscore("byte", symbol_str) == 0) {
+               akind = sign ? ATOMIC_TYPE_CHAR : ATOMIC_TYPE_UCHAR;
+       } else if (strcmp_underscore("HI", symbol_str) == 0) {
+               akind = sign ? ATOMIC_TYPE_SHORT : ATOMIC_TYPE_USHORT;
+       } else if (strcmp_underscore("SI",      symbol_str) == 0
+               || strcmp_underscore("word",    symbol_str) == 0
+               || strcmp_underscore("pointer", symbol_str) == 0) {
+               akind = sign ? ATOMIC_TYPE_INT : ATOMIC_TYPE_UINT;
+       } else if (strcmp_underscore("DI", symbol_str) == 0) {
+               akind = sign ? ATOMIC_TYPE_LONGLONG : ATOMIC_TYPE_ULONGLONG;
+       } else {
+               if (warning.other)
+                       warningf(HERE, "ignoring unknown mode '%s'", symbol_str);
                return orig_type;
        }
-       atomic_type_kind_t  akind = attribute->u.akind;
-       if (!is_type_signed(type)) {
-               switch (akind) {
-               case ATOMIC_TYPE_CHAR: akind = ATOMIC_TYPE_UCHAR; break;
-               case ATOMIC_TYPE_SHORT: akind = ATOMIC_TYPE_USHORT; break;
-               case ATOMIC_TYPE_INT: akind = ATOMIC_TYPE_UINT; break;
-               case ATOMIC_TYPE_LONGLONG: akind = ATOMIC_TYPE_ULONGLONG; break;
-               default:
-                       errorf(HERE, "invalid akind in mode attribute");
-                       return orig_type;
-               }
-       } else {
-               switch (akind) {
-               case ATOMIC_TYPE_CHAR: akind = ATOMIC_TYPE_SCHAR; break;
-               case ATOMIC_TYPE_SHORT: akind = ATOMIC_TYPE_SHORT; break;
-               case ATOMIC_TYPE_INT: akind = ATOMIC_TYPE_INT; break;
-               case ATOMIC_TYPE_LONGLONG: akind = ATOMIC_TYPE_LONGLONG; break;
-               default:
-                       errorf(HERE, "invalid akind in mode attribute");
-                       return orig_type;
-               }
+
+       if (type->kind == TYPE_ATOMIC) {
+               type_t *copy       = duplicate_type(type);
+               copy->atomic.akind = akind;
+               return identify_new_type(copy);
+       } else if (type->kind == TYPE_ENUM) {
+               type_t *copy      = duplicate_type(type);
+               copy->enumt.akind = akind;
+               return identify_new_type(copy);
+       } else if (is_type_pointer(type)) {
+               warningf(HERE, "__attribute__((mode)) on pointers not implemented yet (ignored)");
+               return type;
        }
 
-       type_t *copy       = duplicate_type(type);
-       copy->atomic.akind = akind;
-       return identify_new_type(copy);
+       errorf(HERE, "__attribute__((mode)) only allowed on integer, enum or pointer type");
+       return orig_type;
 }
 
 static type_t *handle_type_attributes(const gnu_attribute_t *attributes,
                                       type_t *type)
 {
-       /* handle these strange/stupid mode attributes */
        const gnu_attribute_t *attribute = attributes;
        for ( ; attribute != NULL; attribute = attribute->next) {
                if (attribute->invalid)
                        continue;
 
                if (attribute->kind == GNU_AK_MODE) {
-                       type = handle_mode_attribute(attribute, type);
+                       type = handle_attribute_mode(attribute, type);
                } else if (attribute->kind == GNU_AK_ALIGNED) {
                        int alignment = 32; /* TODO: fill in maximum useful alignment for
                                               target machine */
@@ -4104,7 +4091,11 @@ warn_about_long_long:
        type->base.qualifiers = qualifiers;
        type->base.modifiers  = modifiers;
 
-       type = identify_new_type(type);
+       if (newtype) {
+               type = identify_new_type(type);
+       } else {
+               type = typehash_insert(type);
+       }
 
        type = handle_type_attributes(specifiers->gnu_attributes, type);
        specifiers->type = type;
@@ -4607,14 +4598,13 @@ static void parse_declaration_attributes(entity_t *entity)
        if (type == NULL)
                return;
 
-       /* handle these strange/stupid mode attributes */
        gnu_attribute_t *attribute = attributes;
        for ( ; attribute != NULL; attribute = attribute->next) {
                if (attribute->invalid)
                        continue;
 
                if (attribute->kind == GNU_AK_MODE) {
-                       type = handle_mode_attribute(attribute, type);
+                       type = handle_attribute_mode(attribute, type);
                } else if (attribute->kind == GNU_AK_ALIGNED) {
                        int alignment = 32; /* TODO: fill in maximum usefull alignment for target machine */
                        if (attribute->has_arguments)
@@ -4667,7 +4657,7 @@ static type_t *construct_declarator_type(construct_type_t *construct_list, type_
                        function_type->function.return_type = type;
 
                        type_t *skipped_return_type = skip_typeref(type);
-                       /* §6.7.5.3(1) */
+                       /* §6.7.5.3:1 */
                        if (is_type_function(skipped_return_type)) {
                                errorf(HERE, "function returning function is not allowed");
                        } else if (is_type_array(skipped_return_type)) {
@@ -4729,7 +4719,7 @@ static type_t *construct_declarator_type(construct_type_t *construct_list, type_
                        }
 
                        type_t *skipped_type = skip_typeref(type);
-                       /* §6.7.5.2(1) */
+                       /* §6.7.5.2:1 */
                        if (is_type_incomplete(skipped_type)) {
                                errorf(HERE, "array of incomplete type '%T' is not allowed", type);
                        } else if (is_type_function(skipped_type)) {
@@ -5011,6 +5001,16 @@ static void error_redefined_as_different_kind(const source_position_t *pos,
               get_entity_kind_name(new_kind), &old->base.source_position);
 }
 
+static bool is_error_entity(entity_t *const ent)
+{
+       if (is_declaration(ent)) {
+               return is_type_valid(skip_typeref(ent->declaration.type));
+       } else if (ent->kind == ENTITY_TYPEDEF) {
+               return is_type_valid(skip_typeref(ent->typedefe.type));
+       }
+       return false;
+}
+
 /**
  * record entities for the NAMESPACE_NORMAL, and produce error messages/warnings
  * for various problems that occur for multiple definitions
@@ -5070,8 +5070,10 @@ static entity_t *record_entity(entity_t *entity, const bool is_definition)
        if (previous_entity != NULL &&
                        previous_entity->base.parent_scope == current_scope) {
                if (previous_entity->kind != entity->kind) {
-                       error_redefined_as_different_kind(pos, previous_entity,
-                                                         entity->kind);
+                       if (!is_error_entity(previous_entity) && !is_error_entity(entity)) {
+                               error_redefined_as_different_kind(pos, previous_entity,
+                                               entity->kind);
+                       }
                        goto finish;
                }
                if (previous_entity->kind == ENTITY_ENUM_VALUE) {
@@ -5107,7 +5109,7 @@ static entity_t *record_entity(entity_t *entity, const bool is_definition)
                type_t *const orig_type = decl->type;
                assert(orig_type != NULL);
                type_t *const type      = skip_typeref(orig_type);
-               type_t *      prev_type = skip_typeref(prev_decl->type);
+               type_t *const prev_type = skip_typeref(prev_decl->type);
 
                if (!types_compatible(type, prev_type)) {
                        errorf(pos,
@@ -5126,20 +5128,16 @@ static entity_t *record_entity(entity_t *entity, const bool is_definition)
                                         prev_decl->type, symbol);
                        }
 
-                       unsigned new_storage_class = decl->storage_class;
-                       if (is_type_incomplete(prev_type)) {
-                               prev_decl->type = type;
-                               prev_type       = type;
-                       }
+                       storage_class_t new_storage_class = decl->storage_class;
 
                        /* pretend no storage class means extern for function
                         * declarations (except if the previous declaration is neither
                         * none nor extern) */
                        if (entity->kind == ENTITY_FUNCTION) {
-                               if (prev_type->function.unspecified_parameters) {
+                               /* the previous declaration could have unspecified parameters or
+                                * be a typedef, so use the new type */
+                               if (prev_type->function.unspecified_parameters || is_definition)
                                        prev_decl->type = type;
-                                       prev_type       = type;
-                               }
 
                                switch (old_storage_class) {
                                case STORAGE_CLASS_NONE:
@@ -5162,6 +5160,8 @@ static entity_t *record_entity(entity_t *entity, const bool is_definition)
                                default:
                                        break;
                                }
+                       } else if (is_type_incomplete(prev_type)) {
+                               prev_decl->type = type;
                        }
 
                        if (old_storage_class == STORAGE_CLASS_EXTERN &&
@@ -5308,7 +5308,7 @@ static void parse_init_declarator_rest(entity_t *entity)
        current_init_decl = NULL;
 
        if (entity->kind == ENTITY_VARIABLE) {
-               /* § 6.7.5 (22)  array initializers for arrays with unknown size
+               /* § 6.7.5:22  array initializers for arrays with unknown size
                 * determine the array type size */
                declaration->type            = env.type;
                entity->variable.initializer = initializer;
@@ -5366,11 +5366,9 @@ static void check_variable_type_complete(entity_t *ent)
        if (!is_type_incomplete(type))
                return;
 
-       /* GCC allows global arrays without size and assigns them a length of one,
-        * if no different declaration follows */
-       if (is_type_array(type) &&
-                       c_mode & _GNUC      &&
-                       ent->base.parent_scope == file_scope) {
+       /* §6.9.2:2 and §6.9.2:5: At the end of the translation incomplete arrays
+        * are given length one. */
+       if (is_type_array(type) && ent->base.parent_scope == file_scope) {
                ARR_APP1(declaration_t*, incomplete_arrays, decl);
                return;
        }
@@ -5534,6 +5532,9 @@ decl_list_end:
 
        parameter = entity->function.parameters.entities;
        for (; parameter != NULL; parameter = parameter->base.next) {
+               if (parameter->kind != ENTITY_PARAMETER)
+                       continue;
+
                type_t *parameter_type = parameter->declaration.type;
                if (parameter_type == NULL) {
                        if (strict_mode) {
@@ -5750,6 +5751,7 @@ static bool expression_returns(expression_t const *const expr)
                case EXPR_FUNCNAME:
                case EXPR_BUILTIN_SYMBOL:
                case EXPR_BUILTIN_CONSTANT_P:
+               case EXPR_BUILTIN_TYPES_COMPATIBLE_P:
                case EXPR_BUILTIN_PREFETCH:
                case EXPR_OFFSETOF:
                case EXPR_INVALID:
@@ -6109,7 +6111,7 @@ found_break_parent:
                if (next == NULL) {
                        noreturn_candidate = false;
 
-                       type_t *const type = current_function->base.type;
+                       type_t *const type = skip_typeref(current_function->base.type);
                        assert(is_type_function(type));
                        type_t *const ret  = skip_typeref(type->function.return_type);
                        if (warning.return_type                    &&
@@ -6362,7 +6364,8 @@ static void parse_external_declaration(void)
        }
 
        assert(is_declaration(ndeclaration));
-       type_t *type = skip_typeref(ndeclaration->declaration.type);
+       type_t *const orig_type = ndeclaration->declaration.type;
+       type_t *      type      = skip_typeref(orig_type);
 
        if (!is_type_function(type)) {
                if (is_type_valid(type)) {
@@ -6371,6 +6374,11 @@ static void parse_external_declaration(void)
                }
                eat_block();
                return;
+       } else if (is_typeref(orig_type)) {
+               /* §6.9.1:2 */
+               errorf(&ndeclaration->base.source_position,
+                               "type of function definition '%#T' is a typedef",
+                               orig_type, ndeclaration->base.symbol);
        }
 
        if (warning.aggregate_return &&
@@ -6937,6 +6945,9 @@ static type_t *get_builtin_symbol_type(symbol_t *symbol)
                return make_function_1_type(type_void, type_valist);
        case T___builtin_expect:
                return make_function_2_type(type_long, type_long, type_long);
+       case T___builtin_return_address:
+       case T___builtin_frame_address:
+               return make_function_1_type(type_void_ptr, type_unsigned_int);
        default:
                internal_errorf(HERE, "not implemented builtin identifier found");
        }
@@ -7518,7 +7529,7 @@ static expression_t *parse_builtin_symbol(void)
 }
 
 /**
- * Parses a __builtin_constant() expression.
+ * Parses a __builtin_constant_p() expression.
  */
 static expression_t *parse_builtin_constant(void)
 {
@@ -7538,6 +7549,31 @@ end_error:
        return create_invalid_expression();
 }
 
+/**
+ * Parses a __builtin_types_compatible_p() expression.
+ */
+static expression_t *parse_builtin_types_compatible(void)
+{
+       expression_t *expression = allocate_expression_zero(EXPR_BUILTIN_TYPES_COMPATIBLE_P);
+
+       eat(T___builtin_types_compatible_p);
+
+       expect('(', end_error);
+       add_anchor_token(')');
+       add_anchor_token(',');
+       expression->builtin_types_compatible.left = parse_typename();
+       rem_anchor_token(',');
+       expect(',', end_error);
+       expression->builtin_types_compatible.right = parse_typename();
+       rem_anchor_token(')');
+       expect(')', end_error);
+       expression->base.type = type_int;
+
+       return expression;
+end_error:
+       return create_invalid_expression();
+}
+
 /**
  * Parses a __builtin_prefetch() expression.
  */
@@ -7779,23 +7815,23 @@ end_error:
 static expression_t *parse_primary_expression(void)
 {
        switch (token.type) {
-               case T_false:                    return parse_bool_const(false);
-               case T_true:                     return parse_bool_const(true);
-               case T_INTEGER:                  return parse_int_const();
-               case T_CHARACTER_CONSTANT:       return parse_character_constant();
-               case T_WIDE_CHARACTER_CONSTANT:  return parse_wide_character_constant();
-               case T_FLOATINGPOINT:            return parse_float_const();
+               case T_false:                        return parse_bool_const(false);
+               case T_true:                         return parse_bool_const(true);
+               case T_INTEGER:                      return parse_int_const();
+               case T_CHARACTER_CONSTANT:           return parse_character_constant();
+               case T_WIDE_CHARACTER_CONSTANT:      return parse_wide_character_constant();
+               case T_FLOATINGPOINT:                return parse_float_const();
                case T_STRING_LITERAL:
-               case T_WIDE_STRING_LITERAL:      return parse_string_const();
-               case T_IDENTIFIER:               return parse_reference();
+               case T_WIDE_STRING_LITERAL:          return parse_string_const();
+               case T_IDENTIFIER:                   return parse_reference();
                case T___FUNCTION__:
-               case T___func__:                 return parse_function_keyword();
-               case T___PRETTY_FUNCTION__:      return parse_pretty_function_keyword();
-               case T___FUNCSIG__:              return parse_funcsig_keyword();
-               case T___FUNCDNAME__:            return parse_funcdname_keyword();
-               case T___builtin_offsetof:       return parse_offsetof();
-               case T___builtin_va_start:       return parse_va_start();
-               case T___builtin_va_arg:         return parse_va_arg();
+               case T___func__:                     return parse_function_keyword();
+               case T___PRETTY_FUNCTION__:          return parse_pretty_function_keyword();
+               case T___FUNCSIG__:                  return parse_funcsig_keyword();
+               case T___FUNCDNAME__:                return parse_funcdname_keyword();
+               case T___builtin_offsetof:           return parse_offsetof();
+               case T___builtin_va_start:           return parse_va_start();
+               case T___builtin_va_arg:             return parse_va_arg();
                case T___builtin_expect:
                case T___builtin_alloca:
                case T___builtin_inf:
@@ -7805,23 +7841,26 @@ static expression_t *parse_primary_expression(void)
                case T___builtin_nanf:
                case T___builtin_nanl:
                case T___builtin_huge_val:
-               case T___builtin_va_end:         return parse_builtin_symbol();
+               case T___builtin_va_end:
+               case T___builtin_return_address:
+               case T___builtin_frame_address:      return parse_builtin_symbol();
                case T___builtin_isgreater:
                case T___builtin_isgreaterequal:
                case T___builtin_isless:
                case T___builtin_islessequal:
                case T___builtin_islessgreater:
-               case T___builtin_isunordered:    return parse_compare_builtin();
-               case T___builtin_constant_p:     return parse_builtin_constant();
-               case T___builtin_prefetch:       return parse_builtin_prefetch();
-               case T__assume:                  return parse_assume();
+               case T___builtin_isunordered:        return parse_compare_builtin();
+               case T___builtin_constant_p:         return parse_builtin_constant();
+               case T___builtin_prefetch:           return parse_builtin_prefetch();
+               case T___builtin_types_compatible_p: return parse_builtin_types_compatible();
+               case T__assume:                      return parse_assume();
                case T_ANDAND:
                        if (GNU_MODE)
                                return parse_label_address();
                        break;
 
-               case '(':                        return parse_parenthesized_expression();
-               case T___noop:                   return parse_noop_expression();
+               case '(':                            return parse_parenthesized_expression();
+               case T___noop:                       return parse_noop_expression();
        }
 
        errorf(HERE, "unexpected token %K, expected an expression", &token);
@@ -8097,6 +8136,28 @@ static void check_call_argument(const function_parameter_t *parameter,
        }
 }
 
+/**
+ * Handle the semantic restrictions of builtin calls
+ */
+static void handle_builtin_argument_restrictions(call_expression_t *call) {
+       switch (call->function->builtin_symbol.symbol->ID) {
+               case T___builtin_return_address:
+               case T___builtin_frame_address: {
+                       /* argument must be constant */
+                       call_argument_t *argument = call->arguments;
+
+                       if (! is_constant_expression(argument->expression)) {
+                               errorf(&call->base.source_position,
+                                      "argument of '%Y' must be a constant expression",
+                                      call->function->builtin_symbol.symbol);
+                       }
+                       break;
+               }
+               default:
+                       break;
+       }
+}
+
 /**
  * Parse a call expression, ie. expression '( ... )'.
  *
@@ -8189,6 +8250,10 @@ static expression_t *parse_call_expression(expression_t *expression)
                         "function call has aggregate value");
        }
 
+       if (call->function->kind == EXPR_BUILTIN_SYMBOL) {
+               handle_builtin_argument_restrictions(&result->call);
+       }
+
 end_error:
        return result;
 }
@@ -8554,7 +8619,7 @@ static bool check_pointer_arithmetic(const source_position_t *source_position,
 
 static bool is_lvalue(const expression_t *expression)
 {
-       /* TODO: doesn't seem to be consistent with §6.3.2.1 (1) */
+       /* TODO: doesn't seem to be consistent with §6.3.2.1:1 */
        switch (expression->kind) {
        case EXPR_ARRAY_ACCESS:
        case EXPR_COMPOUND_LITERAL:
@@ -8880,7 +8945,8 @@ static void warn_div_by_zero(binary_expression_t const *const expression)
 /**
  * Check the semantic restrictions for a div/mod expression.
  */
-static void semantic_divmod_arithmetic(binary_expression_t *expression) {
+static void semantic_divmod_arithmetic(binary_expression_t *expression)
+{
        semantic_binexpr_arithmetic(expression);
        warn_div_by_zero(expression);
 }
@@ -9316,17 +9382,17 @@ static void semantic_binexpr_assign(binary_expression_t *expression)
 static bool expression_has_effect(const expression_t *const expr)
 {
        switch (expr->kind) {
-               case EXPR_UNKNOWN:                   break;
-               case EXPR_INVALID:                   return true; /* do NOT warn */
-               case EXPR_REFERENCE:                 return false;
-               case EXPR_REFERENCE_ENUM_VALUE:      return false;
+               case EXPR_UNKNOWN:                    break;
+               case EXPR_INVALID:                    return true; /* do NOT warn */
+               case EXPR_REFERENCE:                  return false;
+               case EXPR_REFERENCE_ENUM_VALUE:       return false;
                /* suppress the warning for microsoft __noop operations */
-               case EXPR_CONST:                     return expr->conste.is_ms_noop;
-               case EXPR_CHARACTER_CONSTANT:        return false;
-               case EXPR_WIDE_CHARACTER_CONSTANT:   return false;
-               case EXPR_STRING_LITERAL:            return false;
-               case EXPR_WIDE_STRING_LITERAL:       return false;
-               case EXPR_LABEL_ADDRESS:             return false;
+               case EXPR_CONST:                      return expr->conste.is_ms_noop;
+               case EXPR_CHARACTER_CONSTANT:         return false;
+               case EXPR_WIDE_CHARACTER_CONSTANT:    return false;
+               case EXPR_STRING_LITERAL:             return false;
+               case EXPR_WIDE_STRING_LITERAL:        return false;
+               case EXPR_LABEL_ADDRESS:              return false;
 
                case EXPR_CALL: {
                        const call_expression_t *const call = &expr->call;
@@ -9342,38 +9408,40 @@ static bool expression_has_effect(const expression_t *const expr)
                /* Generate the warning if either the left or right hand side of a
                 * conditional expression has no effect */
                case EXPR_CONDITIONAL: {
-                       const conditional_expression_t *const cond = &expr->conditional;
+                       conditional_expression_t const *const cond = &expr->conditional;
+                       expression_t             const *const t    = cond->true_expression;
                        return
-                               expression_has_effect(cond->true_expression) &&
+                               (t == NULL || expression_has_effect(t)) &&
                                expression_has_effect(cond->false_expression);
                }
 
-               case EXPR_SELECT:                    return false;
-               case EXPR_ARRAY_ACCESS:              return false;
-               case EXPR_SIZEOF:                    return false;
-               case EXPR_CLASSIFY_TYPE:             return false;
-               case EXPR_ALIGNOF:                   return false;
-
-               case EXPR_FUNCNAME:                  return false;
-               case EXPR_BUILTIN_SYMBOL:            break; /* handled in EXPR_CALL */
-               case EXPR_BUILTIN_CONSTANT_P:        return false;
-               case EXPR_BUILTIN_PREFETCH:          return true;
-               case EXPR_OFFSETOF:                  return false;
-               case EXPR_VA_START:                  return true;
-               case EXPR_VA_ARG:                    return true;
-               case EXPR_STATEMENT:                 return true; // TODO
-               case EXPR_COMPOUND_LITERAL:          return false;
-
-               case EXPR_UNARY_NEGATE:              return false;
-               case EXPR_UNARY_PLUS:                return false;
-               case EXPR_UNARY_BITWISE_NEGATE:      return false;
-               case EXPR_UNARY_NOT:                 return false;
-               case EXPR_UNARY_DEREFERENCE:         return false;
-               case EXPR_UNARY_TAKE_ADDRESS:        return false;
-               case EXPR_UNARY_POSTFIX_INCREMENT:   return true;
-               case EXPR_UNARY_POSTFIX_DECREMENT:   return true;
-               case EXPR_UNARY_PREFIX_INCREMENT:    return true;
-               case EXPR_UNARY_PREFIX_DECREMENT:    return true;
+               case EXPR_SELECT:                     return false;
+               case EXPR_ARRAY_ACCESS:               return false;
+               case EXPR_SIZEOF:                     return false;
+               case EXPR_CLASSIFY_TYPE:              return false;
+               case EXPR_ALIGNOF:                    return false;
+
+               case EXPR_FUNCNAME:                   return false;
+               case EXPR_BUILTIN_SYMBOL:             break; /* handled in EXPR_CALL */
+               case EXPR_BUILTIN_CONSTANT_P:         return false;
+               case EXPR_BUILTIN_TYPES_COMPATIBLE_P: return false;
+               case EXPR_BUILTIN_PREFETCH:           return true;
+               case EXPR_OFFSETOF:                   return false;
+               case EXPR_VA_START:                   return true;
+               case EXPR_VA_ARG:                     return true;
+               case EXPR_STATEMENT:                  return true; // TODO
+               case EXPR_COMPOUND_LITERAL:           return false;
+
+               case EXPR_UNARY_NEGATE:               return false;
+               case EXPR_UNARY_PLUS:                 return false;
+               case EXPR_UNARY_BITWISE_NEGATE:       return false;
+               case EXPR_UNARY_NOT:                  return false;
+               case EXPR_UNARY_DEREFERENCE:          return false;
+               case EXPR_UNARY_TAKE_ADDRESS:         return false;
+               case EXPR_UNARY_POSTFIX_INCREMENT:    return true;
+               case EXPR_UNARY_POSTFIX_DECREMENT:    return true;
+               case EXPR_UNARY_PREFIX_INCREMENT:     return true;
+               case EXPR_UNARY_PREFIX_DECREMENT:     return true;
 
                /* Treat void casts as if they have an effect in order to being able to
                 * suppress the warning */
@@ -9382,39 +9450,39 @@ static bool expression_has_effect(const expression_t *const expr)
                        return is_type_atomic(type, ATOMIC_TYPE_VOID);
                }
 
-               case EXPR_UNARY_CAST_IMPLICIT:       return true;
-               case EXPR_UNARY_ASSUME:              return true;
-               case EXPR_UNARY_DELETE:              return true;
-               case EXPR_UNARY_DELETE_ARRAY:        return true;
-               case EXPR_UNARY_THROW:               return true;
-
-               case EXPR_BINARY_ADD:                return false;
-               case EXPR_BINARY_SUB:                return false;
-               case EXPR_BINARY_MUL:                return false;
-               case EXPR_BINARY_DIV:                return false;
-               case EXPR_BINARY_MOD:                return false;
-               case EXPR_BINARY_EQUAL:              return false;
-               case EXPR_BINARY_NOTEQUAL:           return false;
-               case EXPR_BINARY_LESS:               return false;
-               case EXPR_BINARY_LESSEQUAL:          return false;
-               case EXPR_BINARY_GREATER:            return false;
-               case EXPR_BINARY_GREATEREQUAL:       return false;
-               case EXPR_BINARY_BITWISE_AND:        return false;
-               case EXPR_BINARY_BITWISE_OR:         return false;
-               case EXPR_BINARY_BITWISE_XOR:        return false;
-               case EXPR_BINARY_SHIFTLEFT:          return false;
-               case EXPR_BINARY_SHIFTRIGHT:         return false;
-               case EXPR_BINARY_ASSIGN:             return true;
-               case EXPR_BINARY_MUL_ASSIGN:         return true;
-               case EXPR_BINARY_DIV_ASSIGN:         return true;
-               case EXPR_BINARY_MOD_ASSIGN:         return true;
-               case EXPR_BINARY_ADD_ASSIGN:         return true;
-               case EXPR_BINARY_SUB_ASSIGN:         return true;
-               case EXPR_BINARY_SHIFTLEFT_ASSIGN:   return true;
-               case EXPR_BINARY_SHIFTRIGHT_ASSIGN:  return true;
-               case EXPR_BINARY_BITWISE_AND_ASSIGN: return true;
-               case EXPR_BINARY_BITWISE_XOR_ASSIGN: return true;
-               case EXPR_BINARY_BITWISE_OR_ASSIGN:  return true;
+               case EXPR_UNARY_CAST_IMPLICIT:        return true;
+               case EXPR_UNARY_ASSUME:               return true;
+               case EXPR_UNARY_DELETE:               return true;
+               case EXPR_UNARY_DELETE_ARRAY:         return true;
+               case EXPR_UNARY_THROW:                return true;
+
+               case EXPR_BINARY_ADD:                 return false;
+               case EXPR_BINARY_SUB:                 return false;
+               case EXPR_BINARY_MUL:                 return false;
+               case EXPR_BINARY_DIV:                 return false;
+               case EXPR_BINARY_MOD:                 return false;
+               case EXPR_BINARY_EQUAL:               return false;
+               case EXPR_BINARY_NOTEQUAL:            return false;
+               case EXPR_BINARY_LESS:                return false;
+               case EXPR_BINARY_LESSEQUAL:           return false;
+               case EXPR_BINARY_GREATER:             return false;
+               case EXPR_BINARY_GREATEREQUAL:        return false;
+               case EXPR_BINARY_BITWISE_AND:         return false;
+               case EXPR_BINARY_BITWISE_OR:          return false;
+               case EXPR_BINARY_BITWISE_XOR:         return false;
+               case EXPR_BINARY_SHIFTLEFT:           return false;
+               case EXPR_BINARY_SHIFTRIGHT:          return false;
+               case EXPR_BINARY_ASSIGN:              return true;
+               case EXPR_BINARY_MUL_ASSIGN:          return true;
+               case EXPR_BINARY_DIV_ASSIGN:          return true;
+               case EXPR_BINARY_MOD_ASSIGN:          return true;
+               case EXPR_BINARY_ADD_ASSIGN:          return true;
+               case EXPR_BINARY_SUB_ASSIGN:          return true;
+               case EXPR_BINARY_SHIFTLEFT_ASSIGN:    return true;
+               case EXPR_BINARY_SHIFTRIGHT_ASSIGN:   return true;
+               case EXPR_BINARY_BITWISE_AND_ASSIGN:  return true;
+               case EXPR_BINARY_BITWISE_XOR_ASSIGN:  return true;
+               case EXPR_BINARY_BITWISE_OR_ASSIGN:   return true;
 
                /* Only examine the right hand side of && and ||, because the left hand
                 * side already has the effect of controlling the execution of the right
@@ -9426,12 +9494,12 @@ static bool expression_has_effect(const expression_t *const expr)
                case EXPR_BINARY_COMMA:
                        return expression_has_effect(expr->binary.right);
 
-               case EXPR_BINARY_ISGREATER:          return false;
-               case EXPR_BINARY_ISGREATEREQUAL:     return false;
-               case EXPR_BINARY_ISLESS:             return false;
-               case EXPR_BINARY_ISLESSEQUAL:        return false;
-               case EXPR_BINARY_ISLESSGREATER:      return false;
-               case EXPR_BINARY_ISUNORDERED:        return false;
+               case EXPR_BINARY_ISGREATER:           return false;
+               case EXPR_BINARY_ISGREATEREQUAL:      return false;
+               case EXPR_BINARY_ISLESS:              return false;
+               case EXPR_BINARY_ISLESSEQUAL:         return false;
+               case EXPR_BINARY_ISLESSGREATER:       return false;
+               case EXPR_BINARY_ISUNORDERED:         return false;
        }
 
        internal_errorf(HERE, "unexpected expression");
@@ -10085,7 +10153,8 @@ end_error:
  *
  * @param statement  the switch statement to check
  */
-static void check_enum_cases(const switch_statement_t *statement) {
+static void check_enum_cases(const switch_statement_t *statement)
+{
        const type_t *type = skip_typeref(statement->expression->base.type);
        if (! is_type_enum(type))
                return;
@@ -10578,12 +10647,11 @@ static statement_t *parse_declaration_statement(void)
                parse_declaration(record_entity, DECL_FLAGS_NONE);
        }
 
-       if (before == NULL) {
-               statement->declaration.declarations_begin = current_scope->entities;
-       } else {
-               statement->declaration.declarations_begin = before->base.next;
-       }
-       statement->declaration.declarations_end = current_scope->last_entity;
+       declaration_statement_t *const decl  = &statement->declaration;
+       entity_t                *const begin =
+               before != NULL ? before->base.next : current_scope->entities;
+       decl->declarations_begin = begin;
+       decl->declarations_end   = begin != NULL ? current_scope->last_entity : NULL;
 
        return statement;
 }
@@ -10723,10 +10791,13 @@ static void parse_namespace_definition(void)
                next_token();
 
                entity = get_entity(symbol, NAMESPACE_NORMAL);
-               if (entity != NULL && entity->kind != ENTITY_NAMESPACE
-                               && entity->base.parent_scope == current_scope) {
-                       error_redefined_as_different_kind(&token.source_position,
-                                                         entity, ENTITY_NAMESPACE);
+               if (entity       != NULL             &&
+                               entity->kind != ENTITY_NAMESPACE &&
+                               entity->base.parent_scope == current_scope) {
+                       if (!is_error_entity(entity)) {
+                               error_redefined_as_different_kind(&token.source_position,
+                                               entity, ENTITY_NAMESPACE);
+                       }
                        entity = NULL;
                }
        }
@@ -11366,8 +11437,8 @@ translation_unit_t *finish_parsing(void)
        return result;
 }
 
-/* GCC allows global arrays without size and assigns them a length of one,
- * if no different declaration follows */
+/* §6.9.2:2 and §6.9.2:5: At the end of the translation incomplete arrays
+ * are given length one. */
 static void complete_incomplete_arrays(void)
 {
        size_t n = ARR_LEN(incomplete_arrays);