fix parameter names being taken from first declaration not currently parse declaration
[cparser] / parser.c
index 66d44c2..0cd0716 100644 (file)
--- a/parser.c
+++ b/parser.c
@@ -14,6 +14,7 @@
 #include "adt/array.h"
 
 //#define PRINT_TOKENS
+//#define ABORT_ON_ERROR
 #define MAX_LOOKAHEAD 2
 
 struct environment_entry_t {
@@ -84,10 +85,10 @@ void next_token(void)
 }
 
 static inline
-const token_t *la(int num)
+const token_t *look_ahead(int num)
 {
        assert(num > 0 && num <= MAX_LOOKAHEAD);
-       int pos = (num-1) % MAX_LOOKAHEAD;
+       int pos = (lookahead_bufpos+num-1) % MAX_LOOKAHEAD;
        return & lookahead_buffer[pos];
 }
 
@@ -104,6 +105,9 @@ void parser_print_error_prefix_pos(const source_position_t source_position)
     fputc(':', stderr);
     fprintf(stderr, "%d", source_position.linenr);
     fputs(": error: ", stderr);
+#ifdef ABORT_ON_ERROR
+       abort();
+#endif
 }
 
 void parser_print_error_prefix(void)
@@ -148,21 +152,60 @@ void parse_error_expected(const char *message, ...)
        fprintf(stderr, "\n");
 }
 
-static
-void eat_until(int token_type)
+static void eat_block(void)
 {
-       while(token.type != token_type) {
+       if(token.type == '{')
+               next_token();
+
+       while(token.type != '}') {
                if(token.type == T_EOF)
                        return;
+               if(token.type == '{') {
+                       eat_block();
+                       continue;
+               }
                next_token();
        }
-       next_token();
+       eat('}');
+}
+
+static void eat_statement(void)
+{
+       while(token.type != ';') {
+               if(token.type == T_EOF)
+                       return;
+               if(token.type == '}')
+                       return;
+               if(token.type == '{') {
+                       eat_block();
+                       continue;
+               }
+               next_token();
+       }
+       eat(';');
+}
+
+static void eat_brace(void)
+{
+       if(token.type == '(')
+               next_token();
+
+       while(token.type != ')') {
+               if(token.type == T_EOF)
+                       return;
+               if(token.type == '{') {
+                       eat_block();
+                       continue;
+               }
+               next_token();
+       }
+       eat(')');
 }
 
 #define expect(expected)                           \
     if(UNLIKELY(token.type != (expected))) {       \
         parse_error_expected(NULL, (expected), 0); \
-        eat_until(';');                            \
+        eat_statement();                           \
         return NULL;                               \
     }                                              \
     next_token();
@@ -170,7 +213,7 @@ void eat_until(int token_type)
 #define expect_void(expected)                      \
     if(UNLIKELY(token.type != (expected))) {       \
         parse_error_expected(NULL, (expected), 0); \
-        eat_until(';');                            \
+        eat_statement();                           \
         return;                                    \
     }                                              \
     next_token();
@@ -191,12 +234,23 @@ static void set_context(context_t *new_context)
        last_declaration = declaration;
 }
 
+/**
+ * called when we find a 2nd declarator for an identifier we already have a
+ * declarator for
+ */
+static int is_compatible_declaration (declaration_t *declaration,
+                                      declaration_t *previous)
+{
+       /* TODO: not correct yet */
+       return declaration->type == previous->type;
+}
+
 /**
  * pushs an environment_entry on the environment stack and links the
  * corresponding symbol to the new entry
  */
 static inline
-void environment_push(declaration_t *declaration, const void *context)
+declaration_t *environment_push(declaration_t *declaration, const void *context)
 {
        environment_entry_t *entry
                = obstack_alloc(&environment_obstack, sizeof(entry[0]));
@@ -212,13 +266,22 @@ void environment_push(declaration_t *declaration, const void *context)
        assert(declaration != symbol->declaration);
 
        if(symbol->context == context) {
+               declaration_t *previous_declaration = symbol->declaration;
                if(symbol->declaration != NULL) {
-                       assert(symbol->declaration != NULL);
-                       parser_print_error_prefix_pos(declaration->source_position);
-                       fprintf(stderr, "multiple definitions for symbol '%s'.\n",
-                                       symbol->string);
-                       parser_print_error_prefix_pos(symbol->declaration->source_position);
-                       fprintf(stderr, "this is the location of the previous declaration.\n");
+                       if(!is_compatible_declaration(declaration, previous_declaration)) {
+                               parser_print_error_prefix_pos(declaration->source_position);
+                               fprintf(stderr, "definition of symbol '%s' with type ",
+                                       declaration->symbol->string);
+                               print_type(declaration->type);
+                               fputc('\n', stderr);
+                               parser_print_error_prefix_pos(
+                                               previous_declaration->source_position);
+                               fprintf(stderr, "is incompatible with previous declaration "
+                                       "of type ");
+                               print_type(previous_declaration->type);
+                               fputc('\n', stderr);
+                       }
+                       return previous_declaration;
                }
        }
 
@@ -227,6 +290,8 @@ void environment_push(declaration_t *declaration, const void *context)
        entry->symbol          = symbol;
        symbol->declaration    = declaration;
        symbol->context        = context;
+
+       return declaration;
 }
 
 /**
@@ -263,22 +328,21 @@ void environment_pop_to(size_t new_top)
 
 static expression_t *parse_constant_expression(void)
 {
-       /* TODO: not correct yet */
-       return parse_expression();
+       /* start parsing at precedence 7 (conditional expression) */
+       return parse_sub_expression(7);
 }
 
 static expression_t *parse_assignment_expression(void)
 {
-       /* TODO: not correct yet */
-       return parse_expression();
+       /* start parsing at precedence 2 (assignment expression) */
+       return parse_sub_expression(2);
 }
 
 static void parse_compound_type_entries(void);
 static void parse_declarator(declaration_t *declaration,
                              storage_class_t storage_class, type_t *type,
                              int may_be_abstract);
-static void maybe_push_declaration(declaration_t *declaration);
-static void record_declaration(declaration_t *declaration);
+static declaration_t *record_declaration(declaration_t *declaration);
 
 typedef struct declaration_specifiers_t  declaration_specifiers_t;
 struct declaration_specifiers_t {
@@ -286,72 +350,88 @@ struct declaration_specifiers_t {
        type_t          *type;
 };
 
-static type_t *parse_struct_specifier(void)
+static compound_type_t *find_compound_type(compound_type_t *types,
+                                           const symbol_t *symbol)
 {
-       eat(T_struct);
+       compound_type_t *type = types;
+       for( ; type != NULL; type = type->next) {
+               if(type->symbol == symbol)
+                       return type;
+       }
 
-       compound_type_t *struct_type = allocate_type_zero(sizeof(struct_type[0]));
-       struct_type->type.type       = TYPE_COMPOUND_STRUCT;
-       struct_type->source_position = token.source_position;
+       return NULL;
+}
 
-       int         top          = environment_top();
-       context_t  *last_context = context;
-       set_context(&struct_type->context);
+static type_t *parse_compound_type_specifier(int is_struct)
+{
+       if(is_struct) {
+               eat(T_struct);
+       } else {
+               eat(T_union);
+       }
+
+       symbol_t        *symbol        = NULL;
+       compound_type_t *compound_type = NULL;
 
        if(token.type == T_IDENTIFIER) {
+               symbol = token.v.symbol;
                next_token();
-               if(token.type == '{') {
-                       parse_compound_type_entries();
+
+               if(context != NULL) {
+                       if(is_struct) {
+                               compound_type = find_compound_type(context->structs, symbol);
+                       } else {
+                               compound_type = find_compound_type(context->unions, symbol);
+                       }
+               }
+       } else if(token.type != '{') {
+               if(is_struct) {
+                       parse_error_expected("problem while parsing struct type specifier",
+                                            T_IDENTIFIER, '{', 0);
+               } else {
+                       parse_error_expected("problem while parsing union type specifier",
+                                            T_IDENTIFIER, '{', 0);
                }
-       } else if(token.type == '{') {
-               parse_compound_type_entries();
-       } else {
-               parse_error_expected("problem while parsing struct type specifiers",
-                                    T_IDENTIFIER, '{', 0);
-               struct_type = NULL;
-       }
 
-       assert(context == &struct_type->context);
-       set_context(last_context);
-       environment_pop_to(top);
+               return NULL;
+       }
 
-       return (type_t*) struct_type;
-}
+       if(compound_type == NULL) {
+               compound_type = allocate_type_zero(sizeof(compound_type[0]));
 
-static type_t *parse_union_specifier(void)
-{
-       eat(T_union);
+               if(is_struct) {
+                       compound_type->type.type = TYPE_COMPOUND_STRUCT;
+               } else {
+                       compound_type->type.type = TYPE_COMPOUND_UNION;
+               }
+               compound_type->source_position = token.source_position;
+               compound_type->symbol          = symbol;
+       }
 
-       compound_type_t *union_type = allocate_type_zero(sizeof(union_type[0]));
-       union_type->type.type       = TYPE_COMPOUND_UNION;
-       union_type->source_position = token.source_position;
+       if(token.type == '{') {
+               if(compound_type->defined) {
+                       parser_print_error_prefix();
+                       fprintf(stderr, "multiple definition of %s %s\n",
+                                       is_struct ? "struct" : "union", symbol->string);
+                       compound_type->context.declarations = NULL;
+               }
+               compound_type->defined = 1;
 
-       int         top          = environment_top();
-       context_t  *last_context = context;
-       set_context(&union_type->context);
+               int         top          = environment_top();
+               context_t  *last_context = context;
+               set_context(&compound_type->context);
 
-       if(token.type == T_IDENTIFIER) {
-               union_type->symbol = token.v.symbol;
-               next_token();
-               if(token.type == '{') {
-                       parse_compound_type_entries();
-               }
-       } else if(token.type == '{') {
                parse_compound_type_entries();
-       } else {
-               parse_error_expected("problem while parsing union type specifiers",
-                                    T_IDENTIFIER, '{');
-               union_type = NULL;
-       }
 
-       assert(context == &union_type->context);
-       set_context(last_context);
-       environment_pop_to(top);
+               assert(context == &compound_type->context);
+               set_context(last_context);
+               environment_pop_to(top);
+       }
 
-       return (type_t*) union_type;
+       return (type_t*) compound_type;
 }
 
-static void parse_enum_type_entries(void)
+static void parse_enum_entries(void)
 {
        eat('{');
 
@@ -362,18 +442,26 @@ static void parse_enum_type_entries(void)
        }
 
        do {
+               declaration_t *entry = allocate_ast_zero(sizeof(entry[0]));
+
                if(token.type != T_IDENTIFIER) {
                        parse_error_expected("problem while parsing enum entry",
                                             T_IDENTIFIER, 0);
-                       eat_until('}');
+                       eat_block();
                        return;
                }
+               entry->storage_class   = STORAGE_CLASS_ENUM_ENTRY;
+               entry->symbol          = token.v.symbol;
+               entry->source_position = token.source_position;
                next_token();
 
                if(token.type == '=') {
-                       parse_constant_expression();
+                       next_token();
+                       entry->initializer = parse_constant_expression();
                }
 
+               record_declaration(entry);
+
                if(token.type != ',')
                        break;
                next_token();
@@ -382,30 +470,135 @@ static void parse_enum_type_entries(void)
        expect_void('}');
 }
 
+static enum_type_t *find_enum_type(enum_type_t *types, const symbol_t *symbol)
+{
+       enum_type_t *type = types;
+       for( ; type != NULL; type = type->next) {
+               if(type->symbol == symbol)
+                       return type;
+       }
+
+       return NULL;
+}
+
 static type_t *parse_enum_specifier(void)
 {
        eat(T_enum);
 
-       enum_type_t *enum_type     = allocate_type_zero(sizeof(enum_type[0]));
-       enum_type->type.type       = TYPE_ENUM;
-       enum_type->source_position = token.source_position;
+       symbol_t    *symbol    = NULL;
+       enum_type_t *enum_type = NULL;
 
        if(token.type == T_IDENTIFIER) {
-               enum_type->symbol = token.v.symbol;
+               symbol = token.v.symbol;
                next_token();
-               if(token.type == '{') {
-                       parse_enum_type_entries();
+
+               if(context != NULL) {
+                       enum_type = find_enum_type(context->enums, symbol);
                }
-       } else if(token.type == '{') {
-               parse_enum_type_entries();
-       } else {
-               parse_error_expected("problem while parsing enum type specifiers",
-                                    T_IDENTIFIER, '{');
+       } else if(token.type != '{') {
+               parse_error_expected("problem while parsing enum type specifier",
+                                    T_IDENTIFIER, '{', 0);
+               return NULL;
+       }
+
+       if(enum_type == NULL) {
+               enum_type                  = allocate_type_zero(sizeof(enum_type[0]));
+               enum_type->type.type       = TYPE_ENUM;
+               enum_type->source_position = token.source_position;
+               enum_type->symbol          = symbol;
+       }
+
+       if(token.type == '{') {
+               if(enum_type->defined) {
+                       parser_print_error_prefix();
+                       fprintf(stderr, "multiple definitions of enum %s\n",
+                               symbol->string);
+                       enum_type->entries_begin = NULL;
+                       enum_type->entries_end   = NULL;
+               }
+               enum_type->defined = 1;
+
+               declaration_t *before = last_declaration;
+
+               parse_enum_entries();
+
+               if(before == NULL) {
+                       enum_type->entries_begin = context->declarations;
+               } else {
+                       enum_type->entries_begin = before->next;
+               }
+               enum_type->entries_end = last_declaration;
        }
 
        return (type_t*) enum_type;
 }
 
+static
+const char *parse_string_literals(void)
+{
+       assert(token.type == T_STRING_LITERAL);
+       const char *result = token.v.string;
+
+       next_token();
+
+       while(token.type == T_STRING_LITERAL) {
+               result = concat_strings(result, token.v.string);
+               next_token();
+       }
+
+       return result;
+}
+
+static
+void parse_attributes(void)
+{
+       while(1) {
+               switch(token.type) {
+               case T___attribute__:
+                       next_token();
+
+                       expect_void('(');
+                       int depth = 1;
+                       while(depth > 0) {
+                               switch(token.type) {
+                               case T_EOF:
+                                       parse_error("EOF while parsing attribute");
+                                       break;
+                               case '(':
+                                       next_token();
+                                       depth++;
+                                       break;
+                               case ')':
+                                       next_token();
+                                       depth--;
+                                       break;
+                               default:
+                                       next_token();
+                               }
+                       }
+                       break;
+               case T_asm:
+                       next_token();
+                       expect_void('(');
+                       if(token.type != T_STRING_LITERAL) {
+                               parse_error_expected("while parsing assembler attribute",
+                                                    T_STRING_LITERAL);
+                               eat_brace();
+                               break;
+                       } else {
+                               parse_string_literals();
+                       }
+                       expect_void(')');
+                       break;
+               default:
+                       goto attributes_finished;
+               }
+       }
+
+attributes_finished:
+       ;
+}
+
 typedef enum {
        SPECIFIER_SIGNED    = 1 << 0,
        SPECIFIER_UNSIGNED  = 1 << 1,
@@ -437,8 +630,7 @@ typedef enum {
        case T_const:           \
        case T_restrict:        \
        case T_volatile:        \
-       case T_inline:          \
-       case T___extension__:
+       case T_inline:
 
 #ifdef PROVIDE_COMPLEX
 #define COMPLEX_SPECIFIERS  \
@@ -576,10 +768,10 @@ void parse_declaration_specifiers(declaration_specifiers_t *specifiers)
 
                /* TODO: if type != NULL for the following rules issue an error */
                case T_struct:
-                       type = parse_struct_specifier();
+                       type = parse_compound_type_specifier(1);
                        break;
                case T_union:
-                       type = parse_union_specifier();
+                       type = parse_compound_type_specifier(0);
                        break;
                case T_enum:
                        type = parse_enum_specifier();
@@ -589,6 +781,11 @@ void parse_declaration_specifiers(declaration_specifiers_t *specifiers)
                        next_token();
                        break;
 
+               case T___attribute__:
+                       /* TODO */
+                       parse_attributes();
+                       break;
+
                case T_IDENTIFIER:
                        declaration = token.v.symbol->declaration;
                        if(declaration == NULL ||
@@ -839,88 +1036,66 @@ declaration_t *parse_parameter(void)
 }
 
 static
-void parse_parameters(method_type_t *type)
+declaration_t *parse_parameters(method_type_t *type)
 {
        if(token.type == T_IDENTIFIER) {
                symbol_t      *symbol      = token.v.symbol;
                declaration_t *declaration = symbol->declaration;
                if(declaration == NULL
                                || declaration->storage_class != STORAGE_CLASS_TYPEDEF) {
+                       /* TODO */
                        parse_identifier_list();
-                       return;
+                       return NULL;
                }
        }
 
        if(token.type == ')') {
                type->unspecified_parameters = 1;
-               return;
+               return NULL;
        }
-       if(token.type == T_void && la(1)->type == ')') {
+       if(token.type == T_void && look_ahead(1)->type == ')') {
                next_token();
-               return;
+               return NULL;
        }
 
-       declaration_t *declaration;
-       method_parameter_type_t *parameter_type;
-       method_parameter_type_t *last_parameter_type = NULL;
+       declaration_t      *declarations = NULL;
+       declaration_t      *declaration;
+       declaration_t      *last_declaration = NULL;
+       method_parameter_t *parameter;
+       method_parameter_t *last_parameter = NULL;
 
        while(1) {
                switch(token.type) {
                case T_DOTDOTDOT:
                        next_token();
                        type->variadic = 1;
-                       return;
+                       return declarations;
 
                case T_IDENTIFIER:
+               case T___extension__:
                DECLARATION_START
                        declaration = parse_parameter();
 
-                       parameter_type = allocate_type_zero(sizeof(parameter_type[0]));
-                       parameter_type->type   = declaration->type;
-                       parameter_type->symbol = declaration->symbol;
+                       parameter       = allocate_type_zero(sizeof(parameter[0]));
+                       parameter->type = declaration->type;
 
-                       if(last_parameter_type != NULL) {
-                               last_parameter_type->next = parameter_type;
+                       if(last_parameter != NULL) {
+                               last_declaration->next = declaration;
+                               last_parameter->next   = parameter;
                        } else {
-                               type->parameter_types = parameter_type;
+                               type->parameters = parameter;
+                               declarations     = declaration;
                        }
-                       last_parameter_type = parameter_type;
+                       last_parameter   = parameter;
+                       last_declaration = declaration;
                        break;
 
                default:
-                       return;
+                       return declarations;
                }
                if(token.type != ',')
-                       return;
-               next_token();
-       }
-}
-
-static
-void parse_attributes(void)
-{
-       while(token.type == T___attribute__) {
+                       return declarations;
                next_token();
-
-               expect_void('(');
-               int depth = 1;
-               while(depth > 0) {
-                       switch(token.type) {
-                       case T_EOF:
-                               parse_error("EOF while parsing attribute");
-                               break;
-                       case '(':
-                               next_token();
-                               depth++;
-                               break;
-                       case ')':
-                               next_token();
-                               depth--;
-                               break;
-                       default:
-                               next_token();
-                       }
-               }
        }
 }
 
@@ -941,6 +1116,9 @@ declarator_part *parse_inner_declarator(declaration_t *declaration,
 
        part->pointers = parse_pointers();
 
+       /* TODO: find out if this is correct */
+       parse_attributes();
+
        switch(token.type) {
        case T_IDENTIFIER:
                if(declaration == NULL) {
@@ -972,7 +1150,10 @@ declarator_part *parse_inner_declarator(declaration_t *declaration,
                                = allocate_type_zero(sizeof(method_type[0]));
                        method_type->type.type   = TYPE_METHOD;
 
-                       parse_parameters(method_type);
+                       declaration_t *parameters = parse_parameters(method_type);
+                       if(declaration != NULL) {
+                               declaration->context.declarations = parameters;
+                       }
 
                        part->method_type = method_type;
 
@@ -994,7 +1175,7 @@ declarator_part *parse_inner_declarator(declaration_t *declaration,
 
                        /* TODO */
 
-                       if(token.type == '*' && la(1)->type == ']') {
+                       if(token.type == '*' && look_ahead(1)->type == ']') {
                                next_token();
                        } else if(token.type != ']') {
                                parse_assignment_expression();
@@ -1023,7 +1204,11 @@ type_t *construct_declarator_type(declarator_part *part, type_t *type)
                if(method_type != NULL) {
                        method_type->result_type = type;
 
-                       type = (type_t*) method_type;
+                       type_t *result = typehash_insert((type_t*) method_type);
+                       if(result != (type_t*) method_type) {
+                               obstack_free(type_obst, method_type);
+                       }
+                       type = result;
                }
 
                part = part->inner;
@@ -1051,53 +1236,106 @@ type_t *parse_abstract_declarator(type_t *base_type)
 {
        declarator_part *part = parse_inner_declarator(NULL, 1);
 
+       if(part == NULL)
+               return NULL;
+
        type_t *result = construct_declarator_type(part, base_type);
        obstack_free(&temp_obst, part);
 
        return result;
 }
 
-static void record_declaration(declaration_t *declaration)
+static declaration_t *record_declaration(declaration_t *declaration)
 {
+       if(context == NULL)
+               return declaration;
+
+       symbol_t *symbol = declaration->symbol;
+       if(symbol != NULL) {
+               declaration_t *alias = environment_push(declaration, context);
+               if(alias != declaration)
+                       return alias;
+       }
+
        if(last_declaration != NULL) {
                last_declaration->next = declaration;
        } else {
-               if(context != NULL)
-                       context->declarations = declaration;
+               context->declarations  = declaration;
        }
        last_declaration = declaration;
+
+       return declaration;
 }
 
 static
-void maybe_push_declaration(declaration_t *declaration)
+void parser_error_multiple_definition(declaration_t *previous,
+                                      declaration_t *declaration)
 {
-       symbol_t *symbol = declaration->symbol;
-
-       if(symbol != NULL) {
-               environment_push(declaration, context);
-       }
+       parser_print_error_prefix_pos(declaration->source_position);
+       fprintf(stderr, "multiple definition of symbol '%s'\n",
+               declaration->symbol->string);
+       parser_print_error_prefix_pos(previous->source_position);
+       fprintf(stderr, "this is the location of the previous "
+               "definition.\n");
 }
 
 static
 void parse_init_declarators(const declaration_specifiers_t *specifiers)
 {
        while(1) {
-               declaration_t *declaration = allocate_ast_zero(sizeof(declaration[0]));
+               declaration_t *ndeclaration
+                       = allocate_ast_zero(sizeof(ndeclaration[0]));
 
-               parse_declarator(declaration, specifiers->storage_class,
+               parse_declarator(ndeclaration, specifiers->storage_class,
                                 specifiers->type, 0);
-               maybe_push_declaration(declaration);
-               record_declaration(declaration);
+               declaration_t *declaration = record_declaration(ndeclaration);
                if(token.type == '=') {
                        next_token();
+
+                       /* TODO: check that this is an allowed type (esp. no method type) */
+
+                       if(declaration->initializer != NULL) {
+                               parser_error_multiple_definition(declaration, ndeclaration);
+                       }
+
                        if(token.type == '{') {
                                // TODO
                                expect_void('}');
                        } else {
-                               parse_assignment_expression();
+                               declaration->initializer = parse_assignment_expression();
                        }
                } else if(token.type == '{') {
+                       if(declaration->type->type != TYPE_METHOD) {
+                               parser_print_error_prefix();
+                               fprintf(stderr, "Declarator ");
+                               print_type_ext(declaration->type, declaration->symbol, NULL);
+                               fprintf(stderr, " is not a method type.\n");
+                       }
+
+                       if(declaration->initializer != NULL) {
+                               parser_error_multiple_definition(declaration, ndeclaration);
+                       }
+                       if(ndeclaration != declaration) {
+                               memcpy(&declaration->context, &ndeclaration->context,
+                                      sizeof(declaration->context));
+                       }
+
+                       int         top          = environment_top();
+                       context_t  *last_context = context;
+                       set_context(&declaration->context);
+
+                       /* push function parameters */
+                       declaration_t *parameter = declaration->context.declarations;
+                       for( ; parameter != NULL; parameter = parameter->next) {
+                               environment_push(parameter, context);
+                       }
+
                        statement_t *statement = parse_compound_statement();
+
+                       assert(context == &declaration->context);
+                       set_context(last_context);
+                       environment_pop_to(top);
+
                        declaration->statement = statement;
                        return;
                }
@@ -1121,8 +1359,9 @@ void parse_struct_declarators(const declaration_specifiers_t *specifiers)
                        declaration_t *declaration
                                = allocate_ast_zero(sizeof(declaration[0]));
                        parse_declarator(declaration, specifiers->storage_class,
-                                        specifiers->type, 0);
-                       maybe_push_declaration(declaration);
+                                        specifiers->type, 1);
+
+                       /* TODO: check for doubled fields */
                        record_declaration(declaration);
 
                        if(token.type == ':') {
@@ -1226,9 +1465,7 @@ expression_t *parse_string_const(void)
        string_literal_t *cnst = allocate_ast_zero(sizeof(cnst[0]));
 
        cnst->expression.type = EXPR_STRING_LITERAL;
-       cnst->value           = token.v.string;
-
-       next_token();
+       cnst->value           = parse_string_literals();
 
        return (expression_t*) cnst;
 }
@@ -1251,25 +1488,107 @@ expression_t *parse_reference(void)
 {
        reference_expression_t *ref = allocate_ast_zero(sizeof(ref[0]));
 
-       ref->expression.type            = EXPR_REFERENCE;
-       ref->symbol                     = token.v.symbol;
+       ref->expression.type = EXPR_REFERENCE;
+       ref->symbol          = token.v.symbol;
+
+       if(ref->symbol->declaration == NULL) {
+               parser_print_error_prefix();
+               fprintf(stderr, "unknown symbol '%s' found.\n", ref->symbol->string);
+       }
+       ref->declaration     = ref->symbol->declaration;
 
        next_token();
 
        return (expression_t*) ref;
 }
 
+static
+expression_t *parse_cast(void)
+{
+       unary_expression_t *cast = allocate_ast_zero(sizeof(cast[0]));
+
+       cast->expression.type            = EXPR_UNARY;
+       cast->type                       = UNEXPR_CAST;
+       cast->expression.source_position = token.source_position;
+
+       type_t *type  = parse_typename();
+
+       expect(')');
+       expression_t *value = parse_sub_expression(20);
+
+       cast->expression.datatype = type;
+       cast->value               = value;
+
+       return (expression_t*) cast;
+}
+
+static
+expression_t *parse_statement_expression(void)
+{
+       statement_expression_t *expression
+               = allocate_ast_zero(sizeof(expression[0]));
+       expression->expression.type = EXPR_STATEMENT;
+       expression->statement       = parse_compound_statement();
+
+       expect(')');
+
+       return (expression_t*) expression;
+}
+
 static
 expression_t *parse_brace_expression(void)
 {
        eat('(');
 
+       declaration_t *declaration;
+       switch(token.type) {
+       case '{':
+               /* gcc extension: a stement expression */
+               return parse_statement_expression();
+
+       TYPE_QUALIFIERS
+       TYPE_SPECIFIERS
+               return parse_cast();
+       case T_IDENTIFIER:
+               declaration = token.v.symbol->declaration;
+               if(declaration != NULL &&
+                               (declaration->storage_class == STORAGE_CLASS_TYPEDEF)) {
+                       return parse_cast();
+               }
+       }
+
        expression_t *result = parse_expression();
        expect(')');
 
        return result;
 }
 
+static
+expression_t *parse_function_keyword(void)
+{
+       eat(T___FUNCTION__);
+       /* TODO */
+
+       string_literal_t *expression = allocate_ast_zero(sizeof(expression[0]));
+       expression->expression.type  = EXPR_FUNCTION;
+       expression->value            = "TODO: FUNCTION";
+
+       return (expression_t*) expression;
+}
+
+static
+expression_t *parse_pretty_function_keyword(void)
+{
+       eat(T___PRETTY_FUNCTION__);
+       /* TODO */
+
+       string_literal_t *expression = allocate_ast_zero(sizeof(expression[0]));
+       expression->expression.type  = EXPR_PRETTY_FUNCTION;
+       expression->value            = "TODO: PRETTY FUNCTION";
+
+       return (expression_t*) expression;
+}
+
 static
 expression_t *parse_primary_expression(void)
 {
@@ -1280,11 +1599,19 @@ expression_t *parse_primary_expression(void)
                return parse_string_const();
        case T_IDENTIFIER:
                return parse_reference();
+       case T___FUNCTION__:
+               return parse_function_keyword();
+       case T___PRETTY_FUNCTION__:
+               return parse_pretty_function_keyword();
        case '(':
                return parse_brace_expression();
        }
 
-       /* TODO: error message */
+       parser_print_error_prefix();
+       fprintf(stderr, "unexpected token ");
+       print_token(stderr, &token);
+       fprintf(stderr, "\n");
+       eat_statement();
        return NULL;
 }
 
@@ -1320,6 +1647,32 @@ type_t *get_expression_type(const expression_t *expression)
        return NULL;
 }
 
+static
+int is_declaration_specifier(const token_t *token, int only_type_specifiers)
+{
+       declaration_t *declaration;
+
+       switch(token->type) {
+               TYPE_SPECIFIERS
+                       return 1;
+               case T_IDENTIFIER:
+                       declaration = token->v.symbol->declaration;
+                       if(declaration == NULL)
+                               return 0;
+                       if(declaration->storage_class != STORAGE_CLASS_TYPEDEF)
+                               return 0;
+                       return 1;
+               STORAGE_CLASSES
+               TYPE_QUALIFIERS
+                       if(only_type_specifiers)
+                               return 0;
+                       return 1;
+
+               default:
+                       return 0;
+       }
+}
+
 static
 expression_t *parse_sizeof(unsigned precedence)
 {
@@ -1329,13 +1682,14 @@ expression_t *parse_sizeof(unsigned precedence)
                = allocate_ast_zero(sizeof(sizeof_expression[0]));
        sizeof_expression->expression.type = EXPR_SIZEOF;
 
-       if(token.type == '(' /* && LA1 is type_specifier */) {
+       if(token.type == '(' && is_declaration_specifier(look_ahead(1), 1)) {
                next_token();
                sizeof_expression->type = parse_typename();
                expect(')');
        } else {
-               expression_t *expression = parse_sub_expression(precedence);
-               sizeof_expression->type  = get_expression_type(expression);
+               expression_t *expression           = parse_sub_expression(precedence);
+               sizeof_expression->type            = get_expression_type(expression);
+               sizeof_expression->size_expression = expression;
        }
 
        return (expression_t*) sizeof_expression;
@@ -1347,7 +1701,7 @@ expression_t *parse_select_expression(unsigned precedence,
 {
        (void) precedence;
 
-       assert(token.type == '.' || token.type == T_SELECT);
+       assert(token.type == '.' || token.type == T_MINUSGREATER);
        next_token();
 
        select_expression_t *select = allocate_ast_zero(sizeof(select[0]));
@@ -1385,7 +1739,9 @@ expression_t *parse_call_expression(unsigned precedence,
                while(1) {
                        call_argument_t *argument = allocate_ast_zero(sizeof(argument[0]));
 
-                       argument->expression = parse_expression();
+                       /* we start parsing at precedence 2 so we don't get comma operators
+                        * parsed */
+                       argument->expression = parse_sub_expression(2);
                        if(last_argument == NULL) {
                                call->arguments = argument;
                        } else {
@@ -1420,6 +1776,15 @@ expression_t *parse_conditional_expression(unsigned precedence,
        return (expression_t*) conditional;
 }
 
+static expression_t *parse_extension(unsigned precedence)
+{
+       eat(T___extension__);
+
+       /* TODO enable extensions */
+
+       return parse_sub_expression(precedence);
+}
+
 #define CREATE_UNARY_EXPRESSION_PARSER(token_type, unexpression_type)     \
 static                                                                    \
 expression_t *parse_##unexpression_type(unsigned precedence)              \
@@ -1475,14 +1840,15 @@ expression_t *parse_##binexpression_type(unsigned precedence,    \
                                                                  \
        binary_expression_t *binexpr                                 \
                = allocate_ast_zero(sizeof(binexpr[0]));                 \
-       binexpr->expression.type            = EXPR_BINARY;           \
-       binexpr->type                       = binexpression_type;    \
-       binexpr->left                       = left;                  \
-       binexpr->right                      = right;                 \
+       binexpr->expression.type = EXPR_BINARY;                      \
+       binexpr->type            = binexpression_type;               \
+       binexpr->left            = left;                             \
+       binexpr->right           = right;                            \
                                                                  \
        return (expression_t*) binexpr;                              \
 }
 
+CREATE_BINEXPR_PARSER(',', BINEXPR_COMMA)
 CREATE_BINEXPR_PARSER('*', BINEXPR_MUL)
 CREATE_BINEXPR_PARSER('/', BINEXPR_DIV)
 CREATE_BINEXPR_PARSER('+', BINEXPR_ADD)
@@ -1491,7 +1857,7 @@ CREATE_BINEXPR_PARSER('<', BINEXPR_LESS)
 CREATE_BINEXPR_PARSER('>', BINEXPR_GREATER)
 CREATE_BINEXPR_PARSER('=', BINEXPR_ASSIGN)
 CREATE_BINEXPR_PARSER(T_EQUALEQUAL, BINEXPR_EQUAL)
-CREATE_BINEXPR_PARSER(T_SLASHEQUAL, BINEXPR_NOTEQUAL)
+CREATE_BINEXPR_PARSER(T_EXCLAMATIONMARKEQUAL, BINEXPR_NOTEQUAL)
 CREATE_BINEXPR_PARSER(T_LESSEQUAL, BINEXPR_LESSEQUAL)
 CREATE_BINEXPR_PARSER(T_GREATEREQUAL, BINEXPR_GREATEREQUAL)
 CREATE_BINEXPR_PARSER('&', BINEXPR_BITWISE_AND)
@@ -1501,6 +1867,16 @@ CREATE_BINEXPR_PARSER(T_ANDAND, BINEXPR_LOGICAL_AND)
 CREATE_BINEXPR_PARSER(T_PIPEPIPE, BINEXPR_LOGICAL_OR)
 CREATE_BINEXPR_PARSER(T_LESSLESS, BINEXPR_SHIFTLEFT)
 CREATE_BINEXPR_PARSER(T_GREATERGREATER, BINEXPR_SHIFTRIGHT)
+CREATE_BINEXPR_PARSER(T_PLUSEQUAL, BINEXPR_ADD_ASSIGN)
+CREATE_BINEXPR_PARSER(T_MINUSEQUAL, BINEXPR_SUB_ASSIGN)
+CREATE_BINEXPR_PARSER(T_ASTERISKEQUAL, BINEXPR_MUL_ASSIGN)
+CREATE_BINEXPR_PARSER(T_SLASHEQUAL, BINEXPR_DIV_ASSIGN)
+CREATE_BINEXPR_PARSER(T_PERCENTEQUAL, BINEXPR_MOD_ASSIGN)
+CREATE_BINEXPR_PARSER(T_LESSLESSEQUAL, BINEXPR_SHIFTLEFT_ASSIGN)
+CREATE_BINEXPR_PARSER(T_GREATERGREATEREQUAL, BINEXPR_SHIFTRIGHT_ASSIGN)
+CREATE_BINEXPR_PARSER(T_ANDEQUAL, BINEXPR_BITWISE_AND_ASSIGN)
+CREATE_BINEXPR_PARSER(T_PIPEEQUAL, BINEXPR_BITWISE_OR_ASSIGN)
+CREATE_BINEXPR_PARSER(T_CARETEQUAL, BINEXPR_BITWISE_XOR_ASSIGN)
 
 static
 expression_t *parse_sub_expression(unsigned precedence)
@@ -1591,28 +1967,48 @@ void init_expression_parsers(void)
                                   T_LESSLESS, 16);
        register_expression_infix_parser(parse_BINEXPR_SHIFTRIGHT,
                                   T_GREATERGREATER, 16);
-       register_expression_infix_parser(parse_BINEXPR_ADD,       '+', 15);
-       register_expression_infix_parser(parse_BINEXPR_SUB,       '-', 15);
-       register_expression_infix_parser(parse_BINEXPR_LESS,      '<', 14);
-       register_expression_infix_parser(parse_BINEXPR_GREATER,   '>', 14);
-       register_expression_infix_parser(parse_BINEXPR_LESSEQUAL, T_LESSEQUAL, 14);
+       register_expression_infix_parser(parse_BINEXPR_ADD,         '+',        15);
+       register_expression_infix_parser(parse_BINEXPR_SUB,         '-',        15);
+       register_expression_infix_parser(parse_BINEXPR_LESS,        '<',        14);
+       register_expression_infix_parser(parse_BINEXPR_GREATER,     '>',        14);
+       register_expression_infix_parser(parse_BINEXPR_LESSEQUAL, T_LESSEQUAL,  14);
        register_expression_infix_parser(parse_BINEXPR_GREATEREQUAL,
-                                  T_GREATEREQUAL, 14);
+                                                               T_GREATEREQUAL, 14);
        register_expression_infix_parser(parse_BINEXPR_EQUAL,     T_EQUALEQUAL, 13);
        register_expression_infix_parser(parse_BINEXPR_NOTEQUAL,
-                                        T_EXCLAMATIONMARKEQUAL, 13);
+                                                       T_EXCLAMATIONMARKEQUAL, 13);
        register_expression_infix_parser(parse_BINEXPR_BITWISE_AND, '&',        12);
        register_expression_infix_parser(parse_BINEXPR_BITWISE_XOR, '^',        11);
        register_expression_infix_parser(parse_BINEXPR_BITWISE_OR,  '|',        10);
        register_expression_infix_parser(parse_BINEXPR_LOGICAL_AND, T_ANDAND,    9);
        register_expression_infix_parser(parse_BINEXPR_LOGICAL_OR,  T_PIPEPIPE,  8);
        register_expression_infix_parser(parse_conditional_expression, '?',      7);
-       register_expression_infix_parser(parse_BINEXPR_ASSIGN,      T_EQUAL,     2);
+       register_expression_infix_parser(parse_BINEXPR_ASSIGN,      '=',         2);
+       register_expression_infix_parser(parse_BINEXPR_ADD_ASSIGN, T_PLUSEQUAL,  2);
+       register_expression_infix_parser(parse_BINEXPR_SUB_ASSIGN, T_MINUSEQUAL, 2);
+       register_expression_infix_parser(parse_BINEXPR_MUL_ASSIGN,
+                                                               T_ASTERISKEQUAL, 2);
+       register_expression_infix_parser(parse_BINEXPR_DIV_ASSIGN, T_SLASHEQUAL, 2);
+       register_expression_infix_parser(parse_BINEXPR_MOD_ASSIGN,
+                                                                T_PERCENTEQUAL, 2);
+       register_expression_infix_parser(parse_BINEXPR_SHIFTLEFT_ASSIGN,
+                                                               T_LESSLESSEQUAL, 2);
+       register_expression_infix_parser(parse_BINEXPR_SHIFTRIGHT_ASSIGN,
+                                                         T_GREATERGREATEREQUAL, 2);
+       register_expression_infix_parser(parse_BINEXPR_BITWISE_AND_ASSIGN,
+                                                                    T_ANDEQUAL, 2);
+       register_expression_infix_parser(parse_BINEXPR_BITWISE_OR_ASSIGN,
+                                                                   T_PIPEEQUAL, 2);
+       register_expression_infix_parser(parse_BINEXPR_BITWISE_XOR_ASSIGN,
+                                                                  T_CARETEQUAL, 2);
+
+       register_expression_infix_parser(parse_BINEXPR_COMMA,       ',',         1);
 
        register_expression_infix_parser(parse_array_expression,        '[',    30);
        register_expression_infix_parser(parse_call_expression,         '(',    30);
        register_expression_infix_parser(parse_select_expression,       '.',    30);
-       register_expression_infix_parser(parse_select_expression,  T_SELECT,    30);
+       register_expression_infix_parser(parse_select_expression,
+                                                               T_MINUSGREATER, 30);
        register_expression_infix_parser(parse_UNEXPR_POSTFIX_INCREMENT,
                                         T_PLUSPLUS, 30);
        register_expression_infix_parser(parse_UNEXPR_POSTFIX_DECREMENT,
@@ -1627,6 +2023,7 @@ void init_expression_parsers(void)
        register_expression_parser(parse_UNEXPR_PREFIX_INCREMENT, T_PLUSPLUS,   25);
        register_expression_parser(parse_UNEXPR_PREFIX_DECREMENT, T_MINUSMINUS, 25);
        register_expression_parser(parse_sizeof,                  T_sizeof,     25);
+       register_expression_parser(parse_extension,            T___extension__, 25);
 }
 
 
@@ -1634,21 +2031,31 @@ static
 statement_t *parse_case_statement(void)
 {
        eat(T_case);
-       parse_expression();
+       case_label_statement_t *label = allocate_ast_zero(sizeof(label[0]));
+       label->statement.type            = STATEMENT_CASE_LABEL;
+       label->statement.source_position = token.source_position;
+
+       label->expression = parse_expression();
+
        expect(':');
-       parse_statement();
+       label->statement.next = parse_statement();
 
-       return NULL;
+       return (statement_t*) label;
 }
 
 static
 statement_t *parse_default_statement(void)
 {
        eat(T_default);
+
+       case_label_statement_t *label = allocate_ast_zero(sizeof(label[0]));
+       label->statement.type            = STATEMENT_CASE_LABEL;
+       label->statement.source_position = token.source_position;
+
        expect(':');
-       parse_statement();
+       label->statement.next = parse_statement();
 
-       return NULL;
+       return (statement_t*) label;
 }
 
 static
@@ -1665,77 +2072,118 @@ static
 statement_t *parse_if(void)
 {
        eat(T_if);
+
+       if_statement_t *statement = allocate_ast_zero(sizeof(statement[0]));
+       statement->statement.type            = STATEMENT_IF;
+       statement->statement.source_position = token.source_position;
+
        expect('(');
-       parse_expression();
+       statement->condition = parse_expression();
        expect(')');
 
-       parse_statement();
+       statement->true_statement = parse_statement();
        if(token.type == T_else) {
                next_token();
-               parse_statement();
+               statement->false_statement = parse_statement();
        }
 
-       return NULL;
+       return (statement_t*) statement;
 }
 
 static
 statement_t *parse_switch(void)
 {
        eat(T_switch);
+
+       switch_statement_t *statement = allocate_ast_zero(sizeof(statement[0]));
+       statement->statement.type            = STATEMENT_SWITCH;
+       statement->statement.source_position = token.source_position;
+
        expect('(');
-       parse_expression();
+       statement->expression = parse_expression();
        expect(')');
-       parse_statement();
+       statement->body = parse_statement();
 
-       return NULL;
+       return (statement_t*) statement;
 }
 
 static
 statement_t *parse_while(void)
 {
        eat(T_while);
+
+       while_statement_t *statement = allocate_ast_zero(sizeof(statement[0]));
+       statement->statement.type            = STATEMENT_WHILE;
+       statement->statement.source_position = token.source_position;
+
        expect('(');
-       parse_expression();
+       statement->condition = parse_expression();
        expect(')');
-       parse_statement();
+       statement->body = parse_statement();
 
-       return NULL;
+       return (statement_t*) statement;
 }
 
 static
 statement_t *parse_do(void)
 {
        eat(T_do);
-       parse_statement();
+
+       do_while_statement_t *statement = allocate_ast_zero(sizeof(statement[0]));
+       statement->statement.type            = STATEMENT_DO_WHILE;
+       statement->statement.source_position = token.source_position;
+
+       statement->body = parse_statement();
        expect(T_while);
        expect('(');
-       parse_expression();
+       statement->condition = parse_expression();
        expect(')');
+       expect(';');
 
-       return NULL;
+       return (statement_t*) statement;
 }
 
 static
 statement_t *parse_for(void)
 {
        eat(T_for);
+
+       for_statement_t *statement = allocate_ast_zero(sizeof(statement[0]));
+       statement->statement.type            = STATEMENT_FOR;
+       statement->statement.source_position = token.source_position;
+
        expect('(');
+
+       int         top          = environment_top();
+       context_t  *last_context = context;
+       set_context(&statement->context);
+
        if(token.type != ';') {
-               /* TODO not correct... this could also be a declaration */
-               parse_expression();
+               if(is_declaration_specifier(&token, 0)) {
+                       parse_declaration();
+               } else {
+                       statement->initialisation = parse_expression();
+                       expect(';');
+               }
+       } else {
+               expect(';');
        }
-       expect(';');
+
        if(token.type != ';') {
-               parse_expression();
+               statement->condition = parse_expression();
        }
        expect(';');
        if(token.type != ')') {
-               parse_expression();
+               statement->step = parse_expression();
        }
        expect(')');
-       parse_statement();
+       statement->body = parse_statement();
 
-       return NULL;
+       assert(context == &statement->context);
+       set_context(last_context);
+       environment_pop_to(top);
+
+       return (statement_t*) statement;
 }
 
 static
@@ -1767,7 +2215,11 @@ statement_t *parse_break(void)
        eat(T_break);
        expect(';');
 
-       return NULL;
+       statement_t *statement     = allocate_ast_zero(sizeof(statement[0]));
+       statement->source_position = token.source_position;
+       statement->type            = STATEMENT_BREAK;
+
+       return statement;
 }
 
 static
@@ -1776,7 +2228,9 @@ statement_t *parse_return(void)
        eat(T_return);
 
        return_statement_t *statement = allocate_ast_zero(sizeof(statement[0]));
-       statement->statement.type = STATEMENT_RETURN;
+
+       statement->statement.type            = STATEMENT_RETURN;
+       statement->statement.source_position = token.source_position;
        if(token.type != ';') {
                statement->return_value = parse_expression();
        }
@@ -1788,15 +2242,45 @@ statement_t *parse_return(void)
 static
 statement_t *parse_declaration_statement(void)
 {
-       parse_declaration();
-       return NULL;
+       declaration_t *before = last_declaration;
+
+       declaration_statement_t *statement
+               = allocate_ast_zero(sizeof(statement[0]));
+       statement->statement.type            = STATEMENT_DECLARATION;
+       statement->statement.source_position = token.source_position;
+
+       declaration_specifiers_t specifiers;
+       memset(&specifiers, 0, sizeof(specifiers));
+       parse_declaration_specifiers(&specifiers);
+
+       if(token.type == ';') {
+               eat(';');
+       } else {
+               parse_init_declarators(&specifiers);
+       }
+
+       if(before == NULL) {
+               statement->declarations_begin = context->declarations;
+       } else {
+               statement->declarations_begin = before->next;
+       }
+       statement->declarations_end = last_declaration;
+
+       return (statement_t*) statement;
 }
 
 static
 statement_t *parse_expression_statement(void)
 {
-       parse_expression();
-       return NULL;
+       expression_statement_t *statement = allocate_ast_zero(sizeof(statement[0]));
+       statement->statement.type            = STATEMENT_EXPRESSION;
+       statement->statement.source_position = token.source_position;
+
+       statement->expression = parse_expression();
+
+       expect(';');
+
+       return (statement_t*) statement;
 }
 
 static
@@ -1856,11 +2340,12 @@ statement_t *parse_statement(void)
                break;
 
        case ';':
+               next_token();
                statement = NULL;
                break;
 
        case T_IDENTIFIER:
-               if(la(1)->type == ':') {
+               if(look_ahead(1)->type == ':') {
                        statement = parse_label_statement();
                        break;
                }
@@ -1875,11 +2360,26 @@ statement_t *parse_statement(void)
                statement = parse_expression_statement();
                break;
 
+       case T___extension__:
+               /* this can be a prefix to a declaration or an expression statement */
+               /* we simply eat it now and parse the rest with tail recursion */
+               do {
+                       next_token();
+               } while(token.type == T___extension__);
+               statement = parse_statement();
+               break;
+
        DECLARATION_START
                statement = parse_declaration_statement();
                break;
+
+       default:
+               statement = parse_expression_statement();
+               break;
        }
 
+       assert(statement == NULL || statement->source_position.input_name != NULL);
+
        return statement;
 }
 
@@ -1890,7 +2390,8 @@ statement_t *parse_compound_statement(void)
 
        compound_statement_t *compound_statement
                = allocate_ast_zero(sizeof(compound_statement[0]));
-       compound_statement->statement.type = STATEMENT_COMPOUND;
+       compound_statement->statement.type            = STATEMENT_COMPOUND;
+       compound_statement->statement.source_position = token.source_position;
 
        int        top          = environment_top();
        context_t *last_context = context;
@@ -1898,14 +2399,20 @@ statement_t *parse_compound_statement(void)
 
        statement_t *last_statement = NULL;
 
-       while(token.type != '}') {
+       while(token.type != '}' && token.type != T_EOF) {
                statement_t *statement = parse_statement();
+               if(statement == NULL)
+                       continue;
 
                if(last_statement != NULL) {
                        last_statement->next = statement;
                } else {
                        compound_statement->statements = statement;
                }
+
+               while(statement->next != NULL)
+                       statement = statement->next;
+
                last_statement = statement;
        }
 
@@ -1942,6 +2449,8 @@ translation_unit_t *parse(void)
        obstack_init(&environment_obstack);
        environment_stack = NEW_ARR_F(environment_entry_t*, 0);
 
+       type_set_output(stderr);
+
        lookahead_bufpos = 0;
        for(int i = 0; i < MAX_LOOKAHEAD + 2; ++i) {
                next_token();