Errors and Features of type_id stuff

[libfirm] / ir / tr / typegmod.c

diff --git a/ir/tr/typegmod.c b/ir/tr/typegmod.c
index d6138fc..4a44ef9 100644 (file)
--- a/ir/tr/typegmod.c
+++ b/ir/tr/typegmod.c
@@ -13,15 +13,22 @@
 inline void exchange_types(type *old_type, type *new_type) {
   int i;
   /* Deallocate datastructures not directly contained in the
-     old type */
-  /* @@@@ */
+     old type.  We must do this now as it is the latest point
+     where we know the original kind of type.
+     */
+  free_type_attrs(old_type);
 
-  /* Remove old type from type list.  Will this confuscate the
-     iterators? */
-  /* @@@ */
-
-  /* Ev. add to a list of id types for later deallocation. */
-  /* @@@ */
+  /* @@@@
+     Things to deal with:
+     * After exchange_types the type has two entries in the list of
+       all types in irp.  So far this is fine for the walker.
+       Maybe it's better to remove the id entry and shrink the list.
+       Does this conflict with the walker?  Might a type be left out
+       during the walk?
+     * Deallocation:  if the Id is removed from the list it will eventualle
+       disappear in a memory leak.  When is impossible to determine so we
+       need to hold it in a seperate list for deallocation.
+  */
 
   /* Exchange the types */
   old_type->type_op = type_id;