Use SPARC_STACK_ALIGNMENT and round_up2() instead of magic numbers and calculations.
[libfirm] / ir / opt / funccall.c
index fe6f8d9..f4cdb39 100644 (file)
@@ -100,7 +100,7 @@ static void collect_const_and_pure_calls(ir_node *node, void *env)
                           is_Sel(ptr) &&
                           get_irg_callee_info_state(get_irn_irg(node)) == irg_callee_info_consistent) {
                        /* If all possible callees are const functions, we can remove the memory edge. */
-                       int i, n_callees = get_Call_n_callees(call);
+                       size_t i, n_callees = get_Call_n_callees(call);
                        if (n_callees == 0) {
                                /* This is kind of strange:  dying code or a Call that will raise an exception
                                   when executed as there is no implementation to call.  So better not
@@ -225,7 +225,7 @@ static void fix_const_call_lists(ir_graph *irg, env_t *ctx)
                }
                case pn_Call_X_except:
                        exc_changed = 1;
-                       exchange(proj, get_irg_bad(irg));
+                       exchange(proj, new_r_Bad(irg, mode_X));
                        break;
                case pn_Call_X_regular: {
                        ir_node *block = get_nodes_block(call);
@@ -239,12 +239,11 @@ static void fix_const_call_lists(ir_graph *irg, env_t *ctx)
        }
 
        /* changes were done ... */
-       set_irg_outs_inconsistent(irg);
        set_irg_loopinfo_state(irg, loopinfo_cf_inconsistent);
 
        if (exc_changed) {
                /* ... including exception edges */
-               set_irg_doms_inconsistent(irg);
+               clear_irg_state(irg, IR_GRAPH_STATE_CONSISTENT_DOMINANCE);
        }
 }  /* fix_const_call_list */
 
@@ -276,7 +275,7 @@ static void collect_nothrow_calls(ir_node *node, void *env)
                           is_Sel(ptr) &&
                           get_irg_callee_info_state(get_irn_irg(node)) == irg_callee_info_consistent) {
                        /* If all possible callees are nothrow functions, we can remove the exception edge. */
-                       int i, n_callees = get_Call_n_callees(call);
+                       size_t i, n_callees = get_Call_n_callees(call);
                        if (n_callees == 0) {
                                /* This is kind of strange:  dying code or a Call that will raise an exception
                                   when executed as there is no implementation to call.  So better not
@@ -360,7 +359,7 @@ static void fix_nothrow_call_list(ir_graph *irg, ir_node *call_list, ir_node *pr
                switch (get_Proj_proj(proj)) {
                case pn_Call_X_except:
                        exc_changed = 1;
-                       exchange(proj, get_irg_bad(irg));
+                       exchange(proj, new_r_Bad(irg, mode_X));
                        break;
                case pn_Call_X_regular: {
                        ir_node *block = get_nodes_block(call);
@@ -374,12 +373,11 @@ static void fix_nothrow_call_list(ir_graph *irg, ir_node *call_list, ir_node *pr
        }
 
        /* changes were done ... */
-       set_irg_outs_inconsistent(irg);
        set_irg_loopinfo_state(irg, loopinfo_cf_inconsistent);
 
        if (exc_changed) {
                /* ... including exception edges */
-               set_irg_doms_inconsistent(irg);
+               clear_irg_state(irg, IR_GRAPH_STATE_CONSISTENT_DOMINANCE);
        }
 }  /* fix_nothrow_call_list */
 
@@ -467,12 +465,10 @@ static mtp_additional_properties follow_mem_(ir_node *node)
                                ir_entity *ent = get_SymConst_entity(ptr);
                                ir_graph  *irg = get_entity_irg(ent);
 
-                               if (irg == get_irn_irg(node)) {
-                                       /* A self-recursive call. The property did not depend on this call. */
-                               } else if (irg == NULL) {
+                               if (irg == NULL) {
                                        m = get_entity_additional_properties(ent) & (mtp_property_const|mtp_property_pure);
                                        mode = max_property(mode, m);
-                               } else if (irg != NULL) {
+                               } else {
                                        /* we have a graph, analyze it. */
                                        m = check_const_or_pure_function(irg, /*top=*/0);
                                        mode = max_property(mode, m);
@@ -512,8 +508,23 @@ static mtp_additional_properties check_const_or_pure_function(ir_graph *irg, int
 {
        ir_node *end, *endbl;
        int j;
+       ir_entity *entity   = get_irg_entity(irg);
+       ir_type   *type     = get_entity_type(entity);
+       size_t     n_params = get_method_n_params(type);
+       size_t     i;
+       mtp_additional_properties may_be_const = mtp_property_const;
        mtp_additional_properties prop = get_irg_additional_properties(irg);
 
+       /* libfirm handles aggregate parameters by passing around pointers to
+        * stuff in memory, so if we have compound parameters we are never const */
+       for (i = 0; i < n_params; ++i) {
+               ir_type *param = get_method_param_type(type, i);
+               if (is_compound_type(param)) {
+                       prop        &= ~mtp_property_const;
+                       may_be_const = mtp_no_property;
+               }
+       }
+
        if (prop & mtp_property_const) {
                /* already marked as a const function */
                return mtp_property_const;
@@ -528,15 +539,16 @@ static mtp_additional_properties check_const_or_pure_function(ir_graph *irg, int
                return mtp_no_property;
        }
        if (IS_IRG_BUSY(irg)) {
-               /* we are still evaluate this method. Be optimistic,
-                  return the best possible so far but mark the result as temporary. */
-               return mtp_temporary | mtp_property_const;
+               /* We are still evaluate this method.
+                * The function (indirectly) calls itself and thus may not terminate.
+                */
+               return mtp_no_property;
        }
        SET_IRG_BUSY(irg);
 
        end   = get_irg_end(irg);
        endbl = get_nodes_block(end);
-       prop  = mtp_property_const;
+       prop  = may_be_const;
 
        ir_reserve_resources(irg, IR_RESOURCE_IRN_VISITED);
        inc_irg_visited(irg);
@@ -590,17 +602,13 @@ static mtp_additional_properties check_const_or_pure_function(ir_graph *irg, int
                }
        }
 
-       if (prop != mtp_no_property) {
-               if (top || (prop & mtp_temporary) == 0) {
-                       /* We use the temporary flag here to mark optimistic result.
-                          Set the property only if we are sure that it does NOT base on
-                          temporary results OR if we are at top-level. */
-                       add_irg_additional_properties(irg, prop & ~mtp_temporary);
-                       SET_IRG_READY(irg);
+       if (top) {
+               /* Set the property only if we are at top-level. */
+               if (prop != mtp_no_property) {
+                       add_irg_additional_properties(irg, prop);
                }
-       }
-       if (top)
                SET_IRG_READY(irg);
+       }
        CLEAR_IRG_BUSY(irg);
        ir_free_resources(irg, IR_RESOURCE_IRN_VISITED);
        return prop;
@@ -722,11 +730,11 @@ static int is_stored(const ir_node *n)
                        ptr = get_Call_ptr(succ);
                        if (is_Global(ptr)) {
                                ir_entity *ent = get_Global_entity(ptr);
-                               int       i;
+                               size_t    i;
 
                                /* we know the called entity */
-                               for (i = get_Call_n_params(succ) - 1; i >= 0; --i) {
-                                       if (get_Call_param(succ, i) == n) {
+                               for (i = get_Call_n_params(succ); i > 0;) {
+                                       if (get_Call_param(succ, --i) == n) {
                                                /* n is the i'th param of the call */
                                                if (get_method_param_access(ent, i) & ptr_access_store) {
                                                        /* n is store in ent */
@@ -755,17 +763,18 @@ static int is_stored(const ir_node *n)
 static mtp_additional_properties check_stored_result(ir_graph *irg)
 {
        ir_node  *end_blk = get_irg_end_block(irg);
-       int      i, j;
+       int      i;
        mtp_additional_properties res = ~mtp_no_property;
        int      old_edges = edges_assure_kind(irg, EDGE_KIND_NORMAL);
 
        for (i = get_Block_n_cfgpreds(end_blk) - 1; i >= 0; --i) {
                ir_node *pred = get_Block_cfgpred(end_blk, i);
+               size_t  j;
 
                if (! is_Return(pred))
                        continue;
-               for (j = get_Return_n_ress(pred) - 1; j >= 0; --j) {
-                       const ir_node *irn = get_Return_res(pred, j);
+               for (j = get_Return_n_ress(pred); j > 0;) {
+                       const ir_node *irn = get_Return_res(pred, --j);
 
                        if (is_stored(irn)) {
                                /* bad, might create an alias */
@@ -792,7 +801,7 @@ static mtp_additional_properties check_nothrow_or_malloc(ir_graph *irg, int top)
        ir_node                  *end_blk   = get_irg_end_block(irg);
        ir_entity *ent;
        ir_type   *mtp;
-       int       i, j;
+       int       i;
 
        if (IS_IRG_READY(irg)) {
                /* already checked */
@@ -816,9 +825,11 @@ static mtp_additional_properties check_nothrow_or_malloc(ir_graph *irg, int top)
 
                if (is_Return(pred)) {
                        if (curr_prop & mtp_property_malloc) {
+                               size_t j;
+
                                /* check, if malloc is called here */
-                               for (j = get_Return_n_ress(pred) - 1; j >= 0; --j) {
-                                       ir_node *res = get_Return_res(pred, j);
+                               for (j = get_Return_n_ress(pred); j > 0;) {
+                                       ir_node *res = get_Return_res(pred, --j);
 
                                        /* skip Confirms and Casts */
                                        res = skip_HighLevel_ops(res);
@@ -847,7 +858,7 @@ static mtp_additional_properties check_nothrow_or_malloc(ir_graph *irg, int top)
                                                           is_Sel(ptr) &&
                                                           get_irg_callee_info_state(irg) == irg_callee_info_consistent) {
                                                        /* check if all possible callees are malloc functions. */
-                                                       int i, n_callees = get_Call_n_callees(res);
+                                                       size_t i, n_callees = get_Call_n_callees(res);
                                                        if (n_callees == 0) {
                                                                /* This is kind of strange:  dying code or a Call that will raise an exception
                                                                   when executed as there is no implementation to call.  So better not
@@ -905,7 +916,7 @@ static mtp_additional_properties check_nothrow_or_malloc(ir_graph *irg, int top)
                                           is_Sel(ptr) &&
                                           get_irg_callee_info_state(irg) == irg_callee_info_consistent) {
                                        /* check if all possible callees are nothrow functions. */
-                                       int i, n_callees = get_Call_n_callees(pred);
+                                       size_t i, n_callees = get_Call_n_callees(pred);
                                        if (n_callees == 0) {
                                                /* This is kind of strange:  dying code or a Call that will raise an exception
                                                   when executed as there is no implementation to call.  So better not
@@ -987,7 +998,7 @@ static void check_for_possible_endless_loops(ir_graph *irg)
 void optimize_funccalls(void)
 {
        size_t i, n;
-       int last_idx;
+       size_t last_idx;
        env_t  ctx;
        size_t num_const   = 0;
        size_t num_pure    = 0;