sparc: fix spilling+reloading of float values
[libfirm] / ir / be / sparc / sparc_transform.c
index e4f5dd1..32babd0 100644 (file)
@@ -83,52 +83,6 @@ static ir_node               *frame_base;
 static size_t                 start_params_offset;
 static size_t                 start_callee_saves_offset;
 
-static const arch_register_t *const caller_saves[] = {
-       &sparc_registers[REG_G1],
-       &sparc_registers[REG_G2],
-       &sparc_registers[REG_G3],
-       &sparc_registers[REG_G4],
-       &sparc_registers[REG_O0],
-       &sparc_registers[REG_O1],
-       &sparc_registers[REG_O2],
-       &sparc_registers[REG_O3],
-       &sparc_registers[REG_O4],
-       &sparc_registers[REG_O5],
-
-       &sparc_registers[REG_F0],
-       &sparc_registers[REG_F1],
-       &sparc_registers[REG_F2],
-       &sparc_registers[REG_F3],
-       &sparc_registers[REG_F4],
-       &sparc_registers[REG_F5],
-       &sparc_registers[REG_F6],
-       &sparc_registers[REG_F7],
-       &sparc_registers[REG_F8],
-       &sparc_registers[REG_F9],
-       &sparc_registers[REG_F10],
-       &sparc_registers[REG_F11],
-       &sparc_registers[REG_F12],
-       &sparc_registers[REG_F13],
-       &sparc_registers[REG_F14],
-       &sparc_registers[REG_F15],
-       &sparc_registers[REG_F16],
-       &sparc_registers[REG_F17],
-       &sparc_registers[REG_F18],
-       &sparc_registers[REG_F19],
-       &sparc_registers[REG_F20],
-       &sparc_registers[REG_F21],
-       &sparc_registers[REG_F22],
-       &sparc_registers[REG_F23],
-       &sparc_registers[REG_F24],
-       &sparc_registers[REG_F25],
-       &sparc_registers[REG_F26],
-       &sparc_registers[REG_F27],
-       &sparc_registers[REG_F28],
-       &sparc_registers[REG_F29],
-       &sparc_registers[REG_F30],
-       &sparc_registers[REG_F31],
-};
-
 static const arch_register_t *const omit_fp_callee_saves[] = {
        &sparc_registers[REG_L0],
        &sparc_registers[REG_L1],
@@ -392,19 +346,19 @@ static ir_node *gen_helper_unfpop(ir_node *node, ir_mode *mode,
                                   new_unop_fp_func new_func_double,
                                   new_unop_fp_func new_func_quad)
 {
-       ir_node  *block   = be_transform_node(get_nodes_block(node));
-       ir_node  *op1     = get_binop_left(node);
-       ir_node  *new_op1 = be_transform_node(op1);
-       dbg_info *dbgi    = get_irn_dbg_info(node);
-       unsigned  bits    = get_mode_size_bits(mode);
+       ir_node  *block  = be_transform_node(get_nodes_block(node));
+       ir_node  *op     = get_unop_op(node);
+       ir_node  *new_op = be_transform_node(op);
+       dbg_info *dbgi   = get_irn_dbg_info(node);
+       unsigned  bits   = get_mode_size_bits(mode);
 
        switch (bits) {
        case 32:
-               return new_func_single(dbgi, block, new_op1, mode);
+               return new_func_single(dbgi, block, new_op, mode);
        case 64:
-               return new_func_double(dbgi, block, new_op1, mode);
+               return new_func_double(dbgi, block, new_op, mode);
        case 128:
-               return new_func_quad(dbgi, block, new_op1, mode);
+               return new_func_quad(dbgi, block, new_op, mode);
        default:
                break;
        }
@@ -641,9 +595,9 @@ static ir_node *gen_SubX_t(ir_node *node)
                                 new_bd_sparc_SubX_reg, new_bd_sparc_SubX_imm);
 }
 
-static ir_node *create_ldf(dbg_info *dbgi, ir_node *block, ir_node *ptr,
-                           ir_node *mem, ir_mode *mode, ir_entity *entity,
-                           long offset, bool is_frame_entity)
+ir_node *create_ldf(dbg_info *dbgi, ir_node *block, ir_node *ptr,
+                    ir_node *mem, ir_mode *mode, ir_entity *entity,
+                    long offset, bool is_frame_entity)
 {
        unsigned bits = get_mode_size_bits(mode);
        assert(mode_is_float(mode));
@@ -660,10 +614,10 @@ static ir_node *create_ldf(dbg_info *dbgi, ir_node *block, ir_node *ptr,
        }
 }
 
-static ir_node *create_stf(dbg_info *dbgi, ir_node *block, ir_node *value,
-                           ir_node *ptr, ir_node *mem, ir_mode *mode,
-                           ir_entity *entity, long offset,
-                           bool is_frame_entity)
+ir_node *create_stf(dbg_info *dbgi, ir_node *block, ir_node *value,
+                    ir_node *ptr, ir_node *mem, ir_mode *mode,
+                    ir_entity *entity, long offset,
+                    bool is_frame_entity)
 {
        unsigned bits = get_mode_size_bits(mode);
        assert(mode_is_float(mode));
@@ -1384,106 +1338,6 @@ static ir_node *gen_Unknown(ir_node *node)
        panic("Unexpected Unknown mode");
 }
 
-/**
- * Produces the type which sits between the stack args and the locals on the
- * stack.
- */
-static ir_type *sparc_get_between_type(void)
-{
-       static ir_type *between_type  = NULL;
-       static ir_type *between_type0 = NULL;
-
-       if (current_cconv->omit_fp) {
-               if (between_type0 == NULL) {
-                       between_type0
-                               = new_type_class(new_id_from_str("sparc_between_type"));
-                       set_type_size_bytes(between_type0, 0);
-               }
-               return between_type0;
-       }
-
-       if (between_type == NULL) {
-               between_type = new_type_class(new_id_from_str("sparc_between_type"));
-               set_type_size_bytes(between_type, SPARC_MIN_STACKSIZE);
-       }
-
-       return between_type;
-}
-
-static ir_type *compute_arg_type(ir_graph *irg)
-{
-       ir_entity  *entity    = get_irg_entity(irg);
-       ir_type    *mtp       = get_entity_type(entity);
-       size_t      n_params  = get_method_n_params(mtp);
-       ir_entity **param_map = ALLOCANZ(ir_entity*, n_params);
-
-       ir_type *frame_type      = get_irg_frame_type(irg);
-       size_t   n_frame_members = get_compound_n_members(frame_type);
-       size_t   f;
-       size_t   i;
-
-       ir_type *res = new_type_struct(id_mangle_u(get_entity_ident(entity), new_id_from_chars("arg_type", 8)));
-
-       /* search for existing value_param entities */
-       for (f = n_frame_members; f > 0; ) {
-               ir_entity *member = get_compound_member(frame_type, --f);
-               size_t     num;
-               const reg_or_stackslot_t *param;
-
-               if (!is_parameter_entity(member))
-                       continue;
-               num = get_entity_parameter_number(member);
-               assert(num < n_params);
-               if (param_map[num] != NULL)
-                       panic("multiple entities for parameter %u in %+F found", f, irg);
-
-               param = &current_cconv->parameters[num];
-               if (param->reg0 != NULL)
-                       continue;
-
-               param_map[num] = member;
-               /* move to new arg_type */
-               set_entity_owner(member, res);
-       }
-
-       for (i = 0; i < n_params; ++i) {
-               reg_or_stackslot_t *param = &current_cconv->parameters[i];
-               ir_entity          *entity;
-
-               if (param->reg0 != NULL)
-                       continue;
-               entity = param_map[i];
-               if (entity == NULL)
-                       entity = new_parameter_entity(res, i, param->type);
-               param->entity = entity;
-               set_entity_offset(entity, param->offset);
-       }
-
-       return res;
-}
-
-static void create_stacklayout(ir_graph *irg)
-{
-       be_stack_layout_t *layout = be_get_irg_stack_layout(irg);
-
-       /* calling conventions must be decided by now */
-       assert(current_cconv != NULL);
-
-       memset(layout, 0, sizeof(*layout));
-
-       layout->frame_type     = get_irg_frame_type(irg);
-       layout->between_type   = sparc_get_between_type();
-       layout->arg_type       = compute_arg_type(irg);
-       layout->initial_offset = 0;
-       layout->initial_bias   = 0;
-       layout->sp_relative    = current_cconv->omit_fp;
-
-       assert(N_FRAME_TYPES == 3);
-       layout->order[0] = layout->frame_type;
-       layout->order[1] = layout->between_type;
-       layout->order[2] = layout->arg_type;
-}
-
 /**
  * transform the start node to the prolog code
  */
@@ -1522,7 +1376,9 @@ static ir_node *gen_Start(ir_node *node)
 
        /* first output is memory */
        start_mem_offset = o;
-       arch_set_out_register_req(start, o++, arch_no_register_req);
+       arch_set_out_register_req(start, o, arch_no_register_req);
+       ++o;
+
        /* the zero register */
        start_g0_offset = o;
        req = be_create_reg_req(obst, &sparc_registers[REG_G0],
@@ -1674,10 +1530,9 @@ static ir_node *gen_Return(ir_node *node)
                ir_node                  *res_value     = get_Return_res(node, i);
                ir_node                  *new_res_value = be_transform_node(res_value);
                const reg_or_stackslot_t *slot          = &current_cconv->results[i];
-               const arch_register_t    *reg           = slot->reg0;
-               assert(slot->reg1 == NULL);
+               assert(slot->req1 == NULL);
                in[p]   = new_res_value;
-               reqs[p] = reg->single_req;
+               reqs[p] = slot->req0;
                ++p;
        }
        /* callee saves */
@@ -1776,6 +1631,7 @@ static ir_node *gen_Call(ir_node *node)
        dbg_info        *dbgi         = get_irn_dbg_info(node);
        ir_type         *type         = get_Call_type(node);
        size_t           n_params     = get_Call_n_params(node);
+       size_t           n_ress       = get_method_n_ress(type);
        /* max inputs: memory, callee, register arguments */
        ir_node        **sync_ins     = ALLOCAN(ir_node*, n_params);
        struct obstack  *obst         = be_get_be_obst(irg);
@@ -1790,13 +1646,16 @@ static ir_node *gen_Call(ir_node *node)
        int              in_arity     = 0;
        int              sync_arity   = 0;
        int              n_caller_saves
-               = sizeof(caller_saves)/sizeof(caller_saves[0]);
+               = rbitset_popcount(cconv->caller_saves, N_SPARC_REGISTERS);
        ir_entity       *entity       = NULL;
        ir_node         *new_frame    = get_stack_pointer_for(node);
+       bool             aggregate_return
+               = type->attr.ma.has_compound_ret_parameter;
        ir_node         *incsp;
        int              mem_pos;
        ir_node         *res;
        size_t           p;
+       size_t           r;
        int              i;
        int              o;
        int              out_arity;
@@ -1828,6 +1687,7 @@ static ir_node *gen_Call(ir_node *node)
                ir_mode                  *mode       = get_type_mode(param_type);
                ir_node                  *new_values[2];
                ir_node                  *str;
+               int                       offset;
 
                if (mode_is_float(mode) && param->reg0 != NULL) {
                        unsigned size_bits = get_mode_size_bits(mode);
@@ -1860,13 +1720,16 @@ static ir_node *gen_Call(ir_node *node)
                        mode      = mode_gp;
                }
 
-               /* create a parameter frame if necessary */
+               /* we need to skip over our save area when constructing the call
+                * arguments on stack */
+               offset = param->offset + SPARC_MIN_STACKSIZE;
+
                if (mode_is_float(mode)) {
                        str = create_stf(dbgi, new_block, new_value, incsp, new_mem,
-                                        mode, NULL, param->offset, true);
+                                        mode, NULL, offset, true);
                } else {
                        str = new_bd_sparc_St_imm(dbgi, new_block, new_value, incsp,
-                                                 new_mem, mode, NULL, param->offset, true);
+                                                 new_mem, mode, NULL, offset, true);
                }
                set_irn_pinned(str, op_pin_state_floats);
                sync_ins[sync_arity++] = str;
@@ -1892,24 +1755,38 @@ static ir_node *gen_Call(ir_node *node)
 
        /* outputs:
         *  - memory
+        *  - results
         *  - caller saves
         */
-       out_arity = 1 + n_caller_saves;
+       out_arity = 1 + cconv->n_reg_results + n_caller_saves;
 
        /* create call node */
        if (entity != NULL) {
                res = new_bd_sparc_Call_imm(dbgi, new_block, in_arity, in, out_arity,
-                                           entity, 0);
+                                           entity, 0, aggregate_return);
        } else {
-               res = new_bd_sparc_Call_reg(dbgi, new_block, in_arity, in, out_arity);
+               res = new_bd_sparc_Call_reg(dbgi, new_block, in_arity, in, out_arity,
+                                           aggregate_return);
        }
        arch_set_in_register_reqs(res, in_req);
 
        /* create output register reqs */
        o = 0;
        arch_set_out_register_req(res, o++, arch_no_register_req);
-       for (i = 0; i < n_caller_saves; ++i) {
-               const arch_register_t *reg = caller_saves[i];
+       /* add register requirements for the result regs */
+       for (r = 0; r < n_ress; ++r) {
+               const reg_or_stackslot_t  *result_info = &cconv->results[r];
+               const arch_register_req_t *req         = result_info->req0;
+               if (req != NULL) {
+                       arch_set_out_register_req(res, o++, req);
+               }
+               assert(result_info->req1 == NULL);
+       }
+       for (i = 0; i < N_SPARC_REGISTERS; ++i) {
+               const arch_register_t *reg;
+               if (!rbitset_is_set(cconv->caller_saves, i))
+                       continue;
+               reg = &sparc_registers[i];
                arch_set_out_register_req(res, o++, reg->single_req);
        }
        assert(o == out_arity);
@@ -2097,16 +1974,23 @@ static ir_node *gen_Proj_Div(ir_node *node)
        ir_node  *pred     = get_Proj_pred(node);
        ir_node  *new_pred = be_transform_node(pred);
        long      pn       = get_Proj_proj(node);
+       ir_mode  *res_mode;
 
-       assert(is_sparc_SDiv(new_pred) || is_sparc_UDiv(new_pred)
-              || is_sparc_fdiv(new_pred));
+       if (is_sparc_SDiv(new_pred) || is_sparc_UDiv(new_pred)) {
+               res_mode = mode_gp;
+       } else if (is_sparc_fdiv(new_pred)) {
+               res_mode = get_Div_resmode(pred);
+       } else {
+               panic("sparc backend: Div transformed to something unexpected: %+F",
+                     new_pred);
+       }
        assert((int)pn_sparc_SDiv_res == (int)pn_sparc_UDiv_res);
        assert((int)pn_sparc_SDiv_M   == (int)pn_sparc_UDiv_M);
        assert((int)pn_sparc_SDiv_res == (int)pn_sparc_fdiv_res);
        assert((int)pn_sparc_SDiv_M   == (int)pn_sparc_fdiv_M);
        switch (pn) {
        case pn_Div_res:
-               return new_r_Proj(new_pred, mode_gp, pn_sparc_SDiv_res);
+               return new_r_Proj(new_pred, res_mode, pn_sparc_SDiv_res);
        case pn_Div_M:
                return new_r_Proj(new_pred, mode_gp, pn_sparc_SDiv_M);
        default:
@@ -2238,23 +2122,6 @@ static ir_node *gen_Proj_Call(ir_node *node)
        panic("Unexpected Call proj %ld\n", pn);
 }
 
-/**
- * Finds number of output value of a mode_T node which is constrained to
- * a single specific register.
- */
-static int find_out_for_reg(ir_node *node, const arch_register_t *reg)
-{
-       int n_outs = arch_irn_get_n_outs(node);
-       int o;
-
-       for (o = 0; o < n_outs; ++o) {
-               const arch_register_req_t *req = arch_get_out_register_req(node, o);
-               if (req == reg->single_req)
-                       return o;
-       }
-       return -1;
-}
-
 static ir_node *gen_Proj_Proj_Call(ir_node *node)
 {
        long                  pn            = get_Proj_proj(node);
@@ -2263,21 +2130,15 @@ static ir_node *gen_Proj_Proj_Call(ir_node *node)
        ir_type              *function_type = get_Call_type(call);
        calling_convention_t *cconv
                = sparc_decide_calling_convention(function_type, NULL);
-       const reg_or_stackslot_t *res = &cconv->results[pn];
-       const arch_register_t    *reg = res->reg0;
-       ir_mode                  *mode;
-       int                       regn;
-
-       assert(res->reg0 != NULL && res->reg1 == NULL);
-       regn = find_out_for_reg(new_call, reg);
-       if (regn < 0) {
-               panic("Internal error in calling convention for return %+F", node);
-       }
-       mode = res->reg0->reg_class->mode;
+       const reg_or_stackslot_t  *res = &cconv->results[pn];
+       ir_mode                   *mode;
+       long                       new_pn = 1 + res->reg_offset;
 
+       assert(res->req0 != NULL && res->req1 == NULL);
+       mode = res->req0->cls->mode;
        sparc_free_calling_convention(cconv);
 
-       return new_r_Proj(new_call, mode, regn);
+       return new_r_Proj(new_call, mode, new_pn);
 }
 
 /**
@@ -2403,7 +2264,7 @@ void sparc_transform_graph(ir_graph *irg)
        stackorder = be_collect_stacknodes(irg);
        current_cconv
                = sparc_decide_calling_convention(get_entity_type(entity), irg);
-       create_stacklayout(irg);
+       sparc_create_stacklayout(irg, current_cconv);
        be_add_parameter_entity_stores(irg);
 
        be_transform_graph(irg, NULL);