It does not make any sense to remove AM, which loads a non-GP value to fix register...
[libfirm] / ir / be / ia32 / ia32_finish.c
index dc4348d..b7d3268 100644 (file)
@@ -44,6 +44,7 @@
 #include "ia32_finish.h"
 #include "ia32_new_nodes.h"
 #include "ia32_map_regs.h"
+#include "ia32_common_transform.h"
 #include "ia32_transform.h"
 #include "ia32_dbg_stat.h"
 #include "ia32_optimize.h"
@@ -55,7 +56,8 @@ DEBUG_ONLY(static firm_dbg_module_t *dbg = NULL;)
  * Transforms a Sub or xSub into Neg--Add iff OUT_REG == SRC2_REG.
  * THIS FUNCTIONS MUST BE CALLED AFTER REGISTER ALLOCATION.
  */
-static void ia32_transform_sub_to_neg_add(ir_node *irn, ia32_code_gen_t *cg) {
+static void ia32_transform_sub_to_neg_add(ir_node *irn, ia32_code_gen_t *cg)
+{
        ir_graph *irg;
        ir_node *in1, *in2, *noreg, *nomem, *res;
        ir_node *noreg_fp, *block;
@@ -63,7 +65,7 @@ static void ia32_transform_sub_to_neg_add(ir_node *irn, ia32_code_gen_t *cg) {
        const arch_register_t *in1_reg, *in2_reg, *out_reg;
 
        /* fix_am will solve this for AddressMode variants */
-       if(get_ia32_op_type(irn) != ia32_Normal)
+       if (get_ia32_op_type(irn) != ia32_Normal)
                return;
 
        noreg    = ia32_new_NoReg_gp(cg);
@@ -85,7 +87,7 @@ static void ia32_transform_sub_to_neg_add(ir_node *irn, ia32_code_gen_t *cg) {
        dbg = get_irn_dbg_info(irn);
 
        /* generate the neg src2 */
-       if(is_ia32_xSub(irn)) {
+       if (is_ia32_xSub(irn)) {
                int size;
                ir_entity *entity;
                ir_mode *op_mode = get_ia32_ls_mode(irn);
@@ -106,7 +108,6 @@ static void ia32_transform_sub_to_neg_add(ir_node *irn, ia32_code_gen_t *cg) {
 
                /* generate the add */
                res = new_rd_ia32_xAdd(dbg, irg, block, noreg, noreg, nomem, res, in1);
-               set_ia32_am_support(res, ia32_am_Source, ia32_am_binary);
                set_ia32_ls_mode(res, get_ia32_ls_mode(irn));
 
                /* exchange the add and the sub */
@@ -119,11 +120,12 @@ static void ia32_transform_sub_to_neg_add(ir_node *irn, ia32_code_gen_t *cg) {
                ir_node         *flags_proj = NULL;
                const ir_edge_t *edge;
 
-               if(get_irn_mode(irn) == mode_T) {
+               if (get_irn_mode(irn) == mode_T) {
+                       /* collect the Proj uses */
                        foreach_out_edge(irn, edge) {
                                ir_node *proj = get_edge_src_irn(edge);
                                long     pn   = get_Proj_proj(proj);
-                               if(pn == pn_ia32_Sub_res) {
+                               if (pn == pn_ia32_Sub_res) {
                                        assert(res_proj == NULL);
                                        res_proj = proj;
                                } else {
@@ -144,7 +146,6 @@ static void ia32_transform_sub_to_neg_add(ir_node *irn, ia32_code_gen_t *cg) {
                        /* generate the add */
                        res = new_rd_ia32_Add(dbg, irg, block, noreg, noreg, nomem, res, in1);
                        arch_set_irn_register(cg->arch_env, res, out_reg);
-                       set_ia32_am_support(res, ia32_am_Full, ia32_am_binary);
                        set_ia32_commutative(res);
 
                        /* exchange the add and the sub */
@@ -156,28 +157,41 @@ static void ia32_transform_sub_to_neg_add(ir_node *irn, ia32_code_gen_t *cg) {
                        ir_node *stc, *cmc, *not, *adc;
                        ir_node *adc_flags;
 
-                       /* ARG, the above technique does NOT set the flags right */
+                       /*
+                        * ARG, the above technique does NOT set the flags right.
+                        * So, we must produce the following code:
+                        * t1 = ~b
+                        * t2 = a + ~b + Carry
+                        * Complement Carry
+                        *
+                        * a + -b = a + (~b + 1)  would set the carry flag IF a == b ...
+                        */
                        not = new_rd_ia32_Not(dbg, irg, block, in2);
                        arch_set_irn_register(cg->arch_env, not, in2_reg);
                        sched_add_before(irn, not);
 
                        stc = new_rd_ia32_Stc(dbg, irg, block);
-                       arch_set_irn_register(cg->arch_env, res,
+                       arch_set_irn_register(cg->arch_env, stc,
                                              &ia32_flags_regs[REG_EFLAGS]);
+                       sched_add_before(irn, stc);
 
-                       /* generate the adc */
                        adc = new_rd_ia32_Adc(dbg, irg, block, noreg, noreg, nomem, not,
                                              in1, stc);
                        arch_set_irn_register(cg->arch_env, adc, out_reg);
                        sched_add_before(irn, adc);
 
-                       adc_flags = new_r_Proj(irg, block, res, mode_Iu, pn_ia32_Adc_flags);
+                       set_irn_mode(adc, mode_T);
+                       adc_flags = new_r_Proj(irg, block, adc, mode_Iu, pn_ia32_Adc_flags);
+                       arch_set_irn_register(cg->arch_env, adc_flags,
+                                             &ia32_flags_regs[REG_EFLAGS]);
 
                        cmc = new_rd_ia32_Cmc(dbg, irg, block, adc_flags);
+                       arch_set_irn_register(cg->arch_env, cmc,
+                                             &ia32_flags_regs[REG_EFLAGS]);
                        sched_add_before(irn, cmc);
 
                        exchange(flags_proj, cmc);
-                       if(res_proj != NULL) {
+                       if (res_proj != NULL) {
                                set_Proj_pred(res_proj, adc);
                                set_Proj_proj(res_proj, pn_ia32_Adc_res);
                        }
@@ -190,33 +204,46 @@ static void ia32_transform_sub_to_neg_add(ir_node *irn, ia32_code_gen_t *cg) {
 
        /* remove the old sub */
        sched_remove(irn);
-       be_kill_node(irn);
+       kill_node(irn);
 
        DBG_OPT_SUB2NEGADD(irn, res);
 }
 
-static INLINE int need_constraint_copy(ir_node *irn) {
-       /* the 3 operand form of IMul needs no constraint copy */
-       if(is_ia32_IMul(irn)) {
-               ir_node *right = get_irn_n(irn, n_ia32_IMul_right);
-               if(is_ia32_Immediate(right))
+static INLINE int need_constraint_copy(ir_node *irn)
+{
+       /* TODO this should be determined from the node specification */
+       switch (get_ia32_irn_opcode(irn)) {
+               case iro_ia32_IMul: {
+                       /* the 3 operand form of IMul needs no constraint copy */
+                       ir_node *right = get_irn_n(irn, n_ia32_IMul_right);
+                       return !is_ia32_Immediate(right);
+               }
+
+               case iro_ia32_Lea:
+               case iro_ia32_Conv_I2I:
+               case iro_ia32_Conv_I2I8Bit:
+               case iro_ia32_CMov:
                        return 0;
-       }
 
-       return  ! is_ia32_Lea(irn)      &&
-               ! is_ia32_Conv_I2I(irn)     &&
-               ! is_ia32_Conv_I2I8Bit(irn) &&
-               ! is_ia32_CMov(irn);
+               default:
+                       return 1;
+       }
 }
 
+/**
+ * Returns the index of the "same" register.
+ * On the x86, we should have only one.
+ */
 static int get_first_same(const arch_register_req_t* req)
 {
        const unsigned other = req->other_same;
        int i;
 
-       for (i = 0;; ++i) {
+       for (i = 0; i < 32; ++i) {
                if (other & (1U << i)) return i;
        }
+       assert(! "same position not found");
+       return 32;
 }
 
 /**
@@ -233,17 +260,7 @@ static void assure_should_be_same_requirements(ia32_code_gen_t *cg,
        const arch_register_t      *out_reg, *in_reg;
        int                         n_res, i;
        ir_node                    *in_node, *block;
-       ia32_op_type_t              op_tp;
-
-       if(!is_ia32_irn(node))
-               return;
 
-       /* some nodes are just a bit less efficient, but need no fixing if the
-        * should be same requirement is not fulfilled */
-       if(!need_constraint_copy(node))
-               return;
-
-       op_tp = get_ia32_op_type(node);
        reqs  = get_ia32_out_req_all(node);
        n_res = get_ia32_n_res(node);
        block = get_nodes_block(node);
@@ -258,7 +275,7 @@ static void assure_should_be_same_requirements(ia32_code_gen_t *cg,
                ir_node                     *perm_proj1;
                ir_node                     *uses_out_reg;
                const arch_register_req_t   *req = reqs[i];
-               const arch_register_class_t *class;
+               const arch_register_class_t *cls;
                int                         uses_out_reg_pos;
 
                if (!arch_register_req_is(req, should_be_same))
@@ -277,30 +294,30 @@ static void assure_should_be_same_requirements(ia32_code_gen_t *cg,
                /* unknowns can be changed to any register we want on emitting */
                if (is_unknown_reg(in_reg))
                        continue;
-               class = arch_register_get_class(in_reg);
-               assert(class == arch_register_get_class(out_reg));
+               cls = arch_register_get_class(in_reg);
+               assert(cls == arch_register_get_class(out_reg));
 
                /* check if any other input operands uses the out register */
                arity = get_irn_arity(node);
                uses_out_reg     = NULL;
                uses_out_reg_pos = -1;
-               for(i2 = 0; i2 < arity; ++i2) {
+               for (i2 = 0; i2 < arity; ++i2) {
                        ir_node               *in     = get_irn_n(node, i2);
                        const arch_register_t *in_reg;
 
-                       if(!mode_is_data(get_irn_mode(in)))
+                       if (!mode_is_data(get_irn_mode(in)))
                                continue;
 
                        in_reg = arch_get_irn_register(arch_env, in);
 
-                       if(in_reg != out_reg)
+                       if (in_reg != out_reg)
                                continue;
 
-                       if(uses_out_reg != NULL && in != uses_out_reg) {
+                       if (uses_out_reg != NULL && in != uses_out_reg) {
                                panic("invalid register allocation");
                        }
                        uses_out_reg = in;
-                       if(uses_out_reg_pos >= 0)
+                       if (uses_out_reg_pos >= 0)
                                uses_out_reg_pos = -1; /* multiple inputs... */
                        else
                                uses_out_reg_pos = i2;
@@ -309,8 +326,8 @@ static void assure_should_be_same_requirements(ia32_code_gen_t *cg,
                /* no-one else is using the out reg, we can simply copy it
                 * (the register can't be live since the operation will override it
                 *  anyway) */
-               if(uses_out_reg == NULL) {
-                       ir_node *copy = be_new_Copy(class, irg, block, in_node);
+               if (uses_out_reg == NULL) {
+                       ir_node *copy = be_new_Copy(cls, irg, block, in_node);
                        DBG_OPT_2ADDRCPY(copy);
 
                        /* destination is the out register */
@@ -322,16 +339,18 @@ static void assure_should_be_same_requirements(ia32_code_gen_t *cg,
                        /* set copy as in */
                        set_irn_n(node, same_pos, copy);
 
-                       DBG((dbg, LEVEL_1, "created copy %+F for should be same argument "
-                            "at input %d of %+F\n", copy, same_pos, node));
+                       DBG((dbg, LEVEL_1,
+                               "created copy %+F for should be same argument at input %d of %+F\n",
+                               copy, same_pos, node));
                        continue;
                }
 
                /* for commutative nodes we can simply swap the left/right */
-               if(is_ia32_commutative(node) && uses_out_reg_pos == n_ia32_binary_right) {
+               if (uses_out_reg_pos == n_ia32_binary_right && is_ia32_commutative(node)) {
                        ia32_swap_left_right(node);
-                       DBG((dbg, LEVEL_1, "swapped left/right input of %+F to resolve "
-                            "should be same constraint\n", node));
+                       DBG((dbg, LEVEL_1,
+                               "swapped left/right input of %+F to resolve should be same constraint\n",
+                               node));
                        continue;
                }
 
@@ -343,7 +362,7 @@ static void assure_should_be_same_requirements(ia32_code_gen_t *cg,
                 * after! the operation as we will override the register. */
                in[0] = in_node;
                in[1] = uses_out_reg;
-               perm  = be_new_Perm(class, irg, block, 2, in);
+               perm  = be_new_Perm(cls, irg, block, 2, in);
 
                perm_proj0 = new_r_Proj(irg, block, perm, get_irn_mode(in[0]), 0);
                perm_proj1 = new_r_Proj(irg, block, perm, get_irn_mode(in[1]), 1);
@@ -353,17 +372,17 @@ static void assure_should_be_same_requirements(ia32_code_gen_t *cg,
 
                sched_add_before(node, perm);
 
-               DBG((dbg, LEVEL_1, "created perm %+F for should be same argument "
-                    "at input %d of %+F (need permutate with %+F)\n", perm, same_pos,
-                    node, uses_out_reg));
+               DBG((dbg, LEVEL_1,
+                       "created perm %+F for should be same argument at input %d of %+F (need permutate with %+F)\n",
+                       perm, same_pos, node, uses_out_reg));
 
                /* use the perm results */
-               for(i2 = 0; i2 < arity; ++i2) {
+               for (i2 = 0; i2 < arity; ++i2) {
                        ir_node *in = get_irn_n(node, i2);
 
-                       if(in == in_node) {
+                       if (in == in_node) {
                                set_irn_n(node, i2, perm_proj0);
-                       } else if(in == uses_out_reg) {
+                       } else if (in == uses_out_reg) {
                                set_irn_n(node, i2, perm_proj1);
                        }
                }
@@ -378,7 +397,8 @@ static void assure_should_be_same_requirements(ia32_code_gen_t *cg,
  * register -> base or index is broken then.
  * Solution: Turn back this address mode into explicit Load + Operation.
  */
-static void fix_am_source(ir_node *irn, void *env) {
+static void fix_am_source(ir_node *irn, void *env)
+{
        ia32_code_gen_t            *cg = env;
        const arch_env_t           *arch_env = cg->arch_env;
        ir_node                    *base;
@@ -393,11 +413,11 @@ static void fix_am_source(ir_node *irn, void *env) {
        if (! is_ia32_irn(irn) || get_ia32_op_type(irn) != ia32_AddrModeS)
                return;
        /* only need to fix binary operations */
-       if (get_ia32_am_arity(irn) != ia32_am_binary)
+       if (get_ia32_am_support(irn) != ia32_am_binary)
                return;
 
-       base  = get_irn_n(irn, 0);
-       index = get_irn_n(irn, 1);
+       base  = get_irn_n(irn, n_ia32_base);
+       index = get_irn_n(irn, n_ia32_index);
 
        reg_base  = arch_get_irn_register(arch_env, base);
        reg_index = arch_get_irn_register(arch_env, index);
@@ -415,18 +435,15 @@ static void fix_am_source(ir_node *irn, void *env) {
                        ir_node               *same_node = get_irn_n(irn, same_pos);
                        const arch_register_t *same_reg
                                = arch_get_irn_register(arch_env, same_node);
-                       const arch_register_class_t *same_cls;
                        ir_graph              *irg   = cg->irg;
                        dbg_info              *dbgi  = get_irn_dbg_info(irn);
                        ir_node               *block = get_nodes_block(irn);
-                       ir_mode               *proj_mode;
                        ir_node               *load;
                        ir_node               *load_res;
                        ir_node               *mem;
-                       int                    pnres;
 
                        /* should_be same constraint is fullfilled, nothing to do */
-                       if(out_reg == same_reg)
+                       if (out_reg == same_reg)
                                continue;
 
                        /* we only need to do something if the out reg is the same as base
@@ -435,46 +452,41 @@ static void fix_am_source(ir_node *irn, void *env) {
                                continue;
 
                        /* turn back address mode */
-                       same_cls = arch_register_get_class(same_reg);
-                       mem = get_irn_n(irn, n_ia32_mem);
+                       mem  = get_irn_n(irn, n_ia32_mem);
                        assert(get_irn_mode(mem) == mode_M);
-                       if (same_cls == &ia32_reg_classes[CLASS_ia32_gp]) {
-                               load      = new_rd_ia32_Load(dbgi, irg, block, base, index, mem);
-                               pnres     = pn_ia32_Load_res;
-                               proj_mode = mode_Iu;
-                       } else if (same_cls == &ia32_reg_classes[CLASS_ia32_xmm]) {
-                               load      = new_rd_ia32_xLoad(dbgi, irg, block, base, index, mem,
-                                                             get_ia32_ls_mode(irn));
-                               pnres     = pn_ia32_xLoad_res;
-                               proj_mode = mode_E;
-                       } else {
-                               panic("cannot turn back address mode for this register class");
-                       }
+                       load = new_rd_ia32_Load(dbgi, irg, block, base, index, mem);
 
                        /* copy address mode information to load */
                        set_ia32_op_type(load, ia32_AddrModeS);
                        ia32_copy_am_attrs(load, irn);
+                       if (is_ia32_is_reload(irn))
+                               set_ia32_is_reload(load);
 
                        /* insert the load into schedule */
                        sched_add_before(irn, load);
 
                        DBG((dbg, LEVEL_3, "irg %+F: build back AM source for node %+F, inserted load %+F\n", cg->irg, irn, load));
 
-                       load_res = new_r_Proj(cg->irg, block, load, proj_mode, pnres);
+                       load_res = new_r_Proj(cg->irg, block, load, mode_Iu, pn_ia32_Load_res);
                        arch_set_irn_register(cg->arch_env, load_res, out_reg);
 
                        /* set the new input operand */
-                       set_irn_n(irn, n_ia32_binary_right, load_res);
-                       if(get_irn_mode(irn) == mode_T) {
+                       if (is_ia32_Immediate(get_irn_n(irn, n_ia32_binary_right)))
+                               set_irn_n(irn, n_ia32_binary_left, load_res);
+                       else
+                               set_irn_n(irn, n_ia32_binary_right, load_res);
+                       if (get_irn_mode(irn) == mode_T) {
                                const ir_edge_t *edge, *next;
                                foreach_out_edge_safe(irn, edge, next) {
                                        ir_node *node = get_edge_src_irn(edge);
                                        int      pn   = get_Proj_proj(node);
-                                       if(pn == 0) {
+                                       if (pn == pn_ia32_res) {
                                                exchange(node, irn);
-                                       } else {
-                                               assert(pn == 1);
+                                       } else if (pn == pn_ia32_mem) {
                                                set_Proj_pred(node, load);
+                                               set_Proj_proj(node, pn_ia32_Load_M);
+                                       } else {
+                                               panic("Unexpected Proj");
                                        }
                                }
                                set_irn_mode(irn, mode_Iu);
@@ -492,7 +504,8 @@ static void fix_am_source(ir_node *irn, void *env) {
 /**
  * Block walker: finishes a block
  */
-static void ia32_finish_irg_walker(ir_node *block, void *env) {
+static void ia32_finish_irg_walker(ir_node *block, void *env)
+{
        ia32_code_gen_t *cg = env;
        ir_node *irn, *next;
 
@@ -516,14 +529,20 @@ static void ia32_finish_irg_walker(ir_node *block, void *env) {
        /* second: insert copies and finish irg */
        for (irn = sched_first(block); ! sched_is_end(irn); irn = next) {
                next = sched_next(irn);
-               assure_should_be_same_requirements(cg, irn);
+               if (is_ia32_irn(irn)) {
+                       /* some nodes are just a bit less efficient, but need no fixing if the
+                        * should be same requirement is not fulfilled */
+                       if (need_constraint_copy(irn))
+                               assure_should_be_same_requirements(cg, irn);
+               }
        }
 }
 
 /**
  * Block walker: pushes all blocks on a wait queue
  */
-static void ia32_push_on_queue_walker(ir_node *block, void *env) {
+static void ia32_push_on_queue_walker(ir_node *block, void *env)
+{
        waitq *wq = env;
        waitq_put(wq, block);
 }
@@ -532,7 +551,8 @@ static void ia32_push_on_queue_walker(ir_node *block, void *env) {
 /**
  * Add Copy nodes for not fulfilled should_be_equal constraints
  */
-void ia32_finish_irg(ir_graph *irg, ia32_code_gen_t *cg) {
+void ia32_finish_irg(ir_graph *irg, ia32_code_gen_t *cg)
+{
        waitq *wq = new_waitq();
 
        /* Push the blocks on the waitq because ia32_finish_irg_walker starts more walks ... */