* @date 05.05.2006
* @version $Id$
*/
-#ifdef HAVE_CONFIG_H
#include "config.h"
-#endif
#include <limits.h>
typedef struct be_verify_register_pressure_env_t_ {
ir_graph *irg; /**< the irg to verify */
be_lv_t *lv; /**< Liveness information. */
- const arch_env_t *arch_env; /**< an architecture environment */
const arch_register_class_t *cls; /**< the register class to check for */
int registers_available; /**< number of available registers */
int problem_found; /**< flag indicating if a problem was found */
/* collect register pressure info, start with end of a block */
// ir_fprintf(stderr, "liveness check %+F\n", block);
ir_nodeset_init(&live_nodes);
- be_liveness_end_of_block(env->lv, env->arch_env, env->cls, block,
+ be_liveness_end_of_block(env->lv, env->cls, block,
&live_nodes);
// print_living_values(stderr, &live_nodes);
break;
// print_living_values(stderr, &live_nodes);
- be_liveness_transfer(env->arch_env, env->cls, irn, &live_nodes);
+ be_liveness_transfer(env->cls, irn, &live_nodes);
pressure = ir_nodeset_size(&live_nodes);
env.lv = be_liveness(birg);
env.irg = irg;
- env.arch_env = birg->main_env->arch_env;
env.cls = cls;
env.registers_available = env.cls->n_regs - be_put_ignore_regs(birg, env.cls, NULL);
env.problem_found = 0;
int problem_found; /**< flags indicating if there was a problem */
bitset_t *scheduled; /**< bitset of scheduled nodes */
ir_graph *irg; /**< the irg to check */
- const arch_env_t *arch_env; /**< the arch_env */
} be_verify_schedule_env_t;
/**
static void verify_schedule_walker(ir_node *block, void *data) {
be_verify_schedule_env_t *env = (be_verify_schedule_env_t*) data;
ir_node *node;
- int non_phi_found = 0;
+ ir_node *non_phi_found = NULL;
int cfchange_found = 0;
/* TODO ask arch about delay branches */
int delay_branches = 0;
/* Check that phis come before any other node */
if (is_Phi(node)) {
- if (non_phi_found) {
- ir_fprintf(stderr, "Verify Warning: Phi node %+F scheduled after non-Phi nodes in block %+F (%s)\n",
- node, block, get_irg_dump_name(env->irg));
+ if (non_phi_found != NULL) {
+ ir_fprintf(stderr, "Verify Warning: Phi node %+F scheduled after non-Phi nodes (for example %+F) in block %+F (%s)\n",
+ node, non_phi_found, block, get_irg_dump_name(env->irg));
env->problem_found = 1;
}
} else {
- non_phi_found = 1;
+ non_phi_found = node;
}
/* Check for control flow changing nodes */
}
}
-static int should_be_scheduled(be_verify_schedule_env_t *env, ir_node *node) {
+static int should_be_scheduled(ir_node *node)
+{
if(is_Block(node))
return -1;
+ if(is_Proj(node))
+ return 0;
+
if(get_irn_mode(node) == mode_M) {
- if(is_Proj(node))
- return 0;
if(is_Phi(node) || is_Sync(node) || is_Pin(node))
return 0;
}
-#ifdef SCHEDULE_PROJS
- if(is_Proj(node)) {
- if(get_irn_mode(node) == mode_X)
- return 0;
- return should_be_scheduled(env, get_Proj_pred(node));
- }
-#else
- if(is_Proj(node))
- return 0;
-#endif
if(be_is_Keep(node) && get_irn_opcode(get_nodes_block(node)) == iro_Bad)
return 0;
break;
}
- if(arch_irn_get_flags(env->arch_env, node) & arch_irn_flags_ignore)
+ if (arch_irn_get_flags(node) & arch_irn_flags_ignore)
return -1;
return 1;
int should_be;
int scheduled;
- should_be = should_be_scheduled(env, node);
+ should_be = should_be_scheduled(node);
if(should_be == -1)
return;
env.problem_found = 0;
env.irg = be_get_birg_irg(birg);
env.scheduled = bitset_alloca(get_irg_last_idx(env.irg));
- env.arch_env = birg->main_env->arch_env;
irg_block_walk_graph(env.irg, verify_schedule_walker, NULL, &env);
/* check if all nodes are scheduled */
} spill_t;
typedef struct {
- const arch_env_t *arch_env;
- ir_graph *irg;
- set *spills;
- ir_node **reloads;
- int problem_found;
+ ir_graph *irg;
+ set *spills;
+ ir_node **reloads;
+ int problem_found;
} be_verify_spillslots_env_t;
static int cmp_spill(const void* d1, const void* d2, size_t size) {
static
void collect_spill(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent) {
- ir_entity *spillent = arch_get_frame_entity(env->arch_env, node);
+ ir_entity *spillent = arch_get_frame_entity(node);
be_check_entity(env, node, spillent);
get_spill(env, node, ent);
*/
static void collect_spills_walker(ir_node *node, void *data) {
be_verify_spillslots_env_t *env = data;
- const arch_env_t *arch_env = env->arch_env;
/* @@@ ia32_classify returns classification of Proj_pred :-/ */
if(is_Proj(node))
return;
- if(arch_irn_class_is(arch_env, node, reload)) {
+ if (arch_irn_class_is(node, reload)) {
ir_node *spill = get_memory_edge(node);
ir_entity *ent;
env->problem_found = 1;
return;
}
- ent = arch_get_frame_entity(env->arch_env, node);
+ ent = arch_get_frame_entity(node);
be_check_entity(env, node, ent);
collect(env, spill, node, ent);
if(be_is_Spill(node) || (is_Proj(node) && be_is_MemPerm(get_Proj_pred(node)))) {
spill_t *spill = find_spill(env, node);
if(be_is_Spill(node)) {
- ir_entity *ent = arch_get_frame_entity(env->arch_env, node);
+ ir_entity *ent = arch_get_frame_entity(node);
be_check_entity(env, node, ent);
}
}
}
-int be_verify_spillslots(const arch_env_t *arch_env, ir_graph *irg)
+int be_verify_spillslots(ir_graph *irg)
{
be_verify_spillslots_env_t env;
- env.arch_env = arch_env;
env.irg = irg;
env.spills = new_set(cmp_spill, 10);
env.reloads = NEW_ARR_F(ir_node*, 0);
/*--------------------------------------------------------------------------- */
+static const arch_env_t *arch_env;
+static ir_graph *irg;
+static be_lv_t *lv;
+static int problem_found;
+static const arch_register_class_t *regclass;
+static ir_node **registers;
-
-typedef struct _be_verify_register_allocation_env_t {
- const arch_env_t *arch_env;
- ir_graph *irg;
- be_lv_t *lv;
- int problem_found;
-} be_verify_register_allocation_env_t;
-
-static void check_register_constraints(ir_node *node,
- be_verify_register_allocation_env_t *env)
+static void check_register_constraints(ir_node *node)
{
- const arch_env_t *arch_env = env->arch_env;
const arch_register_t *reg;
int i, arity;
/* verify output register */
- if (arch_get_irn_reg_class(arch_env, node, -1) != NULL) {
- reg = arch_get_irn_register(arch_env, node);
+ if (arch_get_irn_reg_class_out(node) != NULL) {
+ reg = arch_get_irn_register(node);
if (reg == NULL) {
ir_fprintf(stderr, "Verify warning: Node %+F in block %+F(%s) should have a register assigned\n",
- node, get_nodes_block(node), get_irg_dump_name(env->irg));
- env->problem_found = 1;
- }
- else if (! arch_register_type_is(reg, joker) && !arch_reg_is_allocatable(arch_env, node, -1, reg)) {
+ node, get_nodes_block(node), get_irg_dump_name(irg));
+ problem_found = 1;
+ } else if (!arch_register_type_is(reg, joker) && !arch_reg_out_is_allocatable(node, reg)) {
ir_fprintf(stderr, "Verify warning: Register %s assigned as output of %+F not allowed (register constraint) in block %+F(%s)\n",
- reg->name, node, get_nodes_block(node), get_irg_dump_name(env->irg));
- env->problem_found = 1;
+ reg->name, node, get_nodes_block(node), get_irg_dump_name(irg));
+ problem_found = 1;
}
}
if (is_Bad(pred)) {
ir_fprintf(stderr, "Verify warning: %+F in block %+F(%s) has Bad as input %d\n",
- node, get_nodes_block(node), get_irg_dump_name(env->irg), i);
- env->problem_found = 1;
+ node, get_nodes_block(node), get_irg_dump_name(irg), i);
+ problem_found = 1;
continue;
}
- if (arch_get_irn_reg_class(arch_env, node, i) == NULL)
+ if (arch_get_irn_reg_class(node, i) == NULL)
continue;
- reg = arch_get_irn_register(arch_env, pred);
+ reg = arch_get_irn_register(pred);
if (reg == NULL) {
ir_fprintf(stderr, "Verify warning: Node %+F in block %+F(%s) should have a register assigned (%+F input constraint)\n",
- pred, get_nodes_block(pred), get_irg_dump_name(env->irg), node);
- env->problem_found = 1;
+ pred, get_nodes_block(pred), get_irg_dump_name(irg), node);
+ problem_found = 1;
continue;
- }
- else if (! arch_register_type_is(reg, joker) && ! arch_reg_is_allocatable(arch_env, node, i, reg)) {
+ } else if (!arch_register_type_is(reg, joker) && ! arch_reg_is_allocatable(node, i, reg)) {
ir_fprintf(stderr, "Verify warning: Register %s as input %d of %+F not allowed (register constraint) in block %+F(%s)\n",
- reg->name, i, node, get_nodes_block(node), get_irg_dump_name(env->irg));
- env->problem_found = 1;
+ reg->name, i, node, get_nodes_block(node), get_irg_dump_name(irg));
+ problem_found = 1;
}
}
-}
-static void check_register_allocation(be_verify_register_allocation_env_t *env,
- const arch_register_class_t *regclass,
- ir_nodeset_t *nodes)
-{
- const arch_env_t *arch_env = env->arch_env;
- const arch_register_t *reg = NULL;
- int fail = 0;
- bitset_t *registers = bitset_alloca(arch_register_class_n_regs(regclass));
- ir_node *node;
- ir_nodeset_iterator_t iter;
-
- foreach_ir_nodeset(nodes, node, iter) {
- if (arch_get_irn_reg_class(arch_env, node, -1) != regclass)
- continue;
+ /* phis should be NOPs at this point, which means all input regs
+ * must be the same as the output reg */
+ if (is_Phi(node)) {
+ int i, arity;
- reg = arch_get_irn_register(arch_env, node);
+ reg = arch_get_irn_register(node);
- /* this problem is already reported in 'check_register_constraints' */
- if (! reg)
- continue;
+ arity = get_irn_arity(node);
+ for (i = 0; i < arity; ++i) {
+ ir_node *pred = get_Phi_pred(node, i);
+ const arch_register_t *pred_reg = arch_get_irn_register(pred);
- if (bitset_is_set(registers, reg->index)) {
- fail = 1;
- break;
+ if (reg != pred_reg && !arch_register_type_is(pred_reg, joker)) {
+ ir_fprintf(stderr, "Verify warning: Input %d of %+F in block %+F(%s) uses register %s instead of %s\n",
+ i, node, get_nodes_block(node), get_irg_dump_name(irg), pred_reg->name, reg->name);
+ problem_found = 1;
+ }
}
- bitset_set(registers, reg->index);
}
+}
- if (fail) {
- ir_fprintf(stderr, "Verify warning: Register %s assigned more than once in block %+F(%s)\n",
- reg->name, get_nodes_block(node), get_irg_dump_name(env->irg));
- env->problem_found = 1;
+static void value_used(ir_node *node) {
+ const arch_register_t *reg;
+ ir_node *reg_node;
- foreach_ir_nodeset(nodes, node, iter) {
- if (arch_get_irn_register(arch_env, node) == reg) {
- ir_fprintf(stderr, " at node %+F\n", node);
- }
- }
+ if (arch_get_irn_reg_class_out(node) != regclass)
+ return;
+
+ reg = arch_get_irn_register(node);
+ if (reg->type & arch_register_type_virtual)
+ return;
+
+ reg_node = registers[reg->index];
+ if (reg_node != NULL && reg_node != node) {
+ ir_fprintf(stderr, "Verify warning: Register %s assigned more than once in block %+F(%s) (nodes %+F %+F)\n",
+ reg->name, get_nodes_block(node), get_irg_dump_name(irg),
+ node, reg_node);
+ problem_found = 1;
+ }
+
+ registers[reg->index] = node;
+}
+
+static void value_def(ir_node *node)
+{
+ const arch_register_t *reg;
+ ir_node *reg_node;
+
+ if (arch_get_irn_reg_class_out(node) != regclass)
+ return;
+
+ reg = arch_get_irn_register(node);
+ if (reg->type & arch_register_type_virtual)
+ return;
+
+ reg_node = registers[reg->index];
+
+ if (reg_node != node) {
+ ir_fprintf(stderr, "Verify warning: Node %+F not registered as value for Register %s (but %+F) in block %+F(%s)\n",
+ node, reg->name, reg_node, get_nodes_block(node), get_irg_dump_name(irg));
+ problem_found = 1;
}
+ registers[reg->index] = NULL;
}
static void verify_block_register_allocation(ir_node *block, void *data) {
- be_verify_register_allocation_env_t *env = data;
- const arch_env_t *arch_env = env->arch_env;
int i, nregclasses;
+ (void) data;
nregclasses = arch_env_get_n_reg_class(arch_env);
for (i = 0; i < nregclasses; ++i) {
- const arch_register_class_t *regclass = arch_env_get_reg_class(arch_env, i);
- ir_node *node;
- ir_nodeset_t live_nodes;
+ ir_node *node;
+ int idx, i2, n_regs;
+
+ regclass = arch_env_get_reg_class(arch_env, i);
- ir_nodeset_init(&live_nodes);
+ assert(lv->nodes && "live sets must be computed");
- be_liveness_end_of_block(env->lv, env->arch_env, regclass, block,
- &live_nodes);
- check_register_allocation(env, regclass, &live_nodes);
+ n_regs = arch_register_class_n_regs(regclass);
+ registers = alloca(n_regs * sizeof(registers[0]));
+ memset(registers, 0, n_regs * sizeof(registers[0]));
+
+ be_lv_foreach(lv, block, be_lv_state_end, idx) {
+ ir_node *node = be_lv_get_irn(lv, block, idx);
+ value_used(node);
+ }
sched_foreach_reverse(block, node) {
+ int arity;
+
+ if (get_irn_mode(node) == mode_T) {
+ const ir_edge_t *edge;
+ foreach_out_edge(node, edge) {
+ ir_node *def = get_edge_src_irn(edge);
+ value_def(def);
+ }
+ } else {
+ value_def(node);
+ }
+
+ check_register_constraints(node);
if (is_Phi(node))
- break;
+ continue;
- be_liveness_transfer(env->arch_env, regclass, node, &live_nodes);
- check_register_allocation(env, regclass, &live_nodes);
- check_register_constraints(node, env);
+ arity = get_irn_arity(node);
+ for (i2 = 0; i2 < arity; ++i2) {
+ ir_node *use = get_irn_n(node, i2);
+ value_used(use);
+ }
}
- ir_nodeset_destroy(&live_nodes);
+ be_lv_foreach(lv, block, be_lv_state_in, idx) {
+ ir_node *node = be_lv_get_irn(lv, block, idx);
+ value_def(node);
+ }
+
+ /* set must be empty now */
+ for (i2 = 0; i2 < n_regs; ++i2) {
+ if (registers[i2] == NULL)
+ continue;
+
+ ir_fprintf(stderr, "Verify warning: Node %+F not live-in and no def found in block %+F(%s)\n",
+ registers[i2], block, get_irg_dump_name(irg));
+ problem_found = 1;
+ }
}
}
int be_verify_register_allocation(const be_irg_t *birg) {
- be_verify_register_allocation_env_t env;
+ arch_env = be_get_birg_arch_env(birg);
+ irg = be_get_birg_irg(birg);
+ lv = be_liveness(birg);
+ problem_found = 0;
- env.arch_env = be_get_birg_arch_env(birg);
- env.irg = be_get_birg_irg(birg);
- env.lv = be_liveness(birg);
- env.problem_found = 0;
-
- be_liveness_assure_sets(env.lv);
- irg_block_walk_graph(env.irg, verify_block_register_allocation, NULL, &env);
+ be_liveness_assure_sets(lv);
+ irg_block_walk_graph(irg, verify_block_register_allocation, NULL, NULL);
- be_liveness_free(env.lv);
+ be_liveness_free(lv);
- return !env.problem_found;
+ return !problem_found;
}
ir_graph *irg = env->irg;
const ir_edge_t* edge;
- if(irn_visited(node))
+ if (irn_visited_else_mark(node))
return;
- mark_irn_visited(node);
/* we find too many (uncritical) dead nodes in block out edges */
if(is_Block(node))
projects / libfirm / blobdiff