/*
- * Copyright (C) 1995-2010 University of Karlsruhe. All right reserved.
- *
* This file is part of libFirm.
- *
- * This file may be distributed and/or modified under the terms of the
- * GNU General Public License version 2 as published by the Free Software
- * Foundation and appearing in the file LICENSE.GPL included in the
- * packaging of this file.
- *
- * Licensees holding valid libFirm Professional Edition licenses may use
- * this file in accordance with the libFirm Commercial License.
- * Agreement provided with the Software.
- *
- * This file is provided AS IS with NO WARRANTY OF ANY KIND, INCLUDING THE
- * WARRANTY OF DESIGN, MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE.
+ * Copyright (C) 2012 University of Karlsruhe.
*/
/**
typedef struct be_verify_register_pressure_env_t_ {
ir_graph *irg; /**< the irg to verify */
- be_lv_t *lv; /**< Liveness information. */
+ be_lv_t *lv; /**< Liveness information. */
const arch_register_class_t *cls; /**< the register class to check for */
- int registers_available; /**< number of available registers */
- int problem_found; /**< flag indicating if a problem was found */
+ unsigned registers_available; /**< number of available registers */
+ bool problem_found; /**< flag indicating if a problem was found */
} be_verify_register_pressure_env_t;
/**
{
be_verify_register_pressure_env_t *env = (be_verify_register_pressure_env_t *)data;
ir_nodeset_t live_nodes;
- int pressure;
/* collect register pressure info, start with end of a block */
- // ir_fprintf(stderr, "liveness check %+F\n", block);
ir_nodeset_init(&live_nodes);
be_liveness_end_of_block(env->lv, env->cls, block,
&live_nodes);
- // print_living_values(stderr, &live_nodes);
- pressure = ir_nodeset_size(&live_nodes);
+ unsigned pressure = ir_nodeset_size(&live_nodes);
if (pressure > env->registers_available) {
ir_fprintf(stderr, "Verify Warning: Register pressure too high at end of block %+F(%s) (%d/%d):\n",
block, get_irg_name(env->irg), pressure, env->registers_available);
print_living_values(stderr, &live_nodes);
- env->problem_found = 1;
+ env->problem_found = true;
}
sched_foreach_reverse(block, irn) {
ir_fprintf(stderr, "Verify Warning: Register pressure too high before node %+F in %+F(%s) (%d/%d):\n",
irn, block, get_irg_name(env->irg), pressure, env->registers_available);
print_living_values(stderr, &live_nodes);
- env->problem_found = 1;
+ env->problem_found = true;
assert(0);
}
}
ir_nodeset_destroy(&live_nodes);
}
-/**
- * Start a walk over the irg and check the register pressure.
- */
-int be_verify_register_pressure(ir_graph *irg, const arch_register_class_t *cls)
+bool be_verify_register_pressure(ir_graph *irg, const arch_register_class_t *cls)
{
be_verify_register_pressure_env_t env;
env.irg = irg;
env.cls = cls;
env.registers_available = be_get_n_allocatable_regs(irg, cls);
- env.problem_found = 0;
+ env.problem_found = false;
be_liveness_compute_sets(env.lv);
irg_block_walk_graph(irg, verify_liveness_walker, NULL, &env);
/*--------------------------------------------------------------------------- */
typedef struct be_verify_schedule_env_t_ {
- int problem_found; /**< flags indicating a problem */
+ bool problem_found; /**< flags indicating a problem */
bitset_t *scheduled; /**< bitset of scheduled nodes */
ir_graph *irg; /**< the irg to check */
} be_verify_schedule_env_t;
-/**
- * Simple schedule checker.
- */
static void verify_schedule_walker(ir_node *block, void *data)
{
be_verify_schedule_env_t *env = (be_verify_schedule_env_t*) data;
/* this node is scheduled */
if (bitset_is_set(env->scheduled, get_irn_idx(node))) {
ir_fprintf(stderr, "Verify warning: %+F appears to be schedule twice\n");
- env->problem_found = 1;
+ env->problem_found = true;
}
bitset_set(env->scheduled, get_irn_idx(node));
/* Check that scheduled nodes are in the correct block */
if (get_nodes_block(node) != block) {
ir_fprintf(stderr, "Verify warning: %+F is in block %+F but scheduled in %+F\n", node, get_nodes_block(node), block);
- env->problem_found = 1;
+ env->problem_found = true;
}
/* Check that timesteps are increasing */
if (timestep <= last_timestep) {
ir_fprintf(stderr, "Verify warning: Schedule timestep did not increase at node %+F\n",
node);
- env->problem_found = 1;
+ env->problem_found = true;
}
last_timestep = timestep;
+ if (arch_get_irn_flags(node) & arch_irn_flags_not_scheduled) {
+ ir_fprintf(stderr, "Verify warning: flags_not_scheduled node %+F scheduled anyway\n", node);
+ env->problem_found = true;
+ }
+
/* Check that phis come before any other node */
if (is_Phi(node)) {
if (non_phi_found != NULL) {
ir_fprintf(stderr, "Verify Warning: Phi node %+F scheduled after non-Phi nodes (for example %+F) in block %+F (%s)\n",
node, non_phi_found, block, get_irg_name(env->irg));
- env->problem_found = 1;
+ env->problem_found = true;
}
} else {
non_phi_found = node;
if (cfchange_found != NULL) {
ir_fprintf(stderr, "Verify Warning: Additional control flow changing node %+F scheduled after %+F in block %+F (%s)\n",
node, block, cfchange_found, get_irg_name(env->irg));
- env->problem_found = 1;
+ env->problem_found = true;
} else {
cfchange_found = node;
}
} else if (cfchange_found != NULL) {
- /* proj and keepany aren't real instructions... */
- if (!is_Proj(node) && !be_is_Keep(node)) {
+ /* keepany isn't a real instruction. */
+ if (!be_is_Keep(node)) {
ir_fprintf(stderr, "Verify Warning: Node %+F scheduled after control flow changing node in block %+F (%s)\n",
node, block, get_irg_name(env->irg));
- env->problem_found = 1;
+ env->problem_found = true;
}
}
if (sched_get_time_step(arg) >= nodetime) {
ir_fprintf(stderr, "Verify Warning: Value %+F used by %+F before it was defined in block %+F (%s)\n",
arg, node, block, get_irg_name(env->irg));
- env->problem_found = 1;
+ env->problem_found = true;
}
}
}
if (get_irn_n_edges(node) == 0) {
ir_fprintf(stderr, "Verify warning: Node %+F is dead but scheduled in block %+F (%s)\n",
node, block, get_irg_name(env->irg));
- env->problem_found = 1;
+ env->problem_found = true;
}
if (be_is_Keep(node) || be_is_CopyKeep(node)) {
if (!found) {
ir_fprintf(stderr, "%+F not scheduled after its pred node in block %+F (%s)\n",
node, block, get_irg_name(env->irg));
- env->problem_found = 1;
+ env->problem_found = true;
}
}
}
if (should_be != scheduled) {
ir_fprintf(stderr, "Verify warning: Node %+F in block %+F(%s) should%s be scheduled\n",
node, get_nodes_block(node), get_irg_name(env->irg), should_be ? "" : " not");
- env->problem_found = 1;
+ env->problem_found = true;
}
}
-/**
- * Start a walk over the irg and check schedule.
- */
-int be_verify_schedule(ir_graph *irg)
+bool be_verify_schedule(ir_graph *irg)
{
be_verify_schedule_env_t env;
- env.problem_found = 0;
+ env.problem_found = false;
env.irg = irg;
env.scheduled = bitset_alloca(get_irg_last_idx(env.irg));
ir_graph *irg;
set *spills;
ir_node **reloads;
- int problem_found;
+ bool problem_found;
} be_verify_spillslots_env_t;
static int cmp_spill(const void* d1, const void* d2, size_t size)
if (spillent != ent) {
ir_fprintf(stderr, "Verify warning: Spill %+F has different entity than reload %+F in block %+F(%s)\n",
node, reload, get_nodes_block(node), get_irg_name(env->irg));
- env->problem_found = 1;
+ env->problem_found = true;
}
}
static void collect_memperm(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent)
{
- assert(is_Proj(node));
-
ir_node *memperm = get_Proj_pred(node);
int out = get_Proj_proj(node);
if (spillent != ent) {
ir_fprintf(stderr, "Verify warning: MemPerm %+F has different entity than reload %+F in block %+F(%s)\n",
node, reload, get_nodes_block(node), get_irg_name(env->irg));
- env->problem_found = 1;
+ env->problem_found = true;
}
int hash = hash_ptr(node);
}
spill.ent = spillent;
- res = set_insert(spill_t, env->spills, &spill, sizeof(spill), hash);
+ (void)set_insert(spill_t, env->spills, &spill, sizeof(spill), hash);
int arity = be_get_MemPerm_entity_arity(memperm);
for (int i = 0; i < arity; ++i) {
}
spill.ent = ent;
- res = set_insert(spill_t, env->spills, &spill, sizeof(spill), hash);
+ (void)set_insert(spill_t, env->spills, &spill, sizeof(spill), hash);
/* is 1 of the arguments a spill? */
int arity = get_irn_arity(node);
collect_memperm(env, node, reload, ent);
} else if (is_Phi(node) && get_irn_mode(node) == mode_M) {
collect_memphi(env, node, reload, ent);
- } else {
- /* Disabled for now, spills might get transformed by the backend */
-#if 0
- ir_fprintf(stderr, "Verify warning: No spill, memperm or memphi attached to node %+F found from node %+F in block %+F(%s)\n",
- node, reload, get_nodes_block(node), get_irg_name(env->irg));
- env->problem_found = 1;
-#endif
}
}
if (spill == NULL) {
ir_fprintf(stderr, "Verify warning: No spill attached to reload %+F in block %+F(%s)\n",
node, get_nodes_block(node), get_irg_name(env->irg));
- env->problem_found = 1;
+ env->problem_found = true;
return;
}
ir_entity *ent = arch_get_frame_entity(node);
foreach_set(env->spills, spill_t, spill) {
spills[s++] = spill;
}
+ assert(s == spillcount);
for (int i = 0; i < spillcount; ++i) {
spill_t *sp1 = spills[i];
ir_fprintf(stderr, "Verify warning: Spillslots for %+F in block %+F(%s) and %+F in block %+F(%s) interfere\n",
sp1->spill, get_nodes_block(sp1->spill), get_irg_name(env->irg),
sp2->spill, get_nodes_block(sp2->spill), get_irg_name(env->irg));
- env->problem_found = 1;
+ env->problem_found = true;
my_values_interfere(sp1->spill, sp2->spill);
}
}
}
}
-int be_verify_spillslots(ir_graph *irg)
+bool be_verify_spillslots(ir_graph *irg)
{
be_verify_spillslots_env_t env;
- env.irg = irg;
- env.spills = new_set(cmp_spill, 10);
- env.reloads = NEW_ARR_F(ir_node*, 0);
- env.problem_found = 0;
+ env.irg = irg;
+ env.spills = new_set(cmp_spill, 10);
+ env.reloads = NEW_ARR_F(ir_node*, 0);
+ env.problem_found = false;
irg_walk_graph(irg, collect_spills_walker, NULL, &env);
irg_walk_graph(irg, check_lonely_spills, NULL, &env);
ir_node *pred = get_Phi_pred(node, i);
const arch_register_t *pred_reg = arch_get_irn_register(pred);
- if (reg != pred_reg && !(pred_reg->type & arch_register_type_joker)) {
+ if (reg != pred_reg && !(pred_reg->type & arch_register_type_virtual)) {
const char *pred_name = pred_reg != NULL ? pred_reg->name : "(null)";
const char *reg_name = reg != NULL ? reg->name : "(null)";
ir_fprintf(stderr, "Verify warning: Input %d of %+F in block %+F(%s) uses register %s instead of %s\n",
i, node, get_nodes_block(node),
get_irg_name(irg), pred_name, reg_name);
- problem_found = 1;
+ problem_found = true;
}
}
}
for (unsigned i = 0; i < req->width; ++i) {
const ir_node *reg_node = registers[idx+i];
if (reg_node != NULL && reg_node != node) {
- const arch_register_t *realreg = &arch_env->registers[idx+i];
ir_fprintf(stderr, "Verify warning: Register %s assigned more than once in block %+F(%s) (nodes %+F %+F)\n",
- realreg->name, block, get_irg_name(irg),
+ reg->name, block, get_irg_name(irg),
node, reg_node);
problem_found = true;
}
return;
if (reg_node != node) {
- const arch_register_t *realreg = &arch_env->registers[idx+i];
ir_fprintf(stderr, "Verify warning: Node %+F not registered as value for Register %s (but %+F) in block %+F(%s)\n",
- node, realreg->name, reg_node, get_nodes_block(node),
+ node, reg->name, reg_node, get_nodes_block(node),
get_irg_name(irg));
problem_found = true;
}
}
sched_foreach_reverse(block, node) {
-
- if (get_irn_mode(node) == mode_T) {
- foreach_out_edge(node, edge) {
- ir_node *def = get_edge_src_irn(edge);
- value_def(def);
- check_output_constraints(def);
- }
- } else {
- value_def(node);
- check_output_constraints(node);
- }
+ be_foreach_value(node, value,
+ value_def(value);
+ check_output_constraints(value);
+ );
check_input_constraints(node);
/*--------------------------------------------------------------------------- */
-/**
- * Walker: checks that every predecessors of a node dominates the node.
- */
-static void dom_check(ir_node *irn, void *data)
-{
- bool *problem_found = (bool*)data;
-
- if (!is_Block(irn) && irn != get_irg_end(get_irn_irg(irn))) {
- ir_node *bl = get_nodes_block(irn);
-
- int n = get_irn_arity(irn);
- for (int i = 0; i < n; ++i) {
- ir_node *op = get_irn_n(irn, i);
- ir_node *def_bl = get_nodes_block(op);
- ir_node *use_bl = bl;
-
- if (is_Phi(irn))
- use_bl = get_Block_cfgpred_block(bl, i);
-
- if (get_irn_opcode(use_bl) != iro_Bad
- && get_irn_opcode(def_bl) != iro_Bad
- && !block_dominates(def_bl, use_bl)) {
- ir_fprintf(stderr, "Verify warning: %+F in %+F must dominate %+F for user %+F (%s)\n", op, def_bl, use_bl, irn, get_irg_name(get_irn_irg(op)));
- *problem_found = true;
- }
- }
- }
-}
-
-/* Check, if the SSA dominance property is fulfilled. */
-bool be_check_dominance(ir_graph *irg)
-{
- bool problem_found = false;
-
- assure_doms(irg);
- irg_walk_graph(irg, dom_check, NULL, &problem_found);
-
- return !problem_found;
-}
-
-/*--------------------------------------------------------------------------- */
-
typedef struct lv_walker_t {
be_lv_t *lv;
void *data;
static void lv_check_walker(ir_node *bl, void *data)
{
lv_walker_t *w = (lv_walker_t*)data;
- be_lv_t *lv = w->lv;
be_lv_t *fresh = (be_lv_t*)w->data;
be_lv_info_t *curr = ir_nodehashmap_get(be_lv_info_t, &fresh->map, bl);
if (!fr && curr && curr[0].head.n_members > 0) {
ir_fprintf(stderr, "%+F liveness should be empty but current liveness contains:\n", bl);
for (unsigned i = 0; i < curr[0].head.n_members; ++i) {
- ir_fprintf(stderr, "\t%+F\n", get_idx_irn(lv->irg, curr[1 + i].node.idx));
+ ir_fprintf(stderr, "\t%+F\n", curr[1 + i].node.node);
}
- }
-
- else if (curr) {
+ } else if (curr) {
unsigned n_curr = curr[0].head.n_members;
unsigned n_fresh = fr[0].head.n_members;
ir_fprintf(stderr, "current:\n");
for (unsigned i = 0; i < n_curr; ++i) {
be_lv_info_node_t *n = &curr[1 + i].node;
- ir_fprintf(stderr, "%+F %u %+F %s\n", bl, i, get_idx_irn(lv->irg, n->idx), lv_flags_to_str(n->flags));
+ ir_fprintf(stderr, "%+F %u %+F %s\n", bl, i, n->node, lv_flags_to_str(n->flags));
}
ir_fprintf(stderr, "correct:\n");
for (unsigned i = 0; i < n_fresh; ++i) {
be_lv_info_node_t *n = &fr[1 + i].node;
- ir_fprintf(stderr, "%+F %u %+F %s\n", bl, i, get_idx_irn(lv->irg, n->idx), lv_flags_to_str(n->flags));
+ ir_fprintf(stderr, "%+F %u %+F %s\n", bl, i, n->node, lv_flags_to_str(n->flags));
}
}
}
projects / libfirm / blobdiff