fix warning, always use -m32 on mac assembler
[libfirm] / ir / be / beverify.c
index d2f50e8..68a4c66 100644 (file)
@@ -24,9 +24,7 @@
  * @date        05.05.2006
  * @version     $Id$
  */
-#ifdef HAVE_CONFIG_H
 #include "config.h"
-#endif
 
 #include <limits.h>
 
@@ -43,9 +41,9 @@
 
 #include "beverify.h"
 #include "belive.h"
-#include "besched_t.h"
-#include "benode_t.h"
-#include "beirg_t.h"
+#include "besched.h"
+#include "benode.h"
+#include "beirg.h"
 #include "beintlive_t.h"
 
 static int my_values_interfere(const ir_node *a, const ir_node *b);
@@ -61,7 +59,8 @@ typedef struct be_verify_register_pressure_env_t_ {
 /**
  * Print all nodes of a pset into a file.
  */
-static void print_living_values(FILE *F, const ir_nodeset_t *live_nodes) {
+static void print_living_values(FILE *F, const ir_nodeset_t *live_nodes)
+{
        ir_nodeset_iterator_t iter;
        ir_node *node;
 
@@ -75,7 +74,8 @@ static void print_living_values(FILE *F, const ir_nodeset_t *live_nodes) {
 /**
  * Check if number of live nodes never exceeds the number of available registers.
  */
-static void verify_liveness_walker(ir_node *block, void *data) {
+static void verify_liveness_walker(ir_node *block, void *data)
+{
        be_verify_register_pressure_env_t *env = (be_verify_register_pressure_env_t *)data;
        ir_nodeset_t live_nodes;
        ir_node *irn;
@@ -124,7 +124,7 @@ int be_verify_register_pressure(const be_irg_t *birg,
                                 ir_graph *irg) {
        be_verify_register_pressure_env_t env;
 
-       env.lv                  = be_liveness(birg);
+       env.lv                  = be_liveness(irg);
        env.irg                 = irg;
        env.cls                 = cls;
        env.registers_available = env.cls->n_regs - be_put_ignore_regs(birg, env.cls, NULL);
@@ -152,7 +152,8 @@ typedef struct be_verify_schedule_env_t_ {
 /**
  * Simple schedule checker.
  */
-static void verify_schedule_walker(ir_node *block, void *data) {
+static void verify_schedule_walker(ir_node *block, void *data)
+{
        be_verify_schedule_env_t *env = (be_verify_schedule_env_t*) data;
        ir_node *node;
        ir_node *non_phi_found = NULL;
@@ -253,13 +254,13 @@ static void verify_schedule_walker(ir_node *block, void *data) {
                        env->problem_found = 1;
                }
 
-               if(be_is_Keep(node)) {
+               if(be_is_Keep(node) || be_is_CopyKeep(node)) {
                        /* at least 1 of the keep arguments has to be it schedule
                         * predecessor */
                        int      arity   = get_irn_arity(node);
                        int      problem = 1;
                        ir_node *prev    = sched_prev(node);
-                       while(be_is_Keep(prev))
+                       while(be_is_Keep(prev) || be_is_CopyKeep(prev))
                                prev = sched_prev(prev);
 
                        for(i = 0; i < arity; ++i) {
@@ -286,36 +287,38 @@ static void verify_schedule_walker(ir_node *block, void *data) {
 
 static int should_be_scheduled(ir_node *node)
 {
-       if(is_Block(node))
-               return -1;
-
-       if(is_Proj(node))
-               return 0;
-
-       if(get_irn_mode(node) == mode_M) {
-               if(is_Phi(node) || is_Sync(node) || is_Pin(node))
-                       return 0;
-       }
-       if(be_is_Keep(node) && get_irn_opcode(get_nodes_block(node)) == iro_Bad)
-               return 0;
-
        switch(get_irn_opcode(node)) {
+       case iro_Bad:
+       case iro_Block:
        case iro_End:
        case iro_NoMem:
-       case iro_Bad:
+       case iro_Pin:
+       case iro_Proj:
+       case iro_Sync:
        case iro_Unknown:
                return 0;
+       case iro_Phi:
+               if (get_irn_mode(node) == mode_M)
+                       return 0;
+               break;
+       case iro_Start:
+       case iro_Jmp:
+       case beo_Return:
+               return 1;
        default:
                break;
        }
 
-       if (arch_irn_get_flags(node) & arch_irn_flags_ignore)
-               return -1;
+       if (get_irn_mode(node) != mode_T) {
+               if (arch_irn_is_ignore(node))
+                       return -1;
+       }
 
        return 1;
 }
 
-static void check_schedule(ir_node *node, void *data) {
+static void check_schedule(ir_node *node, void *data)
+{
        be_verify_schedule_env_t *env = data;
        int should_be;
        int scheduled;
@@ -369,7 +372,8 @@ typedef struct {
        int        problem_found;
 } be_verify_spillslots_env_t;
 
-static int cmp_spill(const void* d1, const void* d2, size_t size) {
+static int cmp_spill(const void* d1, const void* d2, size_t size)
+{
        const spill_t* s1 = d1;
        const spill_t* s2 = d2;
        (void) size;
@@ -377,14 +381,16 @@ static int cmp_spill(const void* d1, const void* d2, size_t size) {
        return s1->spill != s2->spill;
 }
 
-static spill_t *find_spill(be_verify_spillslots_env_t *env, ir_node *node) {
+static spill_t *find_spill(be_verify_spillslots_env_t *env, ir_node *node)
+{
        spill_t spill;
 
        spill.spill = node;
        return set_find(env->spills, &spill, sizeof(spill), HASH_PTR(node));
 }
 
-static spill_t *get_spill(be_verify_spillslots_env_t *env, ir_node *node, ir_entity *ent) {
+static spill_t *get_spill(be_verify_spillslots_env_t *env, ir_node *node, ir_entity *ent)
+{
        spill_t spill, *res;
        int hash = HASH_PTR(node);
 
@@ -399,7 +405,8 @@ static spill_t *get_spill(be_verify_spillslots_env_t *env, ir_node *node, ir_ent
        return res;
 }
 
-static ir_node *get_memory_edge(const ir_node *node) {
+static ir_node *get_memory_edge(const ir_node *node)
+{
        int i, arity;
        ir_node *result = NULL;
 
@@ -419,7 +426,8 @@ static
 void collect(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent);
 
 static
-void be_check_entity(be_verify_spillslots_env_t *env, ir_node *node, ir_entity *ent) {
+void be_check_entity(be_verify_spillslots_env_t *env, ir_node *node, ir_entity *ent)
+{
        if(ent == NULL) {
                ir_fprintf(stderr, "Verify warning: Node %+F in block %+F(%s) should have an entity assigned\n",
                           node, get_nodes_block(node), get_irg_dump_name(env->irg));
@@ -427,7 +435,8 @@ void be_check_entity(be_verify_spillslots_env_t *env, ir_node *node, ir_entity *
 }
 
 static
-void collect_spill(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent) {
+void collect_spill(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent)
+{
        ir_entity *spillent = arch_get_frame_entity(node);
        be_check_entity(env, node, spillent);
        get_spill(env, node, ent);
@@ -439,7 +448,8 @@ void collect_spill(be_verify_spillslots_env_t *env, ir_node *node, ir_node *relo
        }
 }
 
-static void collect_memperm(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent) {
+static void collect_memperm(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent)
+{
        int i, arity;
        spill_t spill, *res;
        int hash = HASH_PTR(node);
@@ -477,7 +487,8 @@ static void collect_memperm(be_verify_spillslots_env_t *env, ir_node *node, ir_n
        }
 }
 
-static void collect_memphi(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity *ent) {
+static void collect_memphi(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity *ent)
+{
        int i, arity;
        spill_t spill, *res;
        int hash = HASH_PTR(node);
@@ -500,7 +511,8 @@ static void collect_memphi(be_verify_spillslots_env_t *env, ir_node *node, ir_no
        }
 }
 
-static void collect(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent) {
+static void collect(be_verify_spillslots_env_t *env, ir_node *node, ir_node *reload, ir_entity* ent)
+{
        if(be_is_Spill(node)) {
                collect_spill(env, node, reload, ent);
        } else if(is_Proj(node)) {
@@ -521,7 +533,8 @@ static void collect(be_verify_spillslots_env_t *env, ir_node *node, ir_node *rel
  * This walker function searches for reloads and collects all the spills
  * and memphis attached to them.
  */
-static void collect_spills_walker(ir_node *node, void *data) {
+static void collect_spills_walker(ir_node *node, void *data)
+{
        be_verify_spillslots_env_t *env = data;
 
        /* @@@ ia32_classify returns classification of Proj_pred :-/ */
@@ -546,11 +559,12 @@ static void collect_spills_walker(ir_node *node, void *data) {
        }
 }
 
-static void check_spillslot_interference(be_verify_spillslots_env_t *env) {
-       int spillcount = set_count(env->spills);
-       spill_t **spills = alloca(spillcount * sizeof(spills[0]));
-       spill_t *spill;
-       int i;
+static void check_spillslot_interference(be_verify_spillslots_env_t *env)
+{
+       int       spillcount = set_count(env->spills);
+       spill_t **spills     = ALLOCAN(spill_t*, spillcount);
+       spill_t  *spill;
+       int       i;
 
        for(spill = set_first(env->spills), i = 0; spill != NULL; spill = set_next(env->spills), ++i) {
                spills[i] = spill;
@@ -577,7 +591,8 @@ static void check_spillslot_interference(be_verify_spillslots_env_t *env) {
        }
 }
 
-static void check_lonely_spills(ir_node *node, void *data) {
+static void check_lonely_spills(ir_node *node, void *data)
+{
        be_verify_spillslots_env_t *env = data;
 
        if(be_is_Spill(node) || (is_Proj(node) && be_is_MemPerm(get_Proj_pred(node)))) {
@@ -626,7 +641,8 @@ int be_verify_spillslots(ir_graph *irg)
  * @param b The second value.
  * @return 1, if a and b interfere, 0 if not.
  */
-static int my_values_interfere(const ir_node *a, const ir_node *b) {
+static int my_values_interfere(const ir_node *a, const ir_node *b)
+{
        const ir_edge_t *edge;
        ir_node *bb;
        int a2b = value_dominates(a, b);
@@ -693,24 +709,27 @@ static int                          problem_found;
 static const arch_register_class_t *regclass;
 static ir_node                    **registers;
 
-static void check_register_constraints(ir_node *node)
+static void check_output_constraints(ir_node *node)
 {
-       const arch_register_t *reg;
-       int                   i, arity;
-
        /* verify output register */
-       if (arch_get_irn_reg_class(node, -1) != NULL) {
-               reg = arch_get_irn_register(node);
+       if (arch_get_irn_reg_class_out(node) == regclass) {
+               const arch_register_t *reg = arch_get_irn_register(node);
                if (reg == NULL) {
                        ir_fprintf(stderr, "Verify warning: Node %+F in block %+F(%s) should have a register assigned\n",
                                        node, get_nodes_block(node), get_irg_dump_name(irg));
                        problem_found = 1;
-               } else if (!arch_register_type_is(reg, joker) && !arch_reg_is_allocatable(node, -1, reg)) {
+               } else if (!arch_register_type_is(reg, joker) && !arch_reg_out_is_allocatable(node, reg)) {
                        ir_fprintf(stderr, "Verify warning: Register %s assigned as output of %+F not allowed (register constraint) in block %+F(%s)\n",
                                        reg->name, node, get_nodes_block(node), get_irg_dump_name(irg));
                        problem_found = 1;
                }
        }
+}
+
+static void check_input_constraints(ir_node *node)
+{
+       const arch_register_t *reg;
+       int                    i, arity;
 
        /* verify input register */
        arity = get_irn_arity(node);
@@ -756,29 +775,33 @@ static void check_register_constraints(ir_node *node)
                        const arch_register_t *pred_reg = arch_get_irn_register(pred);
 
                        if (reg != pred_reg && !arch_register_type_is(pred_reg, joker)) {
+                               const char *pred_name = pred_reg != NULL ? pred_reg->name : "(null)";
+                               const char *reg_name  = reg != NULL ? reg->name : "(null)";
                                ir_fprintf(stderr, "Verify warning: Input %d of %+F in block %+F(%s) uses register %s instead of %s\n",
-                                          i, node, get_nodes_block(node), get_irg_dump_name(irg), pred_reg->name, reg->name);
+                                          i, node, get_nodes_block(node),
+                                          get_irg_dump_name(irg), pred_name, reg_name);
                                problem_found = 1;
                        }
                }
        }
 }
 
-static void value_used(ir_node *node) {
+static void value_used(ir_node *block, ir_node *node)
+{
        const arch_register_t *reg;
        ir_node               *reg_node;
 
-       if (arch_get_irn_reg_class(node, -1) != regclass)
+       if (arch_get_irn_reg_class_out(node) != regclass)
                return;
 
        reg = arch_get_irn_register(node);
-       if (reg->type & arch_register_type_virtual)
+       if (reg == NULL || reg->type & arch_register_type_virtual)
                return;
 
        reg_node = registers[reg->index];
        if (reg_node != NULL && reg_node != node) {
                ir_fprintf(stderr, "Verify warning: Register %s assigned more than once in block %+F(%s) (nodes %+F %+F)\n",
-                              reg->name, get_nodes_block(node), get_irg_dump_name(irg),
+                              reg->name, block, get_irg_dump_name(irg),
                               node, reg_node);
                problem_found = 1;
        }
@@ -791,11 +814,11 @@ static void value_def(ir_node *node)
        const arch_register_t *reg;
        ir_node               *reg_node;
 
-       if (arch_get_irn_reg_class(node, -1) != regclass)
+       if (arch_get_irn_reg_class_out(node) != regclass)
                return;
 
        reg = arch_get_irn_register(node);
-       if (reg->type & arch_register_type_virtual)
+       if (reg == NULL || reg->type & arch_register_type_virtual)
                return;
 
        reg_node = registers[reg->index];
@@ -808,26 +831,26 @@ static void value_def(ir_node *node)
        registers[reg->index] = NULL;
 }
 
-static void verify_block_register_allocation(ir_node *block, void *data) {
+static void verify_block_register_allocation(ir_node *block, void *data)
+{
        int i, nregclasses;
        (void) data;
 
        nregclasses = arch_env_get_n_reg_class(arch_env);
        for (i = 0; i < nregclasses; ++i) {
-               ir_node               *node;
-               int                   idx, i2, n_regs;
+               ir_node *node;
+               int      idx, i2, n_regs;
 
                regclass = arch_env_get_reg_class(arch_env, i);
 
                assert(lv->nodes && "live sets must be computed");
 
                n_regs    = arch_register_class_n_regs(regclass);
-               registers = alloca(n_regs * sizeof(registers[0]));
-               memset(registers, 0, n_regs * sizeof(registers[0]));
+               registers = ALLOCANZ(ir_node*, n_regs);
 
                be_lv_foreach(lv, block, be_lv_state_end, idx) {
                        ir_node *node = be_lv_get_irn(lv, block, idx);
-                       value_used(node);
+                       value_used(block, node);
                }
 
                sched_foreach_reverse(block, node) {
@@ -838,19 +861,22 @@ static void verify_block_register_allocation(ir_node *block, void *data) {
                                foreach_out_edge(node, edge) {
                                        ir_node *def = get_edge_src_irn(edge);
                                        value_def(def);
+                                       check_output_constraints(def);
                                }
                        } else {
                                value_def(node);
+                               check_output_constraints(node);
                        }
 
-                       check_register_constraints(node);
-                       if (is_Phi(node))
-                               continue;
+                       check_input_constraints(node);
 
-                       arity = get_irn_arity(node);
-                       for (i2 = 0; i2 < arity; ++i2) {
-                               ir_node *use = get_irn_n(node, i2);
-                               value_used(use);
+                       /* process uses. (Phi inputs are no real uses) */
+                       if (!is_Phi(node)) {
+                               arity = get_irn_arity(node);
+                               for (i2 = 0; i2 < arity; ++i2) {
+                                       ir_node *use = get_irn_n(node, i2);
+                                       value_used(block, use);
+                               }
                        }
                }
 
@@ -871,10 +897,11 @@ static void verify_block_register_allocation(ir_node *block, void *data) {
        }
 }
 
-int be_verify_register_allocation(const be_irg_t *birg) {
+int be_verify_register_allocation(const be_irg_t *birg)
+{
        arch_env      = be_get_birg_arch_env(birg);
        irg           = be_get_birg_irg(birg);
-       lv            = be_liveness(birg);
+       lv            = be_liveness(irg);
        problem_found = 0;
 
        be_liveness_assure_sets(lv);
@@ -897,7 +924,8 @@ typedef struct _verify_out_dead_nodes_env {
        int problem_found;
 } verify_out_dead_nodes_env;
 
-static void check_out_edges(ir_node *node, verify_out_dead_nodes_env *env) {
+static void check_out_edges(ir_node *node, verify_out_dead_nodes_env *env)
+{
        ir_graph *irg = env->irg;
        const ir_edge_t* edge;
 
@@ -928,9 +956,11 @@ static void set_reachable(ir_node *node, void* data)
        bitset_set(reachable, get_irn_idx(node));
 }
 
-int be_verify_out_edges(ir_graph *irg) {
+int be_verify_out_edges(ir_graph *irg)
+{
        verify_out_dead_nodes_env env;
 
+return 1;
        env.irg           = irg;
        env.reachable     = bitset_alloca(get_irg_last_idx(irg));
        env.problem_found = edges_verify(irg);